Changes in lib.rs

fe6f7a40 - Miscellaneous feature-related build fixes. (#12719)

Thu, 05 Mar 2026 17:35:40 +0000

Miscellaneous feature-related build fixes. (#12719)Most found with cargo-all-features.Signed-off-by: Piotr Sikora List of files: /wasmtime-44.0.1/pulley/src/lib.rs

c00e9ea2 - Cranelift: add patchable call instructions. (#12101)

Tue, 02 Dec 2025 00:59:15 +0000

Cranelift: add patchable call instructions. (#12101)* Cranelift: add patchable call instructions.The new `patchable_call` CLIF instruction pairs with the `patchable`ABI, and emits a callsite with one new key property: the MachBuffercarries metadata that describes exactly which byte range to "NOP out"(overwrite with NOP instructions) to disable that callsite. Doing so issemantically valid and explicitly supported.This enables patching of code at runtime to dynamically turn on and offfeatures such as instrumentation or debugging hooks. We plan to use thisto implement breakpoints in Wasmtime's guest debugging support.As part of this change, I added a notion of "unit of NOP bytes" to theMachBuffer so that the consumer (e.g., Wasmtime's Cranelift-based codecompilation pipeline and metadata-producing logic) can handle patchablecallsites without any other special knowledge of the ISA.For the "real metal" ISAs there are perfectly well-defined NOPs to use,but for Pulley, where all opcodes are assigned at compile time by macromagic, I explicitly defined NOP as opcode byte 0 by moving `Nop`'sdefinition to the top of the list and adding a unit test asserting itsencoding.A design note: in principle it would be possible, as an alternative, totreat "patchability" as an orthogonal dimension of all callsites, andemit the metadata describing the instruction-offset range for anycallsite with the flag set. The only truly necessary semanticrestriction is that there are no return values (because if we turn thecallsite off, nothing writes to them); we could support patchability forother ABIs and for the other kinds of call instructions. The `patchable`ABI would then be better described as something like the "no clobbersABI". I opted not to generalize in this way because it creates someless-tested corners and the generalized form, at least at the MachInstlevel, is not really much simpler in the end.A testing note: I opted not to implement actual code patching in the`cranelift-tools` filetest runner and test patching callsites in/out viasome actuation (e.g. a magic hostcall, like we do for throws) because(i) that's a lot of new plumbing and (ii) we are going to test this veryshortly in Wasmtime anyway and (iii) the correctness (or not) of thelocation-and-length metadata is easy enough to verify in thedisassemblies in the compile-tests.* Review feedback: remove dependence on (and test for) NOP being the literal byte 0. List of files: /wasmtime-44.0.1/pulley/src/lib.rs

778771d2 - Update nightly rust used in CI (#11856)

Wed, 15 Oct 2025 15:47:02 +0000

Update nightly rust used in CI (#11856)* Update nightly rust used in CIA few more warnings are cropping up so squash them.* Frob the `unreachable_code` lintLooks like nightly rust has gotten much more aggressive about linting onunreachable code.prtest:full* Allow some more warnings... List of files: /wasmtime-44.0.1/pulley/src/lib.rs

4f2fa154 - Update nightly Rust used in CI (#11755)

Mon, 29 Sep 2025 18:12:14 +0000

Update nightly Rust used in CI (#11755)* Update nightly Rust used in CIKeeping it up-to-dateprtest:full* Fix unused warnings on nightly* Rename rustdoc feature* Adjust some removals List of files: /wasmtime-44.0.1/pulley/src/lib.rs

62276749 - pulley: Implement support for `symbol_value` (#11576)

Tue, 02 Sep 2025 20:54:42 +0000

pulley: Implement support for `symbol_value` (#11576)This commit fills out the Pulley lowerings of the `symbol_value` and`func_addr` CLIF instructions. Additionally handling of relocations onPulley is improved to be more "formal" as opposed to just blindly usingan x64 relocation and assuming it works out. The intention here is tomake Pulley behave more similarly to other platforms in all theserespects while also enabling usage of Wasmtime to eventually use`symbol_addr` to calculate an address relative to the current PC(similar to x64).This includes Cranelift golden tests as well as more filetests beingrun, but the actual integration into Wasmtime will be deferred to afuture commit. List of files: /wasmtime-44.0.1/pulley/src/lib.rs

9260ce47 - pulley: Reimplement wasm loads/stores & memory opcodes (#10154)

Mon, 10 Feb 2025 18:05:03 +0000

pulley: Reimplement wasm loads/stores & memory opcodes (#10154)* pulley: Reimplement wasm loads/stores & memory opcodesThis commit is a large refactoring to reimplement how WebAssemblyloads/stores are translated to Pulley opcodes when using theinterpreter. Additionally the functionality related to memory supporthas changed quite a bit with the interpreter as well. This is all basedoff comments on #10102 with the end goal of folding the two Pulleyopcodes today of "do the bounds check" and "do the load" into oneopcode. This is intended to reduce the number of opcodes and overallimprove interpreter throughput by minimizing turns of the interpreterloop.The basic idea behind this PR is that a new basic suite of loads/storesare added to Pulley which trap if the address is zero. This provides aroute to translate trapping loads/stores in CLIF to Pulley bytecodewithout actually causing segfaults at runtime. WebAssembly translationto CLIF is then updated to use the `select` trick for wasm loads/storeswhere either 0 is loaded from or the actual address is loaded from.Basic support for translation and such is added for this everywhere, andthis ensures that all loads/stores for wasm will be translatedsuccessfully with Pulley.The next step was to extend the "g32" addressing mode preexisting inPulley to support a bounds check as well. New pattern-matches were addedto ISLE to search for a bounds check in the address of a trappingload/store. If found then the entire chain of operations necessary tocompute the address are folded into a single "g32" opcode which ends upbeing a fallible load/store at runtime.To fit all this into Pulley this commit contains a number ofrefactorings to shuffle around existing opcodes related to memory andextend various pieces of functionality here and there:* Pulley now uses a `AddrFoo` types to represent addressing modes as a single immediate rather than splitting it up into pieces for each method. For example `AddrO32` represents "base + offset32". `AddrZ` represents the same thing but traps if the address is zero. The `AddrG32` mode represents a bounds-checked 32-bit linear memory access on behalf of wasm.* Pulley loads/stores were reduced to always using an `AddrFoo` immediate. This means that the old `offset8` addressing mode was removed without replacement here (to be added in the future if necessary). Additionally the suite of sign-extension modes supported were trimmed down to remove 8-to-64, 16-to-64, and 32-to-64 extensions folded as part of the opcode. These can of course always be re-added later but probably want to be added just for the `G32` addressing mode as opposed to all addressing modes.* The interpreter itself was refactored to have an `AddressingMode` trait to ensure that all memory accesses, regardless of addressing modes, are largely just copy/pastes of each other. In the future it might make sense to implement these methods with a macro, but for now it's copy/paste.* In ISLE the `XLoad` generic instruction removed its `ext` field to have extensions handled exclusively in ISLE instead of partly in `emit.rs`.* Float/vector loads/stores now have "g32" addressing (in addition to the "z" that's required for wasm) since it was easy to add them.* Translation of 1-byte accesses on Pulley from WebAssembly to CLIF no longer has a special case for using `a >= b` instead of `a > b - 1` to ensure that the same bounds-check instruction can be used for all sizes of loads/stores.* The bounds-check which folded a load-of-the-bound into the opcode is now present as a "g32bne" addressing mode. with its of suite of instructions to boo.Overall this PR is not a 1:1 replacement of all previous opcodes withexactly one opcode. For example loading 8 bits sign-extended to 64-bitsis now two opcodes instead of one. Additionally some previous opcodeshave expanded in size where for example the 8-bit offset mode was removein favor of only having 32-bit offsets. The goal of this PR is to reboothow memory is handled in Pulley. All loads/stores now use a specificaddressing mode and currently all operations supported across addressingmodes are consistently supported. In the future it's expected that somefeatures will be added to some addressing modes and not others asnecessary, for example extending the "g32" addressing mode only insteadof all addressing modes.For an evaluation of this PR:* Code size: `spidermonkey.cwasm` file is reduced from 19M to 16M.* Sightglass: `pulldown-cmark` is improved by 15%* Sightglass: `bz2` is improved by 20%* Sightglass: `spidermonkey` is improved by 22%* Coremark: score improved by 40%Overall this PR and new design looks to be a large win. This is alldriven by the reduction in opcodes both for compiled code size andexecution speed by minimizing turns of the interpreter loop. In the endI'm also pretty happy with how this turned out and I think therefactorings are well worth it.* Use new `is_pulley` helper more* Improve `addrz` helper, tighten up `memory-inbounds.wat` a bit* Improve codegen in a few `memory-inbounds.wat` cases* Fix test expectation List of files: /wasmtime-44.0.1/pulley/src/lib.rs

505b3c6f - Require lint reasons in `pulley-interpreter` (#10173)

Mon, 03 Feb 2025 19:16:25 +0000

Require lint reasons in `pulley-interpreter` (#10173)* Require lint reasons in `pulley-interpreter`Continuing work originally started in #9696* Add more pulley #[cfg] List of files: /wasmtime-44.0.1/pulley/src/lib.rs

5dfccc07 - pulley: Optimize bounds-checks for 1-byte loads/stores (#10100)

Fri, 24 Jan 2025 23:25:57 +0000

pulley: Optimize bounds-checks for 1-byte loads/stores (#10100)These have a different pattern than N-byte loads/stores where thecondition being tested is `a >= b` which doesn't match the pattern forN-byte loads/stores with `a > b - N`. This commit adds dedicated opcodesto Pulley for this pattern to help optimize single-byte loads/stores. List of files: /wasmtime-44.0.1/pulley/src/lib.rs

7d78789d - pulley: Slightly optimize bounds checks (#10080)

Wed, 22 Jan 2025 20:53:11 +0000

pulley: Slightly optimize bounds checks (#10080)* pulley: Slightly optimize bounds checksIn profiling a module I was noticing that the previous`xbc32_bound_trap` instruction wasn't being used when I expected.Investigation revealed that the load of the bound itself was GVN'd anddeduplicated (yay!) but it meant that the load was used in two locationsmeaning it didn't pass checks for `sinkable_load`. This commit fixesthis by repurposing `xbc32_bound_trap` for "the bound is in a register"and renaming the previous instruction to `xbc32_boundne_trap`. Thishelps cut down on the number of opcodes in this benchmark and improvesperformance slightly.At the same time this tightens up "sinkable loads" to require nativeendianness since that's what the bound of memory is stored as.Additionally in addition to testing for `a < b` and optimizing that thisalso now optimizes `b > a`, the same condition just having the argumentsswapped.* Fix some copy/paste typos List of files: /wasmtime-44.0.1/pulley/src/lib.rs

2f27a10b - pulley: Add a multiply-and-add macro instruction (#10081)

Wed, 22 Jan 2025 20:51:41 +0000

pulley: Add a multiply-and-add macro instruction (#10081)This is present in riscv64 and aarch64 native ISAs and was found in abenchmark I was looking at so let's add a macro-op as well to help caseswhere this crops up in the wild. List of files: /wasmtime-44.0.1/pulley/src/lib.rs

1d1c06f3 - Add basic support for profiling Pulley (#10034)

Thu, 16 Jan 2025 22:49:36 +0000

Add basic support for profiling Pulley (#10034)* Add basic support for profiling PulleyThis commit adds basic support for profiling the Pulley interpreter.This is partially achievable previously through the use of nativeprofilers, but the downside of that approach is that you can find hotinstructions but it's not clear in what context the hot instructions arebeing executed nor what functions are hot. The goal of this profiler isto show pulley bytecode and time spent in bytecode itself to betterunderstand the shape of code around a hot instruction to identify newmacro opcodes for example.The general structure of this new profiler is:* There is a compile-time feature for Pulley which is off-by-default where, when enabled, Pulley will record its current program counter into an `AtomicUsize` before each instruction.* When the CLI has `--profile pulley` Wasmtime will spawn a sampling thread in the same process which will periodically read from this `AtomicUsize` to record where the program is currently executing.* The Pulley profiler additionally records all bytecode through the use of the `ProfilingAgent` trait to ensure that the recording has access to all bytecode as well.* Samples are taken throughout the process and emitted to a `pulley-$pid.data` file. This file is then interpreted and printed by an "example" program `profiler-html.rs` in the `pulley/examples` directory.The end result is that hot functions of Pulley bytecode can be seen andinstructions are annotated with how frequently they were executed. Thisenables finding hot loops and understanding more about the whole loop,bytecodes that were selected, and such.* Add missing source file* Check the profile-pulley feature in CI* Miscellaneous fixes for CI* Fix type-checking of `become` on nightly Rust* Fix more misc CI issues* Fix dispatch in tail loop* Update test expectations* Review comments* Fix a feature combo List of files: /wasmtime-44.0.1/pulley/src/lib.rs

e4fd50d1 - pulley: Shrink frame save/restore instructions (#9999)

Tue, 14 Jan 2025 01:28:53 +0000

pulley: Shrink frame save/restore instructions (#9999)* pulley: Shrink frame save/restore instructionsThis commit shrinks the size of the `PushFrameSave` and`PopFrameRestore` functions which are used in almost all wasm functions.Previously these instructions allowed for 32-bits of stack space inaddition to saving/restoring all 32 X-registers. In reality though it'squite uncommon to need more than 16-bits of stack space and ABI-wise themost commonly saved registers are the upper 16 registers of the Xregister set.This commit therefore shrinks the frame size to 16 bits and only has theability to save/restore the upper 16 X-registers. Note that anyclobbered registers and frame sizes are still supported, they'll justuse more pessimal encodings which aren't a single opcode. If a functionuses >64KiB of stack space though it's probably not too important whatthe dispatch cost is at the beginning.The overall result of this change is that each instruction shaves of 4bytes (2 from the frame size and 2 from the registers beingsaved/restored). This results in a 4% faster execution time on the bz2Sightglass benchmark, ~1% on pulldown-cmark, and while it shrinks`spidermonkey.cwasm` slightly it's not significant.* Remove no-longer-applicable test* Fix clippy error* Update test expectations List of files: /wasmtime-44.0.1/pulley/src/lib.rs

a6a08570 - pulley: Add more addressing modes for loads/stores (#9994)

Mon, 13 Jan 2025 21:05:07 +0000

pulley: Add more addressing modes for loads/stores (#9994)* pulley: Add more addressing modes for loads/storesThis commit adds a new "g32" addressing mode to Pulley that matches thepattern emitted by Cranelift for 32-bit wasm guests running on hosts.The general idea here is that this addressing mode encompasses anaddition of a host-width value to a zero-extended (optionally) 32-bitvalue. On 32-bit hosts there's no zero-extension but on 64-bit hoststhere's a zero-extension. The wasm address is always 32-bits thoughwhich enables using a single instruction for both 32 and 64-bit hosts.New "g32" loads and stores are added to Pulley with varying sizes andoptions according to what seems to be common in wasm. The `disas` testsuite was updated to showcase using these instructions for wasmloads/stores on 32 and 64-bit hosts.An additional change in this commit is to deduplicate the 32/64-bitbounds-check macro-ops. The trick in this commit works for those as wellmeaning that only a single instruction is needed instead ofone-per-host-pointer-width. Additionally the load of the bound from the`VMContext` is folded into the bounds check itself as it was found thatthis was always present anyway before the bounds check.Overall this shrinks the size of `spidermonkey.cwasm` from 21M to 20Mand the runtime of `pulldown-cmark`, `bz2`, and `spidermonkey` onSightglass have all been reduced by 10%. Not as big wins as I was hopingfor but alas.* Fix debug assertions on 32-bit List of files: /wasmtime-44.0.1/pulley/src/lib.rs

ff84f26f - Fix comment about `xbc32_bound32_trap` pulley macro-op (#9998)

Mon, 13 Jan 2025 20:11:40 +0000

Fix comment about `xbc32_bound32_trap` pulley macro-op (#9998)Unlike the `bound64` version, this instruction does not zero-extend the address. List of files: /wasmtime-44.0.1/pulley/src/lib.rs

2fa87113 - pulley: Finish `simd` proposal implementation (#9935)

Mon, 13 Jan 2025 18:46:50 +0000

pulley: Finish `simd` proposal implementation (#9935)* pulley: Finish `simd` proposal implementationThis commit fills out the final and miscellaneous set of opcodes forPulley to have a complete implementation of the `simd` proposal forWebAssembly. All spec tests are now enabled and the Pulley-specificexceptions for `*.wast` tests are all gone.Closes #9783* Remove stray build script List of files: /wasmtime-44.0.1/pulley/src/lib.rs

54385f86 - pulley: Add special instructions for `dst = 0` and 1 (#9986)

Mon, 13 Jan 2025 17:11:55 +0000

pulley: Add special instructions for `dst = 0` and 1 (#9986)* pulley: Add special instructions for `dst = 0` and 1This commit adds a special instruction for setting a register to thevalue 0 or the value 1. This extends to the full width of the registerand accounts for the majority of all `xconst` instructions found in`spidermonkey.cwasm`. It's not a major size decrease, but helps a bit.* Fix CLIF test expectations* Fix more test expectations List of files: /wasmtime-44.0.1/pulley/src/lib.rs

00b7f8dc - pulley: Implement the wide-arithmetic proposal (#9944)

Thu, 09 Jan 2025 16:59:31 +0000

pulley: Implement the wide-arithmetic proposal (#9944)* pulley: Implement the wide-arithmetic proposalAdd a few minor instructions/lowerings for the new operations added aspart of the wide-arithmetic proposal. These are all part of the"extended" opcode set since they shouldn't be common and if they'reperformance critical you probably want a native backend instead.* Review comments List of files: /wasmtime-44.0.1/pulley/src/lib.rs

b6527cf6 - pulley: Add some macro-instructions related to bounds-checks (#9943)

Wed, 08 Jan 2025 17:51:50 +0000

pulley: Add some macro-instructions related to bounds-checks (#9943)* pulley: Add some macro-instructions related to bounds-checksThis commit starts down the path of optimizing wasm loads/stores inPulley with macro-instructions. It's expected that these instructionsare so common that it's worth putting them in the 1-byte namespace ofopcodes.Locally this gets a 10% speedup on the sightglass bz2 benchmark.* Remove incorrect lowering rule List of files: /wasmtime-44.0.1/pulley/src/lib.rs

fc3c868b - pulley: Fill out most remaining simd float ops (#9884)

Mon, 06 Jan 2025 18:34:12 +0000

pulley: Fill out most remaining simd float ops (#9884)* pulley: Fill out most remaining simd float opsGet most simd/float-related tests passing. Mostly reusing preexistingscalar ops for the simd implementation.* Fix fma test on MinGWprtest:full* More MinGW fixes List of files: /wasmtime-44.0.1/pulley/src/lib.rs

5092fe2e - Make Pulley pass `simd_f32x4_arith.wast` (#9897)

Mon, 06 Jan 2025 16:17:19 +0000

Make Pulley pass `simd_f32x4_arith.wast` (#9897)* Add f32x4 arithmetic instructions to Pulley:Adds float SIMD instructions on 4 lanes (f32x4) for subtraction, multiplication, and negation.`vtrunc32x4` and `vmuli32x4` were used as basis on how to organize things.* Mark `simd_f32x4_arith.wast` as passing for Pulley:To be exact: `spec_testsuite/simd_f32x4_arith.wast` has been removed from the should fail list for Pulley.* Rename 2 f32x4 arithmatic instructions to contain "f32x4":Specifically:- "vsub32x4" -> "vsubf32x4"- "vmul32x4" -> "vmulf32x4" List of files: /wasmtime-44.0.1/pulley/src/lib.rs