f1411653 - Remove the borrow checking from `wiggle` entirely (#8702)

Fri, 31 May 2024 17:22:23 +0000

Remove the borrow checking from `wiggle` entirely (#8702)* Remove the borrow checking from `wiggle` entirelyThis commit is a refactoring of the `wiggle` crate which powers the`*.witx`-based bindings generation of Wasmtime for wasip1 support.Originally `wiggle` had a full-blown runtime borrow checker whichverified that borrows were disjoint when appropriate. In #8277 this wasremoved in favor of a more coarse "either all shared or all mutable"guarantee. It turns out that this exactly matches what the Rust typesystem guarantees at compile time as well.This commit removes all runtime borrow checking in favor of compile-timeborrow checking instead. This means that there is no longer thepossibility of a runtime error arising from borrowing errors. Currentbindings in Wasmtime needed no restructuring to work with this new API.The source of the refactors here are all in the `wiggle` crate. Changesinclude:* The `GuestPtr` type lost its type parameter. Additionally it only contains a `u32` pointer now instead.* The `GuestMemory` trait is replaced with a simple `enum` of possibilities.* Helper methods on `GuestPtr` are all moved to `GuestMemory`.* A number of abstractions were simplified now that borrow checking is no longer necessary.* Generated trait methods now all take `&mut GuestMemory<'_>` as an argument.These changes were then propagated to the `wasmtime-wasi` and`wasi-common` crates in their preview0 and preview1 implementations ofWASI. All changes are just general refactors, no functional change isintended here.* Review comments* Fix publishing of wiggle-macro crate* Fix wiggle docs List of files: /wasmtime-44.0.1/crates/wasi-common/src/string_array.rs

47fec44c - move wasi-c2 into wasi-common

Thu, 28 Jan 2021 23:15:50 +0000

move wasi-c2 into wasi-common List of files: /wasmtime-44.0.1/crates/wasi-common/src/string_array.rs

1d410d65 - move more constructor stuff into stringarray

Thu, 03 Sep 2020 00:16:39 +0000

move more constructor stuff into stringarray List of files: /wasmtime-44.0.1/crates/wasi-common/src/string_array.rs

39f1c971 - restructure StringArrayWriter trait into StringArray struct

Wed, 02 Sep 2020 21:11:32 +0000

restructure StringArrayWriter trait into StringArray struct List of files: /wasmtime-44.0.1/crates/wasi-common/src/string_array.rs

Changes in string_array.rs

f1411653 - Remove the borrow checking from `wiggle` entirely (#8702)

47fec44c - move wasi-c2 into wasi-common

1d410d65 - move more constructor stuff into stringarray

39f1c971 - restructure StringArrayWriter trait into StringArray struct