Changes in data_context.rs

9c3d1028 - Allow marking data objects as used for the linker (#11206)

Thu, 10 Jul 2025 17:01:58 +0000

Allow marking data objects as used for the linker (#11206) List of files: /wasmtime-44.0.1/cranelift/module/src/data_context.rs

90ac295e - Update Wasmtime to the 2024 Rust Edition (#10806)

Mon, 19 May 2025 16:40:55 +0000

Update Wasmtime to the 2024 Rust Edition (#10806)* Update Wasmtime to the 2024 Rust EditionNow that our MSRV supports the 2024 edition it's possible to make thisswitch. This commit moves Wasmtime to the 2024 Edition to keepup-to-date with Rust idioms and access many of the edition featuresexclusive to the 2024 edition.prtest:full* Reformat with the 2024 edition List of files: /wasmtime-44.0.1/cranelift/module/src/data_context.rs

b23f534c - riscv64: Implement ELF TLS GD Relocations (#7003)

Mon, 18 Sep 2023 14:44:06 +0000

riscv64: Implement ELF TLS GD Relocations (#7003)* cranelift: Add support for public labels* cranelift: Allow targeting labels with relocations* cranelift: Emit label related relocations in module* riscv64: Implement TLS GD* cranelift: Rename `label_is_public` field* cranelift: Avoid making MachLabel part of the exposed API List of files: /wasmtime-44.0.1/cranelift/module/src/data_context.rs

9ec02f9d - Decouple `serde` from its `derive` crate (#6917)

Tue, 29 Aug 2023 16:02:06 +0000

Decouple `serde` from its `derive` crate (#6917)By not activating the `derive` feature on `serde`, the compilation speedcan be improved by a lot. This is because `serde` can then compile inparallel to `serde_derive`, allowing it to finish compilation possiblyeven before `serde_derive`, unblocking all the crates waiting for`serde` to start compiling much sooner.As it turns out the main deciding factor for how long the compile time of aproject is, is primarly determined by the depth of dependencies ratherthan the width. In other words, a crate's compile times aren't affectedby how many crates it depends on, but rather by the longest chain ofdependencies that it needs to wait on. In many cases `serde` is part ofthat long chain, as it is part of a long chain if the `derive` featureis active:`proc-macro2` compile build script > `proc-macro2` run build script >`proc-macro2` > `quote` > `syn` > `serde_derive` > `serde` >`serde_json` (or any crate that depends on serde)By decoupling it from `serde_derive`, the chain is shortened and compiletimes get much better.Check this issue for a deeper elaboration:https://github.com/serde-rs/serde/issues/2584For `wasmtime` I'm seeing a reduction from 24.75s to 22.45s whencompiling in `release` mode. This is because wasmtime through `gimli`has a dependency on `indexmap` which can only start compiling when`serde` is finished, which you want to happen as early as possible sosome of wasmtime's dependencies can start compiling.To measure the full effect, the dependencies can't by themselvesactivate the `derive` feature. I've upstreamed a patch for`fxprof-processed-profile` which was the only dependency that activatedit for `wasmtime` (not yet published to crates.io). `wasmtime-cli` andco. may need patches for their dependencies to see a similarimprovement. List of files: /wasmtime-44.0.1/cranelift/module/src/data_context.rs

91d1d246 - Allow serializing all cranelift-module data structures (#6172)

Fri, 21 Apr 2023 12:39:15 +0000

Allow serializing all cranelift-module data structures (#6172)* Remove ModuleCompiledFunctionThe same information can be retrieved usingctx.compiled_code().unwrap().code_info().total_sizeIn addition for Module implementations that don't immediately compile thegiven function there is no correct value that can be returned.* Don't give anonymous functions and data objects an internal nameThis internal name can conflict if a module is serialized and thendeserialized into another module. It also wasn't used by any of theModule implementations anyway.* Allow serializing all cranelift-module data structuresThis allows a Module implementation to serialize it's internal state anddeserialize it in another compilation session. For example to implementLTO or to load the module into cranelift-interpreter.* Use expect List of files: /wasmtime-44.0.1/cranelift/module/src/data_context.rs

67c85b88 - Remove the DataContext wrapper around DataDescription (#6170)

Thu, 06 Apr 2023 17:13:55 +0000

Remove the DataContext wrapper around DataDescription (#6170)* Remove the DataContext wrapper around DataDescriptionIt doesn't have much of a purpose while making it harder to for examplerewrite the function and data object declarations within it as isnecessary for deserializing a serialized module.* Derive Debug for DataDescription List of files: /wasmtime-44.0.1/cranelift/module/src/data_context.rs

8a9b1a90 - Implement an incremental compilation cache for Cranelift (#4551)

Fri, 12 Aug 2022 16:47:43 +0000

Implement an incremental compilation cache for Cranelift (#4551)This is the implementation of https://github.com/bytecodealliance/wasmtime/issues/4155, using the "inverted API" approach suggested by @cfallin (thanks!) in Cranelift, and trait object to provide a backend for an all-included experience in Wasmtime. After the suggestion of Chris, `Function` has been split into mostly two parts: - on the one hand, `FunctionStencil` contains all the fields required during compilation, and that act as a compilation cache key: if two function stencils are the same, then the result of their compilation (`CompiledCodeBase`) will be the same. This makes caching trivial, as the only thing to cache is the `FunctionStencil`. - on the other hand, `FunctionParameters` contain the... function parameters that are required to finalize the result of compilation into a `CompiledCode` (aka `CompiledCodeBase`) with proper final relocations etc., by applying fixups and so on. Most changes are here to accomodate those requirements, in particular that `FunctionStencil` should be `Hash`able to be used as a key in the cache: - most source locations are now relative to a base source location in the function, and as such they're encoded as `RelSourceLoc` in the `FunctionStencil`. This required changes so that there's no need to explicitly mark a `SourceLoc` as the base source location, it's automatically detected instead the first time a non-default `SourceLoc` is set. - user-defined external names in the `FunctionStencil` (aka before this patch `ExternalName::User { namespace, index }`) are now references into an external table of `UserExternalNameRef -> UserExternalName`, present in the `FunctionParameters`, and must be explicitly declared using `Function::declare_imported_user_function`. - some refactorings have been made for function names: - `ExternalName` was used as the type for a `Function`'s name; while it thus allowed `ExternalName::Libcall` in this place, this would have been quite confusing to use it there. Instead, a new enum `UserFuncName` is introduced for this name, that's either a user-defined function name (the above `UserExternalName`) or a test case name. - The future of `ExternalName` is likely to become a full reference into the `FunctionParameters`'s mapping, instead of being "either a handle for user-defined external names, or the thing itself for other variants". I'm running out of time to do this, and this is not trivial as it implies touching ISLE which I'm less familiar with. The cache computes a sha256 hash of the `FunctionStencil`, and uses this as the cache key. No equality check (using `PartialEq`) is performed in addition to the hash being the same, as we hope that this is sufficient data to avoid collisions. A basic fuzz target has been introduced that tries to do the bare minimum: - check that a function successfully compiled and cached will be also successfully reloaded from the cache, and returns the exact same function. - check that a trivial modification in the external mapping of `UserExternalNameRef -> UserExternalName` hits the cache, and that other modifications don't hit the cache. - This last check is less efficient and less likely to happen, so probably should be rethought a bit. Thanks to both @alexcrichton and @cfallin for your very useful feedback on Zulip. Some numbers show that for a large wasm module we're using internally, this is a 20% compile-time speedup, because so many `FunctionStencil`s are the same, even within a single module. For a group of modules that have a lot of code in common, we get hit rates up to 70% when they're used together. When a single function changes in a wasm module, every other function is reloaded; that's still slower than I expect (between 10% and 50% of the overall compile time), so there's likely room for improvement. Fixes #4155. List of files: /wasmtime-44.0.1/cranelift/module/src/data_context.rs

6e828df6 - Remove unused `SourceLoc` in many `Mach` data structures (#4180)

Mon, 23 May 2022 16:27:28 +0000

Remove unused `SourceLoc` in many `Mach` data structures (#4180)* Remove unused srcloc in MachReloc * Remove unused srcloc in MachTrap * Use `into_iter` on array in bench code to suppress a warning * Remove unused srcloc in MachCallSite List of files: /wasmtime-44.0.1/cranelift/module/src/data_context.rs

141af752 - Allow cloning DataDescriptor (#3377)

Wed, 23 Feb 2022 18:19:54 +0000

Allow cloning DataDescriptor (#3377) List of files: /wasmtime-44.0.1/cranelift/module/src/data_context.rs

f0e821b9 - Remove all Sink traits

Tue, 11 Jan 2022 18:03:10 +0000

Remove all Sink traits List of files: /wasmtime-44.0.1/cranelift/module/src/data_context.rs

1dc27c93 - Introduce DataDescription::all_relocs to dedup some code

Wed, 11 Nov 2020 11:19:37 +0000

Introduce DataDescription::all_relocs to dedup some code List of files: /wasmtime-44.0.1/cranelift/module/src/data_context.rs

b0616944 - Rustfmt and update docs

Thu, 01 Oct 2020 07:53:23 +0000

Rustfmt and update docs List of files: /wasmtime-44.0.1/cranelift/module/src/data_context.rs

84c6ec32 - Move alignment config from declare_data to define_data

Wed, 30 Sep 2020 17:23:23 +0000

Move alignment config from declare_data to define_data List of files: /wasmtime-44.0.1/cranelift/module/src/data_context.rs

b2549d1f - Rust fmt fixes

Wed, 17 Jun 2020 04:46:58 +0000

Rust fmt fixes List of files: /wasmtime-44.0.1/cranelift/module/src/data_context.rs

0b613caa - Address concerns in pullrequests.

Mon, 15 Jun 2020 18:46:04 +0000

Address concerns in pullrequests. List of files: /wasmtime-44.0.1/cranelift/module/src/data_context.rs

38531b8f - Rust fmt fixes

Mon, 08 Jun 2020 17:56:21 +0000

Rust fmt fixes List of files: /wasmtime-44.0.1/cranelift/module/src/data_context.rs

6b470798 - Cranelift: Module data apis should allow specifying the object file section #1640

Sat, 06 Jun 2020 14:08:21 +0000

Cranelift: Module data apis should allow specifying the object file section #1640 List of files: /wasmtime-44.0.1/cranelift/module/src/data_context.rs

9f506692 - Fix clippy warnings.

Thu, 24 Oct 2019 06:15:42 +0000

Fix clippy warnings.This commit fixes the current set of (stable) clippy warnings in the repo. List of files: /wasmtime-44.0.1/cranelift/module/src/data_context.rs

747ad3c4 - moved crates in lib/ to src/, renamed crates, modified some files' text (#660)

Mon, 28 Jan 2019 23:56:54 +0000

moved crates in lib/ to src/, renamed crates, modified some files' text (#660)moved crates in lib/ to src/, renamed crates, modified some files' text (#660) List of files: /wasmtime-44.0.1/cranelift/module/src/data_context.rs