en Copyright 2015 Java http://172.16.0.5:8080/history/wasmtime-44.0.1/cranelift/codegen/src/unreachable_code.rs#3932e8f1 Some fixes for try_call (#10593)* Fix cranelift-frontend handling of try_call* Implement eliminate_unreachable_code for exception tables* Ensure try_call is considered a memory fence* Don't error on try_call in the verifier if no TargetIsa is passed* Don't clobber all registers for try_call unless the tail call conv is usedThis way other consumers of Cranelift don't have to pay the cost of theway Wasmtime will implement unwinding on exceptions.* Allow SystemV call conv with try_call List of files: /wasmtime-44.0.1/cranelift/codegen/src/unreachable_code.rs Thu, 17 Apr 2025 16:16:41 +0000 bjorn3 <17426603+bjorn3@users.noreply.github.com> http://172.16.0.5:8080/history/wasmtime-44.0.1/cranelift/codegen/src/unreachable_code.rs#b0b3f67c Move jump tables to the DataFlowGraph (#5745)Move the storage for jump tables off of FunctionStencil and onto DataFlowGraph. This change is in service of #5731, making it easier to access the jump table data in the context of helpers like inst_values. List of files: /wasmtime-44.0.1/cranelift/codegen/src/unreachable_code.rs Wed, 08 Feb 2023 05:21:35 +0000 Trevor Elliott <telliott@fastly.com> http://172.16.0.5:8080/history/wasmtime-44.0.1/cranelift/codegen/src/unreachable_code.rs#e9c05622 Keep reachable jump tables (#5721)Instead of identifying unused branch tables by looking for unused blocks inside of them, track used branch tables while traversing reachable blocks. This introduces an extra allocation of an EntitySet to track the used jump tables, but as those are few and this function runs once per ir::Function, the allocation seems reasonable. List of files: /wasmtime-44.0.1/cranelift/codegen/src/unreachable_code.rs Mon, 06 Feb 2023 22:10:47 +0000 Trevor Elliott <telliott@fastly.com> http://172.16.0.5:8080/history/wasmtime-44.0.1/cranelift/codegen/src/unreachable_code.rs#8d022434 cranelift: Introduce a feature to enable `trace` logs (#4484)* Don't use `log::trace` directly but a feature-enabled `trace` macro * Don't emit disassembly based on the log level List of files: /wasmtime-44.0.1/cranelift/codegen/src/unreachable_code.rs Mon, 01 Aug 2022 09:19:15 +0000 Benjamin Bouvier <public@benj.me> http://172.16.0.5:8080/history/wasmtime-44.0.1/cranelift/codegen/src/unreachable_code.rs#43a86f14 Remove more old backend ISA concepts (#3402)This also paves the way for unifying TargetIsa and MachBackend, since now they map one to one. In theory the two traits could be merged, which would be nice to limit the number of total concepts. Also they have quite different responsibilities, so it might be fine to keep them separate. Interestingly, this PR started as removing RegInfo from the TargetIsa trait since the adapter returned a dummy value there. From the fallout, noticed that all Display implementations didn't needed an ISA anymore (since these were only used to render ISA specific registers). Also the whole family of RegInfo / ValueLoc / RegUnit was exclusively used for the old backend, and these could be removed. Notably, some IR instructions needed to be removed, because they were using RegUnit too: this was the oddball of regfill / regmove / regspill / copy_special, which were IR instructions inserted by the old regalloc. Fare thee well! List of files: /wasmtime-44.0.1/cranelift/codegen/src/unreachable_code.rs Mon, 04 Oct 2021 08:36:12 +0000 Benjamin Bouvier <public@benj.me> http://172.16.0.5:8080/history/wasmtime-44.0.1/cranelift/codegen/src/unreachable_code.rs#4283d211 cranelift: Move most debug-level logs to the trace levelCranelift crates have historically been much more verbose with debug-levellogging than most other crates in the Rust ecosystem. We log things like howmany parameters a basic block has, the color of virtual registers duringregalloc, etc. Even for Cranelift hackers, these things are largely only usefulwhen hacking specifically on Cranelift and looking at a particular test case,not even when using some Cranelift embedding (such as Wasmtime).Most of the time, when people want logging for their Rust programs, they dosomething like: RUST_LOG=debug cargo runThis means that they get all that mostly not useful debug logging out ofCranelift. So they might want to disable logging for Cranelift, or change it toa higher log level: RUST_LOG=debug,cranelift=info cargo runThe problem is that this is already more annoying to type that `RUST_LOG=debug`,and that Cranelift isn't one single crate, so you actually have to playwhack-a-mole with naming all the Cranelift crates off the top of your head,something more like this: RUST_LOG=debug,cranelift=info,cranelift_codegen=info,cranelift_wasm=info,...Therefore, we're changing most of the `debug!` logs into `trace!` logs: anythingthat is very Cranelift-internal, unlikely to be useful/meaningful to the"average" Cranelift embedder, or prints a message for each instruction visitedduring a pass. On the other hand, things that just report a one line statisticfor a whole pass, for example, are left as `debug!`. The more verbose the logmessages are, the higher the bar they must clear to be `debug!` rather than`trace!`. List of files: /wasmtime-44.0.1/cranelift/codegen/src/unreachable_code.rs Mon, 26 Jul 2021 18:50:16 +0000 Nick Fitzgerald <fitzgen@gmail.com> http://172.16.0.5:8080/history/wasmtime-44.0.1/cranelift/codegen/src/unreachable_code.rs#48d542d6 Fix bad jumptable block ref when DCE removes a block.When a block is unreachable, the `unreachable_code` pass will remove it,which is perfectly sensible. Jump tables factor into unreachability inan expected way: even if a block is listed in a jump table, the blockmight be unreachable if the jump table itself is unused (or used in anunreachable block). Unfortunately, the verifier still expects allblock refs in all jump tables to be valid, even after DCE, which willnot always be the case.This makes a simple change to the pass: after removing blocks, it scansjump tables. Any jump table that refers to an unreachable block mustitself be unused, and so we just clear its entries. We do not botherremoving it (and renumbering all later jumptables), and we do not bothercomputing full unused-ness of all jumptables, as that would be moreexpensive; it's sufficient to clear out the ones that refer tounreachable blocks, which are a subset of all unused jumptables.Fixes #2670. List of files: /wasmtime-44.0.1/cranelift/codegen/src/unreachable_code.rs Tue, 23 Feb 2021 23:01:01 +0000 Chris Fallin <chris@cfallin.org> http://172.16.0.5:8080/history/wasmtime-44.0.1/cranelift/codegen/src/unreachable_code.rs#832666c4 Mass rename Ebb and relatives to Block (#1365)* Manually rename BasicBlock to BlockPredecessor BasicBlock is a pair of (Ebb, Inst) that is used to represent the basic block subcomponent of an Ebb that is a predecessor to an Ebb. Eventually we will be able to remove this struct, but for now it makes sense to give it a non-conflicting name so that we can start to transition Ebb to represent a basic block. I have not updated any comments that refer to BasicBlock, as eventually we will remove BlockPredecessor and replace with Block, which is a basic block, so the comments will become correct. * Manually rename SSABuilder block types to avoid conflict SSABuilder has its own Block and BlockData types. These along with associated identifier will cause conflicts in a later commit, so they are renamed to be more verbose here. * Automatically rename 'Ebb' to 'Block' in *.rs * Automatically rename 'EBB' to 'block' in *.rs * Automatically rename 'ebb' to 'block' in *.rs * Automatically rename 'extended basic block' to 'basic block' in *.rs * Automatically rename 'an basic block' to 'a basic block' in *.rs * Manually update comment for `Block` `Block`'s wikipedia article required an update. * Automatically rename 'an `Block`' to 'a `Block`' in *.rs * Automatically rename 'extended_basic_block' to 'basic_block' in *.rs * Automatically rename 'ebb' to 'block' in *.clif * Manually rename clif constant that contains 'ebb' as substring to avoid conflict * Automatically rename filecheck uses of 'EBB' to 'BB' 'regex: EBB' -> 'regex: BB' '$EBB' -> '$BB' * Automatically rename 'EBB' 'Ebb' to 'block' in *.clif * Automatically rename 'an block' to 'a block' in *.clif * Fix broken testcase when function name length increases Test function names are limited to 16 characters. This causes the new longer name to be truncated and fail a filecheck test. An outdated comment was also fixed. List of files: /wasmtime-44.0.1/cranelift/codegen/src/unreachable_code.rs Fri, 07 Feb 2020 16:46:47 +0000 Ryan Hunt <rhunt@eqrion.net> http://172.16.0.5:8080/history/wasmtime-44.0.1/cranelift/codegen/src/unreachable_code.rs#747ad3c4 moved crates in lib/ to src/, renamed crates, modified some files' text (#660)moved crates in lib/ to src/, renamed crates, modified some files' text (#660) List of files: /wasmtime-44.0.1/cranelift/codegen/src/unreachable_code.rs Mon, 28 Jan 2019 23:56:54 +0000 lazypassion <25536767+lazypassion@users.noreply.github.com>