Changes in args.rs

0889323a - cranelift-codegen: rename most uses of std to core and alloc (#12237)

Sat, 03 Jan 2026 00:54:48 +0000

cranelift-codegen: rename most uses of std to core and alloc (#12237)* rename most std uses to core and alloc* cargo fmt List of files: /wasmtime-44.0.1/cranelift/codegen/src/isa/pulley_shared/inst/args.rs

62276749 - pulley: Implement support for `symbol_value` (#11576)

Tue, 02 Sep 2025 20:54:42 +0000

pulley: Implement support for `symbol_value` (#11576)This commit fills out the Pulley lowerings of the `symbol_value` and`func_addr` CLIF instructions. Additionally handling of relocations onPulley is improved to be more "formal" as opposed to just blindly usingan x64 relocation and assuming it works out. The intention here is tomake Pulley behave more similarly to other platforms in all theserespects while also enabling usage of Wasmtime to eventually use`symbol_addr` to calculate an address relative to the current PC(similar to x64).This includes Cranelift golden tests as well as more filetests beingrun, but the actual integration into Wasmtime will be deferred to afuture commit. List of files: /wasmtime-44.0.1/cranelift/codegen/src/isa/pulley_shared/inst/args.rs

703871a2 - Enable the `useless_conversion` Clippy lint (#10838)

Tue, 27 May 2025 16:49:22 +0000

Enable the `useless_conversion` Clippy lint (#10838)* Enable the `useless_conversion` Clippy lintWe've got lots of types in Wasmtime and convert between them quite alot, but often over time conversions become unnecessary throughrefactorings or similar. This will hopefully enable us to clean up someconversions as they come up to try to have as few as possible ideally.* Review comments List of files: /wasmtime-44.0.1/cranelift/codegen/src/isa/pulley_shared/inst/args.rs

9260ce47 - pulley: Reimplement wasm loads/stores & memory opcodes (#10154)

Mon, 10 Feb 2025 18:05:03 +0000

pulley: Reimplement wasm loads/stores & memory opcodes (#10154)* pulley: Reimplement wasm loads/stores & memory opcodesThis commit is a large refactoring to reimplement how WebAssemblyloads/stores are translated to Pulley opcodes when using theinterpreter. Additionally the functionality related to memory supporthas changed quite a bit with the interpreter as well. This is all basedoff comments on #10102 with the end goal of folding the two Pulleyopcodes today of "do the bounds check" and "do the load" into oneopcode. This is intended to reduce the number of opcodes and overallimprove interpreter throughput by minimizing turns of the interpreterloop.The basic idea behind this PR is that a new basic suite of loads/storesare added to Pulley which trap if the address is zero. This provides aroute to translate trapping loads/stores in CLIF to Pulley bytecodewithout actually causing segfaults at runtime. WebAssembly translationto CLIF is then updated to use the `select` trick for wasm loads/storeswhere either 0 is loaded from or the actual address is loaded from.Basic support for translation and such is added for this everywhere, andthis ensures that all loads/stores for wasm will be translatedsuccessfully with Pulley.The next step was to extend the "g32" addressing mode preexisting inPulley to support a bounds check as well. New pattern-matches were addedto ISLE to search for a bounds check in the address of a trappingload/store. If found then the entire chain of operations necessary tocompute the address are folded into a single "g32" opcode which ends upbeing a fallible load/store at runtime.To fit all this into Pulley this commit contains a number ofrefactorings to shuffle around existing opcodes related to memory andextend various pieces of functionality here and there:* Pulley now uses a `AddrFoo` types to represent addressing modes as a single immediate rather than splitting it up into pieces for each method. For example `AddrO32` represents "base + offset32". `AddrZ` represents the same thing but traps if the address is zero. The `AddrG32` mode represents a bounds-checked 32-bit linear memory access on behalf of wasm.* Pulley loads/stores were reduced to always using an `AddrFoo` immediate. This means that the old `offset8` addressing mode was removed without replacement here (to be added in the future if necessary). Additionally the suite of sign-extension modes supported were trimmed down to remove 8-to-64, 16-to-64, and 32-to-64 extensions folded as part of the opcode. These can of course always be re-added later but probably want to be added just for the `G32` addressing mode as opposed to all addressing modes.* The interpreter itself was refactored to have an `AddressingMode` trait to ensure that all memory accesses, regardless of addressing modes, are largely just copy/pastes of each other. In the future it might make sense to implement these methods with a macro, but for now it's copy/paste.* In ISLE the `XLoad` generic instruction removed its `ext` field to have extensions handled exclusively in ISLE instead of partly in `emit.rs`.* Float/vector loads/stores now have "g32" addressing (in addition to the "z" that's required for wasm) since it was easy to add them.* Translation of 1-byte accesses on Pulley from WebAssembly to CLIF no longer has a special case for using `a >= b` instead of `a > b - 1` to ensure that the same bounds-check instruction can be used for all sizes of loads/stores.* The bounds-check which folded a load-of-the-bound into the opcode is now present as a "g32bne" addressing mode. with its of suite of instructions to boo.Overall this PR is not a 1:1 replacement of all previous opcodes withexactly one opcode. For example loading 8 bits sign-extended to 64-bitsis now two opcodes instead of one. Additionally some previous opcodeshave expanded in size where for example the 8-bit offset mode was removein favor of only having 32-bit offsets. The goal of this PR is to reboothow memory is handled in Pulley. All loads/stores now use a specificaddressing mode and currently all operations supported across addressingmodes are consistently supported. In the future it's expected that somefeatures will be added to some addressing modes and not others asnecessary, for example extending the "g32" addressing mode only insteadof all addressing modes.For an evaluation of this PR:* Code size: `spidermonkey.cwasm` file is reduced from 19M to 16M.* Sightglass: `pulldown-cmark` is improved by 15%* Sightglass: `bz2` is improved by 20%* Sightglass: `spidermonkey` is improved by 22%* Coremark: score improved by 40%Overall this PR and new design looks to be a large win. This is alldriven by the reduction in opcodes both for compiled code size andexecution speed by minimizing turns of the interpreter loop. In the endI'm also pretty happy with how this turned out and I think therefactorings are well worth it.* Use new `is_pulley` helper more* Improve `addrz` helper, tighten up `memory-inbounds.wat` a bit* Improve codegen in a few `memory-inbounds.wat` cases* Fix test expectation List of files: /wasmtime-44.0.1/cranelift/codegen/src/isa/pulley_shared/inst/args.rs

47a60e83 - fix typo (#9906)

Fri, 27 Dec 2024 17:02:21 +0000

fix typo (#9906)Signed-off-by: Jack Drogon List of files: /wasmtime-44.0.1/cranelift/codegen/src/isa/pulley_shared/inst/args.rs

f6f447b0 - pulley: Add macro `CallN` instructions (#9874)

Fri, 20 Dec 2024 16:17:49 +0000

pulley: Add macro `CallN` instructions (#9874)* pulley: Add macro `CallN` instructionsThis commit adds new macro instructions to assist with speeding up callsbetween functions. Pulley's previous `Call` instruction was similar tonative call instructions where arguments/results are implicitly in theright location according to the ABI, but movement between registers ismore expensive with Pulley than with native architectures. The `CallN`instructions here enable listing a few arguments (only integerregisters) in the opcode itself. This removes the need for individual `xmov`instructions into individual registers and instead it can all be donewithin the opcode handlers.This additionally enables passing the same argument twice to a functionto reside only in one register. Finally parallel-copies between theseregisters are supported as the interpreter loads all registers and thenstores all registers.These new instructions participate in register allocation differentlyfrom before where the first few arguments are allowed to be in anyregister and no longer use `reg_fixed_use`. All other arguments (and allfloat arguments for example) continue to use `reg_fixed_use`.Locally sightglass reports this change speeding up `pulldown-cmark` by2-10%. On a `fib(N)` micro-benchmark it didn't help as much as I washoping that it was going to.* Fix MSRV List of files: /wasmtime-44.0.1/cranelift/codegen/src/isa/pulley_shared/inst/args.rs

41787661 - pulley: Add branch-with-compare-against-immediate (#9863)

Thu, 19 Dec 2024 06:00:01 +0000

pulley: Add branch-with-compare-against-immediate (#9863)This commit adds a large number of new `br_if_x*` instructions whichcompare with an immediate instead of comparing two registers. This ispretty common in wasm/compiled code where, for example, loop upperbounds are often constants. This helps compress code slightly whilefusing more instructions together.The main cost of this is that the number of opcodes added here is quitelarge. Like with previous immediate-taking opcodes both 8 and 32-bitvariants of immediates are added for all comparisons. Additionallyunlike the previous set of branch-and-compare instructions it's requiredto add instructions for `>` and `>=` because the operands cannot beswapped to invert the condition, further increasing the number ofopcodes added.This is a mild size reduction on `spidermonkey.cwasm` from 29M to 28Mbut it's mostly expected to be a performance win for interpreted loops. List of files: /wasmtime-44.0.1/cranelift/codegen/src/isa/pulley_shared/inst/args.rs

04a37367 - pulley: Refactor conditional branches and table codegen (#9794)

Thu, 12 Dec 2024 14:08:21 +0000

pulley: Refactor conditional branches and table codegen (#9794)This commit first fixed an issue with table access codegen to disablespectre mitigations on Pulley targets like how spectre is disabled formemory accesses as well. This unblocked many tests related to tableswhich then led to a different error about a `trapnz` with an 8-bit valuenot being supported.In fixing `trapnz` with 8-bit values this PR went ahead and did ageneral-purpose refactoring for how conditional branches are managed.Previously conditional traps and conditional branches had someduplicated logic and the goal was to unify everything. There is now asingle `Cond` which represents the condition of a conditional jump whichis used uniformly for all locations such as `select`, `brif`, and`trap[n]z`. This new type represents all the sorts of conditionalbranches that can be done in Pulley, for example integer comparisons andwhether or not a register is zero. This `Cond` type has various helpersfor printing it, inverting it, collecting operands, emission, etc.The end result is that it's a bit wordy to work with `Cond` right nowdue to the size of the variants but all locations working withconditional traps are deduplicated and now it's just repetitive logicrather than duplicated logic.Putting all of this together gets a large batch of spec tests working.I'll note that this does remove a feature where `trapnz` was turned intonothing or an unconditional trap if the argument was a constant, butthat feels like an optimization perhaps best left for the middle-endrather than doing it in the backend.cc #9783 List of files: /wasmtime-44.0.1/cranelift/codegen/src/isa/pulley_shared/inst/args.rs

23e8dcea - pulley: Implement more of loads/stores (#9775)

Tue, 10 Dec 2024 18:29:10 +0000

pulley: Implement more of loads/stores (#9775)* pulley: Implement more of loads/storesThis commit gets the `address.wast` spec test working by filling outmore load/store infrastructure in Pulley. In doing so I've done arefactoring of the existing load/store methods. Changes here are:* All load/stores are `*_offset32` now instead of optionally having no offset, a 8-bit offset, or a 64-bit offset.* All x-register loads/stores are prefixed with `x` now.* All loads/stores have "le" for little-endian in their name.* Loads/stores are refactored to have 8 and 16-bit variants.* Sign-extending loads now either extend to 32 or 64 depending on the opcode.* Float loads/stores are added.* Big-endian is handled with explicit big-endian loads/stores instead `bswap` to handle this transparently in the backend (e.g. for stores not ISLE-generated) and to handle floats.* Remove pulley interpreter fuzz targetThis is a bit onerous to keep updated and is probably best subsumed bythe fuzzing support we have in general for wasm.* Update pulley tests* Fixes from a rebase* Review comments* Update test expectations List of files: /wasmtime-44.0.1/cranelift/codegen/src/isa/pulley_shared/inst/args.rs

70a37939 - Support executing Pulley in Wasmtime (#9744)

Fri, 06 Dec 2024 20:23:55 +0000

Support executing Pulley in Wasmtime (#9744)* Support executing Pulley in WasmtimeThis commit is the initial implementation of executing the Pulleyinterpreter from the `wasmtime` crate. This gives access to all of the`wasmtime` crate's runtime APIs backed by execution of bytecode inPulley. This builds on the previous PRs I've been making for support inPulley to culminate in testing on CI in this PR. This PR handles somefinal tidbits related to producing a runnable image that can beinterpreted by the `wasmtime` crate such as:* Pulley compilation artifacts are no longer marked as natively executable, just read-only.* Pulley compilation artifacts include wasm-to-array trampolines like normal platforms (removes a pulley special-case).* Dispatch of host calls from Pulley to the Wasmtime runtime are implemented.* Pulley's list of panicking wasm features is slimmed down as most are covered by "this lowering isn't supported" errors.* Execution of wasm code now has an `if` to see whether Pulley is enabled within a `Store` or not.* Traps and basic "unwinding" of the pulley stack are implemented (e.g. a "pulley version" of `setjmp` and `longjmp`, sort of)* Halting the interpreter has been refactored to help shrink the size of `ControlFlow` and handle metadata with each done state.Some minor refactorings are also included here and there along with afew fixes here and there necessary to get tests passing.The next major part of this commit is updates to our `wast` test suiteand executing all `*.wast` files. Pulley is now executed by default forall files as a new execution engine. This means that all platforms in CIwill start executing Pulley tests. At this time almost all tests areflagged as "expected to fail" but there are a small handful ofallow-listed tests which are expected to pass. This exact list willchange over time as CLIF lowerings are implemented and the interpreteris extended.Follow-up PRs will extend the testing strategy further such as:* Extending `#[wasmtime_test]` to include Pulley in addition to Winch.* Getting testing set up on CI for 32-bit platforms.prtest:full* Fix pulley fuzz build* Fix clippy lints* Shuffle around some `#[cfg]`'d code* Remove unused imports* Update feature sets testing MIRIEnable pulley for wasmtime/wasmtime-cli and also enable all features forwasmtime-environ* Round up pulley's page size to 64k* Skip pulley tests on s390x for now* Add a safety rail for matching a pulley target to the host* Fix more pulley tests on s390x* Review comments* Fix fuzz build List of files: /wasmtime-44.0.1/cranelift/codegen/src/isa/pulley_shared/inst/args.rs

3b6dc591 - pulley: Remove virtual sp offset (#9722)

Wed, 04 Dec 2024 00:37:12 +0000

pulley: Remove virtual sp offset (#9722)This fixes the output of the pulley cranelift backend with respect tovirtual stack offsets and adjustments for calls with stack parametersand results. Previously the virtual stack pointer was updated but therest of the backend assumed the real stack pointer was updated. Thisupdates the pulley backend to match the other backends in this respectsand fixes a test on my "more complete pulley integration" branch. List of files: /wasmtime-44.0.1/cranelift/codegen/src/isa/pulley_shared/inst/args.rs

75a4d279 - pulley: Implement `get_frame_pointer` (#9658)

Tue, 03 Dec 2024 18:32:25 +0000

pulley: Implement `get_frame_pointer` (#9658)* pulley: Implement `get_frame_pointer`This commit implements the CLIF `get_frame_pointer` instruction whichwill be needed by trampolines in Wasmtime. This is implemented bygeneralizing the preexisting `GetSp` `MInst` into a "get special". Thisthe additionally removes the extended `get_sp` opcode in Pulley as it'snot necessary as `xmov` can operate on this register.* Review comments List of files: /wasmtime-44.0.1/cranelift/codegen/src/isa/pulley_shared/inst/args.rs

67674881 - pulley: Remove special registers as candidates from regalloc (#9666)

Fri, 22 Nov 2024 23:35:23 +0000

pulley: Remove special registers as candidates from regalloc (#9666)* pulley: Remove special registers as candidates from regallocThis commit fixes a minor mistake where regalloc was allowed to allocate"special registers" such as the stack pointer, the frame pointer, etc.These register shouldn't participate in general-purpose registerallocation, so they're removed from the list of non-preferred registerswhen metadata is provided to regalloc2.* Assert everything before SPECIAL_START is not special List of files: /wasmtime-44.0.1/cranelift/codegen/src/isa/pulley_shared/inst/args.rs

617f68ad - Add support for stack limit checks in Cranelift's Pulley backend (#9238)

Thu, 12 Sep 2024 22:25:47 +0000

Add support for stack limit checks in Cranelift's Pulley backend (#9238) List of files: /wasmtime-44.0.1/cranelift/codegen/src/isa/pulley_shared/inst/args.rs

7059c570 - pulley: pack `dst`, `src1` and `src2` registers into 2 bytes (#9088)

Mon, 19 Aug 2024 20:10:16 +0000

pulley: pack `dst`, `src1` and `src2` registers into 2 bytes (#9088)* pulley: use enums for `{X,F,V}Reg`Copyright (c) 2024, Arm Limited.Signed-off-by: Karl Meakin * pulley: add `BinaryOperands`Copyright (c) 2024, Arm Limited.Signed-off-by: Karl Meakin * pulley: use `BinaryOperands` for binary operatorsCopyright (c) 2024, Arm Limited.Signed-off-by: Karl Meakin ---------Signed-off-by: Karl Meakin List of files: /wasmtime-44.0.1/cranelift/codegen/src/isa/pulley_shared/inst/args.rs

b5268651 - Cranelift: Add a new backend for emitting Pulley bytecode (#9089)

Wed, 14 Aug 2024 21:17:30 +0000

Cranelift: Add a new backend for emitting Pulley bytecode (#9089)* Cranelift: Add a new backend for emitting Pulley bytecodeThis commit adds two new backends for Cranelift that emits 32- and 64-bit Pulleybytecode. The backends are both actually the same, with a common implementationliving in `cranelift/codegen/src/isa/pulley_shared`. Each backend configures anISA flag that determines the pointer size, and lowering inspects this flag'svalue when lowering memory accesses.To avoid multiple ISLE compilation units, and to avoid compiling duplicatecopies of Pulley's generated `MInst`, I couldn't use `MInst` as the `MachInst`implementation directly. Instead, there is an `InstAndKind` type that is anewtype over the generated `MInst` but which also carries a phantom typeparameter that implements the `PulleyTargetKind` trait. There are twoimplementations of this trait, a 32- and 64-bit version. This is necessarybecause there are various static trait methods for the mach backend which wemust implement, and which return the pointer width, but don't have access to any`self`. Therefore, we are forced to monomorphize some amount of code. This typeparameter is fairly infectious, and all the "big" backendtypes (`PulleyBackend

`, `PulleyABICallSite

`, etc...) are parameterizedover it. Nonetheless, not everything is parameterized over a `PulleyTargetKind`,and we manage to avoid duplicate `MInst` definitions and lowering code.Note that many methods are still stubbed out with `todo!`s. It is expected thatwe will fill in those implementations as the work on Pulley progresses.* Trust the `pulley-interpreter` crate, as it is part of our workspace* fix some clippy warnings* Fix a dead-code warning from inside generated code* Use a helper for emitting br_if+comparison instructions* Add a helper for converting `Reg` to `pulley_interpreter::XReg`* Add version to pulley workspace dependency* search the pulley directory for crates in the publish script List of files: /wasmtime-44.0.1/cranelift/codegen/src/isa/pulley_shared/inst/args.rs