Changes in globalvalue.rs

a0442ea0 - Enforce `uninlined_format_args` for the workspace (#9065)

Mon, 05 Aug 2024 09:59:59 +0000

Enforce `uninlined_format_args` for the workspace (#9065)* Enforce `uninlined_format_args` for the workspace* fix: failing `Monolith Checks` job* fix: formatting List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/globalvalue.rs

c510a2b9 - Couple of small improvements for debugging Cranelift (#8885)

Tue, 02 Jul 2024 16:29:16 +0000

Couple of small improvements for debugging Cranelift (#8885)* Print block params and branch args in vcode* Implement Debug for JumpTableData and GlobalValueData List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/globalvalue.rs

8e00cc20 - PCC: initial end-to-end integration with Wasmtime's static memories. (#7274)

Tue, 17 Oct 2023 23:52:34 +0000

PCC: initial end-to-end integration with Wasmtime's static memories. (#7274)* PCC: add facts to global values, parse and print them. No verification yet.Co-authored-by: Nick Fitzgerald * PCC: propagate facts on GV loads and check them.Co-authored-by: Nick Fitzgerald * PCC: support propagating facts on iteratively-elaborated GVs as well.Co-authored-by: Nick Fitzgerald * PCC: fix up Wasmtime uses of GVs after refactors to memflags handling.Co-authored-by: Nick Fitzgerald * PCC: working end-to-end for static memories!Co-authored-by: Nick Fitzgerald * PCC: add toplevel Wasmtime option `-C enable-pcc=y`.* Fix filetests build.* Review feedback, and blessed test updates due to GV legalization changes.---------Co-authored-by: Nick Fitzgerald List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/globalvalue.rs

9ec02f9d - Decouple `serde` from its `derive` crate (#6917)

Tue, 29 Aug 2023 16:02:06 +0000

Decouple `serde` from its `derive` crate (#6917)By not activating the `derive` feature on `serde`, the compilation speedcan be improved by a lot. This is because `serde` can then compile inparallel to `serde_derive`, allowing it to finish compilation possiblyeven before `serde_derive`, unblocking all the crates waiting for`serde` to start compiling much sooner.As it turns out the main deciding factor for how long the compile time of aproject is, is primarly determined by the depth of dependencies ratherthan the width. In other words, a crate's compile times aren't affectedby how many crates it depends on, but rather by the longest chain ofdependencies that it needs to wait on. In many cases `serde` is part ofthat long chain, as it is part of a long chain if the `derive` featureis active:`proc-macro2` compile build script > `proc-macro2` run build script >`proc-macro2` > `quote` > `syn` > `serde_derive` > `serde` >`serde_json` (or any crate that depends on serde)By decoupling it from `serde_derive`, the chain is shortened and compiletimes get much better.Check this issue for a deeper elaboration:https://github.com/serde-rs/serde/issues/2584For `wasmtime` I'm seeing a reduction from 24.75s to 22.45s whencompiling in `release` mode. This is because wasmtime through `gimli`has a dependency on `indexmap` which can only start compiling when`serde` is finished, which you want to happen as early as possible sosome of wasmtime's dependencies can start compiling.To measure the full effect, the dependencies can't by themselvesactivate the `derive` feature. I've upstreamed a patch for`fxprof-processed-profile` which was the only dependency that activatedit for `wasmtime` (not yet published to crates.io). `wasmtime-cli` andco. may need patches for their dependencies to see a similarimprovement. List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/globalvalue.rs

729e2640 - A bunch of minor cleanups (#6767)

Tue, 25 Jul 2023 14:48:37 +0000

A bunch of minor cleanups (#6767)* Remove DisplayFunctionAnnotationsIt used to exist for printing the debuginfo value ranges with the clifir, but this no longer happens, so it is now useless.* Remove debug info collection from DummyEnvironmentThere are no remaining users of it* Remove ComparableSourceLocIt is unused* Move LabelValueLoc re-export out of the ir moduleIt encodes target specific information, so shouldn't be in the targetindependent ir module.* Remove RelocDistance dependency from ir::extfunc and ir::globalvalue List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/globalvalue.rs

3b6544dc - Fix warnings in `cranelift-codegen` docs builds (#5292)

Thu, 17 Nov 2022 21:13:24 +0000

Fix warnings in `cranelift-codegen` docs builds (#5292) List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/globalvalue.rs

8a9b1a90 - Implement an incremental compilation cache for Cranelift (#4551)

Fri, 12 Aug 2022 16:47:43 +0000

Implement an incremental compilation cache for Cranelift (#4551)This is the implementation of https://github.com/bytecodealliance/wasmtime/issues/4155, using the "inverted API" approach suggested by @cfallin (thanks!) in Cranelift, and trait object to provide a backend for an all-included experience in Wasmtime. After the suggestion of Chris, `Function` has been split into mostly two parts: - on the one hand, `FunctionStencil` contains all the fields required during compilation, and that act as a compilation cache key: if two function stencils are the same, then the result of their compilation (`CompiledCodeBase`) will be the same. This makes caching trivial, as the only thing to cache is the `FunctionStencil`. - on the other hand, `FunctionParameters` contain the... function parameters that are required to finalize the result of compilation into a `CompiledCode` (aka `CompiledCodeBase`) with proper final relocations etc., by applying fixups and so on. Most changes are here to accomodate those requirements, in particular that `FunctionStencil` should be `Hash`able to be used as a key in the cache: - most source locations are now relative to a base source location in the function, and as such they're encoded as `RelSourceLoc` in the `FunctionStencil`. This required changes so that there's no need to explicitly mark a `SourceLoc` as the base source location, it's automatically detected instead the first time a non-default `SourceLoc` is set. - user-defined external names in the `FunctionStencil` (aka before this patch `ExternalName::User { namespace, index }`) are now references into an external table of `UserExternalNameRef -> UserExternalName`, present in the `FunctionParameters`, and must be explicitly declared using `Function::declare_imported_user_function`. - some refactorings have been made for function names: - `ExternalName` was used as the type for a `Function`'s name; while it thus allowed `ExternalName::Libcall` in this place, this would have been quite confusing to use it there. Instead, a new enum `UserFuncName` is introduced for this name, that's either a user-defined function name (the above `UserExternalName`) or a test case name. - The future of `ExternalName` is likely to become a full reference into the `FunctionParameters`'s mapping, instead of being "either a handle for user-defined external names, or the thing itself for other variants". I'm running out of time to do this, and this is not trivial as it implies touching ISLE which I'm less familiar with. The cache computes a sha256 hash of the `FunctionStencil`, and uses this as the cache key. No equality check (using `PartialEq`) is performed in addition to the hash being the same, as we hope that this is sufficient data to avoid collisions. A basic fuzz target has been introduced that tries to do the bare minimum: - check that a function successfully compiled and cached will be also successfully reloaded from the cache, and returns the exact same function. - check that a trivial modification in the external mapping of `UserExternalNameRef -> UserExternalName` hits the cache, and that other modifications don't hit the cache. - This last check is less efficient and less likely to happen, so probably should be rethought a bit. Thanks to both @alexcrichton and @cfallin for your very useful feedback on Zulip. Some numbers show that for a large wasm module we're using internally, this is a 20% compile-time speedup, because so many `FunctionStencil`s are the same, even within a single module. For a group of modules that have a lot of code in common, we get hit rates up to 70% when they're used together. When a single function changes in a wasm module, every other function is reloaded; that's still slower than I expect (between 10% and 50% of the overall compile time), so there's likely room for improvement. Fixes #4155. List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/globalvalue.rs

9c43749d - [RFC] Dynamic Vector Support (#4200)

Thu, 07 Jul 2022 19:54:39 +0000

[RFC] Dynamic Vector Support (#4200)Introduce a new concept in the IR that allows a producer to create dynamic vector types. An IR function can now contain global value(s) that represent a dynamic scaling factor, for a given fixed-width vector type. A dynamic type is then created by 'multiplying' the corresponding global value with a fixed-width type. These new types can be used just like the existing types and the type system has a set of hard-coded dynamic types, such as I32X4XN, which the user defined types map onto. The dynamic types are also used explicitly to create dynamic stack slots, which have no set size like their existing counterparts. New IR instructions are added to access these new stack entities. Currently, during codegen, the dynamic scaling factor has to be lowered to a constant so the dynamic slots do eventually have a compile-time known size, as do spill slots. The current lowering for aarch64 just targets Neon, using a dynamic scale of 1. Copyright (c) 2022, Arm Limited. List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/globalvalue.rs

2fc964ea - Add serde serialization support for the full clif ir

Sat, 19 Dec 2020 15:32:46 +0000

Add serde serialization support for the full clif ir List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/globalvalue.rs

0acd2072 - Fix doc warnings and link failures (#1948)

Tue, 30 Jun 2020 18:01:49 +0000

Fix doc warnings and link failures (#1948)Also add configuration to CI to fail doc generation if any links are broken. Unfortunately we can't blanket deny all warnings in rustdoc since some are unconditional warnings, but for now this is hopefully good enough. Closes #1947 List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/globalvalue.rs

e39b4aba - Fix long-range (non-colocated) aarch64 calls to not use Arm64Call reloc, and fix simplejit to use it.

Tue, 21 Apr 2020 19:23:10 +0000

Fix long-range (non-colocated) aarch64 calls to not use Arm64Call reloc, and fix simplejit to use it.Previously, every call was lowered on AArch64 to a `call` instruction, whichtakes a signed 26-bit PC-relative offset. Including the 2-bit left shift, thisgives a range of +/- 128 MB. Longer-distance offsets would cause an impossiblerelocation record to be emitted (or rather, a record that a more sophisticatedlinker would fix up by inserting a shim/veneer).This commit adds a notion of "relocation distance" in the MachInst backends,and provides this information for every call target and symbol reference. Theintent is that backends on architectures like AArch64, where there are differentoffset sizes / addressing strategies to choose from, can either emit a regularcall or a load-64-bit-constant / call-indirect sequence, as necessary. Thisavoids the need to implement complex linking behavior.The MachInst driver code provides this information based on the "colocated" bitin the CLIF symbol references, which appears to have been designed for thispurpose, or at least a similar one. Combined with the `use_colocated_libcalls`setting, this allows client code to ensure that library calls can link tolibrary code at any location in the address space.Separately, the `simplejit` example did not handle `Arm64Call`; rather than doingso, it appears all that is necessary to get its tests to pass is to set the`use_colocated_libcalls` flag to false, to make use of the above change. Thisfixes the `libcall_function` unit-test in this crate. List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/globalvalue.rs

0a1bb3ba - Add TLS support for ELF and MachO (#1174)

Wed, 26 Feb 2020 01:50:04 +0000

Add TLS support for ELF and MachO (#1174)* Add TLS support * Add binemit and legalize tests * Spill all caller-saved registers when necessary List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/globalvalue.rs

9f506692 - Fix clippy warnings.

Thu, 24 Oct 2019 06:15:42 +0000

Fix clippy warnings.This commit fixes the current set of (stable) clippy warnings in the repo. List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/globalvalue.rs

d7d48d5c - Add the dyn keyword before trait objects;

Thu, 06 Jun 2019 08:11:41 +0000

Add the dyn keyword before trait objects; List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/globalvalue.rs

166c11af - Fix global value colocated printing

Sat, 23 Feb 2019 10:13:24 +0000

Fix global value colocated printingIt used to print `gv0 = colocated symbol u1:1` while cranelift-readerexpects `gv0 = symbol colocated u1:1`. List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/globalvalue.rs

747ad3c4 - moved crates in lib/ to src/, renamed crates, modified some files' text (#660)

Mon, 28 Jan 2019 23:56:54 +0000

moved crates in lib/ to src/, renamed crates, modified some files' text (#660)moved crates in lib/ to src/, renamed crates, modified some files' text (#660) List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/globalvalue.rs