Changes in function.rs

2f7dbd61 - PCC: remove proof-carrying code (for now?). (#12800)

Tue, 31 Mar 2026 04:36:33 +0000

PCC: remove proof-carrying code (for now?). (#12800)In late 2023, we built out an experimental feature calledProof-Carrying Code (PCC), where we attached "facts" to values in theCLIF IR and built verification of these facts after lowering tomachine instructions. We also added "memory types" describing layoutof memory and a "checked" flag on memory operations such that we couldverify that any checked memory operation accessed valid memory (asdefined by memory types attached to pointer values viafacts). Wasmtime's Cranelift backend then put appropriate memory typesand facts in its IR such that all accesses to memory (aspirationally)could be checked, taking the whole mid-end and lowering backend ofCranelift out of the trusted core that enforces SFI.This basically worked, at the time, for static memories; but never fordynamic memories, and then work on the feature lostprioritization (aka I had to work on other things) and I wasn't ableto complete it and put it in fuzzing/enable it as a production option.Unfortunately since then it has bit-rotted significantly -- as we addnew backend optimizations and instruction lowerings we haven't keptthe PCC framework up to date.Inspired by the discussion in #12497 I think it's time to deleteit (hopefully just "for now"?) unless/until we can build it again. Andwhen we do that, we should probably get it to the point of validatingrobust operation on all combinations of memory configurations beforemerging. (That implies a big experiment branch rather than a bunch ofeager PRs in-tree, but so it goes.) I still believe it is possible tobuild this (and I have ideas on how to do it!) but not right now. List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/function.rs

a3d6e407 - Cranelift: add debug tag infrastructure. (#11768)

Mon, 06 Oct 2025 19:38:03 +0000

Cranelift: add debug tag infrastructure. (#11768)* Cranelift: add debug tag infrastructure.This PR adds *debug tags*, a kind of metadata that can attach to CLIFinstructions and be lowered to VCode instructions and as metadata onthe produced compiled code. It also adds opaque descriptor blobscarried with stackslots. Together, these two features allow decoratingIR with first-class debug instrumentation that is properly preservedby the compiler, including across optimizations andinlining. (Wasmtime's use of these features will come in followupPRs.)The key idea of a "debug tag" is to allow the Cranelift embedder toexpress whatever information it needs to, in a format that is opaqueto Cranelift itself, except for the parts that need translation duringlowering. In particular, the `DebugTag::StackSlot` variant getstranslated to a physical offset into the stackframe in the compiledmetadata output. So, for example, the embedder can emit a tagreferring to a stackslot, and another describing an offset in thatstackslot.The debug tags exist as a *sequence* on any given instruction; themeaning of the sequence is known only to the embedder, *except* thatduring inlining, the tags for the inlining call instruction areprepended to the tags of inlined instructions. In this way, acanonical use-case of tags as describing original source-languageframes can preserve the source-language view even when multiplefunctions are inlined into one.The descriptor on a stackslot may look a little odd at first, but itspurpose is to allow serializing some description ofstackslot-contained runtime user-program data, in a way that is firmlyattached to the stackslot. In particular, in the face of inlining,this descriptor is copied into the inlining (parent) function from theinlined function when the stackslot entity is copied; no othermetadata outside Cranelift needs to track the identity of stackslotsand know about that motion. This fits nicely with the ability of tagsto refer to stackslots; together, the embedder can annotateinstructions as having certain state in stackslots, and describe theformat of that state per stackslot.This infrastructure is tested with some compile-tests now;testing of the interpretation of the metadata output will come withend-to-end debug instrumentation tests in a followup PR.* Review feedback: add back sequence points and enforce tags only on sequence points or calls.* Use Vecs for debug metadata in MachBuffer to avoid SmallVec size penalty in not-used case.* Review feedback: switch from inlined stackslot descriptor blobs to u64 keys. List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/function.rs

3fe9c3c7 - fix: accurate leaf detection (#11581)

Wed, 03 Sep 2025 15:57:55 +0000

fix: accurate leaf detection (#11581)* feat: add is_call() method to MachInst trait and VCode analysisAdd is_call() method to MachInst trait to enable accurate leaf functiondetection during register allocation. Update VCode compute_clobbers() toreturn (clobbers, is_leaf) tuple by analyzing actual call instructionsin machine code.* feat: implement is_call() method across all architecturesImplement is_call() method for all architecture-specific MachInstimplementations:- x64: Detects CallKnown, CallUnknown, ReturnCall variants, and TLScalls (ElfTlsGetAddr, MachOTlsGetAddr)- aarch64: Detects Call, CallInd, ReturnCall variants, and TLS calls(ElfTlsGetAddr, MachOTlsGetAddr)- riscv64: Detects Call, CallInd, ReturnCall variants, and ElfTlsGetAddr- s390x: Detects CallKnown, CallUnknown, ReturnCall variants- pulley: Detects Call, CallIndirect, ReturnCall variantsCo-authored-by: bjorn3 <17426603+bjorn3@users.noreply.github.com>* feat: improve leaf function detection and pass is_leaf to FrameLayout* test: add filetests for leaf detection* test: update expected outputs for accurate leaf function detection* test(riscv64): update filetests output---------Co-authored-by: bjorn3 <17426603+bjorn3@users.noreply.github.com> List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/function.rs

90ac295e - Update Wasmtime to the 2024 Rust Edition (#10806)

Mon, 19 May 2025 16:40:55 +0000

Update Wasmtime to the 2024 Rust Edition (#10806)* Update Wasmtime to the 2024 Rust EditionNow that our MSRV supports the 2024 edition it's possible to make thisswitch. This commit moves Wasmtime to the 2024 Edition to keepup-to-date with Rust idioms and access many of the edition featuresexclusive to the 2024 edition.prtest:full* Reformat with the 2024 edition List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/function.rs

3da7fc8e - [DI] Dump value label assignments in a table (#10549)

Tue, 08 Apr 2025 19:42:14 +0000

[DI] Dump value label assignments in a table (#10549)* Dump compilation start/end* [DI] Log value label ranges in a tableSample table:|Inst |IP |VL0 |VL1 |VL3 |VL4 |VL5 |VL7 |VL10 |VL11 |VL4294967294||--------|----|--------|---------|---------|--------|--------|--------|---------|--------|------------||Inst 0 |53 | | | | | | | | | | | | | | | | | | ||Inst 1 |53 | | | | | | | | | | | | | | | | | | ||Inst 2 |60 |v194|p2i|v232|p12i| | | | | | | | | | | | |v192|p7i ||Inst 3 |64 |* |p2i|* |p12i|v231|p13i| | | | | | | | | | |* |p7i ||Inst 4 |68 |* |p2i|* |p12i|* |p13i| | | | | | | | | | |* |p7i ||Inst 5 |72 |* |p2i|* |p12i|* |p13i| | | | | | | | | | |* |p7i ||Inst 6 |76 |* |p2i|* |p12i|* |p13i| | | | | | | | | | |* |p7i ||Inst 7 |87 |* | |* |p12i|* |p13i| | | | | | | | | | |* |p7i ||Inst 8 |92 |* | |* |p12i|* |p13i|v227|p0i| | | | | | | | |* |p15i ||Inst 9 |94 |* | |v204| |v204| |v204| |v204| |v204| |v204| |v204| |* |p15i ||Inst 10 |100 |* | |* | |* | |* | |* | |* | |* | |* | |* |p15i ||Inst 11 |105 |* | |* | |* | |* | |v226|p9i|* | |* | |* | |* |p15i ||Inst 12 |109 |* | |* | |* | |* | |* | |v225|p9i|* | |* | |* |p15i ||Inst 13 |114 |* | |* | |* | |* | |* | |* | |* | |* | |* |p15i ||Inst 14 |119 |* | |* | |* | |* | |* | |* | |* | |* | |* |p15i ||Inst 15 |125 |* | |* | |* | |* | |* | |* | |* | |* | |* |p15i ||Inst 16 |129 |* | |* | |* | |* | |* | |* | |v223|p11i|* | |* |p15i ||Inst 17 |134 |* | |* | |* | |* | |* | |* | |* | |* | |* |p15i ||Inst 18 |134 |* | |* | |* | |* | |* | |* | |* | |* | |* |p15i ||Inst 19 |139 |* | |* | |* | |* | |* | |* | |* | |v222|p0i|* |p15i ||Inst 20 |143 |* | |* | |* | |* | |* | |* | |* | |* |p0i|* |p15i ||Inst 21 |143 |* | |* | |* | |* | |* | |* | |* | |* |p0i|* | |This will make it much easier to diagnose problems with incomplete/missing live ranges. List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/function.rs

94ec88ea - Cranelift: initial try_call / try_call_indirect (exception) support. (#10510)

Tue, 08 Apr 2025 00:02:16 +0000

Cranelift: initial try_call / try_call_indirect (exception) support. (#10510)* Cranelift: initial try_call / try_call_indirect (exception) support.This PR adds `try_call` and `try_call_indirect` instructions, andlowerings on four of five ISAs (x86-64, aarch64, riscv64, pulley; s390xhas its own non-shared ABI code that will need separate work).It extends CLIF to support these instructions as new kinds of branches,and extends block-calls to accept `retN` and `exnN` block-call args thatcarry the normal return values or exception payloads (respectively) intothe appropriate successor blocks.It wires up the "normal return path" so that it continues to work.It updates the ABI so that unwinding is possible without an initialregister state at throw: specifically, as per our RFC, all registers areclobbered. It also includes metadata in the `MachBuffer` that describesexception-catch destinations. However, no unwinder exists to interpretthese catch-destinations yet, so they are untested.* Add try_call_indirect lowering as well. List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/function.rs

3c089804 - Don't allow jump instructions after a terminator in is_block_basic (#9592)

Mon, 11 Nov 2024 16:03:59 +0000

Don't allow jump instructions after a terminator in is_block_basic (#9592)We merged brz/brnz+jump into br_if a while ago. List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/function.rs

a0442ea0 - Enforce `uninlined_format_args` for the workspace (#9065)

Mon, 05 Aug 2024 09:59:59 +0000

Enforce `uninlined_format_args` for the workspace (#9065)* Enforce `uninlined_format_args` for the workspace* fix: failing `Monolith Checks` job* fix: formatting List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/function.rs

f763f0e7 - Cranelift: Add a helper for getting a block's successors (#9067)

Fri, 02 Aug 2024 19:08:30 +0000

Cranelift: Add a helper for getting a block's successors (#9067)Co-authored-by: Trevor Elliott List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/function.rs

c4478334 - cranelift: Remove support for WebAssembly tables (#8124)

Thu, 14 Mar 2024 15:40:25 +0000

cranelift: Remove support for WebAssembly tables (#8124)Wasmtime no longer needs any of this infrastructure and neither shouldanybody else.This diff is nearly identical to @bjorn3's version of the same change,except I didn't remove Uimm64, which has started being used in otherplaces. I forgot bjorn3 had already tackled this part until after I wasalready done, but it's reassuring that we both made the same changes.https://github.com/bjorn3/wasmtime/commit/fb82ccb3948e949641a6d9581aa84472f68f97b8Fixes #5532 List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/function.rs

8e00cc20 - PCC: initial end-to-end integration with Wasmtime's static memories. (#7274)

Tue, 17 Oct 2023 23:52:34 +0000

PCC: initial end-to-end integration with Wasmtime's static memories. (#7274)* PCC: add facts to global values, parse and print them. No verification yet.Co-authored-by: Nick Fitzgerald * PCC: propagate facts on GV loads and check them.Co-authored-by: Nick Fitzgerald * PCC: support propagating facts on iteratively-elaborated GVs as well.Co-authored-by: Nick Fitzgerald * PCC: fix up Wasmtime uses of GVs after refactors to memflags handling.Co-authored-by: Nick Fitzgerald * PCC: working end-to-end for static memories!Co-authored-by: Nick Fitzgerald * PCC: add toplevel Wasmtime option `-C enable-pcc=y`.* Fix filetests build.* Review feedback, and blessed test updates due to GV legalization changes.---------Co-authored-by: Nick Fitzgerald List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/function.rs

1ced3e8e - PCC: add basic "memory types". (#7219)

Thu, 12 Oct 2023 00:02:09 +0000

PCC: add basic "memory types". (#7219)* PCC: define memory types and add some examples in filetests (no parsing yet).* PCC: add a notion of memory types.Co-authored-by: Nick Fitzgerald * Transition `points_to` to a `memory` (static memory) memory-type.* Review feedback.---------Co-authored-by: Nick Fitzgerald List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/function.rs

a6b62d6c - cranelift: Consider functions with TLS values as non leaf (#7177)

Fri, 06 Oct 2023 19:35:43 +0000

cranelift: Consider functions with TLS values as non leaf (#7177) List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/function.rs

9ec02f9d - Decouple `serde` from its `derive` crate (#6917)

Tue, 29 Aug 2023 16:02:06 +0000

Decouple `serde` from its `derive` crate (#6917)By not activating the `derive` feature on `serde`, the compilation speedcan be improved by a lot. This is because `serde` can then compile inparallel to `serde_derive`, allowing it to finish compilation possiblyeven before `serde_derive`, unblocking all the crates waiting for`serde` to start compiling much sooner.As it turns out the main deciding factor for how long the compile time of aproject is, is primarly determined by the depth of dependencies ratherthan the width. In other words, a crate's compile times aren't affectedby how many crates it depends on, but rather by the longest chain ofdependencies that it needs to wait on. In many cases `serde` is part ofthat long chain, as it is part of a long chain if the `derive` featureis active:`proc-macro2` compile build script > `proc-macro2` run build script >`proc-macro2` > `quote` > `syn` > `serde_derive` > `serde` >`serde_json` (or any crate that depends on serde)By decoupling it from `serde_derive`, the chain is shortened and compiletimes get much better.Check this issue for a deeper elaboration:https://github.com/serde-rs/serde/issues/2584For `wasmtime` I'm seeing a reduction from 24.75s to 22.45s whencompiling in `release` mode. This is because wasmtime through `gimli`has a dependency on `indexmap` which can only start compiling when`serde` is finished, which you want to happen as early as possible sosome of wasmtime's dependencies can start compiling.To measure the full effect, the dependencies can't by themselvesactivate the `derive` feature. I've upstreamed a patch for`fxprof-processed-profile` which was the only dependency that activatedit for `wasmtime` (not yet published to crates.io). `wasmtime-cli` andco. may need patches for their dependencies to see a similarimprovement. List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/function.rs

729e2640 - A bunch of minor cleanups (#6767)

Tue, 25 Jul 2023 14:48:37 +0000

A bunch of minor cleanups (#6767)* Remove DisplayFunctionAnnotationsIt used to exist for printing the debuginfo value ranges with the clifir, but this no longer happens, so it is now useless.* Remove debug info collection from DummyEnvironmentThere are no remaining users of it* Remove ComparableSourceLocIt is unused* Move LabelValueLoc re-export out of the ir moduleIt encodes target specific information, so shouldn't be in the targetindependent ir module.* Remove RelocDistance dependency from ir::extfunc and ir::globalvalue List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/function.rs

91d1d246 - Allow serializing all cranelift-module data structures (#6172)

Fri, 21 Apr 2023 12:39:15 +0000

Allow serializing all cranelift-module data structures (#6172)* Remove ModuleCompiledFunctionThe same information can be retrieved usingctx.compiled_code().unwrap().code_info().total_sizeIn addition for Module implementations that don't immediately compile thegiven function there is no correct value that can be returned.* Don't give anonymous functions and data objects an internal nameThis internal name can conflict if a module is serialized and thendeserialized into another module. It also wasn't used by any of theModule implementations anyway.* Allow serializing all cranelift-module data structuresThis allows a Module implementation to serialize it's internal state anddeserialize it in another compilation session. For example to implementLTO or to load the module into cranelift-interpreter.* Use expect List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/function.rs

4053ae9e - Minir typo/Grammar fixes (#6187)

Mon, 10 Apr 2023 19:39:25 +0000

Minir typo/Grammar fixes (#6187)* fix typo* add test to check that Option is twice as large as EntityRef* grammar* grammar* reverse snakecase -- Not sure if folks want this type of change List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/function.rs

a9cda5af - cranelift: Implement PartialEq in `Function` (#6157)

Wed, 05 Apr 2023 22:33:10 +0000

cranelift: Implement PartialEq in `Function` (#6157) List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/function.rs

80c147d9 - Rework br_table to use BlockCall (#5731)

Thu, 16 Feb 2023 17:23:27 +0000

Rework br_table to use BlockCall (#5731)Rework br_table to use BlockCall, allowing us to avoid adding new nodes during ssa construction to hold block arguments. Additionally, many places where we previously matched on InstructionData to extract branch destinations can be replaced with a use of branch_destination or branch_destination_mut. List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/function.rs

d99783fc - Move default blocks into jump tables (#5756)

Fri, 10 Feb 2023 16:53:30 +0000

Move default blocks into jump tables (#5756)Move the default block off of the br_table instrution, and into the JumpTable that it references. List of files: /wasmtime-44.0.1/cranelift/codegen/src/ir/function.rs