Changes in lib.rs

cfe17cb1 - Cranelift: Generate integer numeric ops and conversions for ISLE in the meta crate (#11065)

Thu, 19 Jun 2025 00:24:34 +0000

Cranelift: Generate integer numeric ops and conversions for ISLE in the meta crate (#11065)* Cranelift: Generate integer numeric ops and conversions for ISLE in the meta crateThis automatically generates operations and conversions for integer types foruse in ISLE.Supported types are: `{i,u}{8,16,32,64,128}`We generate* Comparisons (eq, ne, lt, lt_eq, gt, gt_eq)* Arithmetic operations (add, sub, mul, div, neg) * These each have checked, wrapping, and unwrapping variants* Bitwise operations (and, or, xor, shifts, counting leading/trailing zeros/ones)* A variety of predicates (is_zero, is_power_of_two, is_odd, etc...) * These generate both partial constructors and a handful of extractors* Conversions * These come in a variety of flavors: fallible, infallible, truncating, unwrapping, sign-reinterpretation * Fallible conversions are also available as an extractor* Fix copy paste* Rename `x_reinterpret_as_y` to `x_cast_[un]signed`* Collapse some fallible conversions in pulley lowering* Clean up pulley iconst lowering, make sure narrowest `xconst*` instruction is always used* Avoid an unnecessary truncation in riscv64 lowering* Use extractor instead of partial constructor in x64 `imm` rule* Clean up `op mem, imm` x64 lowering rules* Use `(i64_eq a b)` instead of `(u64_eq (i64_cast_unsigned a) (i64_cast_unsigned b))`* Rename `_unwrapping_` to `_` List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/lib.rs

90ac295e - Update Wasmtime to the 2024 Rust Edition (#10806)

Mon, 19 May 2025 16:40:55 +0000

Update Wasmtime to the 2024 Rust Edition (#10806)* Update Wasmtime to the 2024 Rust EditionNow that our MSRV supports the 2024 edition it's possible to make thisswitch. This commit moves Wasmtime to the 2024 Edition to keepup-to-date with Rust idioms and access many of the edition featuresexclusive to the 2024 edition.prtest:full* Reformat with the 2024 edition List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/lib.rs

bce7f205 - meta: move all ISLE-related generated code to `cranelift-codegen-meta` (#10352)

Sat, 08 Mar 2025 00:40:58 +0000

meta: move all ISLE-related generated code to `cranelift-codegen-meta` (#10352)* meta: move all ISLE-related generated code to `cranelift-codegen-meta`Previously, the new `cranelift-assembler-x64` crate would generate theassembler Rust code, the ISLE integration code, and the ISLE'saccompanying Rust macro all in the same crate. Because these last twofiles were generated in the assembler's `OUT_DIR`, they caused issuesfor deterministic builds that expect those files in`cranelift-codegen`'s `OUT_DIR` (see #10348). This change fixes that bymoving all of the assembler's generated integration code, the ISLEinstruction definitions and their accompanying Rust macro, to the`cranelift-codegen-meta` crate.This has the added advantage that `cranelift-assembler-x64` now canfocus exclusively on being an assembler and not being concerned with theISLE integration, which is substantial.* Move lint `allow` to problem siteApparently allowing unused variables for unimplemented parts of fixedregister instructions will not work at the macro scope; this moves the`allow` to the offending line.* Remove `rustfmt` of generated assembler code List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/lib.rs

c3bf042a - meta: deduplicate source generation infrastructure (#10348)

Fri, 07 Mar 2025 02:26:43 +0000

meta: deduplicate source generation infrastructure (#10348)* Move `Formatter` and `Error` to new crate: `cranelift-srcgen`The `cranelift-codegen-meta` crate emits both Rust and ISLE source codeusing a `Formatter` which may fail with an `Error`. The`cranelift-assembler-x64-meta` crate uses a subset of thisfunctionality. To deduplicate efforts, this creates a new crate,`cranelift-srcgen`, and moves only the `cranelift-codgen-meta`functionality there (for now).* Add notion of a formatted `Language`; append file locationsWhile developing `cranelift-assembler-x64`, it became clear that knowingthe source code location that _generated_ some code was extremelyuseful. This change alters the `fmtln!` macro to append file locationsas comments to the generated code; this doesn't change all the`fmt.line()` invocations but it's a start. To do this, we need to knowwhich language we are generating to emit the correct comment kind. Thisled to adding a new `enum Language` to identify that.* Rename `update_file` to `write`* Use shared `Formatter` in `cranelift-assembler-x64-meta`This change removes the duplicate implementation of `Formatter` in`cranelift-assembler-x64-meta` and replaces it with the shared`Formatter` in `cranelift-srcgen`.* Add `Formatter::add_block`While implementing all these changes, I noticed an opportunity: byadding `Formatter::add_block` we can automatically adds braces andindentation. This should be more safe (i.e., harder to forget to appendthe ending `}`) and result in less verbose generator code (no need for`fmtln!(...)` then `f.indent(|f| ...)`). This refactoring does touch alarge amount of code, though.Now with `Formatter::add_block`, we can allow the `fmtln!` macro toauto-format no-arg format strings (e.g., `fmtln!(f, "{x}")`), whichshould be a bit more ergonomic. This does mean that a few locations thatweren't covered by `Formatter::add_block` need some extra escaping(e.g., `{` -> `{{`).* Avoid appending a file location comment to a Rust comment* Make `cranelift-srcgen` publishableThis ensures the crate has a version and is tracked by`cranelift-srcgen`. List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/lib.rs

c6658769 - Procedurally generate Pulley Cranelift boilerplate (#9760)

Tue, 10 Dec 2024 14:18:15 +0000

Procedurally generate Pulley Cranelift boilerplate (#9760)* Procedurally generate Pulley Cranelift boilerplateThis commit is an integration of the `for_each_op!` macro (and extendedops) for Cranelift. This procedurally generates a few new items forCranelift's Pulley backend to use:* `RawInst` - a raw enumeration of instructions as-is.* ISLE constructors (e.g. `pulley_*` ctors) - generated for all of the `RawInst` variants.* Register allocation methods for `RawInst`* Pretty printing methods for `RawInst`* Emission methods for `RawInst`The `Inst` enum now has a `Raw` variant which contains a `RawInst`. Inthis manner the main `Inst` enum can still have pseudo-insts like`Call`, polymorphic instructions like loads/stores (probably gonna getrefactored in the future though), and slightly different representationssuch as `Inst::Trap` having a `TrapCode` and `RawInst::Trap` wouldn't.The goal of this commit is to lower the amount of effort to quickly addand experiment with new instructions in Pulley. Ideally it's now just(a) define them in the pulley macro, (b) implement a direct loweringrule, and (c) implement it in the interpreter. Ideally no need toimplement anything else inside of Cranelift as everything should beauto-generated.Many existing `Inst` variants have been deleted in favor of theirequivalents in `RawInst` now. This undeniably increases the complexityof the Pulley backend but at least for me I find it well worth it tohave all this boilerplate generated automatically.* Fill out TODO* Fix conditional generation of pulley ISLE List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/lib.rs

a0442ea0 - Enforce `uninlined_format_args` for the workspace (#9065)

Mon, 05 Aug 2024 09:59:59 +0000

Enforce `uninlined_format_args` for the workspace (#9065)* Enforce `uninlined_format_args` for the workspace* fix: failing `Monolith Checks` job* fix: formatting List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/lib.rs

47d1640e - cranelift/codegen/meta: provide entry point to generate ISLE code only (#8462)

Thu, 02 May 2024 20:22:52 +0000

cranelift/codegen/meta: provide entry point to generate ISLE code only (#8462)* extract isle code generation* revert some customizations* revert changes to meta/src/error.rs List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/lib.rs

4b9f53a9 - move get_isle_compilations to codegen::meta (#8423)

Sun, 21 Apr 2024 23:10:35 +0000

move get_isle_compilations to codegen::meta (#8423) List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/lib.rs

7e66ed24 - A bunch of cleanups for cranelift-codegen-meta (#6772)

Tue, 25 Jul 2023 21:20:40 +0000

A bunch of cleanups for cranelift-codegen-meta (#6772)* Remove shared_defs args from all per-isa definitionsThey don't and shouldn't define any isa-independent things* Inline all define_settings functions* Merge verify_instruction_formats into shared::define()It isn't modified in between anyway now.* Enable document private items for cranelift-codegen-metaThe mentioned cargo bug has been fixed* Remove unused testing_hooks cargo featureIt has been unused ever since we removed the old backend framework. List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/lib.rs

85118c8c - Add clippy suggestions (#6203)

Mon, 17 Apr 2023 15:53:34 +0000

Add clippy suggestions (#6203)* add clippy suggestions* revert &/ref change* Update cranelift/isle/isle/src/parser.rsCo-authored-by: Jamey Sharp ---------Co-authored-by: Jamey Sharp List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/lib.rs

2be12a51 - egraph-based midend: draw the rest of the owl (productionized). (#4953)

Wed, 12 Oct 2022 01:15:53 +0000

egraph-based midend: draw the rest of the owl (productionized). (#4953)* egraph-based midend: draw the rest of the owl. * Rename `egg` submodule of cranelift-codegen to `egraph`. * Apply some feedback from @jsharp during code walkthrough. * Remove recursion from find_best_node by doing a single pass. Rather than recursively computing the lowest-cost node for a given eclass and memoizing the answer at each eclass node, we can do a single forward pass; because every eclass node refers only to earlier nodes, this is sufficient. The behavior may slightly differ from the earlier behavior because we cannot short-circuit costs to zero once a node is elaborated; but in practice this should not matter. * Make elaboration non-recursive. Use an explicit stack instead (with `ElabStackEntry` entries, alongside a result stack). * Make elaboration traversal of the domtree non-recursive/stack-safe. * Work analysis logic in Cranelift-side egraph glue into a general analysis framework in cranelift-egraph. * Apply static recursion limit to rule application. * Fix aarch64 wrt dynamic-vector support -- broken rebase. * Topo-sort cranelift-egraph before cranelift-codegen in publish script, like the comment instructs me to! * Fix multi-result call testcase. * Include `cranelift-egraph` in `PUBLISHED_CRATES`. * Fix atomic_rmw: not really a load. * Remove now-unnecessary PartialOrd/Ord derivations. * Address some code-review comments. * Review feedback. * Review feedback. * No overlap in mid-end rules, because we are defining a multi-constructor. * rustfmt * Review feedback. * Review feedback. * Review feedback. * Review feedback. * Remove redundant `mut`. * Add comment noting what rules can do. * Review feedback. * Clarify comment wording. * Update `has_memory_fence_semantics`. * Apply @jameysharp's improved loop-level computation. Co-authored-by: Jamey Sharp * Fix suggestion commit. * Fix off-by-one in new loop-nest analysis. * Review feedback. * Review feedback. * Review feedback. * Use `Default`, not `std::default::Default`, as per @fitzgen Co-authored-by: Nick Fitzgerald * Apply @fitzgen's comment elaboration to a doc-comment. Co-authored-by: Nick Fitzgerald * Add stat for hitting the rewrite-depth limit. * Some code motion in split prelude to make the diff a little clearer wrt `main`. * Take @jameysharp's suggested `try_into()` usage for blockparam indices. Co-authored-by: Jamey Sharp * Take @jameysharp's suggestion to avoid double-match on load op. Co-authored-by: Jamey Sharp * Fix suggestion (add import). * Review feedback. * Fix stack_load handling. * Remove redundant can_store case. * Take @jameysharp's suggested improvement to FuncEGraph::build() logic Co-authored-by: Jamey Sharp * Tweaks to FuncEGraph::build() on top of suggestion. * Take @jameysharp's suggested clarified condition Co-authored-by: Jamey Sharp * Clean up after suggestion (unused variable). * Fix loop analysis. * loop level asserts * Revert constant-space loop analysis -- edge cases were incorrect, so let's go with the simple thing for now. * Take @jameysharp's suggestion re: result_tys Co-authored-by: Jamey Sharp * Fix up after suggestion * Take @jameysharp's suggestion to use fold rather than reduce Co-authored-by: Jamey Sharp * Fixup after suggestion * Take @jameysharp's suggestion to remove elaborate_eclass_use's return value. * Clarifying comment in terminator insts. Co-authored-by: Jamey Sharp Co-authored-by: Nick Fitzgerald List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/lib.rs

5d671952 - Cranelift: do not check in generated ISLE code; regenerate on every compile. (#4143)

Thu, 12 May 2022 05:25:24 +0000

Cranelift: do not check in generated ISLE code; regenerate on every compile. (#4143)This PR fixes #4066: it modifies the Cranelift `build.rs` workflow to invoke the ISLE DSL compiler on every compilation, rather than only when the user specifies a special "rebuild ISLE" feature. The main benefit of this change is that it vastly simplifies the mental model required of developers, and removes a bunch of failure modes we have tried to work around in other ways. There is now just one "source of truth", the ISLE source itself, in the repository, and so there is no need to understand a special "rebuild" step and how to handle merge errors. There is no special process needed to develop the compiler when modifying the DSL. And there is no "noise" in the git history produced by constantly-regenerated files. The two main downsides we discussed in #4066 are: - Compile time could increase, by adding more to the "meta" step before the main build; - It becomes less obvious where the source definitions are (everything becomes more "magic"), which makes exploration and debugging harder. This PR addresses each of these concerns: 1. To maintain reasonable compile time, it includes work to cut down the dependencies of the `cranelift-isle` crate to *nothing* (only the Rust stdlib), in the default build. It does this by putting the error-reporting bits (`miette` crate) under an optional feature, and the logging (`log` crate) under a feature-controlled macro, and manually writing an `Error` impl rather than using `thiserror`. This completely avoids proc macros and the `syn` build slowness. The user can still get nice errors out of `miette`: this is enabled by specifying a Cargo feature `--features isle-errors`. 2. To allow the user to optionally inspect the generated source, which nominally lives in a hard-to-find path inside `target/` now, this PR adds a feature `isle-in-source-tree` that, as implied by the name, moves the target for ISLE generated source into the source tree, at `cranelift/codegen/isle_generated_source/`. It seems reasonable to do this when an explicit feature (opt-in) is specified because this is how ISLE regeneration currently works as well. To prevent surprises, if the feature is *not* specified, the build fails if this directory exists. List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/lib.rs

91d4f369 - Move generate_table from cranelift-codegen-shared to cranelift-codegen-meta

Wed, 27 Oct 2021 11:23:29 +0000

Move generate_table from cranelift-codegen-shared to cranelift-codegen-meta List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/lib.rs

d377b665 - Initial ISLE integration with the x64 backend

Wed, 13 Oct 2021 00:11:58 +0000

Initial ISLE integration with the x64 backendOn the build side, this commit introduces two things:1. The automatic generation of various ISLE definitions for working withCLIF. Specifically, it generates extern type definitions for clif opcodes andthe clif instruction data `enum`, as well as extractors for matching each clifinstructions. This happens inside the `cranelift-codegen-meta` crate.2. The compilation of ISLE DSL sources to Rust code, that can be included in themain `cranelift-codegen` compilation.Next, this commit introduces the integration glue code required to getISLE-generated Rust code hooked up in clif-to-x64 lowering. When lowering a clifinstruction, we first try to use the ISLE code path. If it succeeds, then we aredone lowering this instruction. If it fails, then we proceed along the existinghand-written code path for lowering.Finally, this commit ports many lowering rules over from hand-written,open-coded Rust to ISLE.In the process of supporting ISLE, this commit also makes the x64 `Inst` capableof expressing SSA by supporting 3-operand forms for all of the existinginstructions that only have a 2-operand form encoding: dst = src1 op src2Rather than only the typical x86-64 2-operand form: dst = dst op srcThis allows `MachInst` to be in SSA form, since `dst` and `src1` aredisentangled.("3-operand" and "2-operand" are a little bit of a misnomer since not alloperations are binary operations, but we do the same thing for, e.g., unaryoperations by disentangling the sole operand from the result.)There are two motivations for this change:1. To allow ISLE lowering code to have value-equivalence semantics. We want ISLE lowering to translate a CLIF expression that evaluates to some value into a `MachInst` expression that evaluates to the same value. We want both the lowering itself and the resulting `MachInst` to be pure and referentially transparent. This is both a nice paradigm for compiler writers that are authoring and maintaining lowering rules and is a prerequisite to any sort of formal verification of our lowering rules in the future.2. Better align `MachInst` with `regalloc2`'s API, which requires that the input be in SSA form. List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/lib.rs

b0b8c1ed - Remove default_map

Tue, 12 Oct 2021 13:07:49 +0000

Remove default_map List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/lib.rs

d590e6bc - Remove x86 old-backend special case from cranelift-codegen-meta

Wed, 29 Sep 2021 17:12:51 +0000

Remove x86 old-backend special case from cranelift-codegen-meta List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/lib.rs

eb01ba1e - Flatten directory structure for cranelift_codegen_meta::isa

Wed, 29 Sep 2021 17:06:12 +0000

Flatten directory structure for cranelift_codegen_meta::isa List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/lib.rs

3e4167ba - Remove registers from cranelift-codegen-meta

Mon, 21 Jun 2021 10:57:37 +0000

Remove registers from cranelift-codegen-meta List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/lib.rs

18bd27e9 - Remove legalizer support from cranelift-codegen-meta

Mon, 21 Jun 2021 10:55:08 +0000

Remove legalizer support from cranelift-codegen-meta List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/lib.rs

d4999336 - Remove encoding generation from cranelift-codegen-meta

Mon, 21 Jun 2021 10:13:20 +0000

Remove encoding generation from cranelift-codegen-meta List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/lib.rs