Changes in operands.rs

4c01ee2f - Cranelift: add get_exception_handler_address. (#11629)

Fri, 05 Sep 2025 22:41:46 +0000

Cranelift: add get_exception_handler_address. (#11629)* Cranelift: add get_exception_handler_address.This is designed to enable applications such as #11592 that usealternative unwinding mechanisms that may not necessarily want to walk astack and look up exception tables. The idea is that whenever it wouldbe valid to resume to an exception handler that is active on the stack,we can provide the same PC as a first-class runtime value that would befound in the exception table for the given handler edge. A "custom"resume step can then use this PC as a resume-point as long as it followsthe relevant exception ABI (i.e.: restore SP, FP, any other savedregisters that the exception ABI specifies, and provide appropriatepayload value(s)).Handlers are associated with edges out of `try_call`s (or`try_call_indirect`s); and edges specifically, not blocks, because therecould be multiple out-edges to one block. The instruction thus takes theblock that contains the try-call and an immediate that indexes itsexceptional edges.This CLIF instruction required a bit of infrastructure to (i) allownaming raw blocks, not just block calls, as instruction arguments, and(ii) allow getting the MachLabel for any other lowered block duringlowering. But given that, the lowerings themselves are straightforwarduses of MachBuffer labels to fix-up PC-relative address-loadinginstructions (e.g., `LEA` or `ADR` or `AUIPC`+`ADDI`).* Review feedback.* Review feedback: more tests. List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/cdsl/operands.rs

85118c8c - Add clippy suggestions (#6203)

Mon, 17 Apr 2023 15:53:34 +0000

Add clippy suggestions (#6203)* add clippy suggestions* revert &/ref change* Update cranelift/isle/isle/src/parser.rsCo-authored-by: Jamey Sharp ---------Co-authored-by: Jamey Sharp List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/cdsl/operands.rs

1e6c13d8 - cranelift: Rework block instructions to use BlockCall (#5464)

Wed, 18 Jan 2023 00:31:15 +0000

cranelift: Rework block instructions to use BlockCall (#5464)Add a new type BlockCall that represents the pair of a block name with arguments to be passed to it. (The mnemonic here is that it looks a bit like a function call.) Rework the implementation of jump, brz, and brnz to use BlockCall instead of storing the block arguments as varargs in the instruction's ValueList. To ensure that we're processing block arguments from BlockCall values in instructions, three new functions have been introduced on DataFlowGraph that both sets of arguments: inst_values - returns an iterator that traverses values in the instruction and block arguments map_inst_values - applies a function to each value in the instruction and block arguments overwrite_inst_values - overwrite all values in an instruction and block arguments with values from the iterator Co-authored-by: Jamey Sharp List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/cdsl/operands.rs

e913cf36 - Remove IFLAGS/FFLAGS types (#5406)

Fri, 09 Dec 2022 21:42:03 +0000

Remove IFLAGS/FFLAGS types (#5406)All instructions using the CPU flags types (IFLAGS/FFLAGS) were already removed. This patch completes the cleanup by removing all remaining instructions that define values of CPU flags types, as well as the types themselves. Specifically, the following features are removed: - The IFLAGS and FFLAGS types and the SpecialType category. - Special handling of IFLAGS and FFLAGS in machinst/isle.rs and machinst/lower.rs. - The ifcmp, ifcmp_imm, ffcmp, iadd_ifcin, iadd_ifcout, iadd_ifcarry, isub_ifbin, isub_ifbout, and isub_ifborrow instructions. - The writes_cpu_flags instruction property. - The flags verifier pass. - Flags handling in the interpreter. All of these features are currently unused; no functional change intended by this patch. This addresses https://github.com/bytecodealliance/wasmtime/issues/3249. List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/cdsl/operands.rs

5d671952 - Cranelift: do not check in generated ISLE code; regenerate on every compile. (#4143)

Thu, 12 May 2022 05:25:24 +0000

Cranelift: do not check in generated ISLE code; regenerate on every compile. (#4143)This PR fixes #4066: it modifies the Cranelift `build.rs` workflow to invoke the ISLE DSL compiler on every compilation, rather than only when the user specifies a special "rebuild ISLE" feature. The main benefit of this change is that it vastly simplifies the mental model required of developers, and removes a bunch of failure modes we have tried to work around in other ways. There is now just one "source of truth", the ISLE source itself, in the repository, and so there is no need to understand a special "rebuild" step and how to handle merge errors. There is no special process needed to develop the compiler when modifying the DSL. And there is no "noise" in the git history produced by constantly-regenerated files. The two main downsides we discussed in #4066 are: - Compile time could increase, by adding more to the "meta" step before the main build; - It becomes less obvious where the source definitions are (everything becomes more "magic"), which makes exploration and debugging harder. This PR addresses each of these concerns: 1. To maintain reasonable compile time, it includes work to cut down the dependencies of the `cranelift-isle` crate to *nothing* (only the Rust stdlib), in the default build. It does this by putting the error-reporting bits (`miette` crate) under an optional feature, and the logging (`log` crate) under a feature-controlled macro, and manually writing an `Error` impl rather than using `thiserror`. This completely avoids proc macros and the `syn` build slowness. The user can still get nice errors out of `miette`: this is enabled by specifying a Cargo feature `--features isle-errors`. 2. To allow the user to optionally inspect the generated source, which nominally lives in a hard-to-find path inside `target/` now, this PR adds a feature `isle-in-source-tree` that, as implied by the name, moves the target for ISLE generated source into the source tree, at `cranelift/codegen/isle_generated_source/`. It seems reasonable to do this when an explicit feature (opt-in) is specified because this is how ISLE regeneration currently works as well. To prevent surprises, if the feature is *not* specified, the build fails if this directory exists. List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/cdsl/operands.rs

86611d3b - isle: expand enums in ISLE (#3586)

Mon, 13 Dec 2021 02:31:42 +0000

isle: expand enums in ISLE (#3586)* x64: expand FloatCC enum in ISLE * isle: regenerate manifests * isle: generate all enum fields in `clif.isle` This expands the `gen_isle` function to write all of the immediate `enum`s out explicitly in `clif.isle`. Non-`enum` immediates are still `extern primitive`. * Only compile `enum_values` with `rebuild-isle` feature * Only compile `gen_enum_isle` with `rebuild-isle` feature List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/cdsl/operands.rs

93e9bb02 - Review comments

Mon, 01 Nov 2021 17:17:57 +0000

Review comments List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/cdsl/operands.rs

f84e1c16 - Enforce all OperandKind have documentation

Sun, 31 Oct 2021 18:27:12 +0000

Enforce all OperandKind have documentation List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/cdsl/operands.rs

d8b840d2 - [meta] Remove the OperandKindBuilder;

Tue, 29 Oct 2019 15:57:11 +0000

[meta] Remove the OperandKindBuilder;And replace it by constructors in OperandKind. There's a single optionalparameter function `set_doc` that remains, and didn't justify the wholeOperandKindBuilder concept to exist. List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/cdsl/operands.rs

d5e99022 - [meta] Remove OperandKind::name field and explicitly pass rust_field_name/rust_type; (fixes #1177)

Tue, 29 Oct 2019 14:46:06 +0000

[meta] Remove OperandKind::name field and explicitly pass rust_field_name/rust_type; (fixes #1177) List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/cdsl/operands.rs

0eb2dfc4 - [meta] Rename OperandKind::default_member to format_field_name;

Tue, 29 Oct 2019 14:41:13 +0000

[meta] Rename OperandKind::default_member to format_field_name; List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/cdsl/operands.rs

4f5b0689 - [meta] Remove OperandKind::imm_name method;

Tue, 29 Oct 2019 14:24:52 +0000

[meta] Remove OperandKind::imm_name method; List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/cdsl/operands.rs

ae3ea47d - [meta] Delegate finding the default value to OperandKind instead of its builder.

Tue, 29 Oct 2019 14:18:45 +0000

[meta] Delegate finding the default value to OperandKind instead of its builder.This applies both to the default_member value (which is now determined atruntime, instead of pre-computed) and the rust_type value (which isdetermined in the Operand's ctor, instead of the builder). List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/cdsl/operands.rs

4632d351 - [meta] Remove the OperandBuilder, replace it with Operand ctors;

Tue, 29 Oct 2019 13:44:25 +0000

[meta] Remove the OperandBuilder, replace it with Operand ctors; List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/cdsl/operands.rs

2bebc40c - [meta] Move the doc() default values in the Operand/OperandKind;

Tue, 29 Oct 2019 10:50:34 +0000

[meta] Move the doc() default values in the Operand/OperandKind; List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/cdsl/operands.rs

5889dd2c - [meta] Add more pub(crate) definitions.

Mon, 28 Oct 2019 17:13:25 +0000

[meta] Add more pub(crate) definitions. List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/cdsl/operands.rs

06b1817d - [meta] Rename Operand::is_pure_immediate into is_immediate;

Mon, 28 Oct 2019 16:46:26 +0000

[meta] Rename Operand::is_pure_immediate into is_immediate; List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/cdsl/operands.rs

b657aa57 - [meta] Rename Operand::is_immediate to is_immediate_or_entityref

Mon, 28 Oct 2019 16:45:40 +0000

[meta] Rename Operand::is_immediate to is_immediate_or_entityref List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/cdsl/operands.rs

0243b642 - [meta] Remove name lookups in formats;

Fri, 18 Oct 2019 17:24:03 +0000

[meta] Remove name lookups in formats;This does a lot at once, since there was no clear way to split the threecommits:- Instruction need to be passed an explicit InstructionFormat,- InstructionFormat deduplication is checked once all entities have beendefined; List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/cdsl/operands.rs

70f79d23 - [meta] Make Builders build() instead of finish();

Tue, 28 May 2019 13:01:14 +0000

[meta] Make Builders build() instead of finish(); List of files: /wasmtime-44.0.1/cranelift/codegen/meta/src/cdsl/operands.rs