en Copyright 2015 Java http://172.16.0.5:8080/history/llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h#3153bdd5 [libomptarget][amdgpu] Drop env variablesUse the same debug print as the rest of libomptarget plugins withthe same environment control. Also drop the max queue size debugging hook asI don't believe it is still in use, can bring it back near the rest of the envhandling in rtl.cpp if someone objects.That makes most of rt.h and all of utils.cpp unused. Clean that up and simplifycontrol flow in a couple of places.Behaviour change is that debug prints that used to use the old environmentvariable now use the new one and print in slightly different format, and theremoval of the max queue size variable.Reviewed By: pdhaliwalDifferential Revision: https://reviews.llvm.org/D108784 List of files: /llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h Thu, 02 Sep 2021 10:02:37 +0000 Jon Chesterfield <jonathanchesterfield@gmail.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h#68ab93f4 [libomptarget][amdgpu][nfc] Rename source files List of files: /llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h Thu, 26 Aug 2021 16:36:04 +0000 Jon Chesterfield <jonathanchesterfield@gmail.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h#9b8b7c11 [AMDGPU][Libomptarget] Delete g_atl_machine globalWith uses of g_atl_machine gone, a significant portion of deadcode has been removed.This patch depends on D104691 and D104695.Reviewed By: JonChesterfieldDifferential Revision: https://reviews.llvm.org/D104696 List of files: /llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h Wed, 11 Aug 2021 06:35:56 +0000 Pushpinder Singh <Pushpinder.Singh@amd.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h#9e05c084 [libomptarget][amdgpu][nfc] Normalise license headersReviewed By: gregrodgers, jdoerfertDifferential Revision: https://reviews.llvm.org/D106581 List of files: /llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h Thu, 22 Jul 2021 19:22:49 +0000 Jon Chesterfield <jonathanchesterfield@gmail.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h#a733bbbd [libomptarget][amdgpu][nfc] Refactor #includesCreate a hsa_api.h header that includes the ROCr headers in useDrop some unused headers and _cplusplus macrosReviewed By: jdoerfertDifferential Revision: https://reviews.llvm.org/D106455 List of files: /llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h Wed, 21 Jul 2021 16:28:07 +0000 Jon Chesterfield <jonathanchesterfield@gmail.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h#d86b0073 [libomptarget][amdgpu][nfc] Fix build warnings, drop some headersRemoves stdarg header, drops uses of iostream, fix some format string errors.Also changes a C style struct to C++ style to avoid a warning from clang/Reviewed By: pdhaliwalDifferential Revision: https://reviews.llvm.org/D104923 List of files: /llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h Wed, 30 Jun 2021 21:23:34 +0000 Jon Chesterfield <jonathanchesterfield@gmail.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h#cadcaf3f [AMDGPU][Libomptarget] Drop dead code related to g_atl_machineThis patch includes some changes which deletes the code accessingg_atl_machine global. Some accesses related to memory_pools arestill remaining.Reviewed By: JonChesterfieldDifferential Revision: https://reviews.llvm.org/D103813 List of files: /llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h Fri, 11 Jun 2021 12:31:48 +0000 Pushpinder Singh <Pushpinder.Singh@amd.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h#2368170a [AMDGPU][Libomptarget][NFC] Remove atmi_place_tatmi_place_t has been replaced with int DeviceId.Reviewed By: JonChesterfieldDifferential Revision: https://reviews.llvm.org/D103508 List of files: /llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h Wed, 02 Jun 2021 07:22:40 +0000 Pushpinder Singh <Pushpinder.Singh@amd.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h#fb113264 [AMDGPU][Libomptarget] Remove g_atmi_machine globalTurns out the only purpose of this class was verify if device IDwas in range or not which could be done easily by using g_atl_machine.Still getting rid of g_atl_machine is pending which would be done ina later patch.Reviewed By: JonChesterfieldDifferential Revision: https://reviews.llvm.org/D103443 List of files: /llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h Tue, 01 Jun 2021 09:23:10 +0000 Pushpinder Singh <Pushpinder.Singh@amd.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h#4fc32869 [AMDGPU][Libomptarget][NFC] Split host and device mallocThis patch splits the code path for host and device malloc.Reviewed By: JonChesterfieldDifferential Revision: https://reviews.llvm.org/D103389 List of files: /llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h Mon, 31 May 2021 07:19:41 +0000 Pushpinder Singh <Pushpinder.Singh@amd.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h#8b79dfb3 [AMDGPU][Libomptarget][NFC] Remove atmi_mem_place_tThis struct was used to specify the device on which memory wasbeing allocated/free in atmi_malloc/free. It has now been replacedwith int DeviceId.Reviewed By: JonChesterfieldDifferential Revision: https://reviews.llvm.org/D103239 List of files: /llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h Thu, 27 May 2021 10:55:38 +0000 Pushpinder Singh <Pushpinder.Singh@amd.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h#07f59baa [libomptarget][nfc][amdgpu] Remove atmi_status_t typeATMI_STATUS_UNKNOWN was unused, deleted references to it.Replaced ATMI_STATUS_{SUCCESS,ERROR} with HSA_STATUS_{SUCCESS,ERROR}Replaced atmi_status_t with hsa_status_tOtherwise no change. In particular, conversions between atmi_status_t andhsa_status_t will now be conversions between hsa_status_t and itself.Reviewed By: pdhaliwalDifferential Revision: https://reviews.llvm.org/D103115 List of files: /llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h Wed, 26 May 2021 16:02:19 +0000 Jon Chesterfield <jonathanchesterfield@gmail.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h#a2d6ef58 [AMDGPU][Libomptarget] Inline atmi_init/atmi_finalizeAfter D102847, these functions can be inlined.Reviewed By: JonChesterfieldDifferential Revision: https://reviews.llvm.org/D103075 List of files: /llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h Tue, 25 May 2021 07:57:10 +0000 Pushpinder Singh <Pushpinder.Singh@amd.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h#d7503c3b [AMDGPU][Libomptarget] Rename & move g_executables to privateThis patch moves g_executables to private member of Runtime classand is renamed to HSAExecutables following LLVM naming convention.This movement required making Runtime::Initialize and Runtime::Finalizenon-static. Verified the correctness of this change by runninglibomptarget tests on gfx906.Reviewed By: JonChesterfieldDifferential Revision: https://reviews.llvm.org/D102600 List of files: /llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h Mon, 17 May 2021 08:22:36 +0000 Pushpinder Singh <Pushpinder.Singh@amd.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h#dc70c56b [libomptarget][amdgpu][nfc] Update comments[libomptarget][amdgpu][nfc] Update commentsReviewed By: jdoerfertDifferential Revision: https://reviews.llvm.org/D95295 List of files: /llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h Sat, 23 Jan 2021 22:53:57 +0000 Jon Chesterfield <jonathanchesterfield@gmail.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h#5d989fb3 [libomptarget][amdgpu] Improve thread safety, remove dead code List of files: /llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h Wed, 26 Aug 2020 21:04:03 +0000 JonChesterfield <jonathanchesterfield@gmail.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h#d0b31295 [libomptarget] Implement host plugin for amdgpu[libomptarget] Implement host plugin for amdgpuReplacement for D71384. Primary difference is inlining the dependency on atmifollowed by extensive simplification and bugfixes. This is the latest versionfrom https://github.com/ROCm-Developer-Tools/amd-llvm-project/tree/aomp12 withminor patches and a rename from hsa to amdgpu, on the basis that this can't beused by other implementations of hsa without additional work.This will not build unless the ROCM_DIR variable is passed so won't break otherbuilds. That variable is used to locate two amdgpu specific libraries that shipas part of rocm:libhsakmt at https://github.com/RadeonOpenCompute/ROCT-Thunk-Interfacelibhsa-runtime64 at https://github.com/RadeonOpenCompute/ROCR-RuntimeThese libraries build from source. The build scripts in those repos are forshared libraries, but can be adapted to statically link both into this plugin.There are caveats.- This works well enough to run various tests and benchmarks, and will be used to support the current clang bring up- It is adequately thread safe for the above but there will be races remaining- It is not stylistically correct for llvm, though has had clang-format run- It has suboptimal memory management and locking strategies- The debug printing / error handling is inconsistentI would like to contribute this pretty much as-is and then improve it in-tree.This would be advantagous because the aomp12 branch that was in use for fixingthis codebase has just been joined with the amd internal rocm dev process.Reviewed By: jdoerfertDifferential Revision: https://reviews.llvm.org/D85742 List of files: /llvm-project-15.0.7/openmp/libomptarget/plugins/amdgpu/impl/rt.h Sat, 15 Aug 2020 22:52:19 +0000 Jon Chesterfield <jonathanchesterfield@gmail.com>