Changes in vector-transfer-full-partial-split.mlir

ad1d60c3 - [FileCheck] Catch missspelled directives.

Thu, 26 May 2022 08:48:01 +0000

[FileCheck] Catch missspelled directives.Reviewed By: MaskRayDifferential Revision: https://reviews.llvm.org/D125604 List of files: /llvm-project-15.0.7/mlir/test/Dialect/Vector/vector-transfer-full-partial-split.mlir

4c807f2f - [mlir][vector] insert `alloca`s outside of loops

Mon, 25 Apr 2022 08:25:59 +0000

[mlir][vector] insert `alloca`s outside of loopsAfter https://reviews.llvm.org/D119743 added the `AutomaticAllocationScope`trait to loop-like constructs, the vector transfer full/partial splitting passstarted inserting allocations for temporaries within the closest loop ratherthan the closest function (or other allocation scope such as `async.execute`).While this is correct as long as the lowered code takes care of automaticdeallocation at the end of each iteration of the loop, this interferes withdownstream optimizations that expect `alloca`s to be at the function level.Step over loops when looking for the closest allocation scope in vectortransfer full/partial splitting pass thus restoring the original behavior.Reviewed By: hanchungDifferential Revision: https://reviews.llvm.org/D124366 List of files: /llvm-project-15.0.7/mlir/test/Dialect/Vector/vector-transfer-full-partial-split.mlir

0fd3a1ce - [mlir][NFC] Update remaining textual references of un-namespaced `func` operations

Thu, 21 Apr 2022 04:39:02 +0000

[mlir][NFC] Update remaining textual references of un-namespaced `func` operationsThe special case parsing of operations in the `func` dialect is being removed, andoperations will require the dialect namespace prefix. List of files: /llvm-project-15.0.7/mlir/test/Dialect/Vector/vector-transfer-full-partial-split.mlir

c48e3a13 - [mlir][NFC] Update textual references of `func` to `func.func` in Tensor/Tosa/Vector tests

Wed, 20 Apr 2022 23:19:48 +0000

[mlir][NFC] Update textual references of `func` to `func.func` in Tensor/Tosa/Vector testsThe special case parsing of `func` operations is being removed. List of files: /llvm-project-15.0.7/mlir/test/Dialect/Vector/vector-transfer-full-partial-split.mlir

7294be2b - [mlir][linalg] Replace linalg.fill by OpDSL variant.

Mon, 14 Mar 2022 10:45:04 +0000

[mlir][linalg] Replace linalg.fill by OpDSL variant.The revision removes the linalg.fill operation and renames the OpDSL generated linalg.fill_tensor operation to replace it. After the change, all named structured operations are defined via OpDSL and there are no handwritten operations left.A side-effect of the change is that the pretty printed form changes from:```%1 = linalg.fill(%cst, %0) : f32, tensor -> tensor```changes to```%1 = linalg.fill ins(%cst : f32) outs(%0 : tensor) -> tensor```Additionally, the builder signature now takes input and output value ranges as it is the case for all other OpDSL operations:```rewriter.create(loc, val, output)```changes to```rewriter.create(loc, ValueRange{val}, ValueRange{output})```All other changes remain minimal. In particular, the canonicalization patterns are the same and the `value()`, `output()`, and `result()` methods are now implemented by the FillOpInterface.Depends On D120726Reviewed By: nicolasvasilacheDifferential Revision: https://reviews.llvm.org/D120728 List of files: /llvm-project-15.0.7/mlir/test/Dialect/Vector/vector-transfer-full-partial-split.mlir

3c3810e7 - [mlir][vector] Avoid hoisting alloca'ed temporary buffers across AutomaticAllocationScope

Wed, 02 Feb 2022 10:21:02 +0000

[mlir][vector] Avoid hoisting alloca'ed temporary buffers across AutomaticAllocationScopeThis revision avoids incorrect hoisting of alloca'd buffers across an AutomaticAllocationScope boundary.In the more general case, we will probably need a ParallelScope-like interface.Differential Revision: https://reviews.llvm.org/D118768 List of files: /llvm-project-15.0.7/mlir/test/Dialect/Vector/vector-transfer-full-partial-split.mlir

ebc81537 - Revert "Revert "[mlir] Purge `linalg.copy` and use `memref.copy` instead.""

Tue, 01 Feb 2022 17:07:33 +0000

Revert "Revert "[mlir] Purge `linalg.copy` and use `memref.copy` instead.""This reverts commit 25bf6a2a9bc6ecb3792199490c70c4ce50a94aea. List of files: /llvm-project-15.0.7/mlir/test/Dialect/Vector/vector-transfer-full-partial-split.mlir

25bf6a2a - Revert "[mlir] Purge `linalg.copy` and use `memref.copy` instead."

Mon, 31 Jan 2022 17:51:39 +0000

Revert "[mlir] Purge `linalg.copy` and use `memref.copy` instead."This reverts commit 016956b68081705ffee511c334e31e414fa1ddbf.Reverting it to fix NVidia build without being in a hurry. List of files: /llvm-project-15.0.7/mlir/test/Dialect/Vector/vector-transfer-full-partial-split.mlir

016956b6 - [mlir] Purge `linalg.copy` and use `memref.copy` instead.

Mon, 31 Jan 2022 17:18:28 +0000

[mlir] Purge `linalg.copy` and use `memref.copy` instead.Differential Revision: https://reviews.llvm.org/D118028 List of files: /llvm-project-15.0.7/mlir/test/Dialect/Vector/vector-transfer-full-partial-split.mlir

a54f4eae - [MLIR] Replace std ops with arith dialect ops

Tue, 12 Oct 2021 23:14:57 +0000

[MLIR] Replace std ops with arith dialect opsPrecursor: https://reviews.llvm.org/D110200Removed redundant ops from the standard dialect that were moved to the`arith` or `math` dialects.Renamed all instances of operations in the codebase and in tests.Reviewed By: rriddle, jpienaarDifferential Revision: https://reviews.llvm.org/D110797 List of files: /llvm-project-15.0.7/mlir/test/Dialect/Vector/vector-transfer-full-partial-split.mlir

ffdf0a37 - [mlir][vector] Fix bug in vector-transfer-full-partial-split

Mon, 27 Sep 2021 08:13:11 +0000

[mlir][vector] Fix bug in vector-transfer-full-partial-splitWhen splitting with linalg.copy, cannot write into the destination alloc directly. Instead, write into a subview of the alloc.Differential Revision: https://reviews.llvm.org/D110512 List of files: /llvm-project-15.0.7/mlir/test/Dialect/Vector/vector-transfer-full-partial-split.mlir

a21a6f51 - [mlir][linalg] Change the pretty printed FillOp operand order.

Wed, 23 Jun 2021 06:28:58 +0000

[mlir][linalg] Change the pretty printed FillOp operand order.The patch changes the pretty printed FillOp operand order from output, value to value, output. The change is a follow up to https://reviews.llvm.org/D104121 that passes the fill value using a scalar input instead of the former capture semantics.Differential Revision: https://reviews.llvm.org/D104356 List of files: /llvm-project-15.0.7/mlir/test/Dialect/Vector/vector-transfer-full-partial-split.mlir

88a48999 - Support VectorTransfer splitting on writes also.

Fri, 07 May 2021 14:19:22 +0000

Support VectorTransfer splitting on writes also.VectorTransfer split previously only split read xfer ops. This addsthe same logic to write ops. The resulting code involves 2conditionals for write ops while read ops only needed 1, but the createdops are built upon the same patterns, so pattern matching/expectationsare all consistent other than in regards to the if/else ops.Differential Revision: https://reviews.llvm.org/D102157 List of files: /llvm-project-15.0.7/mlir/test/Dialect/Vector/vector-transfer-full-partial-split.mlir

95f81350 - [mlir] Change vector.transfer_read/write "masked" attribute to "in_bounds".

Wed, 31 Mar 2021 05:59:30 +0000

[mlir] Change vector.transfer_read/write "masked" attribute to "in_bounds".This is in preparation for adding a new "mask" operand. The existing "masked" attribute was used to specify dimensions that may be out-of-bounds. Such transfers can be lowered to masked load/stores. The new "in_bounds" attribute is used to specify dimensions that are guaranteed to be within bounds. (Semantics is inverted.)Differential Revision: https://reviews.llvm.org/D99639 List of files: /llvm-project-15.0.7/mlir/test/Dialect/Vector/vector-transfer-full-partial-split.mlir

b2f232b8 - [testsuite] Make testsuite more stable vs canonicalization change. NFC.

Sat, 20 Mar 2021 00:57:47 +0000

[testsuite] Make testsuite more stable vs canonicalization change. NFC.Differential Revision: https://reviews.llvm.org/D98998 List of files: /llvm-project-15.0.7/mlir/test/Dialect/Vector/vector-transfer-full-partial-split.mlir

e2310704 - [MLIR] Create memref dialect and move dialect-specific ops from std.

Wed, 10 Feb 2021 12:53:11 +0000

[MLIR] Create memref dialect and move dialect-specific ops from std.Create the memref dialect and move dialect-specific opsfrom std dialect to this dialect.Moved ops:AllocOp -> MemRef_AllocOpAllocaOp -> MemRef_AllocaOpAssumeAlignmentOp -> MemRef_AssumeAlignmentOpDeallocOp -> MemRef_DeallocOpDimOp -> MemRef_DimOpMemRefCastOp -> MemRef_CastOpMemRefReinterpretCastOp -> MemRef_ReinterpretCastOpGetGlobalMemRefOp -> MemRef_GetGlobalOpGlobalMemRefOp -> MemRef_GlobalOpLoadOp -> MemRef_LoadOpPrefetchOp -> MemRef_PrefetchOpReshapeOp -> MemRef_ReshapeOpStoreOp -> MemRef_StoreOpSubViewOp -> MemRef_SubViewOpTransposeOp -> MemRef_TransposeOpTensorLoadOp -> MemRef_TensorLoadOpTensorStoreOp -> MemRef_TensorStoreOpTensorToMemRefOp -> MemRef_BufferCastOpViewOp -> MemRef_ViewOpThe roadmap to split the memref dialect from std is discussed here:https://llvm.discourse.group/t/rfc-split-the-memref-dialect-from-std/2667Differential Revision: https://reviews.llvm.org/D98041 List of files: /llvm-project-15.0.7/mlir/test/Dialect/Vector/vector-transfer-full-partial-split.mlir

40d8e4d3 - Revert "[Canonicalizer] Process regions top-down instead of bottom up & reuse existing constants."

Mon, 15 Mar 2021 09:26:41 +0000

Revert "[Canonicalizer] Process regions top-down instead of bottom up & reuse existing constants."This reverts commit b5d9a3c92358349d5444ab28de8ab5b2bee33a01.The commit introduced a memory error in canonicalization/operationwalking that is exposed when compiled with ASAN. It leads to crashes insome "release" configurations. List of files: /llvm-project-15.0.7/mlir/test/Dialect/Vector/vector-transfer-full-partial-split.mlir

b5d9a3c9 - [Canonicalizer] Process regions top-down instead of bottom up & reuse existing constants.

Sun, 14 Mar 2021 20:14:48 +0000

[Canonicalizer] Process regions top-down instead of bottom up & reuse existing constants.Two changes: 1) Change the canonicalizer to walk the function in top-down order instead of bottom-up order. This composes well with the "top down" nature of constant folding and simplification, reducing iterations and re-evaluation of ops in simple cases. 2) Explicitly enter existing constants into the OperationFolder table before canonicalizing. Previously we would "constant fold" them and rematerialize them, wastefully recreating a bunch fo constants, which lead to pointless memory traffic.Both changes together provide a 33% speedup for canonicalize on some mid-sizeCIRCT examples.One artifact of this change is that the constants generated in normal patternapplication get inserted at the top of the function as the patterns are applied.Because of this, we get "inverted" constants more often, which is an aetheticchange to the IR but does permute some testcases.Differential Revision: https://reviews.llvm.org/D98609 List of files: /llvm-project-15.0.7/mlir/test/Dialect/Vector/vector-transfer-full-partial-split.mlir

a89035d7 - Revert "[MLIR] Create memref dialect and move several dialect-specific ops from std."

Thu, 18 Feb 2021 11:49:52 +0000

Revert "[MLIR] Create memref dialect and move several dialect-specific ops from std."This commit introduced a cyclic dependency:Memref dialect depends on Standard because it used ConstantIndexOp.Std depends on the MemRef dialect in its EDSC/Intrinsics.hWorking on a fix.This reverts commit 8aa6c3765b924d86f623d452777eb76b83bf2787. List of files: /llvm-project-15.0.7/mlir/test/Dialect/Vector/vector-transfer-full-partial-split.mlir

8aa6c376 - [MLIR] Create memref dialect and move several dialect-specific ops from std.

Wed, 10 Feb 2021 12:53:11 +0000

[MLIR] Create memref dialect and move several dialect-specific ops from std.Create the memref dialect and move several dialect-specific ops withoutdependencies to other ops from std dialect to this dialect.Moved ops:AllocOp -> MemRef_AllocOpAllocaOp -> MemRef_AllocaOpDeallocOp -> MemRef_DeallocOpMemRefCastOp -> MemRef_CastOpGetGlobalMemRefOp -> MemRef_GetGlobalOpGlobalMemRefOp -> MemRef_GlobalOpPrefetchOp -> MemRef_PrefetchOpReshapeOp -> MemRef_ReshapeOpStoreOp -> MemRef_StoreOpTransposeOp -> MemRef_TransposeOpViewOp -> MemRef_ViewOpThe roadmap to split the memref dialect from std is discussed here:https://llvm.discourse.group/t/rfc-split-the-memref-dialect-from-std/2667Differential Revision: https://reviews.llvm.org/D96425 List of files: /llvm-project-15.0.7/mlir/test/Dialect/Vector/vector-transfer-full-partial-split.mlir