Changes in ROCDLDialect.cpp

8df54a6a - [mlir] Update accessors to prefixed form (NFC)

Sun, 19 Jun 2022 00:53:22 +0000

[mlir] Update accessors to prefixed form (NFC)Follow up from flipping dialects to both, flip accessor used to prefixedvariant ahead to flipping from _Both to _Prefixed. This just flips tothe accessors introduced in the preceding change which are just prefixedforms of the existing accessor changed from.Mechanical change using helper scripthttps://github.com/jpienaar/llvm-project/blob/main/clang-tools-extra/clang-tidy/misc/AddGetterCheck.cpp and clang-format. List of files: /llvm-project-15.0.7/mlir/lib/Dialect/LLVMIR/IR/ROCDLDialect.cpp

f1f05a91 - [MLIR][AMDGPU] Add AMDGPU dialect, wrappers around raw buffer intrinsics

Wed, 30 Mar 2022 21:56:19 +0000

[MLIR][AMDGPU] Add AMDGPU dialect, wrappers around raw buffer intrinsicsBy analogy with the NVGPU dialect, introduce an AMDGPU dialect forAMD-specific intrinsic wrappers.The dialect initially includes wrappers around the raw buffer intrinsics.On AMD GPUs, a memref can be converted to a "buffer descriptor" thatallows more precise control of memory access, such as by allowing forout of bounds loads/stores to be replaced by 0/ignored without addingadditional conditional logic, which is important for performance.The repository currently contains a limited conversion fromtransfer_read/transfer_write to Mubuf intrinsics, which are an older,deprecated intrinsic for the same functionality.The new amdgpu.raw_buffer_* ops allow these operations to be usedexplicitly and for including metadata such as whether the targetchipset is an RDNA chip or not (which impacts the interpretation ofsome bits in the buffer descriptor), while still maintaining anMLIR-like interface.(This change also exposes the floating-point atomic add intrinsic.)Reviewed By: ThomasRaouxDifferential Revision: https://reviews.llvm.org/D122765 List of files: /llvm-project-15.0.7/mlir/lib/Dialect/LLVMIR/IR/ROCDLDialect.cpp

e13d23bc - [mlir] Rename `OpAsmParser::OperandType` to `OpAsmParser::UnresolvedOperand`

Mon, 21 Mar 2022 20:42:13 +0000

[mlir] Rename `OpAsmParser::OperandType` to `OpAsmParser::UnresolvedOperand`I am not sure about the meaning of Type in the name (was it meant be interpreted as Kind?), and given the importance and meaning of Type in the context of MLIR, its probably better to rename it. Given the comment in the source code, the suggestion in the GitHub issue and the final discussions in the review, this patch renames the OperandType to UnresolvedOperand.Fixes https://github.com/llvm/llvm-project/issues/54446Differential Revision: https://reviews.llvm.org/D122142 List of files: /llvm-project-15.0.7/mlir/lib/Dialect/LLVMIR/IR/ROCDLDialect.cpp

2418cd92 - [mlir] Update uses of `parser`/`printer` ODS op field to `hasCustomAssemblyFormat`

Tue, 08 Feb 2022 01:54:04 +0000

[mlir] Update uses of `parser`/`printer` ODS op field to `hasCustomAssemblyFormat`The parser/printer fields are deprecated and in the process of being removed. List of files: /llvm-project-15.0.7/mlir/lib/Dialect/LLVMIR/IR/ROCDLDialect.cpp

0c7890c8 - [mlir] Convert NamedAttribute to be a class

Thu, 18 Nov 2021 05:23:32 +0000

[mlir] Convert NamedAttribute to be a classNamedAttribute is currently represented as an std::pair, but thiscreates an extremely clunky .first/.second API. This commitconverts it to a class, with better accessors (getName/getValue)and also opens the door for more convenient API in the future.Differential Revision: https://reviews.llvm.org/D113956 List of files: /llvm-project-15.0.7/mlir/lib/Dialect/LLVMIR/IR/ROCDLDialect.cpp

fb093c83 - [ODS/AsmParser] Don't pass MLIRContext with DialectAsmParser.

Thu, 30 Sep 2021 00:47:08 +0000

[ODS/AsmParser] Don't pass MLIRContext with DialectAsmParser.The former is redundant because the later carries it as part ofits builder. Add a getContext() helper method to DialectAsmParserto make this more convenient, and stop passing the context aroundexplicitly. This simplifies ODS generated parser hooks for attrsand types.This resolves PR51985Recommit 4b32f8bac4 after fixing a dependency.Differential Revision: https://reviews.llvm.org/D110796 List of files: /llvm-project-15.0.7/mlir/lib/Dialect/LLVMIR/IR/ROCDLDialect.cpp

3310e002 - Revert "[ODS/AsmParser] Don't pass MLIRContext with DialectAsmParser."

Thu, 30 Sep 2021 05:01:17 +0000

Revert "[ODS/AsmParser] Don't pass MLIRContext with DialectAsmParser."This reverts commit 4b32f8bac40dcd1535bfe95757c3de0911bf6d1a.Seems like the build is broken with -DDBUILD_SHARED_LIBS=ON List of files: /llvm-project-15.0.7/mlir/lib/Dialect/LLVMIR/IR/ROCDLDialect.cpp

4b32f8ba - [ODS/AsmParser] Don't pass MLIRContext with DialectAsmParser.

Thu, 30 Sep 2021 00:47:08 +0000

[ODS/AsmParser] Don't pass MLIRContext with DialectAsmParser.The former is redundant because the later carries it as part ofits builder. Add a getContext() helper method to DialectAsmParserto make this more convenient, and stop passing the context aroundexplicitly. This simplifies ODS generated parser hooks for attrsand types.This resolves PR51985Differential Revision: https://reviews.llvm.org/D110796 List of files: /llvm-project-15.0.7/mlir/lib/Dialect/LLVMIR/IR/ROCDLDialect.cpp

485cc55e - [mlir] Generare .cpp.inc files for dialects.

Mon, 28 Jun 2021 22:54:11 +0000

[mlir] Generare .cpp.inc files for dialects.* Previously, we were only generating .h.inc files. We foresee the need to also generate implementations and this is a step towards that.* Discussed in https://llvm.discourse.group/t/generating-cpp-inc-files-for-dialects/3732/2* Deviates from the discussion above by generating a default constructor in the .cpp.inc file (and adding a tablegen bit that disables this in case if this is user provided).* Generating the destructor started as a way to flush out the missing includes (produces a link error), but it is a strict improvement on its own that is worth doing (i.e. by emitting key methods in the .cpp file, we root vtables in one translation unit, which is a non-controversial improvement).Differential Revision: https://reviews.llvm.org/D105070 List of files: /llvm-project-15.0.7/mlir/lib/Dialect/LLVMIR/IR/ROCDLDialect.cpp

9cd47a26 - [mlir] add verifiers for NVVM and ROCDL kernel attributes

Tue, 16 Feb 2021 17:05:47 +0000

[mlir] add verifiers for NVVM and ROCDL kernel attributesMake sure they can only be attached to LLVM functions as a result of convertingGPU functions to the LLVM Dialect. List of files: /llvm-project-15.0.7/mlir/lib/Dialect/LLVMIR/IR/ROCDLDialect.cpp

bd30a796 - [mlir] use built-in vector types instead of LLVM dialect types when possible

Mon, 11 Jan 2021 12:58:05 +0000

[mlir] use built-in vector types instead of LLVM dialect types when possibleContinue the convergence between LLVM dialect and built-in types by using thebuilt-in vector type whenever possible, that is for fixed vectors of built-inintegers and built-in floats. LLVM dialect vector type is still in use forpointers, less frequent floating point types that do not have a built-inequivalent, and scalable vectors. However, the top-level `LLVMVectorType` classhas been removed in favor of free functions capable of inspecting both built-inand LLVM dialect vector types: `LLVM::getVectorElementType`,`LLVM::getNumVectorElements` and `LLVM::getFixedVectorType`. Additional work isnecessary to design an implemented the extensions to built-in types so as toremove the `LLVMFixedVectorType` entirely.Note that the default output format for the built-in vectors does not havewhitespace around the `x` separator, e.g., `vector<4xf32>` as opposed to theLLVM dialect vector type format that does, e.g., `!llvm.vec<4 x fp128>`. Thisrequired changing the FileCheck patterns in several tests.Reviewed By: mehdi_amini, silvasDifferential Revision: https://reviews.llvm.org/D94405 List of files: /llvm-project-15.0.7/mlir/lib/Dialect/LLVMIR/IR/ROCDLDialect.cpp

2230bf99 - [mlir] replace LLVMIntegerType with built-in integer type

Wed, 06 Jan 2021 15:19:04 +0000

[mlir] replace LLVMIntegerType with built-in integer typeThe LLVM dialect type system has been closed until now, i.e. did not supporttypes from other dialects inside containers. While this has had obviousbenefits of deriving from a common base class, it has led to some simple typesbeing almost identical with the built-in types, namely integer and floatingpoint types. This in turn has led to a lot of larger-scale complexity: simpletypes must still be converted, numerous operations that correspond to LLVM IRintrinsics are replicated to produce versions operating on either LLVM dialector built-in types leading to quasi-duplicate dialects, lowering to the LLVMdialect is essentially required to be one-shot because of type conversion, etc.In this light, it is reasonable to trade off some local complexity in theinternal implementation of LLVM dialect types for removing larger-scale systemcomplexity. Previous commits to the LLVM dialect type system have adapted theAPI to support types from other dialects.Replace LLVMIntegerType with the built-in IntegerType plus additional checksthat such types are signless (these are isolated in a utility function thatreplaced `isa` and in the parser). Temporarily keep the possibilityto parse `!llvm.i32` as a synonym for `i32`, but add a deprecation notice.Reviewed By: mehdi_amini, silvas, antiagainstDifferential Revision: https://reviews.llvm.org/D94178 List of files: /llvm-project-15.0.7/mlir/lib/Dialect/LLVMIR/IR/ROCDLDialect.cpp

7ed9cfc7 - [mlir] Remove static constructors from LLVMType

Tue, 22 Dec 2020 10:22:56 +0000

[mlir] Remove static constructors from LLVMTypeLLVMType contains numerous static constructors that were initially introducedfor API compatibility with LLVM. Most of these merely forward to arguments to`SpecificType::get` (MLIR defines classes for all types, unlike LLVM IR), whilesome introduce subtle semantics differences due to different modeling of MLIRtypes (e.g., structs are not auto-renamed in case of conflicts). Furthermore,these constructors don't match MLIR idioms and actively prevent us from makingthe LLVM dialect type system more open. Remove them and use `SpecificType::get`instead.Depends On D93680Reviewed By: mehdi_aminiDifferential Revision: https://reviews.llvm.org/D93681 List of files: /llvm-project-15.0.7/mlir/lib/Dialect/LLVMIR/IR/ROCDLDialect.cpp

09f7a55f - [mlir][Types][NFC] Move all of the builtin Type classes to BuiltinTypes.h

Fri, 04 Dec 2020 01:22:29 +0000

[mlir][Types][NFC] Move all of the builtin Type classes to BuiltinTypes.hThis is part of a larger refactoring the better congregates the builtin structures under the BuiltinDialect. This also removes the problematic "standard" naming that clashes with the "standard" dialect, which is not defined within IR/. A temporary forward is placed in StandardTypes.h to allow time for downstream users to replaced references.Differential Revision: https://reviews.llvm.org/D92435 List of files: /llvm-project-15.0.7/mlir/lib/Dialect/LLVMIR/IR/ROCDLDialect.cpp

7d1ed69c - Make namespace handling uniform across dialect backends.

Mon, 14 Sep 2020 20:01:07 +0000

Make namespace handling uniform across dialect backends.Now backends spell out which namespace they want to be in, instead of relying onclients #including them inside already-opened namespaces. This also means thatcppNamespaces should be fully qualified, and there's no implicit "::mlir::"prepended to them anymore.Reviewed By: mehdi_aminiDifferential Revision: https://reviews.llvm.org/D86811 List of files: /llvm-project-15.0.7/mlir/lib/Dialect/LLVMIR/IR/ROCDLDialect.cpp

575b22b5 - Revisit Dialect registration: require and store a TypeID on dialects

Fri, 07 Aug 2020 02:41:44 +0000

Revisit Dialect registration: require and store a TypeID on dialectsThis patch moves the registration to a method in the MLIRContext: getOrCreateDialect()This method requires dialect to provide a static getDialectNamespace()and store a TypeID on the Dialect itself, which allows to lazyilycreate a dialect when not yet loaded in the context.As a side effect, it means that duplicated registration of the samedialect is not an issue anymore.To limit the boilerplate, TableGen dialect generation is modified toemit the constructor entirely and invoke separately a "init()" methodthat the user implements.Differential Revision: https://reviews.llvm.org/D85495 List of files: /llvm-project-15.0.7/mlir/lib/Dialect/LLVMIR/IR/ROCDLDialect.cpp

5446ec85 - [mlir] take MLIRContext instead of LLVMDialect in getters of LLVMType's

Wed, 05 Aug 2020 22:52:20 +0000

[mlir] take MLIRContext instead of LLVMDialect in getters of LLVMType'sHistorical modeling of the LLVM dialect types had been wrapping LLVM IR typesand therefore needed access to the instance of LLVMContext stored in theLLVMDialect. The new modeling does not rely on that and only needs theMLIRContext that is used for uniquing, similarly to other MLIR types. ChangeLLVMType::getTy functions to take `MLIRContext *` instead of`LLVMDialect *` as first argument. This brings the code base closer tocompletely removing the dependence on LLVMContext from the LLVMDialect,together with additional support for thread-safety of its use.Depends On D85371Reviewed By: rriddleDifferential Revision: https://reviews.llvm.org/D85372 List of files: /llvm-project-15.0.7/mlir/lib/Dialect/LLVMIR/IR/ROCDLDialect.cpp

9db53a18 - [mlir][NFC] Remove usernames and google bug numbers from TODO comments.

Tue, 07 Jul 2020 08:35:23 +0000

[mlir][NFC] Remove usernames and google bug numbers from TODO comments.These were largely leftover from when MLIR was a google project, and don't really follow LLVM guidelines. List of files: /llvm-project-15.0.7/mlir/lib/Dialect/LLVMIR/IR/ROCDLDialect.cpp

9c53ac08 - [mlir][rocdl] Exposing buffer load/store intrinsic

Tue, 19 May 2020 19:59:58 +0000

[mlir][rocdl] Exposing buffer load/store intrinsicSummary:* Updated ROCDLOps tablegen* Added parsing and printing function for new intrinsic* Added unit testsReviewers: ftynseSubscribers: mehdi_amini, rriddle, jpienaar, shauheen, antiagainst, nicolasvasilache, arpith-jacob, mgester, lucyrfox, liufengdb, stephenneuendorffer, Joonsoo, grosul1, frgossen, Kayjukh, jurahul, llvm-commitsTags: #llvmDifferential Revision: https://reviews.llvm.org/D80233 List of files: /llvm-project-15.0.7/mlir/lib/Dialect/LLVMIR/IR/ROCDLDialect.cpp

c6477050 - Remove static registration for dialects, and the "alwayslink" hack for passes

Wed, 12 Feb 2020 09:03:40 +0000

Remove static registration for dialects, and the "alwayslink" hack for passesIn the previous state, we were relying on forcing the linker to includeall libraries in the final binary and the global initializer to self-registerevery piece of the system. This change help moving away from this model, andallow users to compose pieces more freely. The current change is only "fixing"the dialect registration and avoiding relying on "whole link" for the passes.The translation is still relying on the global registry, and some refactoringis needed to make this all more convenient.Differential Revision: https://reviews.llvm.org/D74461 List of files: /llvm-project-15.0.7/mlir/lib/Dialect/LLVMIR/IR/ROCDLDialect.cpp