Changes in OptionParsingTest.cpp

e28cd75a - [OptTable] Reapply Improve error message output for grouped short options

Fri, 03 Sep 2021 10:08:39 +0000

[OptTable] Reapply Improve error message output for grouped short optionsThis reapplies 71d7fed3bc2ad6c22729d446526a59fcfd99bd03 which wasreverted by 3e2bd82f02c6cbbfb0544897c7645867f04b3a7e. This changeincludes the fix for breaking the sanitizer bots.As seen in https://bugs.llvm.org/show_bug.cgi?id=48880 the currentimplementation for parsing grouped short options can return unclearerror messages. This change fixes the example given in the ticket inwhich a flag is incorrectly given an argument. Also when parsing agroup we now keep reading past the first incorrect option and outputerrors for all incorrect options in the group.Differential Revision: https://reviews.llvm.org/D108770 List of files: /llvm-project-15.0.7/llvm/unittests/Option/OptionParsingTest.cpp

3e2bd82f - Revert "[OptTable] Improve error message output for grouped short options"

Tue, 31 Aug 2021 21:00:30 +0000

Revert "[OptTable] Improve error message output for grouped short options"This reverts commit 71d7fed3bc2ad6c22729d446526a59fcfd99bd03.Reason: broke sanitizer botsmore info: https://reviews.llvm.org/D108770 List of files: /llvm-project-15.0.7/llvm/unittests/Option/OptionParsingTest.cpp

71d7fed3 - [OptTable] Improve error message output for grouped short options

Tue, 31 Aug 2021 15:41:08 +0000

[OptTable] Improve error message output for grouped short optionsAs seen in https://bugs.llvm.org/show_bug.cgi?id=48880 the currentimplementation for parsing grouped short options can return unclearerror messages. This change fixes the example given in the ticket inwhich a flag is incorrectly given an argument. Also when parsing agroup we now keep reading past the first incorrect option and outputerrors for all incorrect options in the group.Differential Revision: https://reviews.llvm.org/D108770 List of files: /llvm-project-15.0.7/llvm/unittests/Option/OptionParsingTest.cpp

f1e2d585 - [OptTable] Rename PrintHelp to printHelp

Thu, 24 Jun 2021 21:47:03 +0000

[OptTable] Rename PrintHelp to printHelpTo be consistent with other member functions and match the coding standard. List of files: /llvm-project-15.0.7/llvm/unittests/Option/OptionParsingTest.cpp

f8a29b17 - [OptTable] Support grouped short options

Fri, 17 Jul 2020 16:18:24 +0000

[OptTable] Support grouped short optionsPOSIX.1-2017 12.2 Utility Syntax Guidelines, Guideline 5 says:> One or more options without option-arguments, followed by at most one option that takes an option-argument, should be accepted when grouped behind one '-' delimiter.i.e. -abc represents -a -b -c. The grouped short options are very common. Manyutilities extend the syntax by allowing (an option with an argument) following asequence of short options.This patch adds the support to OptTable, similar to cl::Group for CommandLine(D58711). llvm-symbolizer will use the feature (D83530). CommandLine is exoticin some aspects. OptTable is preferred if the user wants to get rid of thebehaviors.* `cl::opt i(...)` can be disabled via -i=false or -i=0, which is different from conventional --no-i.* Handling --foo & --no-foo requires a comparison of argument positions, which is a bit clumsy in user code.OptTable::parseOneArg (non-const reference InputArgList) is added along withParseOneArg (const ArgList &). The duplicate does not look great at firstglance. However, The implementation can be simpler if ArgList is mutable.(ParseOneArg is used by clang-cl (FlagsToInclude/FlagsToExclude) and lld COFF(case-insensitive). Adding grouped short options can make the function even morecomplex.)The implementation allows a long option following a group of short options. Weprobably should refine the code to disallow this in the future. Allowing thisseems benign for now.Reviewed By: grimar, jhendersonDifferential Revision: https://reviews.llvm.org/D83639 List of files: /llvm-project-15.0.7/llvm/unittests/Option/OptionParsingTest.cpp

c991daa5 - Option spell checking: Penalize delimiter flags if input has no argument

Wed, 01 May 2019 16:45:15 +0000

Option spell checking: Penalize delimiter flags if input has no argumentIf the user passes a flag like `-version` to a program, it's more likelythey mean `--version` than `-version:`, since there's no parameterpassed. Hence, give delimited arguments a penalty of 1 if the user inputdoesn't contain the delimiter or no data after it.The motivation is that with this, lld-link can suggest "--version"instead of "-version:" for "-version" and "-nodefaultlib" instead of"-nodefaultlib:" for "-nodefaultlibs".Differential Revision: https://reviews.llvm.org/D61382llvm-svn: 359701 List of files: /llvm-project-15.0.7/llvm/unittests/Option/OptionParsingTest.cpp

f68e0f79 - Fix OptTable::findNearest() adding delimiter for free

Wed, 01 May 2019 14:46:17 +0000

Fix OptTable::findNearest() adding delimiter for freePrior to this, OptTable::findNearest() thought that the input `--foo`had an editing distance of 0 from an existing flag `--foo=`, which madeit suggest flags with delimiters more often than flags without one.After this, it correctly assigns this case an editing distance of 1.Differential Revision: https://reviews.llvm.org/D61373llvm-svn: 359685 List of files: /llvm-project-15.0.7/llvm/unittests/Option/OptionParsingTest.cpp

98ca8da5 - Re-reland "[Option] Fix PR37006 prefix choice in findNearest"

Tue, 30 Apr 2019 17:46:00 +0000

Re-reland "[Option] Fix PR37006 prefix choice in findNearest"This was first reviewed in https://reviews.llvm.org/D46776 andlanded in r332299, but got reverted because it broke the PS4bots.https://reviews.llvm.org/D50410 fixed this, and then thischange was re-reviewed at https://reviews.llvm.org/D50515 andrelanded in r341329. It got reverted due to causing MSan issues.However, nobody wrote down the error message and the bot linkis dead, so I'm relanding this to capture the MSan error.I'll then either fix it, or copy it somewhere and revert iffixing looks difficult.llvm-svn: 359580 List of files: /llvm-project-15.0.7/llvm/unittests/Option/OptionParsingTest.cpp

2946cd70 - Update the file headers across all of the LLVM projects in the monorepo

Sat, 19 Jan 2019 08:50:56 +0000

Update the file headers across all of the LLVM projects in the monorepoto reflect the new license.We understand that people may be surprised that we're moving the headerentirely to discuss the new license. We checked this carefully with theFoundation's lawyer and we believe this is the correct approach.Essentially, all code in the project is now made available by the LLVMproject under our new license, so you will see that the license headersinclude that license only. Some of our contributors have contributedcode under our old license, and accordingly, we have retained a copy ofour old license notice in the top-level files in each project andrepository.llvm-svn: 351636 List of files: /llvm-project-15.0.7/llvm/unittests/Option/OptionParsingTest.cpp

88478bbc - [opt] Change the parameter of OptTable::PrintHelp from Name to Usage and don't append "[options] "

Wed, 10 Oct 2018 00:15:31 +0000

[opt] Change the parameter of OptTable::PrintHelp from Name to Usage and don't append "[options] "Summary:Before, "[options] " is unconditionally appended to the `Name` parameter. It is more flexible to change its semantic to `Usage` and let user customize the usage line.% llvm-objcopy...USAGE: llvm-objcopy [ ] [options] With this patch:% llvm-objcopy...USAGE: llvm-objcopy input [output]Reviewers: rupprecht, alexshap, jhendersonReviewed By: rupprechtSubscribers: jakehehrlich, mehdi_amini, steven_wu, dexonsmith, llvm-commitsDifferential Revision: https://reviews.llvm.org/D51009llvm-svn: 344097 List of files: /llvm-project-15.0.7/llvm/unittests/Option/OptionParsingTest.cpp

dfe99574 - Revert r341329 due to MSAN error

Mon, 03 Sep 2018 18:13:46 +0000

Revert r341329 due to MSAN errorPushing https://reviews.llvm.org/rL341329 revealed an MSAN error. Revert itso that we can fix the error.llvm-svn: 341333 List of files: /llvm-project-15.0.7/llvm/unittests/Option/OptionParsingTest.cpp

f5344853 - Re-push "[Option] Fix PR37006 prefix choice in findNearest"

Mon, 03 Sep 2018 17:30:57 +0000

Re-push "[Option] Fix PR37006 prefix choice in findNearest"Summary:Original changeset (https://reviews.llvm.org/D46776) by @modocache. It wasreverted after the PS4 bot failed.The issue has been determined to be with the way the PS4 SDK handles thisparticular option. https://reviews.llvm.org/D50410 removes this test, so wecan push this again.Patch by Arnaud Coomans!Reviewers: cfe-commits, modocacheReviewed By: modocacheDifferential Revision: https://reviews.llvm.org/D50515llvm-svn: 341329 List of files: /llvm-project-15.0.7/llvm/unittests/Option/OptionParsingTest.cpp

9968e0dd - Re-revert "[Option] Fix PR37006 prefix choice in findNearest"

Sat, 19 May 2018 16:21:01 +0000

Re-revert "[Option] Fix PR37006 prefix choice in findNearest"Summary:Reverting due to a test failure in an llvm-mt test on some buildbots, namelyhttp://green.lab.llvm.org/green/job/clang-stage2-configure-Rlto/26020/.llvm-svn: 332812 List of files: /llvm-project-15.0.7/llvm/unittests/Option/OptionParsingTest.cpp

8cfb4b6d - Un-revert "[Option] Fix PR37006 prefix choice in findNearest"

Sat, 19 May 2018 12:03:26 +0000

Un-revert "[Option] Fix PR37006 prefix choice in findNearest"Summary:In https://reviews.llvm.org/rL332804 I loosed the assertion inthe Clang driver test that forced me to reverthttps://reviews.llvm.org/rL332299. Once this lands I should beable to narrow down what caused PS4 buildbots to fail, andreinstate the check in that test.Test Plan: check-llvm & check-clangllvm-svn: 332805 List of files: /llvm-project-15.0.7/llvm/unittests/Option/OptionParsingTest.cpp

ed5b3255 - Revert "[Option] Fix PR37006 prefix choice in findNearest"

Mon, 14 May 2018 22:36:47 +0000

Revert "[Option] Fix PR37006 prefix choice in findNearest"Summary:This revision causes build failures in PS4 and ppc64le buildbots (for example,http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/29988).I'll revert for now and try to diagnose the issue.Test Plan: check-llvm check-clangllvm-svn: 332304 List of files: /llvm-project-15.0.7/llvm/unittests/Option/OptionParsingTest.cpp

eda977f4 - [Option] Fix PR37006 prefix choice in findNearest

Mon, 14 May 2018 21:35:00 +0000

[Option] Fix PR37006 prefix choice in findNearestSummary:In https://bugs.llvm.org/show_bug.cgi?id=37006 Nico Weber points out aflaw in `OptTable::findNearest`: if an option "foo"'s prefixes are "--"and "-", then the nearest option for "--fob" will be "-foo". This isincorrect, however, since the function is expected to return "--foo".The bug is due to a naive loop that attempts to predetermines whichprefix is best. Instead, compute the edit distance for each prefix/namepair.Test Plan: `check-llvm`Reviewers: thakisReviewed By: thakisSubscribers: llvm-commitsDifferential Revision: https://reviews.llvm.org/D46776llvm-svn: 332299 List of files: /llvm-project-15.0.7/llvm/unittests/Option/OptionParsingTest.cpp

d481df53 - [Option] For typo '-foo', suggest '--foo'

Tue, 09 Jan 2018 19:38:04 +0000

[Option] For typo '-foo', suggest '--foo'Summary:https://reviews.llvm.org/rL321877 introduced the `OptTable::findNearest`method, to find the closest edit distance option for a given string.However, the implementation contained a bug: for a typo `-foo` with anedit distance of 1 away from a valid option `--foo`, `findNearest`would suggest a nearby option of `foo`. That is, the result would notinclude the `--` prefix, and so was not a valid option.Fix the bug by ensuring that the prefix string is initialized to one ofthe valid prefixes for the option.Test Plan: `check-llvm-unit`Reviewers: v.g.vassilev, teemperor, ruiu, jroelofs, yamaguchiReviewed By: jroelofsSubscribers: llvm-commitsDifferential Revision: https://reviews.llvm.org/D41873llvm-svn: 322109 List of files: /llvm-project-15.0.7/llvm/unittests/Option/OptionParsingTest.cpp

7b84de79 - [Option] Add 'findNearest' method to catch typos

Fri, 05 Jan 2018 17:10:39 +0000

[Option] Add 'findNearest' method to catch typosSummary:Add a method `OptTable::findNearest`, which allows users of OptTable tocheck user input for misspelled options. In addition, have llvm-mtcheck for misspelled options. For example, if a user invokes`llvm-mt /oyt:foo`, the error message will indicate that while anoption named `/oyt:` does not exist, `/out:` does.The method ports the functionality of the `LookupNearestOption` methodfrom LLVM CommandLine to libLLVMOption. This allows tools like Clangand Swift, which do not use CommandLine, to use this functionality tosuggest similarly spelled options.As room for future improvement, the new method as-is cannot yet properly suggestnearby "joined" options -- that is, for an option string "-FozBar", where"-Foo" is the correct option name and "Bar" is the value being passed alongwith the misspelled option, this method will calculate an edit distance of 4,by deleting "Bar" and changing "z" to "o". It should instead calculate an editdistance of just 1, by changing "z" to "o" and recognizing "Bar" as avalue. This commit includes a disabled test that expresses this limitation.Test Plan: `check-llvm`Reviewers: yamaguchi, v.g.vassilev, teemperor, ruiu, jroelofsReviewed By: jroelofsSubscribers: jroelofs, llvm-commitsDifferential Revision: https://reviews.llvm.org/D41732llvm-svn: 321877 List of files: /llvm-project-15.0.7/llvm/unittests/Option/OptionParsingTest.cpp

ba5d4af4 - [GSoC] Flag value completion for clang

Tue, 20 Jun 2017 16:31:31 +0000

[GSoC] Flag value completion for clangThis is patch for GSoC project, bash-completion for clang.To use this on bash, please run `source clang/utils/bash-autocomplete.sh`.bash-autocomplete.sh is code for bash-completion.In this patch, Options.td was mainly changed in order to add value classin Options.inc.llvm-svn: 305805 List of files: /llvm-project-15.0.7/llvm/unittests/Option/OptionParsingTest.cpp

6fd4bc6b - Fix some ArgList uses after API change in r300135.

Wed, 12 Apr 2017 23:43:58 +0000

Fix some ArgList uses after API change in r300135.llvm-svn: 300139 List of files: /llvm-project-15.0.7/llvm/unittests/Option/OptionParsingTest.cpp