en Copyright 2015 Java http://172.16.0.5:8080/history/llvm-project-15.0.7/llvm/test/tools/llvm-objdump/Inputs/embedded-source#783d84bb [llvm] Prevent duplicate files in debug line header in dwarf 5: another attemptAnother attempt to land the changes in debug line header to prevent duplicatefiles in Dwarf 5. I rolled back my previous commit because of a mistake ingenerating the object file in a test. Meanwhile, I addressed some offlinecomments and changed the implementation; the largest difference is thatMCDwarfLineTableHeader does not keep DwarfVersion but gets it as a parameter. Ialso merged the patch to fix two lld tests that will strt to fail into thispatch.Original Commit:https://reviews.llvm.org/D59515Original Message:Motivation: In previous dwarf versions, file name indexes started from 1, andthe primary source file was not explicit. Dwarf 5 standard (6.2.4) prescribesthe primary source file to be explicitly given an entry with an index number 0.The current implementation honors the specification by just duplicating themain source file, once with index number 0, and later maybe with anotherindex number. While this is compliant with the letter of the standard, theduplication causes problems for consumers of this information such as lldb.(Some files are duplicated, where only some of them have a line table althoughall refer to the same file)With this change, dwarf 5 debug line section files always start from 0, andthe zeroth entry is not duplicated whenever possible. This requires differenthandling of dwarf 4 and dwarf 5 during generation (e.g. when a function returnsan index zero for a file name, it signals an error in dwarf 4, but not in dwarf5) However, I think the minor complication is worth it, because it enables allconsumers (lldb, gdb, dwarfdump, objdump, and so on) to treat all files in thefile name list homogenously.llvm-svn: 358732 List of files: /llvm-project-15.0.7/llvm/test/tools/llvm-objdump/Inputs/embedded-source Fri, 19 Apr 2019 02:26:56 +0000 Ali Tamur <tamur@google.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/llvm/test/tools/llvm-objdump/Inputs/embedded-source#02e96648 Revert "[llvm] Reapply "Prevent duplicate files in debug line header in dwarf 5.""This reverts commit rL357020.The commit broke the test llvm/test/tools/llvm-objdump/embedded-source.teston some builds including clang-ppc64be-linux-multistage,clang-s390x-linux, clang-with-lto-ubuntu, clang-x64-windows-msvc,llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast (and others).llvm-svn: 357026 List of files: /llvm-project-15.0.7/llvm/test/tools/llvm-objdump/Inputs/embedded-source Tue, 26 Mar 2019 20:05:27 +0000 Ali Tamur <tamur@google.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/llvm/test/tools/llvm-objdump/Inputs/embedded-source#2f5cd03a [llvm] Reapply "Prevent duplicate files in debug line header in dwarf 5."Reapply rL356941 after regenerating the object file in the failing testllvm/test/tools/llvm-objdump/embedded-source.test from source.Original commit message:[llvm] Prevent duplicate files in debug line header in dwarf 5.Motivation: In previous dwarf versions, file name indexes started from 1, andthe primary source file was not explicit. Dwarf 5 standard (6.2.4) prescribesthe primary source file to be explicitly given an entry with an index number 0.The current implementation honors the specification by just duplicating themain source file, once with index number 0, and later maybe with anotherindex number. While this is compliant with the letter of the standard, theduplication causes problems for consumers of this information such as lldb.(Some files are duplicated, where only some of them have a line table althoughall refer to the same file)With this change, dwarf 5 debug line section files always start from 0, andthe zeroth entry is not duplicated whenever possible. This requires differenthandling of dwarf 4 and dwarf 5 during generation (e.g. when a function returnsan index zero for a file name, it signals an error in dwarf 4, but not in dwarf 5)However, I think the minor complication is worth it, because it enables allconsumers (lldb, gdb, dwarfdump, objdump, and so on) to treat all files in thefile name list homogenously.Tags: #llvm, #debug-infoDifferential Revision: https://reviews.llvm.org/D59515llvm-svn: 357018 List of files: /llvm-project-15.0.7/llvm/test/tools/llvm-objdump/Inputs/embedded-source Tue, 26 Mar 2019 18:53:23 +0000 Ali Tamur <tamur@google.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/llvm/test/tools/llvm-objdump/Inputs/embedded-source#fdce82a8 Revert "[llvm] Prevent duplicate files in debug line header in dwarf 5."This reverts commit 312ab05887d0e2caa29aaf843cefe39379a98d36.My commit broke the build; I will revert and find out what happened.llvm-svn: 356951 List of files: /llvm-project-15.0.7/llvm/test/tools/llvm-objdump/Inputs/embedded-source Mon, 25 Mar 2019 21:09:07 +0000 Ali Tamur <tamur@google.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/llvm/test/tools/llvm-objdump/Inputs/embedded-source#312ab058 [llvm] Prevent duplicate files in debug line header in dwarf 5.Summary:Motivation: In previous dwarf versions, file name indexes started from 1, andthe primary source file was not explicit. Dwarf 5 standard (6.2.4) prescribesthe primary source file to be explicitly given an entry with an index number 0.The current implementation honors the specification by just duplicating themain source file, once with index number 0, and later maybe with anotherindex number. While this is compliant with the letter of the standard, theduplication causes problems for consumers of this information such as lldb.(Some files are duplicated, where only some of them have a line table althoughall refer to the same file)With this change, dwarf 5 debug line section files always start from 0, andthe zeroth entry is not duplicated whenever possible. This requires differenthandling of dwarf 4 and dwarf 5 during generation (e.g. when a function returnsan index zero for a file name, it signals an error in dwarf 4, but not in dwarf 5)However, I think the minor complication is worth it, because it enables allconsumers (lldb, gdb, dwarfdump, objdump, and so on) to treat all files in thefile name list homogenously.Reviewers: dblaikie, probinson, aprantl, espindolaReviewed By: probinsonSubscribers: emaste, jvesely, nhaehnle, aprantl, javed.absar, arichardson, hiraditya, MaskRay, rupprecht, jdoerfert, llvm-commitsTags: #llvm, #debug-infoDifferential Revision: https://reviews.llvm.org/D59515llvm-svn: 356941 List of files: /llvm-project-15.0.7/llvm/test/tools/llvm-objdump/Inputs/embedded-source Mon, 25 Mar 2019 20:08:00 +0000 Ali Tamur <tamur@google.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/llvm/test/tools/llvm-objdump/Inputs/embedded-source#c16b975a [DebugInfo] Add remaining files to r325970Add files which I missed in the original check-inllvm-svn: 325973 List of files: /llvm-project-15.0.7/llvm/test/tools/llvm-objdump/Inputs/embedded-source Fri, 23 Feb 2018 23:13:18 +0000 Scott Linder <scott@scottlinder.com>