en Copyright 2015 Java http://172.16.0.5:8080/history/llvm-project-15.0.7/llvm/test/tools/llvm-libtool-darwin/create-static-lib.test#bd0bddc1 [CommandLine] Remove `may only occur zero or one times!` errorEarly adoption of new technologies or adjusting certain code generation/IR optimization thresholdsis often available through some cl::opt options (which have unstable surfaces).Specifying such an option twice will lead to an error.```% clang -c a.c -mllvm -disable-binop-extract-shuffle -mllvm -disable-binop-extract-shuffleclang (LLVM option parsing): for the --disable-binop-extract-shuffle option: may only occur zero or one times!% clang -c a.c -mllvm -hwasan-instrument-reads=0 -mllvm -hwasan-instrument-reads=0clang (LLVM option parsing): for the --hwasan-instrument-reads option: may only occur zero or one times!% clang -c a.c -mllvm --scalar-evolution-max-arith-depth=32 -mllvm --scalar-evolution-max-arith-depth=16clang (LLVM option parsing): for the --scalar-evolution-max-arith-depth option: may only occur zero or one times!```The option is specified twice, because there is sometimes a global setting anda specific file or project may need to override (or duplicately specify) thevalue.The error is contrary to the common practice of getopt/getopt_long command lineutilities that let the last option win and the `getLastArg` behavior used byClang driver options. I have seen such errors for several times. I think theerror just makes users inconvenient, while providing very little value ondiscouraging production usage of unstable surfaces (this goal is itselfcontroversial, because developers might not want to commit to a stable surfacetoo early, or there is just some subtle codegen toggle which is infeasible tohave a driver option). Therefore, I suggest we drop the diagnostic, at leastbefore the diagnostic gets sufficiently better support for the overridding needs.Removing the error is a degraded error checking experience. I think this errorchecking behavior, if desirable, should be enabled explicitly by tools. Userspreferring the behavior can figure out a way to do so.Reviewed By: jhenderson, rnkDifferential Revision: https://reviews.llvm.org/D120455 List of files: /llvm-project-15.0.7/llvm/test/tools/llvm-libtool-darwin/create-static-lib.test Fri, 11 Mar 2022 19:25:04 +0000 Fangrui Song <i@maskray.me> http://172.16.0.5:8080/history/llvm-project-15.0.7/llvm/test/tools/llvm-libtool-darwin/create-static-lib.test#4c12a75e [llvm-libtool-darwin] Add -warnings_as_errorslibtool can currently produce 2 warnings:1. No symbols were in the object file2. An object file with the same basename was specified multiple timesThe first warning here is often harmless and may just mean you have sometranslation units with no symbols for the target you're building for.The second warning can lead to real issues like those mentioned inhttps://reviews.llvm.org/D113130 where ODR violations can slip in.This introduces a new -warnings_as_errors flag that can be used by buildsystems that want to verify they never hit these warnings. For examplewith bazel the libtool caller first uniques names to make sure theduplicate base name case is not possible, but if that doesn't work asexpected, having it fail would be preferred.It's also worth noting that llvm-libtool-darwin works around an issuethat cctools libtool experiences related to debug info and duplicatebasenames, the workaround is described here:https://github.com/llvm/llvm-project/blob/30baa5d2a450d5e302d8cba3fc7a26a59d4b7ae1/llvm/lib/Object/ArchiveWriter.cpp#L424-L465And it avoids this bug:https://github.com/keith/radars/tree/f0cbbb1c37126ec6528c132510b29e08566377a7/DuplicateBasenameIssueDifferential Revision: https://reviews.llvm.org/D118931 List of files: /llvm-project-15.0.7/llvm/test/tools/llvm-libtool-darwin/create-static-lib.test Thu, 03 Feb 2022 01:46:11 +0000 Keith Smiley <keithbsmiley@gmail.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/llvm/test/tools/llvm-libtool-darwin/create-static-lib.test#f4744e9a Reapply "[llvm-libtool-darwin] Print a warning if object file names are repeated"Loosen the test to make it pass on Windows.This reapplies commit 4993eff3e253a1c04e1a1a2fa5d68f6b33423419.This reverts commit 96c66040125e87808b23410632b1a6a34547b4e3. List of files: /llvm-project-15.0.7/llvm/test/tools/llvm-libtool-darwin/create-static-lib.test Fri, 28 Jan 2022 07:40:30 +0000 Shoaib Meenai <smeenai@fb.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/llvm/test/tools/llvm-libtool-darwin/create-static-lib.test#96c66040 Revert "[llvm-libtool-darwin] Print a warning if object file names are repeated"This reverts commit 4993eff3e253a1c04e1a1a2fa5d68f6b33423419.Tests are failing on Windows: http://45.33.8.238/win/52360/step_11.txt.We'll need to account for forward slashes vs. backslashes. List of files: /llvm-project-15.0.7/llvm/test/tools/llvm-libtool-darwin/create-static-lib.test Wed, 12 Jan 2022 06:02:59 +0000 Shoaib Meenai <smeenai@fb.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/llvm/test/tools/llvm-libtool-darwin/create-static-lib.test#4993eff3 [llvm-libtool-darwin] Print a warning if object file names are repeatedPrint a warning if `llvm-libtool-darwin` if any of the objectfiles provided by the user have the same file name.The tool will now print a warning if there is a name collision across:* Two object files* An object file and an object file from within a static library* Two object files from different static librariesHere is an example of the error:```$ llvm-libtool-darwin -static -o archive.a out.o out.oerror: file 'out.o' was specified multiple times.in: out.oin: out.o$ llvm-libtool-darwin -static -o archive.a out.o$ llvm-libtool-darwin -static -o combined.a archive.a out.oerror: file 'out.o' was specified multiple times.in: archive.ain: out.o```This change mimics apple's cctools libtool's behavior which always shows a warning in such cases.Reviewed By: smeenaiDifferential Revision: https://reviews.llvm.org/D113130 List of files: /llvm-project-15.0.7/llvm/test/tools/llvm-libtool-darwin/create-static-lib.test Tue, 11 Jan 2022 22:38:25 +0000 Roger Kim <rgr@fb.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/llvm/test/tools/llvm-libtool-darwin/create-static-lib.test#05f7b682 [llvm-libtool-darwin] Add support for LLVM bitcode filesThis diff adds support for LLVM bitcode objects to llvm-libtool-darwin.Test plan: make check-allDifferential revision: https://reviews.llvm.org/D88722 List of files: /llvm-project-15.0.7/llvm/test/tools/llvm-libtool-darwin/create-static-lib.test Thu, 29 Oct 2020 18:08:45 +0000 Paul-Antoine Arras <paarras@quarkslab.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/llvm/test/tools/llvm-libtool-darwin/create-static-lib.test#303a7f7a [llvm-libtool-darwin] Add support for -static optionAdd support for creating static libraries when the input includes onlyMach-O binaries (and not libraries/archives themselves).Reviewed by alexshap, Ktwu, smeenai, jhenderson, MaskRay, mtrentDifferential Revision: https://reviews.llvm.org/D83002 List of files: /llvm-project-15.0.7/llvm/test/tools/llvm-libtool-darwin/create-static-lib.test Wed, 01 Jul 2020 22:02:22 +0000 Sameer Arora <sameerarora101@fb.com>