Changes in memset-01.ll

cbf682cb - [SystemZ] Improve codegen for memset.

Thu, 14 Oct 2021 18:10:47 +0000

[SystemZ] Improve codegen for memset.Memset with a constant length was implemented with a single store followed bya series of MVC:s. This patch changes this so that one store of the byte isemitted for each MVC, which avoids data dependencies between the MVCs. AnMVI/STC + MVC(len-1) is done for each block.In addition, memset with a variable length is now also handled without alibcall. Since the byte is first stored and then MVC is used from thataddress, a length of two must now be subtracted instead of one for the loopand EXRL. This requires an extra check for the one-byte case, which ishandled in a special block with just a single MVI/STC (like GCC).Review: Ulrich WeigandDifferential Revision: https://reviews.llvm.org/D112004 List of files: /llvm-project-15.0.7/llvm/test/CodeGen/SystemZ/memset-01.ll

1e68724d - Remove alignment argument from memcpy/memmove/memset in favour of alignment attributes (Step 1)

Fri, 19 Jan 2018 17:13:12 +0000

Remove alignment argument from memcpy/memmove/memset in favour of alignment attributes (Step 1)Summary: This is a resurrection of work first proposed and discussed in Aug 2015: http://lists.llvm.org/pipermail/llvm-dev/2015-August/089384.htmland initially landed (but then backed out) in Nov 2015: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20151109/312083.html The @llvm.memcpy/memmove/memset intrinsics currently have an explicit argumentwhich is required to be a constant integer. It represents the alignment of thedest (and source), and so must be the minimum of the actual alignment of thetwo. This change is the first in a series that allows source and dest to eachhave their own alignments by using the alignment attribute on their arguments. In this change we:1) Remove the alignment argument.2) Add alignment attributes to the source & dest arguments. We, temporarily, require that the alignments for source & dest be equal. For example, code which used to read: call void @llvm.memcpy.p0i8.p0i8.i32(i8* %dest, i8* %src, i32 100, i32 4, i1 false)will now read call void @llvm.memcpy.p0i8.p0i8.i32(i8* align 4 %dest, i8* align 4 %src, i32 100, i1 false) Downstream users may have to update their lit tests that check for@llvm.memcpy/memmove/memset call/declaration patterns. The following extended sed scriptmay help with updating the majority of your tests, but it does not catch all possiblepatterns so some manual checking and updating will be required.s~declare void @llvm\.mem(set|cpy|move)\.p([^(]*)$(.*), i32, i1$~declare void @llvm.mem\1.p\2(\3, i1)~gs~call void @llvm\.memset\.p([^(]*)i8$i8([^*]*)\* (.*), i8 (.*), i8 (.*), i32 [01], i1 ([^)]*)$~call void @llvm.memset.p\1i8(i8\2* \3, i8 \4, i8 \5, i1 \6)~gs~call void @llvm\.memset\.p([^(]*)i16$i8([^*]*)\* (.*), i8 (.*), i16 (.*), i32 [01], i1 ([^)]*)$~call void @llvm.memset.p\1i16(i8\2* \3, i8 \4, i16 \5, i1 \6)~gs~call void @llvm\.memset\.p([^(]*)i32$i8([^*]*)\* (.*), i8 (.*), i32 (.*), i32 [01], i1 ([^)]*)$~call void @llvm.memset.p\1i32(i8\2* \3, i8 \4, i32 \5, i1 \6)~gs~call void @llvm\.memset\.p([^(]*)i64$i8([^*]*)\* (.*), i8 (.*), i64 (.*), i32 [01], i1 ([^)]*)$~call void @llvm.memset.p\1i64(i8\2* \3, i8 \4, i64 \5, i1 \6)~gs~call void @llvm\.memset\.p([^(]*)i128$i8([^*]*)\* (.*), i8 (.*), i128 (.*), i32 [01], i1 ([^)]*)$~call void @llvm.memset.p\1i128(i8\2* \3, i8 \4, i128 \5, i1 \6)~gs~call void @llvm\.memset\.p([^(]*)i8$i8([^*]*)\* (.*), i8 (.*), i8 (.*), i32 ([0-9]*), i1 ([^)]*)$~call void @llvm.memset.p\1i8(i8\2* align \6 \3, i8 \4, i8 \5, i1 \7)~gs~call void @llvm\.memset\.p([^(]*)i16$i8([^*]*)\* (.*), i8 (.*), i16 (.*), i32 ([0-9]*), i1 ([^)]*)$~call void @llvm.memset.p\1i16(i8\2* align \6 \3, i8 \4, i16 \5, i1 \7)~gs~call void @llvm\.memset\.p([^(]*)i32$i8([^*]*)\* (.*), i8 (.*), i32 (.*), i32 ([0-9]*), i1 ([^)]*)$~call void @llvm.memset.p\1i32(i8\2* align \6 \3, i8 \4, i32 \5, i1 \7)~gs~call void @llvm\.memset\.p([^(]*)i64$i8([^*]*)\* (.*), i8 (.*), i64 (.*), i32 ([0-9]*), i1 ([^)]*)$~call void @llvm.memset.p\1i64(i8\2* align \6 \3, i8 \4, i64 \5, i1 \7)~gs~call void @llvm\.memset\.p([^(]*)i128$i8([^*]*)\* (.*), i8 (.*), i128 (.*), i32 ([0-9]*), i1 ([^)]*)$~call void @llvm.memset.p\1i128(i8\2* align \6 \3, i8 \4, i128 \5, i1 \7)~gs~call void @llvm\.mem(cpy|move)\.p([^(]*)i8$i8([^*]*)\* (.*), i8([^*]*)\* (.*), i8 (.*), i32 [01], i1 ([^)]*)$~call void @llvm.mem\1.p\2i8(i8\3* \4, i8\5* \6, i8 \7, i1 \8)~gs~call void @llvm\.mem(cpy|move)\.p([^(]*)i16$i8([^*]*)\* (.*), i8([^*]*)\* (.*), i16 (.*), i32 [01], i1 ([^)]*)$~call void @llvm.mem\1.p\2i16(i8\3* \4, i8\5* \6, i16 \7, i1 \8)~gs~call void @llvm\.mem(cpy|move)\.p([^(]*)i32$i8([^*]*)\* (.*), i8([^*]*)\* (.*), i32 (.*), i32 [01], i1 ([^)]*)$~call void @llvm.mem\1.p\2i32(i8\3* \4, i8\5* \6, i32 \7, i1 \8)~gs~call void @llvm\.mem(cpy|move)\.p([^(]*)i64$i8([^*]*)\* (.*), i8([^*]*)\* (.*), i64 (.*), i32 [01], i1 ([^)]*)$~call void @llvm.mem\1.p\2i64(i8\3* \4, i8\5* \6, i64 \7, i1 \8)~gs~call void @llvm\.mem(cpy|move)\.p([^(]*)i128$i8([^*]*)\* (.*), i8([^*]*)\* (.*), i128 (.*), i32 [01], i1 ([^)]*)$~call void @llvm.mem\1.p\2i128(i8\3* \4, i8\5* \6, i128 \7, i1 \8)~gs~call void @llvm\.mem(cpy|move)\.p([^(]*)i8$i8([^*]*)\* (.*), i8([^*]*)\* (.*), i8 (.*), i32 ([0-9]*), i1 ([^)]*)$~call void @llvm.mem\1.p\2i8(i8\3* align \8 \4, i8\5* align \8 \6, i8 \7, i1 \9)~gs~call void @llvm\.mem(cpy|move)\.p([^(]*)i16$i8([^*]*)\* (.*), i8([^*]*)\* (.*), i16 (.*), i32 ([0-9]*), i1 ([^)]*)$~call void @llvm.mem\1.p\2i16(i8\3* align \8 \4, i8\5* align \8 \6, i16 \7, i1 \9)~gs~call void @llvm\.mem(cpy|move)\.p([^(]*)i32$i8([^*]*)\* (.*), i8([^*]*)\* (.*), i32 (.*), i32 ([0-9]*), i1 ([^)]*)$~call void @llvm.mem\1.p\2i32(i8\3* align \8 \4, i8\5* align \8 \6, i32 \7, i1 \9)~gs~call void @llvm\.mem(cpy|move)\.p([^(]*)i64$i8([^*]*)\* (.*), i8([^*]*)\* (.*), i64 (.*), i32 ([0-9]*), i1 ([^)]*)$~call void @llvm.mem\1.p\2i64(i8\3* align \8 \4, i8\5* align \8 \6, i64 \7, i1 \9)~gs~call void @llvm\.mem(cpy|move)\.p([^(]*)i128$i8([^*]*)\* (.*), i8([^*]*)\* (.*), i128 (.*), i32 ([0-9]*), i1 ([^)]*)$~call void @llvm.mem\1.p\2i128(i8\3* align \8 \4, i8\5* align \8 \6, i128 \7, i1 \9)~g The remaining changes in the series will:Step 2) Expand the IRBuilder API to allow creation of memcpy/memmove with differing source and dest alignments.Step 3) Update Clang to use the new IRBuilder API.Step 4) Update Polly to use the new IRBuilder API.Step 5) Update LLVM passes that create memcpy/memmove calls to use the new IRBuilder API, and those that use use MemIntrinsicInst::[get|set]Alignment() to use getDestAlignment() and getSourceAlignment() instead.Step 6) Remove the single-alignment IRBuilder API for memcpy/memmove, and the MemIntrinsicInst::[get|set]Alignment() methods.Reviewers: pete, hfinkel, lhames, reames, bolluReviewed By: reamesSubscribers: niosHD, reames, jholewinski, qcolombet, jfb, sanjoy, arsenm, dschuff, dylanmckay, mehdi_amini, sdardis, nemanjai, david2050, nhaehnle, javed.absar, sbc100, jgravelle-google, eraman, aheejin, kbarton, JDevlieghere, asb, rbar, johnrusso, simoncook, jordy.potman.lists, apazos, sabuasal, llvm-commitsDifferential Revision: https://reviews.llvm.org/D41675llvm-svn: 322965 List of files: /llvm-project-15.0.7/llvm/test/CodeGen/SystemZ/memset-01.ll

67cf9a72 - Revert "Change memcpy/memset/memmove to have dest and source alignments."

Thu, 19 Nov 2015 05:56:52 +0000

Revert "Change memcpy/memset/memmove to have dest and source alignments."This reverts commit r253511.This likely broke the bots inhttp://lab.llvm.org:8011/builders/clang-ppc64-elf-linux2/builds/20202http://bb.pgr.jp/builders/clang-3stage-i686-linux/builds/3787llvm-svn: 253543 List of files: /llvm-project-15.0.7/llvm/test/CodeGen/SystemZ/memset-01.ll

72bc23ef - Change memcpy/memset/memmove to have dest and source alignments.

Wed, 18 Nov 2015 22:17:24 +0000

Change memcpy/memset/memmove to have dest and source alignments.Note, this was reviewed (and more details are in) http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20151109/312083.htmlThese intrinsics currently have an explicit alignment argument which isrequired to be a constant integer. It represents the alignment of thesource and dest, and so must be the minimum of those.This change allows source and dest to each have their own alignmentsby using the alignment attribute on their arguments. The alignmentargument itself is removed.There are a few places in the code for which the code needs to bechecked by an expert as to whether using only src/dest alignment issafe. For those places, they currently take the minimum of src/destalignments which matches the current behaviour.For example, code which used to read: call void @llvm.memcpy.p0i8.p0i8.i32(i8* %dest, i8* %src, i32 500, i32 8, i1 false)will now read: call void @llvm.memcpy.p0i8.p0i8.i32(i8* align 8 %dest, i8* align 8 %src, i32 500, i1 false)For out of tree owners, I was able to strip alignment from calls using sed by replacing: (call.*llvm\.memset.*)i32\ [0-9]*\,\ i1 false\)with: $1i1 false)and similarly for memmove and memcpy.I then added back in alignment to test cases which needed it.A similar commit will be made to clang which actually has many differences in alignment as nowIRBuilder can generate different source/dest alignments on calls.In IRBuilder itself, a new argument was added. Instead of calling: CreateMemCpy(Dst, Src, getInt64(Size), DstAlign, /* isVolatile */ false)you now call CreateMemCpy(Dst, Src, getInt64(Size), DstAlign, SrcAlign, /* isVolatile */ false)There is a temporary class (IntegerAlignment) which takes the source alignment and rejectsimplicit conversion from bool. This is to prevent isVolatile here from passing its defaultparameter to the source alignment.Note, changes in future can now be made to codegen. I didn't change anything here, but thischange should enable better memcpy code sequences.Reviewed by Hal Finkel.llvm-svn: 253511 List of files: /llvm-project-15.0.7/llvm/test/CodeGen/SystemZ/memset-01.ll

5e318f0b - [SystemZ] Extend memcpy and memset support to all constant lengths

Tue, 27 Aug 2013 09:54:29 +0000

[SystemZ] Extend memcpy and memset support to all constant lengthsLengths up to a certain threshold (currently 6 * 256) use a series of MVCs.Lengths above that threshold use a loop to handle X*256 bytes followedby a single MVC to handle the excess (if any). This loop will also beneeded in future when support for variable lengths is added.Because the same tablegen classes are used to define MVC and CLC,the patch also has the side-effect of defining a pseudo loop instructionfor CLC. That instruction isn't used yet (and wouldn't be handled correctlyif it were). I'm planning to use it soon though.llvm-svn: 189331 List of files: /llvm-project-15.0.7/llvm/test/CodeGen/SystemZ/memset-01.ll

d24ab20e - Mass update to CodeGen tests to use CHECK-LABEL for labels corresponding to function definitions for more informative error messages. No functionality change and all updated tests passed locally.

Sun, 14 Jul 2013 06:24:09 +0000

Mass update to CodeGen tests to use CHECK-LABEL for labels corresponding to function definitions for more informative error messages. No functionality change and all updated tests passed locally.This update was done with the following bash script: find test/CodeGen -name "*.ll" | \ while read NAME; do echo "$NAME" if ! grep -q "^; *RUN: *llc.*debug" $NAME; then TEMP=`mktemp -t temp` cp $NAME $TEMP sed -n "s/^define [^@]*@$[A-Za-z0-9_]*$(.*$/\1/p" < $NAME | \ while read FUNC; do sed -i '' "s/;$.*$$[A-Za-z0-9_-]*$:$ *$$FUNC: *\$/;\1\2-LABEL:\3$FUNC:/g" $TEMP done sed -i '' "s/;$.*$-LABEL-LABEL:/;\1-LABEL:/" $TEMP sed -i '' "s/;$.*$-NEXT-LABEL:/;\1-NEXT:/" $TEMP sed -i '' "s/;$.*$-NOT-LABEL:/;\1-NOT:/" $TEMP sed -i '' "s/;$.*$-DAG-LABEL:/;\1-DAG:/" $TEMP mv $TEMP $NAME fi donellvm-svn: 186280 List of files: /llvm-project-15.0.7/llvm/test/CodeGen/SystemZ/memset-01.ll

47660c14 - [SystemZ] Use "STC;MVC" for memset

Tue, 09 Jul 2013 09:32:42 +0000

[SystemZ] Use "STC;MVC" for memsetUse "STC;MVC" for memsets that are too big for two STCs or MV...Is yetsmall enough for a single MVC. As with memcpy, I'm leaving longer casestill later.The number of tests might seem excessive, but f33 & f34 from memset-04.llfailed the first cut because I'd not added the "?:" on the calculationof Size1.llvm-svn: 185918 List of files: /llvm-project-15.0.7/llvm/test/CodeGen/SystemZ/memset-01.ll