Changes in stack-protector-bmovpcb_call.ll

4ab3041a - Revert "[NFC] remove explicit default value for strboolattr attribute in tests"

Mon, 24 May 2021 17:43:40 +0000

Revert "[NFC] remove explicit default value for strboolattr attribute in tests"This reverts commit bda6e5bee04c75b1f1332b4fd1ac4e8ef6c3c247.See https://lab.llvm.org/buildbot/#/builders/109/builds/15424 for instance List of files: /llvm-project-15.0.7/llvm/test/CodeGen/ARM/stack-protector-bmovpcb_call.ll

bda6e5be - [NFC] remove explicit default value for strboolattr attribute in tests

Sun, 23 May 2021 11:19:23 +0000

[NFC] remove explicit default value for strboolattr attribute in testsSince d6de1e1a71406c75a4ea4d5a2fe84289f07ea3a1, no attributes is quivalent tosetting attribute to false.This is a preliminary commit for https://reviews.llvm.org/D99080 List of files: /llvm-project-15.0.7/llvm/test/CodeGen/ARM/stack-protector-bmovpcb_call.ll

a36ddf0a - Migrate function attribute "no-frame-pointer-elim"="false" to "frame-pointer"="none" as cleanups after D56351

Wed, 25 Dec 2019 00:11:33 +0000

Migrate function attribute "no-frame-pointer-elim"="false" to "frame-pointer"="none" as cleanups after D56351 List of files: /llvm-project-15.0.7/llvm/test/CodeGen/ARM/stack-protector-bmovpcb_call.ll

1e68724d - Remove alignment argument from memcpy/memmove/memset in favour of alignment attributes (Step 1)

Fri, 19 Jan 2018 17:13:12 +0000

Remove alignment argument from memcpy/memmove/memset in favour of alignment attributes (Step 1)Summary: This is a resurrection of work first proposed and discussed in Aug 2015: http://lists.llvm.org/pipermail/llvm-dev/2015-August/089384.htmland initially landed (but then backed out) in Nov 2015: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20151109/312083.html The @llvm.memcpy/memmove/memset intrinsics currently have an explicit argumentwhich is required to be a constant integer. It represents the alignment of thedest (and source), and so must be the minimum of the actual alignment of thetwo. This change is the first in a series that allows source and dest to eachhave their own alignments by using the alignment attribute on their arguments. In this change we:1) Remove the alignment argument.2) Add alignment attributes to the source & dest arguments. We, temporarily, require that the alignments for source & dest be equal. For example, code which used to read: call void @llvm.memcpy.p0i8.p0i8.i32(i8* %dest, i8* %src, i32 100, i32 4, i1 false)will now read call void @llvm.memcpy.p0i8.p0i8.i32(i8* align 4 %dest, i8* align 4 %src, i32 100, i1 false) Downstream users may have to update their lit tests that check for@llvm.memcpy/memmove/memset call/declaration patterns. The following extended sed scriptmay help with updating the majority of your tests, but it does not catch all possiblepatterns so some manual checking and updating will be required.s~declare void @llvm\.mem(set|cpy|move)\.p([^(]*)$(.*), i32, i1$~declare void @llvm.mem\1.p\2(\3, i1)~gs~call void @llvm\.memset\.p([^(]*)i8$i8([^*]*)\* (.*), i8 (.*), i8 (.*), i32 [01], i1 ([^)]*)$~call void @llvm.memset.p\1i8(i8\2* \3, i8 \4, i8 \5, i1 \6)~gs~call void @llvm\.memset\.p([^(]*)i16$i8([^*]*)\* (.*), i8 (.*), i16 (.*), i32 [01], i1 ([^)]*)$~call void @llvm.memset.p\1i16(i8\2* \3, i8 \4, i16 \5, i1 \6)~gs~call void @llvm\.memset\.p([^(]*)i32$i8([^*]*)\* (.*), i8 (.*), i32 (.*), i32 [01], i1 ([^)]*)$~call void @llvm.memset.p\1i32(i8\2* \3, i8 \4, i32 \5, i1 \6)~gs~call void @llvm\.memset\.p([^(]*)i64$i8([^*]*)\* (.*), i8 (.*), i64 (.*), i32 [01], i1 ([^)]*)$~call void @llvm.memset.p\1i64(i8\2* \3, i8 \4, i64 \5, i1 \6)~gs~call void @llvm\.memset\.p([^(]*)i128$i8([^*]*)\* (.*), i8 (.*), i128 (.*), i32 [01], i1 ([^)]*)$~call void @llvm.memset.p\1i128(i8\2* \3, i8 \4, i128 \5, i1 \6)~gs~call void @llvm\.memset\.p([^(]*)i8$i8([^*]*)\* (.*), i8 (.*), i8 (.*), i32 ([0-9]*), i1 ([^)]*)$~call void @llvm.memset.p\1i8(i8\2* align \6 \3, i8 \4, i8 \5, i1 \7)~gs~call void @llvm\.memset\.p([^(]*)i16$i8([^*]*)\* (.*), i8 (.*), i16 (.*), i32 ([0-9]*), i1 ([^)]*)$~call void @llvm.memset.p\1i16(i8\2* align \6 \3, i8 \4, i16 \5, i1 \7)~gs~call void @llvm\.memset\.p([^(]*)i32$i8([^*]*)\* (.*), i8 (.*), i32 (.*), i32 ([0-9]*), i1 ([^)]*)$~call void @llvm.memset.p\1i32(i8\2* align \6 \3, i8 \4, i32 \5, i1 \7)~gs~call void @llvm\.memset\.p([^(]*)i64$i8([^*]*)\* (.*), i8 (.*), i64 (.*), i32 ([0-9]*), i1 ([^)]*)$~call void @llvm.memset.p\1i64(i8\2* align \6 \3, i8 \4, i64 \5, i1 \7)~gs~call void @llvm\.memset\.p([^(]*)i128$i8([^*]*)\* (.*), i8 (.*), i128 (.*), i32 ([0-9]*), i1 ([^)]*)$~call void @llvm.memset.p\1i128(i8\2* align \6 \3, i8 \4, i128 \5, i1 \7)~gs~call void @llvm\.mem(cpy|move)\.p([^(]*)i8$i8([^*]*)\* (.*), i8([^*]*)\* (.*), i8 (.*), i32 [01], i1 ([^)]*)$~call void @llvm.mem\1.p\2i8(i8\3* \4, i8\5* \6, i8 \7, i1 \8)~gs~call void @llvm\.mem(cpy|move)\.p([^(]*)i16$i8([^*]*)\* (.*), i8([^*]*)\* (.*), i16 (.*), i32 [01], i1 ([^)]*)$~call void @llvm.mem\1.p\2i16(i8\3* \4, i8\5* \6, i16 \7, i1 \8)~gs~call void @llvm\.mem(cpy|move)\.p([^(]*)i32$i8([^*]*)\* (.*), i8([^*]*)\* (.*), i32 (.*), i32 [01], i1 ([^)]*)$~call void @llvm.mem\1.p\2i32(i8\3* \4, i8\5* \6, i32 \7, i1 \8)~gs~call void @llvm\.mem(cpy|move)\.p([^(]*)i64$i8([^*]*)\* (.*), i8([^*]*)\* (.*), i64 (.*), i32 [01], i1 ([^)]*)$~call void @llvm.mem\1.p\2i64(i8\3* \4, i8\5* \6, i64 \7, i1 \8)~gs~call void @llvm\.mem(cpy|move)\.p([^(]*)i128$i8([^*]*)\* (.*), i8([^*]*)\* (.*), i128 (.*), i32 [01], i1 ([^)]*)$~call void @llvm.mem\1.p\2i128(i8\3* \4, i8\5* \6, i128 \7, i1 \8)~gs~call void @llvm\.mem(cpy|move)\.p([^(]*)i8$i8([^*]*)\* (.*), i8([^*]*)\* (.*), i8 (.*), i32 ([0-9]*), i1 ([^)]*)$~call void @llvm.mem\1.p\2i8(i8\3* align \8 \4, i8\5* align \8 \6, i8 \7, i1 \9)~gs~call void @llvm\.mem(cpy|move)\.p([^(]*)i16$i8([^*]*)\* (.*), i8([^*]*)\* (.*), i16 (.*), i32 ([0-9]*), i1 ([^)]*)$~call void @llvm.mem\1.p\2i16(i8\3* align \8 \4, i8\5* align \8 \6, i16 \7, i1 \9)~gs~call void @llvm\.mem(cpy|move)\.p([^(]*)i32$i8([^*]*)\* (.*), i8([^*]*)\* (.*), i32 (.*), i32 ([0-9]*), i1 ([^)]*)$~call void @llvm.mem\1.p\2i32(i8\3* align \8 \4, i8\5* align \8 \6, i32 \7, i1 \9)~gs~call void @llvm\.mem(cpy|move)\.p([^(]*)i64$i8([^*]*)\* (.*), i8([^*]*)\* (.*), i64 (.*), i32 ([0-9]*), i1 ([^)]*)$~call void @llvm.mem\1.p\2i64(i8\3* align \8 \4, i8\5* align \8 \6, i64 \7, i1 \9)~gs~call void @llvm\.mem(cpy|move)\.p([^(]*)i128$i8([^*]*)\* (.*), i8([^*]*)\* (.*), i128 (.*), i32 ([0-9]*), i1 ([^)]*)$~call void @llvm.mem\1.p\2i128(i8\3* align \8 \4, i8\5* align \8 \6, i128 \7, i1 \9)~g The remaining changes in the series will:Step 2) Expand the IRBuilder API to allow creation of memcpy/memmove with differing source and dest alignments.Step 3) Update Clang to use the new IRBuilder API.Step 4) Update Polly to use the new IRBuilder API.Step 5) Update LLVM passes that create memcpy/memmove calls to use the new IRBuilder API, and those that use use MemIntrinsicInst::[get|set]Alignment() to use getDestAlignment() and getSourceAlignment() instead.Step 6) Remove the single-alignment IRBuilder API for memcpy/memmove, and the MemIntrinsicInst::[get|set]Alignment() methods.Reviewers: pete, hfinkel, lhames, reames, bolluReviewed By: reamesSubscribers: niosHD, reames, jholewinski, qcolombet, jfb, sanjoy, arsenm, dschuff, dylanmckay, mehdi_amini, sdardis, nemanjai, david2050, nhaehnle, javed.absar, sbc100, jgravelle-google, eraman, aheejin, kbarton, JDevlieghere, asb, rbar, johnrusso, simoncook, jordy.potman.lists, apazos, sabuasal, llvm-commitsDifferential Revision: https://reviews.llvm.org/D41675llvm-svn: 322965 List of files: /llvm-project-15.0.7/llvm/test/CodeGen/ARM/stack-protector-bmovpcb_call.ll

67cf9a72 - Revert "Change memcpy/memset/memmove to have dest and source alignments."

Thu, 19 Nov 2015 05:56:52 +0000

Revert "Change memcpy/memset/memmove to have dest and source alignments."This reverts commit r253511.This likely broke the bots inhttp://lab.llvm.org:8011/builders/clang-ppc64-elf-linux2/builds/20202http://bb.pgr.jp/builders/clang-3stage-i686-linux/builds/3787llvm-svn: 253543 List of files: /llvm-project-15.0.7/llvm/test/CodeGen/ARM/stack-protector-bmovpcb_call.ll

72bc23ef - Change memcpy/memset/memmove to have dest and source alignments.

Wed, 18 Nov 2015 22:17:24 +0000

Change memcpy/memset/memmove to have dest and source alignments.Note, this was reviewed (and more details are in) http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20151109/312083.htmlThese intrinsics currently have an explicit alignment argument which isrequired to be a constant integer. It represents the alignment of thesource and dest, and so must be the minimum of those.This change allows source and dest to each have their own alignmentsby using the alignment attribute on their arguments. The alignmentargument itself is removed.There are a few places in the code for which the code needs to bechecked by an expert as to whether using only src/dest alignment issafe. For those places, they currently take the minimum of src/destalignments which matches the current behaviour.For example, code which used to read: call void @llvm.memcpy.p0i8.p0i8.i32(i8* %dest, i8* %src, i32 500, i32 8, i1 false)will now read: call void @llvm.memcpy.p0i8.p0i8.i32(i8* align 8 %dest, i8* align 8 %src, i32 500, i1 false)For out of tree owners, I was able to strip alignment from calls using sed by replacing: (call.*llvm\.memset.*)i32\ [0-9]*\,\ i1 false\)with: $1i1 false)and similarly for memmove and memcpy.I then added back in alignment to test cases which needed it.A similar commit will be made to clang which actually has many differences in alignment as nowIRBuilder can generate different source/dest alignments on calls.In IRBuilder itself, a new argument was added. Instead of calling: CreateMemCpy(Dst, Src, getInt64(Size), DstAlign, /* isVolatile */ false)you now call CreateMemCpy(Dst, Src, getInt64(Size), DstAlign, SrcAlign, /* isVolatile */ false)There is a temporary class (IntegerAlignment) which takes the source alignment and rejectsimplicit conversion from bool. This is to prevent isVolatile here from passing its defaultparameter to the source alignment.Note, changes in future can now be made to codegen. I didn't change anything here, but thischange should enable better memcpy code sequences.Reviewed by Hal Finkel.llvm-svn: 253511 List of files: /llvm-project-15.0.7/llvm/test/CodeGen/ARM/stack-protector-bmovpcb_call.ll

23af6484 - [opaque pointer type] Add textual IR support for explicit type parameter to the call instruction

Thu, 16 Apr 2015 23:24:18 +0000

[opaque pointer type] Add textual IR support for explicit type parameter to the call instructionSee r230786 and r230794 for similar changes to gep and loadrespectively.Call is a bit different because it often doesn't have a single explicittype - usually the type is deduced from the arguments, and just thereturn type is explicit. In those cases there's no need to change theIR.When that's not the case, the IR usually contains the pointer type ofthe first operand - but since typed pointers are going away, thatrepresentation is insufficient so I'm just stripping the "pointerness"of the explicit type away.This does make the IR a bit weird - it /sort of/ reads like the type ofthe first operand: "call void () %x(" but %x is actually of type "void()*" and will eventually be just of type "ptr". But this seems not toobad and I don't think it would benefit from repeating the type("void (), void () * %x(" and then eventually "void (), ptr %x(") as hasbeen done with gep and load.This also has a side benefit: since the explicit type is no longer apointer, there's no ambiguity between an explicit type and a functionthat returns a function pointer. Previously this case needed an explicittype (eg: a function returning a void() function was written as"call void () () * @x(" rather than "call void () * @x(" because of theambiguity between a function returning a pointer to a void() functionand a function returning void).No ambiguity means even function pointer return types can just bewritten alone, without writing the whole function's type.This leaves /only/ the varargs case where the explicit type is required.Given the special type syntax in call instructions, the regex-fu usedfor migration was a bit more involved in its own unique way (as everyone of these is) so here it is. Use it in conjunction with the apply.shscript and associated find/xargs commands I've provided in rr230786 tomigrate your out of tree tests. Do let me know if any of this doesn'tcover your cases & we can iterate on a more general script/regexes tohelp others with out of tree tests.About 9 test cases couldn't be automatically migrated - half of thosewere functions returning function pointers, where I just had to manuallydelete the function argument types now that we didn't need an explicitfunction type there. The other half were typedefs of function types usedin calls - just had to manually drop the * from those.import fileinputimport sysimport repat = re.compile(r'((?:=|:|^|\s)call\s(?:[^@]*?))(\s*$|\s*(?:(?:\[\[[a-zA-Z0-9_]+\]\]|[@%](?:(")?[\\\?@a-zA-Z0-9_.]*?(?(3)"|)|{{.*}}))(?:$|$)|undef|inttoptr|bitcast|null|asm).*$)')addrspace_end = re.compile(r"addrspace\(\d+$\s*\*$")func_end = re.compile("(?:void.*|\)\s*)\*$")def conv(match, line): if not match or re.search(addrspace_end, match.group(1)) or not re.search(func_end, match.group(1)): return line return line[:match.start()] + match.group(1)[:match.group(1).rfind('*')].rstrip() + match.group(2) + line[match.end():]for line in sys.stdin: sys.stdout.write(conv(re.search(pat, line), line))llvm-svn: 235145 List of files: /llvm-project-15.0.7/llvm/test/CodeGen/ARM/stack-protector-bmovpcb_call.ll

f72d05bc - [opaque pointer type] Add textual IR support for explicit type parameter to gep operator

Fri, 13 Mar 2015 18:20:45 +0000

[opaque pointer type] Add textual IR support for explicit type parameter to gep operatorSimilar to gep (r230786) and load (r230794) changes.Similar migration script can be used to update test cases, whichsuccessfully migrated all of LLVM and Polly, but about 4 test casesneeded manually changes in Clang.(this script will read the contents of stdin and massage it into stdout- wrap it in the 'apply.sh' script shown in previous commits + xargs toapply it over a large set of test cases)import fileinputimport sysimport rerep = re.compile(r"(getelementptr(?:\s+inbounds)?\s*$)((<\d*\s+x\s+)?([^@]*?)(|\s*addrspace\(\d+$)\s*\*(?(3)>)\s*)(?=$|%|@|null|undef|blockaddress|getelementptr|addrspacecast|bitcast|inttoptr|zeroinitializer|<|\[\[[a-zA-Z]|\{\{)", re.MULTILINE | re.DOTALL)def conv(match): line = match.group(1) line += match.group(4) line += ", " line += match.group(2) return lineline = sys.stdin.read()off = 0for match in re.finditer(rep, line): sys.stdout.write(line[off:match.start()]) sys.stdout.write(conv(match)) off = match.end()sys.stdout.write(line[off:])llvm-svn: 232184 List of files: /llvm-project-15.0.7/llvm/test/CodeGen/ARM/stack-protector-bmovpcb_call.ll

79e6c749 - [opaque pointer type] Add textual IR support for explicit type parameter to getelementptr instruction

Fri, 27 Feb 2015 19:29:02 +0000

[opaque pointer type] Add textual IR support for explicit type parameter to getelementptr instructionOne of several parallel first steps to remove the target type of pointers,replacing them with a single opaque pointer type.This adds an explicit type parameter to the gep instruction so that when thefirst parameter becomes an opaque pointer type, the type to gep through isstill available to the instructions.* This doesn't modify gep operators, only instructions (operators will be handled separately)* Textual IR changes only. Bitcode (including upgrade) and changing the in-memory representation will be in separate changes.* geps of vectors are transformed as: getelementptr <4 x float*> %x, ... ->getelementptr float, <4 x float*> %x, ... Then, once the opaque pointer type is introduced, this will ultimately look like: getelementptr float, <4 x ptr> %x with the unambiguous interpretation that it is a vector of pointers to float.* address spaces remain on the pointer, not the type: getelementptr float addrspace(1)* %x ->getelementptr float, float addrspace(1)* %x Then, eventually: getelementptr float, ptr addrspace(1) %xImportantly, the massive amount of test case churn has been automated bysame crappy python code. I had to manually update a few test cases thatwouldn't fit the script's model (r228970,r229196,r229197,r229198). Thepython script just massages stdin and writes the result to stdout, Ithen wrapped that in a shell script to handle replacing files, thenusing the usual find+xargs to migrate all the files.update.py:import fileinputimport sysimport reibrep = re.compile(r"(^.*?[^%\w]getelementptr inbounds )(((?:<\d* x )?)(.*?)(| addrspace$\d$) *\*(|>)(?:$| *(?:%|@|null|undef|blockaddress|getelementptr|addrspacecast|bitcast|inttoptr|\[\[[a-zA-Z]|\{\{).*$))")normrep = re.compile( r"(^.*?[^%\w]getelementptr )(((?:<\d* x )?)(.*?)(| addrspace$\d$) *\*(|>)(?:$| *(?:%|@|null|undef|blockaddress|getelementptr|addrspacecast|bitcast|inttoptr|\[\[[a-zA-Z]|\{\{).*$))")def conv(match, line): if not match: return line line = match.groups()[0] if len(match.groups()[5]) == 0: line += match.groups()[2] line += match.groups()[3] line += ", " line += match.groups()[1] line += "\n" return linefor line in sys.stdin: if line.find("getelementptr ") == line.find("getelementptr inbounds"): if line.find("getelementptr inbounds") != line.find("getelementptr inbounds ("): line = conv(re.match(ibrep, line), line) elif line.find("getelementptr ") != line.find("getelementptr ("): line = conv(re.match(normrep, line), line) sys.stdout.write(line)apply.sh:for name in "$@"do python3 `dirname "$0"`/update.py < "$name" > "$name.tmp" && mv "$name.tmp" "$name" rm -f "$name.tmp"doneThe actual commands:From llvm/src:find test/ -name *.ll | xargs ./apply.shFrom llvm/src/tools/clang:find test/ -name *.mm -o -name *.m -o -name *.cpp -o -name *.c | xargs -I '{}' ../../apply.sh "{}"From llvm/src/tools/polly:find test/ -name *.ll | xargs ./apply.shAfter that, check-all (with llvm, clang, clang-tools-extra, lld,compiler-rt, and polly all checked out).The extra 'rm' in the apply.sh script is due to a few files in clang's testsuite using interesting unicode stuff that my python script was throwingexceptions on. None of those files needed to be migrated, so it seemedsufficient to ignore those cases.Reviewers: rafael, dexonsmith, grosserDifferential Revision: http://reviews.llvm.org/D7636llvm-svn: 230786 List of files: /llvm-project-15.0.7/llvm/test/CodeGen/ARM/stack-protector-bmovpcb_call.ll

20f25eb9 - [stack protector] Work around an issue with the BMOVPCB_CALL instruction on ARM by disabling does not return on __stack_chk_fail.

Thu, 22 Aug 2013 23:45:24 +0000

[stack protector] Work around an issue with the BMOVPCB_CALL instruction on ARM by disabling does not return on __stack_chk_fail.This is to fix the bots while I look to see if there is something I can do here.rdar://14811848llvm-svn: 189076 List of files: /llvm-project-15.0.7/llvm/test/CodeGen/ARM/stack-protector-bmovpcb_call.ll