Changes in fast-isel-pred.ll

a79ac14f - [opaque pointer type] Add textual IR support for explicit type parameter to load instruction

Fri, 27 Feb 2015 21:17:42 +0000

[opaque pointer type] Add textual IR support for explicit type parameter to load instructionEssentially the same as the GEP change in r230786.A similar migration script can be used to update test cases, though a few moretest case improvements/changes were required this time around: (r229269-r229278)import fileinputimport sysimport repat = re.compile(r"((?:=|:|^)\s*load (?:atomic )?(?:volatile )?(.*?))(| addrspace$\d+$ *)\*($| *(?:%|@|null|undef|blockaddress|getelementptr|addrspacecast|bitcast|inttoptr|\[\[[a-zA-Z]|\{\{).*$)")for line in sys.stdin: sys.stdout.write(re.sub(pat, r"\1, \2\3*\4", line))Reviewers: rafael, dexonsmith, grosserDifferential Revision: http://reviews.llvm.org/D7649llvm-svn: 230794 List of files: /llvm-project-15.0.7/llvm/test/CodeGen/ARM/fast-isel-pred.ll

79e6c749 - [opaque pointer type] Add textual IR support for explicit type parameter to getelementptr instruction

Fri, 27 Feb 2015 19:29:02 +0000

[opaque pointer type] Add textual IR support for explicit type parameter to getelementptr instructionOne of several parallel first steps to remove the target type of pointers,replacing them with a single opaque pointer type.This adds an explicit type parameter to the gep instruction so that when thefirst parameter becomes an opaque pointer type, the type to gep through isstill available to the instructions.* This doesn't modify gep operators, only instructions (operators will be handled separately)* Textual IR changes only. Bitcode (including upgrade) and changing the in-memory representation will be in separate changes.* geps of vectors are transformed as: getelementptr <4 x float*> %x, ... ->getelementptr float, <4 x float*> %x, ... Then, once the opaque pointer type is introduced, this will ultimately look like: getelementptr float, <4 x ptr> %x with the unambiguous interpretation that it is a vector of pointers to float.* address spaces remain on the pointer, not the type: getelementptr float addrspace(1)* %x ->getelementptr float, float addrspace(1)* %x Then, eventually: getelementptr float, ptr addrspace(1) %xImportantly, the massive amount of test case churn has been automated bysame crappy python code. I had to manually update a few test cases thatwouldn't fit the script's model (r228970,r229196,r229197,r229198). Thepython script just massages stdin and writes the result to stdout, Ithen wrapped that in a shell script to handle replacing files, thenusing the usual find+xargs to migrate all the files.update.py:import fileinputimport sysimport reibrep = re.compile(r"(^.*?[^%\w]getelementptr inbounds )(((?:<\d* x )?)(.*?)(| addrspace$\d$) *\*(|>)(?:$| *(?:%|@|null|undef|blockaddress|getelementptr|addrspacecast|bitcast|inttoptr|\[\[[a-zA-Z]|\{\{).*$))")normrep = re.compile( r"(^.*?[^%\w]getelementptr )(((?:<\d* x )?)(.*?)(| addrspace$\d$) *\*(|>)(?:$| *(?:%|@|null|undef|blockaddress|getelementptr|addrspacecast|bitcast|inttoptr|\[\[[a-zA-Z]|\{\{).*$))")def conv(match, line): if not match: return line line = match.groups()[0] if len(match.groups()[5]) == 0: line += match.groups()[2] line += match.groups()[3] line += ", " line += match.groups()[1] line += "\n" return linefor line in sys.stdin: if line.find("getelementptr ") == line.find("getelementptr inbounds"): if line.find("getelementptr inbounds") != line.find("getelementptr inbounds ("): line = conv(re.match(ibrep, line), line) elif line.find("getelementptr ") != line.find("getelementptr ("): line = conv(re.match(normrep, line), line) sys.stdout.write(line)apply.sh:for name in "$@"do python3 `dirname "$0"`/update.py < "$name" > "$name.tmp" && mv "$name.tmp" "$name" rm -f "$name.tmp"doneThe actual commands:From llvm/src:find test/ -name *.ll | xargs ./apply.shFrom llvm/src/tools/clang:find test/ -name *.mm -o -name *.m -o -name *.cpp -o -name *.c | xargs -I '{}' ../../apply.sh "{}"From llvm/src/tools/polly:find test/ -name *.ll | xargs ./apply.shAfter that, check-all (with llvm, clang, clang-tools-extra, lld,compiler-rt, and polly all checked out).The extra 'rm' in the apply.sh script is due to a few files in clang's testsuite using interesting unicode stuff that my python script was throwingexceptions on. None of those files needed to be migrated, so it seemedsufficient to ignore those cases.Reviewers: rafael, dexonsmith, grosserDifferential Revision: http://reviews.llvm.org/D7636llvm-svn: 230786 List of files: /llvm-project-15.0.7/llvm/test/CodeGen/ARM/fast-isel-pred.ll

18db1f2f - Enable FastISel on ARM for Linux and NaCl, not MCJIT

Fri, 14 Jun 2013 02:49:43 +0000

Enable FastISel on ARM for Linux and NaCl, not MCJITThis is a resubmit of r182877, which was reverted because it brokenMCJIT tests on ARM. The patch leaves MCJIT on ARM as it was before: onlyenabled for iOS. I've CC'ed people from the original review and revert.FastISel was only enabled for iOS ARM and Thumb2, this patch enables itfor ARM (not Thumb2) on Linux and NaCl, but not MCJIT.Thumb2 support needs a bit more work, mainly around register classrestrictions.The patch punts to SelectionDAG when doing TLS relocation on non-Darwintargets. I will fix this and other FastISel-to-SelectionDAG failures ina separate patch.The patch also forces FastISel to retain frame pointers: iOS alwayskeeps them for backtracking (so emitted code won't change because ofthis), but Linux was getting much worse code that was incorrect whenusing big frames (such as test-suite's lencod). I'll also fix this in alater patch, it will probably require a peephole so that FastISeldoesn't rematerialize frame pointers back-to-back.The test changes are straightforward, similar to: http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20130513/174279.htmlThey also add a vararg test that got dropped in that change.I ran all of lnt test-suite on A15 hardware with --optimize-option=-O0and all the tests pass. All the tests also pass on x86 make check-all. Ialso re-ran the check-all tests that failed on ARM, and they all seem topass.llvm-svn: 183966 List of files: /llvm-project-15.0.7/llvm/test/CodeGen/ARM/fast-isel-pred.ll

99bd2ae4 - Revert r182937 and r182877.

Thu, 30 May 2013 20:37:52 +0000

Revert r182937 and r182877.r182877 broke MCJIT tests on ARM and r182937 was working around another failureby r182877.This should make the ARM bots green.llvm-svn: 182960 List of files: /llvm-project-15.0.7/llvm/test/CodeGen/ARM/fast-isel-pred.ll

f60e0e44 - Enable FastISel on ARM for Linux and NaCl

Wed, 29 May 2013 20:38:10 +0000

Enable FastISel on ARM for Linux and NaClFastISel was only enabled for iOS ARM and Thumb2, this patch enables itfor ARM (not Thumb2) on Linux and NaCl.Thumb2 support needs a bit more work, mainly around register classrestrictions.The patch punts to SelectionDAG when doing TLS relocation on non-Darwintargets. I will fix this and other FastISel-to-SelectionDAG failures ina separate patch.The patch also forces FastISel to retain frame pointers: iOS alwayskeeps them for backtracking (so emitted code won't change because ofthis), but Linux was getting much worse code that was incorrect whenusing big frames (such as test-suite's lencod). I'll also fix this in alater patch, it will probably require a peephole so that FastISeldoesn't rematerialize frame pointers back-to-back.The test changes are straightforward, similar to: http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20130513/174279.htmlThey also add a vararg test that got dropped in that change.I ran all of test-suite on A15 hardware with --optimize-option=-O0 andall the tests pass.llvm-svn: 182877 List of files: /llvm-project-15.0.7/llvm/test/CodeGen/ARM/fast-isel-pred.ll

45c33c98 - Add -verify-machineinstrs to these fast-isel test cases.

Tue, 27 Nov 2012 20:49:56 +0000

Add -verify-machineinstrs to these fast-isel test cases.llvm-svn: 168723 List of files: /llvm-project-15.0.7/llvm/test/CodeGen/ARM/fast-isel-pred.ll

d3cc9fdd - Fix this test up a bit.

Mon, 14 Mar 2011 21:05:21 +0000

Fix this test up a bit.llvm-svn: 127621 List of files: /llvm-project-15.0.7/llvm/test/CodeGen/ARM/fast-isel-pred.ll

c313d940 - Saving files before committing is overrated.

Sat, 12 Mar 2011 01:36:23 +0000

Saving files before committing is overrated.Add a RUN line to this test.llvm-svn: 127520 List of files: /llvm-project-15.0.7/llvm/test/CodeGen/ARM/fast-isel-pred.ll

174d8727 - Sometimes isPredicable lies to us and tells us we don't need the operands.

Sat, 12 Mar 2011 01:09:29 +0000

Sometimes isPredicable lies to us and tells us we don't need the operands.Go ahead and add them on when we might want to use them and letlater passes remove them.Fixes rdar://9118569llvm-svn: 127518 List of files: /llvm-project-15.0.7/llvm/test/CodeGen/ARM/fast-isel-pred.ll