en Copyright 2015 Java http://172.16.0.5:8080/history/llvm-project-15.0.7/llvm/test/Bitcode/upgrade-arc-runtime-calls.ll#9e51fb6c [AutoUpgrader] Make ArcRuntime Autoupgrader more conservativeSummary:This is a tweak to r368311 and r368646 which auto upgrades the calls toobjc runtime functions to objc runtime intrinsics, in order to make surethat the auto upgrader does not trigger with up-to-date bitcode.It is possible for bitcode that is up-to-date to contain direct calls toobjc runtime function and those are not inserted by compiler as part ofARC and they should not be upgraded. Now auto upgrader only triggers aswhen the old style of ARC marker is used so it is guaranteed that itwon't trigger on update-to-date bitcode.This also means it won't do this upgrade for bitcode from llvm-8 andllvm-9, which preserves the behavior of those releases. Ideally theyshould be upgraded as well but it is more important to make sureAutoUpgrader will not trigger on up-to-date bitcode.Reviewers: ahatanak, rjmccall, dexonsmith, peteReviewed By: dexonsmithSubscribers: hiraditya, jkorous, llvm-commitsTags: #llvmDifferential Revision: https://reviews.llvm.org/D66153llvm-svn: 368730 List of files: /llvm-project-15.0.7/llvm/test/Bitcode/upgrade-arc-runtime-calls.ll Tue, 13 Aug 2019 17:52:21 +0000 Steven Wu <stevenwu@apple.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/llvm/test/Bitcode/upgrade-arc-runtime-calls.ll#3c7c0531 Do not call replaceAllUsesWith to upgrade calls to ARC runtime functionsto intrinsic callsThis fixes a bug in r368311.It turns out that the ARC runtime functions in the IR can have pointerparameter types that are not i8* or i8**. Instead of RAUWing normalfunctions with intrinsics, manually bitcast the arguments before passingthem to the intrinsic functions and bitcast the return value back to thetype of the original call instruction.This recommits r368634, which was reverted in r368637. The loop in thepatch was iterating over uses of a function and deleting function callsinside it, which caused bots to crash.rdar://problem/54125406Differential Revision: https://reviews.llvm.org/D66047llvm-svn: 368646 List of files: /llvm-project-15.0.7/llvm/test/Bitcode/upgrade-arc-runtime-calls.ll Tue, 13 Aug 2019 01:23:06 +0000 Akira Hatanaka <ahatanaka@apple.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/llvm/test/Bitcode/upgrade-arc-runtime-calls.ll#c1098089 Revert "Do not call replaceAllUsesWith to upgrade calls to ARC runtime functions"This reverts commit r368634 because it broke a bot.llvm-svn: 368637 List of files: /llvm-project-15.0.7/llvm/test/Bitcode/upgrade-arc-runtime-calls.ll Tue, 13 Aug 2019 00:20:36 +0000 Akira Hatanaka <ahatanaka@apple.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/llvm/test/Bitcode/upgrade-arc-runtime-calls.ll#6817ce24 Do not call replaceAllUsesWith to upgrade calls to ARC runtime functionsto intrinsic callsThis fixes a bug in r368311.It turns out that the ARC runtime functions in the IR can have pointerparameter types that are not i8* or i8**. Instead of RAUWing normalfunctions with intrinsics, manually bitcast the arguments before passingthem to the intrinsic functions and bitcast the return value back to thetype of the original call instruction.rdar://problem/54125406llvm-svn: 368634 List of files: /llvm-project-15.0.7/llvm/test/Bitcode/upgrade-arc-runtime-calls.ll Mon, 12 Aug 2019 23:53:23 +0000 Akira Hatanaka <ahatanaka@apple.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/llvm/test/Bitcode/upgrade-arc-runtime-calls.ll#ecde8c7a [ObjC][ARC] Upgrade calls to ARC runtime functions to intrinsic calls ifthe bitcode has the arm64 retainAutoreleasedReturnValue markerThe ARC middle-end passes stopped optimizing or transforming bitcodethat has been compiled with old compilers after we started emittingcalls to ARC runtime functions as intrinsic calls instead of normalfunction calls in the front-end and made changes to teach the ARCmiddle-end passes about those intrinsics (see r349534). This patchconverts calls to ARC runtime functions that are not intrinsic functionsto intrinsic function calls if the bitcode has the arm64retainAutoreleasedReturnValue marker. Checking for the presence of themarker is necessary to make sure we aren't changing ARC function callsthat were originally MRR message sends (see r349952).rdar://problem/53280660Differential Revision: https://reviews.llvm.org/D65902llvm-svn: 368311 List of files: /llvm-project-15.0.7/llvm/test/Bitcode/upgrade-arc-runtime-calls.ll Thu, 08 Aug 2019 16:59:31 +0000 Akira Hatanaka <ahatanaka@apple.com>