Changes in ELFAsmParser.cpp

b6889f0f - [Sparc] Don't use SunStyleELFSectionSwitchSyntax

Wed, 17 Aug 2022 10:59:29 +0000

[Sparc] Don't use SunStyleELFSectionSwitchSyntaxAs discussed in D85414 , two testscurrently `FAIL` on Sparc since that backend uses the Sun assembler syntaxfor the `.section` directive, controlled by`SunStyleELFSectionSwitchSyntax`.Instead of adapting the affected tests, this patch changes that default.The internal assembler still accepts both forms as input, only the outputsyntax is affected.Current support for the Sun syntax is cursory at best: the built-inassembler cannot even assemble some of the directives emitted by GCC, andthe set supported by the Solaris assembler is even larger: SPARC AssemblyLanguage Reference Manual, 3.4 Pseudo-Op Attributes.A few Sparc test cases need to be adjusted. At the same time, the patchfixes the failures from D85414 .Tested on `sparcv9-sun-solaris2.11`.Differential Revision: https://reviews.llvm.org/D85415(cherry picked from commit d9993484ee40abaab6d9e96872d3a29044202aea) List of files: /llvm-project-15.0.7/llvm/lib/MC/MCParser/ELFAsmParser.cpp

1d2ce4da - [Object] Add ELF section type for offloading objects

Sun, 03 Jul 2022 20:46:31 +0000

[Object] Add ELF section type for offloading objectsCurrently we use the `.llvm.offloading` section to store device-sideobjects inside the host, creating a fat binary. The contents of thesesections is currently determined by the name of the section while itshould ideally be determined by its type. This patch adds the new`SHT_LLVM_OFFLOADING` section type to the ELF section types. Whichshould make it easier to identify this specific data format.Reviewed By: jhendersonDifferential Revision: https://reviews.llvm.org/D129052 List of files: /llvm-project-15.0.7/llvm/lib/MC/MCParser/ELFAsmParser.cpp

adf4142f - [MC] De-capitalize SwitchSection. NFC

Sat, 11 Jun 2022 05:50:55 +0000

[MC] De-capitalize SwitchSection. NFCAdd SwitchSection to return switchSection. The API will be removed soon. List of files: /llvm-project-15.0.7/llvm/lib/MC/MCParser/ELFAsmParser.cpp

15d82c62 - [MC] De-capitalize MCStreamer functions

Tue, 07 Jun 2022 07:31:02 +0000

[MC] De-capitalize MCStreamer functionsFollow-up to c031378ce01b8485ba0ef486654bc9393c4ac024 .The class is mostly consistent now. List of files: /llvm-project-15.0.7/llvm/lib/MC/MCParser/ELFAsmParser.cpp

365be7ac - [MC][ELF] Use SHF_SUNW_NODISCARD instead of SHF_GNU_RETAIN on Solaris

Wed, 23 Feb 2022 14:43:12 +0000

[MC][ELF] Use SHF_SUNW_NODISCARD instead of SHF_GNU_RETAIN on SolarisAs requested in D107955 , this patchsplits off the `MC` and `CodeGen` parts and adds a testcase.Tested on `sparcv9-sun-solaris2.11`, `amd64-pc-solaris2.11`, and`x86_64-pc-linux-gnu`.Differential Revision: https://reviews.llvm.org/D120318 List of files: /llvm-project-15.0.7/llvm/lib/MC/MCParser/ELFAsmParser.cpp

06943537 - Cleanup MCParser headers

Wed, 09 Feb 2022 19:00:42 +0000

Cleanup MCParser headersAs usual with that header cleanup series, some implicit dependencies now need tobe explicit:llvm/MC/MCParser/MCAsmParser.h no longer includes llvm/MC/MCParser/MCAsmLexer.hPreprocessed lines to build llvm on my setup:after: 1068185081before: 1068324320So no compile time benefit to expect, but we still get the looser couplingbetween files which is great.Discourse thread: https://discourse.llvm.org/t/include-what-you-use-include-cleanupDifferential Revision: https://reviews.llvm.org/D119359 List of files: /llvm-project-15.0.7/llvm/lib/MC/MCParser/ELFAsmParser.cpp

c6bf7136 - [ELFAsmParser] Optimize hasPrefix with StringRef::consume_front

Thu, 30 Dec 2021 08:16:03 +0000

[ELFAsmParser] Optimize hasPrefix with StringRef::consume_front List of files: /llvm-project-15.0.7/llvm/lib/MC/MCParser/ELFAsmParser.cpp

c01c62c7 - [MC][ELF] Fix accepting abbreviated form with Type change

Tue, 30 Nov 2021 14:33:48 +0000

[MC][ELF] Fix accepting abbreviated form with Type changeFollow up to D92052 and D94072, exposed due to D107707Many assemblers to permit that only the first .section contains allthe attributes like '.lds_bss,"w",@nobits' and later section onlyuse the name ('.lds_bss') inheriting those attributes from the firstsection. I turned out that the case that Type changed was missedwhen implementing it - and D107707 make it much more likely to hitthat issue. That's fixed by this commit.Reviewed By: MaskRayDifferential Revision: https://reviews.llvm.org/D114717 List of files: /llvm-project-15.0.7/llvm/lib/MC/MCParser/ELFAsmParser.cpp

d14d7068 - [llvm] Use StringRef::contains (NFC)

Sat, 23 Oct 2021 15:45:27 +0000

[llvm] Use StringRef::contains (NFC) List of files: /llvm-project-15.0.7/llvm/lib/MC/MCParser/ELFAsmParser.cpp

990e8025 - [MC][ELF] Do not error on parsing .debug_* section directive for MIPS

Sun, 08 Aug 2021 05:09:59 +0000

[MC][ELF] Do not error on parsing .debug_* section directive for MIPSMIPS .debug_* sections should have SHT_MIPS_DWARF section type todistinguish among sections contain DWARF and ECOFF debug formats, but inassembly files these sections have SHT_PROGBITS (@progbits) type. Nowassembler shows 'changed section type for ...' error when parsing`.section .debug_*,"",@progbits` directive for MIPS targets.The same problem exists for x86-64 target and this patch extendsworkaround implemented in D76151. The patch adds one more casewhen assembler ignores section types mismatch after `SwitchSection()`call.Differential Revision: https://reviews.llvm.org/D107707 List of files: /llvm-project-15.0.7/llvm/lib/MC/MCParser/ELFAsmParser.cpp

b4a8c0eb - [LTO][MC] Discard non-prevailing defined symbols in module-level assembly

Thu, 18 Mar 2021 22:32:29 +0000

[LTO][MC] Discard non-prevailing defined symbols in module-level assemblyThis is the alternative approach to D96931.In LTO, for each module with inlineasm block, prepend directive ".lto_discard , *" to the beginning of the inlineasm. ".lto_discard" is both a module inlineasm block marker and (optionally) provides a list of symbols to be discarded.In MC while emitting for inlineasm, discard symbol binding & symboldefinitions according to ".lto_disard".Reviewed By: MaskRayDifferential Revision: https://reviews.llvm.org/D98762 List of files: /llvm-project-15.0.7/llvm/lib/MC/MCParser/ELFAsmParser.cpp

d96af2ed - [MC] Support .symver , , remove

Sat, 06 Mar 2021 23:23:02 +0000

[MC] Support .symver *, *, removeAs a resolution to https://sourceware.org/bugzilla/show_bug.cgi?id=25295 , GNU asfrom binutils 2.35 supports the optional third argument for the .symver directive.'remove' for a non-default version is useful:`.symver def_v1, def@v1, remove` => def_v1 is not retained in the symbol table.Previously the user has to strip the original symbol or specify a `local:`version node in a version script to localize the symbol.`.symver def, def@@v1, remove` and `.symver def, def@@@v1, remove` are supportedas well, though they are identical to `.symver def, def@@@v1`.local/hidden are not useful so this patch does not implement them. List of files: /llvm-project-15.0.7/llvm/lib/MC/MCParser/ELFAsmParser.cpp

16af9739 - [MC][ELF] Support for zero flag section groups

Mon, 01 Feb 2021 06:42:35 +0000

[MC][ELF] Support for zero flag section groupsThis change introduces support for zero flag ELF section groups to LLVM.LLVM already supports COMDAT sections, which in ELF are a special typeof ELF section groups. These are generally useful to enable linker GCwhere you want a group of sections to always travel together, that is tobe either retained or discarded as a whole, but without the COMDATsemantics. Other ELF assemblers already support zero flag ELF sectiongroups and this change helps us reach feature parity.Differential Revision: https://reviews.llvm.org/D95851 List of files: /llvm-project-15.0.7/llvm/lib/MC/MCParser/ELFAsmParser.cpp

1477ed84 - [MC] Support SHF_GNU_RETAIN as section flag 'R'

Tue, 02 Feb 2021 17:34:08 +0000

[MC] Support SHF_GNU_RETAIN as section flag 'R'On Linux target triples, GNU as sets EI_OSABI to ELFOSABI_GNU when SHF_GNU_RETAIN is used。On `*-*-freebsd`, it usually sets EI_OSABI to ELFOSABI_FREEBSD.GNU ld respects SHF_GNU_RETAIN only for ELFOSABI_FREEBSD/ELFOSABI_GNU.https://sourceware.org/bugzilla/show_bug.cgi?id=27282MC doesn't set ELFOSABI_GNU for SHF_GNU_RETAIN/STB_GNU_UNIQUE/STT_GNU_IFUNC.MC assembled object files do not have special semantics in GNU ld.Reviewed By: psmithDifferential Revision: https://reviews.llvm.org/D95730 List of files: /llvm-project-15.0.7/llvm/lib/MC/MCParser/ELFAsmParser.cpp

70ea15b8 - [MC][ELF] Fix accepting abbreviated form with sh_flags and sh_entsize

Thu, 28 Jan 2021 14:07:28 +0000

[MC][ELF] Fix accepting abbreviated form with sh_flags and sh_entsizeFollowup to D92052 as I missed an issue as shown via GCC bug https://gcc.gnu.org/PR97827, namely: (e.g.) ".rodata." implies ELF::SHF_ALLOC.Crossref:- D73999 / commit 75af9da755721123e62b45cd0bc0c5e688a9722a added for LLVM 11 a check that sh_flags and sh_entsize (and sh_type) changes are an error, in line with GNU assembler.- D92052 / commit 1deff4009e0ae661b03682901bf6932297ce7ea1 permitted the abbreviated form which many assemblers accept and GCC generates: while the first .section contains the flags and entsize, subsequent sections simply contain the name without repeating entsize or flags.However, the latter patch missed in the check that some flags are automatically set, e.g. '.rodata." implies ELF::SHF_ALLOC.Related https://bugs.llvm.org/show_bug.cgi?id=48201Reviewed By: jhendersonDifferential Revision: https://reviews.llvm.org/D94072 List of files: /llvm-project-15.0.7/llvm/lib/MC/MCParser/ELFAsmParser.cpp

1deff400 - [MC][ELF] Accept abbreviated form with sh_flags and sh_entsize

Fri, 11 Dec 2020 16:43:06 +0000

[MC][ELF] Accept abbreviated form with sh_flags and sh_entsizeD73999 / commit 75af9da755721123e62b45cd0bc0c5e688a9722aadded for LLVM 11 a check that sh_flags and sh_entsize (and sh_type)changes are an error, in line with GNU assembler.However, GNU assembler accepts and GCC generates an abbreviated form:while the first .section contains the flags and entsize, subsequentsections simply contain the name without repeating entsize or flags.Do likewise for better compatibility.See https://bugs.llvm.org/show_bug.cgi?id=48201Reviewed By: jhenderson, MaskRayDifferential Revision: https://reviews.llvm.org/D92052 List of files: /llvm-project-15.0.7/llvm/lib/MC/MCParser/ELFAsmParser.cpp

fac0622a - ELFAsmParser: Remove non-SHF_ALLOC or non-executable sections' line info/address ranges contribution for -g

Tue, 17 Nov 2020 04:02:25 +0000

ELFAsmParser: Remove non-SHF_ALLOC or non-executable sections' line info/address ranges contribution for -gI filed the issue https://sourceware.org/bugzilla/show_bug.cgi?id=26850 ,which was acknowledged and fixed in GNU binutils 2.36This patch adds the similar behavior to MC.Reviewed By: #debug-info, dblaikieDifferential Revision: https://reviews.llvm.org/D91505 List of files: /llvm-project-15.0.7/llvm/lib/MC/MCParser/ELFAsmParser.cpp

395c8bed - [MC] Make MCStreamer aware of AsmParser's StartTokLoc

Mon, 02 Nov 2020 20:32:06 +0000

[MC] Make MCStreamer aware of AsmParser's StartTokLocA SMLoc allows MCStreamer to report location-aware diagnostics, whichwere previously done by adding SMLoc to various methods (e.g. emit*) in an ad-hoc way.Since the file:line is most important, the column is less important andthe start token location suffices in many cases, this patch revertsb7e7131af2dd7bdb03fa42a3bc1b4bc72ab95ce1```// oldsymbol-binding-changed.s:6:8: error: local changed binding to STB_GLOBAL.globl local ^// newsymbol-binding-changed.s:6:1: error: local changed binding to STB_GLOBAL.globl local^```Reviewed By: rnkDifferential Revision: https://reviews.llvm.org/D90511 List of files: /llvm-project-15.0.7/llvm/lib/MC/MCParser/ELFAsmParser.cpp

b7e7131a - [MC] Add SMLoc to MCStreamer::emitSymbolAttribute and report changed binding warnings/errors for ELF

Fri, 30 Oct 2020 02:41:59 +0000

[MC] Add SMLoc to MCStreamer::emitSymbolAttribute and report changed binding warnings/errors for ELF List of files: /llvm-project-15.0.7/llvm/lib/MC/MCParser/ELFAsmParser.cpp

2b0c5d76 - Introduce and use a new section type for the bb_addr_map section.

Thu, 08 Oct 2020 18:12:40 +0000

Introduce and use a new section type for the bb_addr_map section.This patch lets the bb_addr_map (renamed to __llvm_bb_addr_map) section use a special section type (SHT_LLVM_BB_ADDR_MAP) instead of SHT_PROGBITS. This would help parsers, dumpers and other tools to use the sh_type ELF field to identify this section rather than relying on string comparison on the section name.Reviewed By: jhendersonDifferential Revision: https://reviews.llvm.org/D88199 List of files: /llvm-project-15.0.7/llvm/lib/MC/MCParser/ELFAsmParser.cpp