Changes in LLVMExternalProjectUtils.cmake

4e1b8906 - cmake fill `cmake_args` when cross-compiling external project with non-clang compiler

Wed, 01 Jun 2022 18:10:06 +0000

cmake fill `cmake_args` when cross-compiling external project with non-clang compilerThis makes it possible to crosscompile runtimes with cl.exe on Windows.An external project is completely misconfigured otherwise becausecmake_args is set only for native builds or builds crosscompiled withclang.Differential Revision: https://reviews.llvm.org/D122578Reviewed By: beanz, compnerd List of files: /llvm-project-15.0.7/llvm/cmake/modules/LLVMExternalProjectUtils.cmake

a831ce52 - Revert "[runtimes] Detect changes to Tests.cmake"

Thu, 26 May 2022 16:34:18 +0000

Revert "[runtimes] Detect changes to Tests.cmake"This reverts commit ec10ac750a8ad96983d85263323635f3dabe92fd.See https://discourse.llvm.org/t/cmake-regeneration-is-broken/62788.This change caused Ninja's CMake regeneration to depend on the build,which prevented CMake regeneration from functioning properly and causedspurious build failures on incremental builds when a CMake changeoccurred. List of files: /llvm-project-15.0.7/llvm/cmake/modules/LLVMExternalProjectUtils.cmake

ec10ac75 - [runtimes] Detect changes to Tests.cmake

Mon, 14 Mar 2022 21:21:26 +0000

[runtimes] Detect changes to Tests.cmakeThis ensures that Tests.cmake is tracked by Ninja and any changes tothis file from the subbuilds are correctly detected.Differential Revision: https://reviews.llvm.org/D121647 List of files: /llvm-project-15.0.7/llvm/cmake/modules/LLVMExternalProjectUtils.cmake

da85307b - [CMake] Pass CMAKE_C/CXX_COMPILER_LAUNCHER down to cross-compile and runtime build

Mon, 24 Jan 2022 21:42:47 +0000

[CMake] Pass CMAKE_C/CXX_COMPILER_LAUNCHER down to cross-compile and runtime buildSimilar to D59032.Reviewed By: dexonsmithDifferential Revision: https://reviews.llvm.org/D117746 List of files: /llvm-project-15.0.7/llvm/cmake/modules/LLVMExternalProjectUtils.cmake

d4d9de36 - [CMake] Support passing arguments to build tool for external projects

Tue, 14 Dec 2021 14:34:44 +0000

[CMake] Support passing arguments to build tool for external projectsAdd CMake variable LLVM_EXTERNAL_PROJECT_BUILD_TOOL_ARGS to allowarguments to be passed to the native tool used in CMake --buildinvocations for external projects.Can be used to pass extra arguments for enhanced versions of buildtools, e.g. distributed build options.Differential Revision: https://reviews.llvm.org/D115815 List of files: /llvm-project-15.0.7/llvm/cmake/modules/LLVMExternalProjectUtils.cmake

d8936920 - [CMake] Pass through CMAKE_READELF to subbuilds

Sat, 25 Sep 2021 00:56:00 +0000

[CMake] Pass through CMAKE_READELF to subbuildsThis matches handling of other CMake variables.Differential Revision: https://reviews.llvm.org/D110463 List of files: /llvm-project-15.0.7/llvm/cmake/modules/LLVMExternalProjectUtils.cmake

093245ed - [CMake] Pass llvm-readelf to CMake external builds

Thu, 23 Sep 2021 07:48:24 +0000

[CMake] Pass llvm-readelf to CMake external buildsThis matches other LLVM binary tools.Differential Revision: https://reviews.llvm.org/D110313 List of files: /llvm-project-15.0.7/llvm/cmake/modules/LLVMExternalProjectUtils.cmake

10a72896 - [runtimes] Fix crosscompiling after a7cad6680b4087eff8994f1f99ac40c661a6621f (D97451)

Wed, 03 Mar 2021 14:25:25 +0000

[runtimes] Fix crosscompiling after a7cad6680b4087eff8994f1f99ac40c661a6621f (D97451)It moved the logic for CMake target arguments into llvm_ExternalProject_Add().No handling was added for CMAKE_CROSSCOMPILING, which has a separate set of compiler_args.This broke crosscompiling, as now the runtimes builds defaulted to the compiler's default.I've also added passing of CMAKE_ASM_COMPILER, which was missing before although we were passing the triple for it.Reviewed By: zero9178Differential Revision: https://reviews.llvm.org/D97855 List of files: /llvm-project-15.0.7/llvm/cmake/modules/LLVMExternalProjectUtils.cmake

a7cad668 - [PR48898][CMake] Support MinGW Toolchain tool sin llvm_ExternalProject_Add

Tue, 02 Mar 2021 21:44:51 +0000

[PR48898][CMake] Support MinGW Toolchain tool sin llvm_ExternalProject_AddWindows is in the unique position of having two drivers, clang-cl and normal GNU clang, depending on whether a GNU or MSVC target is used. The current implementation with the USE_TOOLCHAIN argument assumes that when CMAKE_SYSTEM_NAME is set to Windows that clang-cl should be used, which is the incorrect choice when targeting a GNU environment.This patch solves this problem by adding an optional TARGET_TRIPLE argument to llvm_ExternalProject_Add, which sets the various CMAKE__COMPILER_TARGET variables. Additionally, if the triple is detected as an MSVC environment, clang-cl and similar MSVC specific tools will be used instead of the GNU tools. List of files: /llvm-project-15.0.7/llvm/cmake/modules/LLVMExternalProjectUtils.cmake

25affb04 - [CMake][AIX] Limit tools in external project build

Thu, 20 Aug 2020 22:24:11 +0000

[CMake][AIX] Limit tools in external project buildThis is a follow on to D85329 which disabled some llvm tools in theruntimes build due to XCOFF64 limitations. This change disables themin other external project builds as well, when no list of tools isspecified in the arguments.Reviewed By: hubert.reinterpretcast, stevewanDifferential Revision: https://reviews.llvm.org/D88310 List of files: /llvm-project-15.0.7/llvm/cmake/modules/LLVMExternalProjectUtils.cmake

c74da051 - [CMake] Make sure _cmake_system_name has a default

Fri, 21 Aug 2020 16:47:12 +0000

[CMake] Make sure _cmake_system_name has a defaultWe currently try to pick it up from the CMake arguments passed to llvm_ExternalProject_Add butif there isn't an explicit option passed, we should reflect CMake's own default behaviourof targeting the host, since we'll make decisions about what tools to use for the build based onthe setting. Otherwise, we'll get different behaviour between configuring an external project withthe default target and configuring with an explicit one targeting the same platform.Reviewed By: stevewan, hubert.reinterpretcastDifferential Revision: https://reviews.llvm.org/D88157 List of files: /llvm-project-15.0.7/llvm/cmake/modules/LLVMExternalProjectUtils.cmake

ee7ee71f - Explicitly specify CMAKE_AR in WinMsvc.cmake

Wed, 23 Sep 2020 23:20:06 +0000

Explicitly specify CMAKE_AR in WinMsvc.cmakeAs of cmake 3.18, cmake changes how it searches for compilers forWindows (seehttps://gitlab.kitware.com/cmake/cmake/-/commit/55196a1440e26917d40e6a7a3eb8d9fb323fa657)and now finds llvm-ar instead of llvm-lib as CMAKE_AR. This explicitlyspecifies CMAKE_AR as llvm-lib so the correct program is found.Reviewed By: smeenaiDifferential Revision: https://reviews.llvm.org/D88176 List of files: /llvm-project-15.0.7/llvm/cmake/modules/LLVMExternalProjectUtils.cmake

2c80e2fe - [runtimes] Use llvm-libtool-darwin for runtimes build

Fri, 21 Aug 2020 20:03:13 +0000

[runtimes] Use llvm-libtool-darwin for runtimes buildIt's full featured now and we can use it for the runtimes build insteadof relying on an external libtool, which means the CMAKE_HOST_APPLErestriction serves no purpose either now. Restrict llvm-lipo to Darwintargets while I'm here, since it's only needed there.Reviewed By: phosekDifferential Revision: https://reviews.llvm.org/D86367 List of files: /llvm-project-15.0.7/llvm/cmake/modules/LLVMExternalProjectUtils.cmake

16f27e1e - [cmake] Don't use ld.lld when targeting Darwin

Fri, 21 Aug 2020 02:50:09 +0000

[cmake] Don't use ld.lld when targeting Darwinld.lld is an ELF linker. We can switch to the new LLD for Mach-O portwhen it's more complete, but for now, assume the user will have setCMAKE_LINKER correctly themselves when targeting Darwin. List of files: /llvm-project-15.0.7/llvm/cmake/modules/LLVMExternalProjectUtils.cmake

835c1f9f - [compiler-rt][CMake] Pass down LLVM_LIT_ARGS in runtime build

Mon, 13 Jul 2020 02:54:20 +0000

[compiler-rt][CMake] Pass down LLVM_LIT_ARGS in runtime buildWe should also pass down the LLVM_LIT_ARGS in runtime build mode,so that the runtime tests can be well controlled as well.We actually passed this down in clang/runtime/CMakeLists.txtBut not for calls from llvm/runtime/CMakeLists.txt.Reviewed By: phosekDifferential Revision: https://reviews.llvm.org/D83565 List of files: /llvm-project-15.0.7/llvm/cmake/modules/LLVMExternalProjectUtils.cmake

7f5fe30a - [cmake] Only set deps for an ExternalProject if the type is executable or library

Tue, 31 Mar 2020 00:22:52 +0000

[cmake] Only set deps for an ExternalProject if the type is executable or librarySummary:cmake fails with an error when attempting to evaluate $where `tgt` is defined via an `add_custom_target` and thus the `TYPE`is `UTILITY`. Requesting a TARGET_FILE only works on an `EXECUTABLE`or one of a few differetnt types of `X_LIBRARY` (e.g. added via`add_library` or `add_executable`). The logic as implemented in cmakeis below: enum TargetType { EXECUTABLE, STATIC_LIBRARY, SHARED_LIBRARY, MODULE_LIBRARY, OBJECT_LIBRARY, UTILITY, GLOBAL_TARGET, INTERFACE_LIBRARY, UNKNOWN_LIBRARY }; if (target->GetType() >= cmStateEnums::OBJECT_LIBRARY && target->GetType() != cmStateEnums::UNKNOWN_LIBRARY) { ::reportError(context, content->GetOriginalExpression(), "Target \"" + name + "\" is not an executable or library."); return nullptr; }This has always been the case back to at least 3.12 (furthest Ichecked) but this is causing a new failure in cmake 3.17 whileevaluating ExternalProjectAdd.Subscribers: mgorny, llvm-commitsTags: #llvmDifferential Revision: https://reviews.llvm.org/D77284 List of files: /llvm-project-15.0.7/llvm/cmake/modules/LLVMExternalProjectUtils.cmake

8a8778f2 - [CMake] Enable the use of -ffile-prefix-map

Wed, 11 Mar 2020 17:59:12 +0000

[CMake] Enable the use of -ffile-prefix-mapThis handles not paths embedded in debug info, but also in sources.Since the use of this flag is controlled by an option, rather thanreplacing the new option, we add a new option.Differential Revision: https://reviews.llvm.org/D76018 List of files: /llvm-project-15.0.7/llvm/cmake/modules/LLVMExternalProjectUtils.cmake

fdfdd275 - [CMake] Use LLVM tools external project build where possible

Thu, 06 Feb 2020 03:37:50 +0000

[CMake] Use LLVM tools external project build where possibleThis reduces the reliance on host tools and makes the build morehermetic. Some of the runtimes already assume that certain tools arealways available, for example libc++ and libc++abi archive mergingrelies on ar to extract files out of the archive, even on Darwin.Differential Revision: https://reviews.llvm.org/D74107 List of files: /llvm-project-15.0.7/llvm/cmake/modules/LLVMExternalProjectUtils.cmake

56b7f595 - [CMake] Set ASM compiler for external projects

Tue, 28 Jan 2020 03:14:32 +0000

[CMake] Set ASM compiler for external projectsThis is necessary on Windows, otherwise CMake fails. It's notconventional on Windows to use cl for assembly (you'd use ml or ml64instead), but CMake has a separate ASM_MASM mode for that, and clang-clworks fine for assembly so we'll use that on Windows for consistency.Differential Revision: https://reviews.llvm.org/D73522 List of files: /llvm-project-15.0.7/llvm/cmake/modules/LLVMExternalProjectUtils.cmake

f5bbe387 - [llvm] Add llvm-lipo dependency to runtimes

Mon, 16 Dec 2019 23:46:02 +0000

[llvm] Add llvm-lipo dependency to runtimesSummary: Currently, llvm-lipo is not specified as a dependency, but it is needed when building Darwin-x86_64 runtimes, so I'm adding it to the dependencies lists.Reviewers: alexshap, beanz, phosek, compnerd, smeenai, mtrent, plotfi, xiaobaiReviewed By: phosek, smeenaiSubscribers: smeenai, mgorny, llvm-commitsTags: #llvmDifferential Revision: https://reviews.llvm.org/D71429 List of files: /llvm-project-15.0.7/llvm/cmake/modules/LLVMExternalProjectUtils.cmake