en Copyright 2015 Java http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/test/Shell/Commands/Inputs/command-disassemble.lldbinit#8b845ac5 Recommit "[lldb] Don't dissasemble large functions by default"This recommits f665e80c023 which was reverted in 1cbd1b8f692d for breakingTestFoundationDisassembly.py. The fix is to use --force in the test to avoidbailing out on large functions.I have also doubled the large function limit to 8000 bytes (~~ 2000 insns), asthe foundation library contains a lot of large-ish functions. The intent of thisfeature is to prevent accidental disassembling of enormous (multi-megabyte)"functions", not to get in people's way.The original commit message follows:If we have a binary without symbol information (and withoutLC_FUNCTION_STARTS, if on a mac), then we have to resort to usingheuristics to determine the function boundaries. However, these don'talways work, and so we can easily end up thinking we have functionswhich are several megabytes in size. Attempting to (accidentally)disassemble these can take a very long time spam the terminal withthousands of lines of disassembly.This patch works around that problem by adding a sanity check to thedisassemble command. If we are about to disassemble a function which islarger than a certain threshold, we will refuse to disassemble such afunction unless the user explicitly specifies the number of instructionsto disassemble, uses start/stop addresses for disassembly, or passes the(new) --force argument.The threshold is currently fairly aggressive (4000 bytes ~~ 1000instructions). If needed, we can increase it, or even make itconfigurable.Differential Revision: https://reviews.llvm.org/D79789 List of files: /llvm-project-15.0.7/lldb/test/Shell/Commands/Inputs/command-disassemble.lldbinit Tue, 12 May 2020 15:14:20 +0000 Pavel Labath <pavel@labath.sk> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/test/Shell/Commands/Inputs/command-disassemble.lldbinit#1cbd1b8f Revert "[lldb] Don't dissasemble large functions by default"This reverts commit f665e80c023ec52557f55d7eeaf34471e4c6fa0d.Reverting because it breaks TestFoundationDisassembly.py List of files: /llvm-project-15.0.7/lldb/test/Shell/Commands/Inputs/command-disassemble.lldbinit Thu, 14 May 2020 21:15:51 +0000 shafik <syaghmour@apple.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/test/Shell/Commands/Inputs/command-disassemble.lldbinit#f665e80c [lldb] Don't dissasemble large functions by defaultSummary:If we have a binary without symbol information (and withoutLC_FUNCTION_STARTS, if on a mac), then we have to resort to usingheuristics to determine the function boundaries. However, these don'talways work, and so we can easily end up thinking we have functionswhich are several megabytes in size. Attempting to (accidentally)disassemble these can take a very long time spam the terminal withthousands of lines of disassembly.This patch works around that problem by adding a sanity check to thedisassemble command. If we are about to disassemble a function which islarger than a certain threshold, we will refuse to disassemble such afunction unless the user explicitly specifies the number of instructionsto disassemble, uses start/stop addresses for disassembly, or passes the(new) --force argument.The threshold is currently fairly aggressive (4000 bytes ~~ 1000instructions). If needed, we can increase it, or even make itconfigurable.Differential Revision: https://reviews.llvm.org/D79789 List of files: /llvm-project-15.0.7/lldb/test/Shell/Commands/Inputs/command-disassemble.lldbinit Tue, 12 May 2020 15:14:20 +0000 Pavel Labath <pavel@labath.sk> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/test/Shell/Commands/Inputs/command-disassemble.lldbinit#573e0776 [lldb] Add detailed tests for the "disassemble" commandWhile we have some tests for this command already, they are very vague.This is not surprising -- it's hard to make strict assertions about theassembly if your input is a c++ source file. This means that the testscan more-or-less only detect when the command breaks completely, and notwhen there is a subtle change in meaning due to e.g. a code refactor --which is something that I am getting ready to do.This tests in this patch create binaries with well known data (via assemblerand yaml2obj). This means that we are able to make precise assertionsabout the text that lldb is supposed to print. As some of the featuresof this command are only available with a real process, I use a minidumpcore file to create a sufficiently realistic process object. List of files: /llvm-project-15.0.7/lldb/test/Shell/Commands/Inputs/command-disassemble.lldbinit Tue, 03 Mar 2020 15:23:00 +0000 Pavel Labath <pavel@labath.sk>