en Copyright 2015 Java http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/test/API/tools/lldb-vscode/breakpoint/Makefile#e796c77b [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints requestSummary:When using source maps for a breakpoint, in order to find the actual source that breakpoint has resolved, weneed to use a query similar to what CommandObjectSource::DumpLinesInSymbolContexts does, which is the logicused by the CLI to display the source line at a given breakpoint. That's necessary because from a breakpointlocation you only have an address, which points to the original source location, not the source mapped one.in the setBreakpoints request handler, we haven't been doing such query and we were returning the originalsource location, which was breaking the UX of VSCode, as many breakpoints were being set but not displayedin the source file next to each line. Besides, clicking the source path of a breakpoint in the breakpointsview in the debug tab was not working for this case, as VSCode was trying to open a non-existent file, thusshowing an error to the user.Ideally, we should do the query mentioned above to find the actual source location to respond to the IDE,however, that query is expensive and users can have an arbitrary number of breakpoints set. As a simpler fix,the request sent by VSCode already contains the full source path, which exists because the user set it fromthe IDE itself, so we can simply reuse it instead of querying from the SB API.I wrote a test for this, and found out that I had to move SetSourceMapFromArguments after RunInitCommands inlldb-vscode.cpp, because an init command used in all tests is `settings clear -all`, which would clear thesource map unless specified after initCommands. And in any case, I think it makes sense to have initCommandsrun before anything the debugger would do.Reviewers: clayborg, kusmour, labath, aadsmSubscribers: lldb-commitsTags: #lldbDifferential Revision: https://reviews.llvm.org/D76968 List of files: /llvm-project-15.0.7/lldb/test/API/tools/lldb-vscode/breakpoint/Makefile Sat, 28 Mar 2020 02:31:14 +0000 Walter Erquinigo <waltermelon@fb.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/test/API/tools/lldb-vscode/breakpoint/Makefile#99451b44 [lldb][test] Remove symlink for API tests.Summary: Moves lldbsuite tests to lldb/test/API.This is a largely mechanical change, moved with the following steps:```rm lldb/test/API/testcasesmkdir -p lldb/test/API/{test_runner/test,tools/lldb-{server,vscode}}mv lldb/packages/Python/lldbsuite/test/test_runner/test lldb/test/API/test_runnerfor d in $(find lldb/packages/Python/lldbsuite/test/* -maxdepth 0 -type d | egrep -v "make|plugins|test_runner|tools"); do mv $d lldb/test/API; donefor d in $(find lldb/packages/Python/lldbsuite/test/tools/lldb-vscode -maxdepth 1 -mindepth 1 | grep -v ".py"); do mv $d lldb/test/API/tools/lldb-vscode; donefor d in $(find lldb/packages/Python/lldbsuite/test/tools/lldb-server -maxdepth 1 -mindepth 1 | egrep -v "gdbremote_testcase.py|lldbgdbserverutils.py|socket_packet_pump.py"); do mv $d lldb/test/API/tools/lldb-server; done```lldb/packages/Python/lldbsuite/__init__.py and lldb/test/API/lit.cfg.py were also updated with the new directory structure.Reviewers: labath, JDevlieghereTags: #lldbDifferential Revision: https://reviews.llvm.org/D71151 List of files: /llvm-project-15.0.7/lldb/test/API/tools/lldb-vscode/breakpoint/Makefile Tue, 11 Feb 2020 18:01:16 +0000 Jordan Rupprecht <rupprecht@google.com>