en Copyright 2015 Java http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/test/API/tools/lldb-server/vCont-threads/TestPartialResume.py#eb43e43b Reland "[lldb] [llgs] Fix multi-resume bugs with nonstop mode"Improve handling of multiple successive continue packets in non-stopmode. More specifically:1. Explicitly send error response (instead of crashing on assertion) if the user attempts to resume the same process twice. Since we do not support thread-level non-stop mode, one needs to always stop the process explicitly before resuming another thread set.2. Actually stop the process if "vCont;t" is delivered to a running process. Similarly, we only support stopping all the running threads simultaneously (via -1) and return an error in any other case.With this patch, running multiple processes simultaneously is stillunsupported. The patch also employs a hack to avoid enabling stdioforwarding on "vCont;t" packet. Both of these issues are addressedby followup patches.Sponsored by: The FreeBSD FoundationDifferential Revision: https://reviews.llvm.org/D128710 List of files: /llvm-project-15.0.7/lldb/test/API/tools/lldb-server/vCont-threads/TestPartialResume.py Tue, 28 Jun 2022 04:00:46 +0000 Michał Górny <mgorny@moritz.systems> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/test/API/tools/lldb-server/vCont-threads/TestPartialResume.py#7a2b09b4 Revert "[lldb] [llgs] Fix multi-resume bugs with nonstop mode"This reverts commit f8605da8758fbae16410e4ed5493a39429fd73ec.This is causing buildbot failures and now I see that I have not updatedthe tests to use "stop" instead of "trap". List of files: /llvm-project-15.0.7/lldb/test/API/tools/lldb-server/vCont-threads/TestPartialResume.py Fri, 15 Jul 2022 11:43:34 +0000 Michał Górny <mgorny@moritz.systems> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/test/API/tools/lldb-server/vCont-threads/TestPartialResume.py#f8605da8 [lldb] [llgs] Fix multi-resume bugs with nonstop modeImprove handling of multiple successive continue packets in non-stopmode. More specifically:1. Explicitly send error response (instead of crashing on assertion) if the user attempts to resume the same process twice. Since we do not support thread-level non-stop mode, one needs to always stop the process explicitly before resuming another thread set.2. Actually stop the process if "vCont;t" is delivered to a running process. Similarly, we only support stopping all the running threads simultaneously (via -1) and return an error in any other case.With this patch, running multiple processes simultaneously is stillunsupported. The patch also employs a hack to avoid enabling stdioforwarding on "vCont;t" packet. Both of these issues are addressedby followup patches.Sponsored by: The FreeBSD FoundationDifferential Revision: https://reviews.llvm.org/D128710 List of files: /llvm-project-15.0.7/lldb/test/API/tools/lldb-server/vCont-threads/TestPartialResume.py Tue, 28 Jun 2022 04:00:46 +0000 Michał Górny <mgorny@moritz.systems> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/test/API/tools/lldb-server/vCont-threads/TestPartialResume.py#9790406a Reland "[lldb] [test] Improve stability of llgs vCont-threads tests"Perform a major refactoring of vCont-threads tests in order to attemptto improve their stability and performance.Split test_vCont_run_subset_of_threads() into smaller test cases,and split the whole suite into two files: one for signal-related tests,the running-subset-of tests.Eliminate output_match checks entirely, as they are fragile tofragmentation of output. Instead, for the initial thread list captureraise an explicit SIGINT from inside the test program, and forthe remaining output let the test program run until exit, and check allthe captured output afterwards.For resume tests, capture the LLDB's thread view before and afterstarting new threads in order to determine the IDs correspondingto subthreads rather than relying on program output for that.Add a mutex for output to guarantee serialization. A barrier is usedto guarantee that all threads start before SIGINT, and an atomic boolis used to delay prints from happening until after SIGINT.Call std::this_thread::yield() to reduce the risk of one of the threadsnot being run.This fixes the test hangs on FreeBSD. Hopefully, it will also fix allthe flakiness on buildbots.Thanks to Pavel Labath for figuring out why the original version did notwork on Debian.Sponsored by: The FreeBSD FoundationDifferential Revision: https://reviews.llvm.org/D129012 List of files: /llvm-project-15.0.7/lldb/test/API/tools/lldb-server/vCont-threads/TestPartialResume.py Fri, 01 Jul 2022 14:46:56 +0000 Michał Górny <mgorny@moritz.systems> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/test/API/tools/lldb-server/vCont-threads/TestPartialResume.py#86e47231 [lldb] [test] Improve stability of llgs vCont-threads testsPerform a major refactoring of vCont-threads tests in order to attemptto improve their stability and performance.Split test_vCont_run_subset_of_threads() into smaller test cases,and split the whole suite into two files: one for signal-related tests,the running-subset-of tests.Eliminate output_match checks entirely, as they are fragile tofragmentation of output. Instead, for the initial thread list captureraise an explicit SIGSTOP from inside the test program, and forthe remaining output let the test program run until exit, and check allthe captured output afterwards.For resume tests, capture the LLDB's thread view before and afterstarting new threads in order to determine the IDs correspondingto subthreads rather than relying on program output for that.Add a mutex for output to guarantee serialization. A barrier is usedto guarantee that all threads start before SIGSTOP, and an atomic boolis used to delay prints from happening until after SIGSTOP.Call std::this_thread::yield() to reduce the risk of one of the threadsnot being run.This fixes the test hangs on FreeBSD. Hopefully, it will also fix allthe flakiness on buildbots.Sponsored by: The FreeBSD FoundationDifferential Revision: https://reviews.llvm.org/D129012 List of files: /llvm-project-15.0.7/lldb/test/API/tools/lldb-server/vCont-threads/TestPartialResume.py Fri, 01 Jul 2022 14:46:56 +0000 Michał Górny <mgorny@moritz.systems>