en Copyright 2015 Java http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp#20048f31 [lldb] use one shared ThreadPool and task groupsAs a preparation for parallelizing loading of symbols (D122975),it is necessary to use just one thread pool to avoid usinga thread pool from inside a task of another thread pool.Differential Revision: https://reviews.llvm.org/D123226 List of files: /llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp Wed, 06 Apr 2022 13:48:22 +0000 Luboš Luňák <l.lunak@centrum.cz> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp#ae869d44 [LLDB] Remove cases of using namespace llvm:: from header fileWe have using namespace llvm::dwarf in dwarf.h header globally. Replacing thatwith a using namespace within lldb_private::dwarf and moving to ausing namespace lldb_private::dwarf in .cpp files and fully qualified namesin the few header files.Differential Revision: https://reviews.llvm.org/D120836 List of files: /llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp Thu, 03 Mar 2022 18:39:06 +0000 Shafik Yaghmour <syaghmour@apple.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp#2d75f627 [lldb] Convert DWARF log to the new APIThis also deletes some dead log statements (log initialization commentedout). List of files: /llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp Thu, 27 Jan 2022 14:10:29 +0000 Pavel Labath <pavel@labath.sk> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp#a2154b19 Cache the manual DWARF index out to the LLDB cache directory when the LLDB index cache is enabled.This patch add the ability to cache the manual DWARF indexing results to disk for faster subsequent debug sessions. Manual DWARF indexing is time consuming and causes all DWARF to be fully parsed and indexed each time you debug a binary that doesn't have an acceptable accelerator table. Acceptable accelerator tables include .debug_names in DWARF5 or Apple accelerator tables.This patch breaks up testing by testing all of the encoding and decoding of required C++ objects in a gtest unit test, and then has a test to verify the debug info cache is generated correctly.This patch also adds the ability to track when a symbol table or DWARF index is loaded or saved to the cache in the "statistics dump" command. This is essential to know in statistics as it can help explain why a debug session was slower or faster than expected.Reviewed By: labath, wallaceDifferential Revision: https://reviews.llvm.org/D115951 List of files: /llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp Tue, 28 Dec 2021 18:49:59 +0000 Greg Clayton <gclayton@fb.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp#2887d9fd Add new key/value pairs to the module statistics for "statistics dump".The new key/value pairs that are added to each module's stats are:"debugInfoByteSize": The size in bytes of debug info for each module."debugInfoIndexTime": The time in seconds that it took to index the debug info."debugInfoParseTime": The time in seconds that debug info had to be parsed.At the top level we add up all of the debug info size, parse time and index time with the following keys:"totalDebugInfoByteSize": The size in bytes of all debug info in all modules."totalDebugInfoIndexTime": The time in seconds that it took to index all debug info if it was indexed for all modules."totalDebugInfoParseTime": The time in seconds that debug info was parsed for all modules.Differential Revision: https://reviews.llvm.org/D112501 List of files: /llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp Tue, 26 Oct 2021 01:03:06 +0000 Greg Clayton <gclayton@fb.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp#f3932b9a [nfc] [lldb] Assertions for D106270 - [DWARF5] Fix offset check when using .debug_namesSkeleton vs. DWO units mismatch has been fixed in D106270. As they bothhave type DWARFUnit it is a bit difficult to debug. So it is better tomake it safe against future changes.Reviewed By: kimanh, clayborgDifferential Revision: https://reviews.llvm.org/D107659 List of files: /llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp Tue, 10 Aug 2021 18:39:40 +0000 Jan Kratochvil <jan.kratochvil@redhat.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp#0dda5425 [DWARF5] Fix offset check when using .debug_namesWhen going through the CU entries in the name index,make sure to compare the name entry's CUoffset against the skeleton CU's offset.Previously there would be a mismatch, since thewrong offset was compared, and thus no suitableentry was found.Reviewed By: jankratochvilDifferential Revision: https://reviews.llvm.org/D106270 List of files: /llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp Mon, 09 Aug 2021 11:14:41 +0000 Kim-Anh Tran <kimanh@chromium.org> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp#e122877f Add a progress class that can track long running operations in LLDB.LLDB can often appear deadlocked to users that use IDEs when it is indexing DWARF, or parsing symbol tables. These long running operations can make a debug session appear to be doing nothing even though a lot of work is going on inside LLDB. This patch adds a public API to allow clients to listen to debugger events that report progress and will allow UI to create an activity window or display that can show users what is going on and keep them informed of expensive operations that are going on inside LLDB.Differential Revision: https://reviews.llvm.org/D97739 List of files: /llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp Mon, 01 Mar 2021 23:26:35 +0000 Greg Clayton <gclayton@fb.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp#5c1c8443 [lldb] Abstract scoped timer logic behind LLDB_SCOPED_TIMER (NFC)This patch introduces a LLDB_SCOPED_TIMER macro to hide the needlesslyrepetitive creation of scoped timers in LLDB. It's similar to theLLDB_LOG(F) macro.Differential revision: https://reviews.llvm.org/D93663 List of files: /llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp Mon, 21 Dec 2020 21:41:57 +0000 Jonas Devlieghere <jonas@devlieghere.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp#68358081 Add optimal thread strategyAdd an optimal thread strategy to execute specified amount of tasks.This strategy should prevent us from creating too many threads if weoccasionaly have an unexpectedly small amount of tasks.Differential Revision: https://reviews.llvm.org/D87765 List of files: /llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp Wed, 23 Sep 2020 16:37:50 +0000 Dmitry Antipov <dmantipov@yandex.ru> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp#e57361c0 [lldb/Host] Remove TaskPool and replace its uses with llvm::ThreadPoolRemove LLDB's TaskPool and replace its uses with LLVM's ThreadPool.Differential revision: https://reviews.llvm.org/D78337 List of files: /llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp Wed, 22 Apr 2020 15:48:31 +0000 Jonas Devlieghere <jonas@devlieghere.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp#d482fe2a [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIEPavel Labath wrote in D73206:The internal representation of DebugNames and Apple indexes is fixed bythe relevant (pseudo-)standards, so we can't really change it. Thequestion is how to efficiently (and cleanly) convert from the internalrepresentation to some common thing. The conversion from AppleIndex toDIERef is trivial (which is not surprising as it was the first and theoverall design was optimized for that). With debug_names, the situationgets more tricky. The internal representation of debug_names usesCU-relative DIE offsets, but DIERef wants an absolute offset. That meansthe index has to do more work to produce the common representation. Andit needs to do that for all results, even though a lot of the indexusers are really interested only in a single entry. With the switch touser_id_t, _all_ indexes would have to do some extra work to encode it,only for their users to have to immediately decode it back. Havinga iterator/callback based api would allow us to minimize the impact ofthat, as it would only need to happen for the entries that are reallyused. And /I think/ we could make it interface returns DWARFDiesdirectly, and each index converts to that using the most direct approachavailable.Jan Kratochvil:It also makes all the callers shorter as they no longer need to fetchDWARFDIE from DIERef (and handling if not found by ReportInvalidDIERef)but the callers are already served DWARFDIE which they need.In some cases the DWARFDIE had to be fetched both by callee (DWARFIndeximplementation) and caller.Differential Revision: https://reviews.llvm.org/D77970 List of files: /llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp Wed, 22 Apr 2020 14:46:29 +0000 Jan Kratochvil <jan.kratochvil@redhat.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp#ce779004 [DWARF] Rename a function and comment it for clarity.Pointed out by Adrian. List of files: /llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp Thu, 16 Apr 2020 22:36:43 +0000 Davide Italiano <ditaliano@apple.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp#5e04b5f2 [nfc] [lldb] Introduce DWARF callbacks (fixed-up)As requested by @labath in https://reviews.llvm.org/D73206#1949516providing DWARF index callbacks refactorization.It is a re-landing of the patch with a regression fix the previouscommit had.Differential Revision: https://reviews.llvm.org/D77327 List of files: /llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp Wed, 15 Apr 2020 21:39:40 +0000 Jan Kratochvil <jan.kratochvil@redhat.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp#9289f343 Revert "[nfc] [lldb] Introduce DWARF callbacks"This reverts commit bd47c470d13b1c57ecf37c1faf0324833d3a4542.It broke Green Dragon, reason is unknown to me so far: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/15323/consoleFullDifferential Revision: https://reviews.llvm.org/D77327 List of files: /llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp Wed, 15 Apr 2020 13:12:59 +0000 Jan Kratochvil <jan.kratochvil@redhat.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp#bd47c470 [nfc] [lldb] Introduce DWARF callbacksAs requested by @labath in https://reviews.llvm.org/D73206#1949516providing DWARF index callbacks refactorization.Differential Revision: https://reviews.llvm.org/D77327 List of files: /llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp Wed, 15 Apr 2020 08:36:31 +0000 Jan Kratochvil <jan.kratochvil@redhat.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp#d51b38f1 [DWARF] Not all the constant variables are "static".Fixes rdar://problem/61402307Differential Revision: https://reviews.llvm.org/D77698 List of files: /llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp Wed, 08 Apr 2020 18:06:00 +0000 Davide Italiano <ditaliano@apple.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp#f30ebf43 [ManualDWARFIndex] Remove dead code, in preparation for moving this function. List of files: /llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp Tue, 07 Apr 2020 23:27:29 +0000 Davide Italiano <ditaliano@apple.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp#80237523 [nfc] [lldb] Unindent code - obvious partIt is an obvious part of D77326.It removes some needless deep indentation and some redundant statements.It prepares the code for a more clean next patch - DWARF index callbacksin D77327. List of files: /llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp Fri, 03 Apr 2020 19:58:11 +0000 Jan Kratochvil <jan.kratochvil@redhat.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp#0f7cfb25 [lldb/DWARF] Don't index dwp file multiple timesSummary:When we added support for type units in dwo files, we changed the"manual" dwarf index to index _all_ dwarf units in the dwo file insteadof just the split unit belonging to our skeleton unit. This was fine fordwo files, as they contain only a single compile units and type units donot have a split type unit which would point to them.However, this does not work for dwp files because, these files docontain multiple split compile units, and the current approach meansthat each unit gets indexed multiple times (once for each split unit =>n^2 complexity).This patch teaches the manual dwarf index to treat dwp files specially.Any type units in the dwp file added to the main list of compile unitsand indexed with them in a single batch. Split compile units in dwpfiles are still indexed as a part of their skeleton unit -- this is donebecause we need the DW_AT_language attribute from the skeleton unit toindex them properly.Handling of dwo files remains unchanged -- all units (type and skeleton)are indexed when we reach the dwo file through the split unit.Reviewers: clayborg, JDevlieghere, aprantlSubscribers: arphaman, lldb-commitsTags: #lldbDifferential Revision: https://reviews.llvm.org/D74964 List of files: /llvm-project-15.0.7/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp Fri, 21 Feb 2020 14:49:12 +0000 Pavel Labath <pavel@labath.sk>