Changes in ProcessGDBRemote.h

12606d16 - Revert "Expose GetAddressingBits() in the Process API."

Wed, 23 Mar 2022 22:27:38 +0000

Revert "Expose GetAddressingBits() in the Process API."This reverts commit 7504dd5e00f514628614db8ee07514c73220e597.In newer review feedback it was pointed out that there is a better API for this in Process::GetCodeAddressMask(). List of files: /llvm-project-15.0.7/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h

7504dd5e - Expose GetAddressingBits() in the Process API.

Wed, 23 Mar 2022 21:06:18 +0000

Expose GetAddressingBits() in the Process API.This is needed by the Swift Plugin.See also https://github.com/apple/llvm-project/pull/4110.Differential Revision: https://reviews.llvm.org/D122347 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h

68099b1d - [lldb] Add a getter for the process' system architecture

Fri, 11 Mar 2022 18:50:10 +0000

[lldb] Add a getter for the process' system architectureThis patch adds a getter for the process' system architecture. I wentwith Process::GetSystemArchitecture to matchPlatform::GetSystemArchitecture.Differential revision: https://reviews.llvm.org/D121443 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h

ed1a83be - [lldb/gdb-remote] Remove ancient debugserver workaround

Wed, 09 Mar 2022 17:19:58 +0000

[lldb/gdb-remote] Remove ancient debugserver workaroundThis workaround is the source of an awkwared Process->Platformdependency. While this could be solved in various ways (the only thingwe really use is the plugin name), it may be better to just remove it --the workaround was added 10 years ago (43c555dfc), and the affecteddebugservers were "old" even then, so hopefully they are not in useanymore.Differential Revision: https://reviews.llvm.org/D121305 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h

12c9c4a8 - [lldb/host] Remove monitor_signals argument from process monitoring functions

Tue, 22 Feb 2022 16:45:35 +0000

[lldb/host] Remove monitor_signals argument from process monitoring functionsAll current callers set the argument to false. monitor_signals=true usedto be used in the Process plugins (which needed to know when thedebugged process gets a signal), but this implementation has severalserious issues, which means that individual process plugins noworchestrate the monitoring of debugged processes themselves.This allows us to simplify the implementation (no need to play withprocess groups), and the interface (we only catch fatal events, so thecallback is always called just once).Differential Revision: https://reviews.llvm.org/D120425 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h

d0810779 - [lldb] Modernize ThreadLauncher

Mon, 21 Feb 2022 10:07:38 +0000

[lldb] Modernize ThreadLauncherAccept a function object instead of a raw pointer. This avoids a bunchof boilerplate typically needed to pass arguments to the threadfunctions.Differential Revision: https://reviews.llvm.org/D120321 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h

2937b282 - Reland "[lldb] Remove non address bits when looking up memory regions"

Wed, 01 Dec 2021 16:14:54 +0000

Reland "[lldb] Remove non address bits when looking up memory regions"This reverts commit 0df522969a7a0128052bd79182c8d58e00556e2f.Additional checks are added to fix the detection of the last memory regionin GetMemoryRegions or repeating the "memory region" command when thetarget has non-address bits.Normally you keep reading from address 0, looking up each region's endaddress until you get LLDB_INVALID_ADDR as the region end address.(0xffffffffffffffff)This is what the remote will return once you go beyond the last mapped region:[0x0000fffffffdf000-0x0001000000000000) rw- [stack][0x0001000000000000-0xffffffffffffffff) ---Problem is that when we "fix" the lookup address, we remove some bitsfrom it. On an AArch64 system we have 48 bit virtual addresses, so whenwe fix the end address of the [stack] region the result is 0.So we loop back to the start.[0x0000fffffffdf000-0x0001000000000000) rw- [stack][0x0000000000000000-0x0000000000400000) ---To fix this I added an additional check for the last range.If the end address of the region is different once you applyFixDataAddress, we are at the last region.Since the end of the last region will be the last valid mappableaddress, plus 1. That 1 will be removed by the ABI plugin.The only side effect is that on systems with non-address bits, youwon't get that last catch all unmapped region from the max virtualaddress up to 0xf...f.[0x0000fffff8000000-0x0000fffffffdf000) ---[0x0000fffffffdf000-0x0001000000000000) rw- [stack]Though in some way this is more correct because that region is notjust unmapped, it's not mappable at all.No extra testing is needed because this is already covered byTestMemoryRegion.py, I simply forgot to run it on system that hadboth top byte ignore and pointer authentication.This change has been tested on a qemu VM with top byte ignore,memory tagging and pointer authentication enabled.Reviewed By: omjavaidDifferential Revision: https://reviews.llvm.org/D115508 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h

a8ae6828 - [lldb] Delete GDBRemoteCommunicationReplayServer

Mon, 03 Jan 2022 15:12:47 +0000

[lldb] Delete GDBRemoteCommunicationReplayServerThis survived the reproducer deletion. List of files: /llvm-project-15.0.7/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h

0df52296 - Revert "Reland "[lldb] Remove non address bits when looking up memory regions""

Fri, 26 Nov 2021 15:16:03 +0000

Revert "Reland "[lldb] Remove non address bits when looking up memory regions""This reverts commit fac3f20de55769d028bd92220e74f22fa57dd4b2.I found this has broken how we detect the last memory region inGetMemoryRegions/"memory region" command.When you're debugging an AArch64 system with pointer authentication,the ABI plugin will remove the top bit from the end address of the lastuser mapped area.(lldb)[0x0000fffffffdf000-0x0001000000000000) rw- [stack]ABI plugin removes anything above the 48th bit (48 bit virtual addressesby default on AArch64, leaving an address of 0.(lldb)[0x0000000000000000-0x0000000000400000) ---You get back a mapping for 0 and get into an infinite loop. List of files: /llvm-project-15.0.7/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h

6f82264d - [lldb/gdb-remote] Remove more non-stop mode remnants

Wed, 24 Nov 2021 08:59:16 +0000

[lldb/gdb-remote] Remove more non-stop mode remnantsThe read thread handling is completely dead code now that non-stop modeno longer exists. List of files: /llvm-project-15.0.7/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h

fac3f20d - Reland "[lldb] Remove non address bits when looking up memory regions"

Wed, 03 Nov 2021 13:32:34 +0000

Reland "[lldb] Remove non address bits when looking up memory regions"This reverts commit 5fbcf677347e38718461496d9e9e184a7a30c3fb.ProcessDebugger is used in ProcessWindows and NativeProcessWindows.I thought I was simplifying things by renaming to DoGetMemoryRegionInfoin ProcessDebugger but the Native process side expects "GetMemoryRegionInfo".Follow the pattern that WriteMemory uses. So:* ProcessWindows::DoGetMemoryRegioninfo calls ProcessDebugger::GetMemoryRegionInfo* NativeProcessWindows::GetMemoryRegionInfo does the same List of files: /llvm-project-15.0.7/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h

5fbcf677 - Revert "[lldb] Remove non address bits when looking up memory regions"

Wed, 03 Nov 2021 13:27:41 +0000

Revert "[lldb] Remove non address bits when looking up memory regions"This reverts commit 6f5ce43b433706c3ae5c37022d6c0964b6bfadf8 due tobuild failure on Windows. List of files: /llvm-project-15.0.7/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h

6f5ce43b - [lldb] Remove non address bits when looking up memory regions

Wed, 03 Nov 2021 10:14:13 +0000

[lldb] Remove non address bits when looking up memory regionsOn AArch64 we have various things using the non address bitsof pointers. This means when you lookup their containing regionyou won't find it if you don't remove them.This changes Process GetMemoryRegionInfo to a non virtual methodthat uses the current ABI plugin to remove those bits. Then itcalls DoGetMemoryRegionInfo.That function does the actual work and is virtual to be overridenby Process implementations.A test case is added that runs on AArch64 Linux using the topbyte ignore feature.Reviewed By: omjavaidDifferential Revision: https://reviews.llvm.org/D102757 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h

5f4980f0 - [lldb] Remove ConstString from Process, ScriptInterpreter and StructuredData plugin names

Fri, 22 Oct 2021 17:53:43 +0000

[lldb] Remove ConstString from Process, ScriptInterpreter and StructuredData plugin names List of files: /llvm-project-15.0.7/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h

a3939e15 - [lldb] Return StringRef from PluginInterface::GetPluginName

Fri, 15 Oct 2021 11:07:39 +0000

[lldb] Return StringRef from PluginInterface::GetPluginNameThere is no reason why this function should be returning a ConstString.While modifying these files, I also fixed several instances whereGetPluginName and GetPluginNameStatic were returning different strings.I am not changing the return type of GetPluginNameStatic in this patch, as thatwould necessitate additional changes, and this patch is big enough as it is.Differential Revision: https://reviews.llvm.org/D111877 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h

58492191 - [lldb] [ABI] Apply AugmentRegisterInfo() to DynamicRegisterInfo::Registers

Tue, 05 Oct 2021 12:58:10 +0000

[lldb] [ABI] Apply AugmentRegisterInfo() to DynamicRegisterInfo::RegistersCall ABI::AugmentRegisterInfo() once with a vector of all definedregisters rather than calling it for every individual register. Moveand rename RemoteRegisterInfo from gdb-remote toDynamicRegisterInfo::Register, and use this class when augmentingregisters.Differential Revision: https://reviews.llvm.org/D111142 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h

202af507 - Recommit: [lldb] Remove "dwarf dynamic register size expressions" from RegisterInfo

Thu, 23 Sep 2021 12:10:49 +0000

Recommit: [lldb] Remove "dwarf dynamic register size expressions" from RegisterInfoThe previous version of the patch did not update the definitions inconditionally compiled code. This patch includes changes to ARC andwindows targets.Original commit message was:These were added to support some mips registers on linux, but linux mipssupport has now been removed due.They are still referenced in the freebds mips implementation, but thecompleteness of that implementation is also unknown. All otherarchitectures just set these fields to zero, which is a cause ofsignificant bloat in our register info definitions.Arm also has registers with variable sizes, but they were implemented ina more gdb-compatible fashion and don't use this feature.Differential Revision: https://reviews.llvm.org/D110914 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h

b2c906da - Revert "[lldb] Remove "dwarf dynamic register size expressions" from RegisterInfo"

Wed, 06 Oct 2021 15:46:26 +0000

Revert "[lldb] Remove "dwarf dynamic register size expressions" from RegisterInfo"This reverts commit 00e704bf080ffeeb9e334fb3ab71594f9aa50969.This commit should should have updatedllvm/llvm-project/lldb/source/Plugins/ABI/ARC/ABISysV_arc.cpp like the otherarchitectures. List of files: /llvm-project-15.0.7/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h

00e704bf - [lldb] Remove "dwarf dynamic register size expressions" from RegisterInfo

Thu, 23 Sep 2021 12:10:49 +0000

[lldb] Remove "dwarf dynamic register size expressions" from RegisterInfoThese were added to support some mips registers on linux, but linux mipssupport has now been removed due.They are still referenced in the freebds mips implementation, but thecompleteness of that implementation is also unknown. All otherarchitectures just set these fields to zero, which is a cause ofsignificant bloat in our register info definitions.Arm also has registers with variable sizes, but they were implemented ina more gdb-compatible fashion and don't use this feature.Differential Revision: https://reviews.llvm.org/D110914 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h

156cb4cc - [lldb] Remove non-stop mode code

Mon, 27 Sep 2021 14:54:00 +0000

[lldb] Remove non-stop mode codeWe added some support for this mode back in 2015, but the feature wasnever productionized. It is completely untested, and there are knownmajor structural lldb issues that need to be resolved before thisfeature can really be supported.It also complicates making further changes to stop reply packethandling, which is what I am about to do.Differential Revision: https://reviews.llvm.org/D110553 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h