Changes in NSError.cpp

459cfa5e - [LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan

Wed, 20 Jul 2022 20:32:53 +0000

[LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scanImprove LLDB reliability by fixing the following "uninitialized variables" static code inspection warnings fromscan.coverity.com:1094796 1095721 1095728 1095737 10957411095756 1095779 1095789 1095805 12145521229457 1232475 1274006 1274010 12934271364800 1364802 1364804 1364812 13648161374902 1374909 1384975 1399312 14204511431704 1454230 1454554 1454615 14545791454594 1454832 1457759 1458696 14619091467658 1487814 1487830 1487845Differential Revision: https://reviews.llvm.org/D130098 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Language/ObjC/NSError.cpp

80a11e08 - [LLDB] Replace use of double underscore in identifiers

Wed, 16 Feb 2022 19:51:50 +0000

[LLDB] Replace use of double underscore in identifiersIdentifiers with __ anywhere are reserved. I picked this up via thebugprone-reserved-identifier clang-tidy check but -Wreserved-identifier willalso flag these uses as well.Differential Revision: https://reviews.llvm.org/D119915 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Language/ObjC/NSError.cpp

594308c7 - [lldb][NFC] Rename TypeSystemClang::GetScratch to ScratchTypeSystemClang::GetForTarget

Fri, 04 Dec 2020 09:26:03 +0000

[lldb][NFC] Rename TypeSystemClang::GetScratch to ScratchTypeSystemClang::GetForTargetAlso add some documentation while I'm at it. List of files: /llvm-project-15.0.7/lldb/source/Plugins/Language/ObjC/NSError.cpp

8be30215 - [lldb] Move clang-based files out of Symbol

Wed, 29 Jan 2020 19:59:28 +0000

[lldb] Move clang-based files out of SymbolSummary:This change represents the move of ClangASTImporter, ClangASTMetadata,ClangExternalASTSourceCallbacks, ClangUtil, CxxModuleHandler, andTypeSystemClang from lldbSource to lldbPluginExpressionParserClang.hThis explicitly removes knowledge of clang internals from lldbSymbol,moving towards a more generic core implementation of lldb.Reviewers: JDevlieghere, davide, aprantl, teemperor, clayborg, labath, jingham, shafikSubscribers: emaste, mgorny, arphaman, jfb, usaxena95, lldb-commitsTags: #lldbDifferential Revision: https://reviews.llvm.org/D73661 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Language/ObjC/NSError.cpp

80814287 - [lldb][NFC] Fix all formatting errors in .cpp file headers

Fri, 24 Jan 2020 07:23:27 +0000

[lldb][NFC] Fix all formatting errors in .cpp file headersSummary:A *.cpp file header in LLDB (and in LLDB) should like this:```//===-- TestUtilities.cpp -------------------------------------------------===//```However in LLDB most of our source files have arbitrary changes to this format andthese changes are spreading through LLDB as folks usually just use the existingsource files as templates for their new files (most notably the unnecessaryeditor language indicator `-*- C++ -*-` is spreading and in every reviewsomeone is pointing out that this is wrong, resulting in people pointing out that thisis done in the same way in other files).This patch removes most of these inconsistencies including the editor language indicators,all the different missing/additional '-' characters, files that center the file name, missingtrailing `===//` (mostly caused by clang-format breaking the line).Reviewers: aprantl, espindola, jfb, shafik, JDevlieghereReviewed By: JDevlieghereSubscribers: dexonsmith, wuzish, emaste, sdardis, nemanjai, kbarton, MaskRay, atanasyan, arphaman, jfb, abidh, jsji, JDevlieghere, usaxena95, lldb-commitsTags: #lldbDifferential Revision: https://reviews.llvm.org/D73258 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Language/ObjC/NSError.cpp

6e3b0cc2 - [lldb][NFC] Rename ClangASTContext to TypeSystemClang

Thu, 23 Jan 2020 09:04:13 +0000

[lldb][NFC] Rename ClangASTContext to TypeSystemClangSummary:This commit renames ClangASTContext to TypeSystemClang to better reflect what this class is actually supposed to do(implement the TypeSystem interface for Clang). It also gets rid of the very confusing situation that we have both a`clang::ASTContext` and a `ClangASTContext` in clang (which sometimes causes Clang people to think I'm fiddlingwith Clang's ASTContext when I'm actually just doing LLDB work).I also have plans to potentially have multiple clang::ASTContext instances associated with one ClangASTContext sothe ASTContext naming will then become even more confusing to people.Reviewers: #lldb, aprantl, shafik, clayborg, labath, JDevlieghere, davide, espindola, jdoerfert, xiaobaiReviewed By: clayborg, labath, xiaobaiSubscribers: wuzish, emaste, nemanjai, mgorny, kbarton, MaskRay, arphaman, jfb, usaxena95, jingham, xiaobai, abidh, JDevlieghere, lldb-commitsTags: #lldbDifferential Revision: https://reviews.llvm.org/D72684 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Language/ObjC/NSError.cpp

3031818a - [Target] Remove Target::GetScratchClangASTContext

Thu, 14 Nov 2019 21:41:52 +0000

[Target] Remove Target::GetScratchClangASTContextTarget doesn't really need to know about ClangASTContext more than anyother TypeSystem. We can create a method ClangASTContext::GetScratch foranything who needs a ClangASTContext specifically instead of just ageneric TypeSystem. List of files: /llvm-project-15.0.7/lldb/source/Plugins/Language/ObjC/NSError.cpp

b5701710 - [LanguageRuntime] Move ObjCLanguageRuntime into a plugin

Mon, 15 Jul 2019 22:56:12 +0000

[LanguageRuntime] Move ObjCLanguageRuntime into a pluginSummary:Following up to my CPPLanguageRuntime change, I'm movingObjCLanguageRuntime into a plugin as well.Reviewers: JDevlieghere, compnerd, jingham, clayborgSubscribers: mgorny, arphaman, lldb-commitsDifferential Revision: https://reviews.llvm.org/D64763llvm-svn: 366148 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Language/ObjC/NSError.cpp

e823bbe8 - [Target] Remove Process::GetObjCLanguageRuntime

Mon, 10 Jun 2019 20:53:23 +0000

[Target] Remove Process::GetObjCLanguageRuntimeSummary:In an effort to make Process more language agnostic, I removedGetCPPLanguageRuntime from Process. I'm following up now with an equivalentchange for ObjC.Differential Revision: https://reviews.llvm.org/D63052llvm-svn: 362981 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Language/ObjC/NSError.cpp

056f6f18 - [LanguageRuntime] Introduce LLVM-style casts

Sat, 08 Jun 2019 18:45:00 +0000

[LanguageRuntime] Introduce LLVM-style castsSummary:Using llvm-style rtti gives us stronger guarantees around castingLanguageRuntimes.As discussed in D62755Differential Revision: https://reviews.llvm.org/D62934llvm-svn: 362884 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Language/ObjC/NSError.cpp

0e4c4821 - Pass ConstString by value (NFC)

Wed, 06 Mar 2019 21:22:25 +0000

Pass ConstString by value (NFC)My apologies for the large patch. With the exception of ConstString.hitself it was entirely produced by sed.ConstString has exactly one const char * data member, so passing aConstString by reference is not any more efficient than copying it byvalue. In both cases a single pointer is passed. But passing it byvalue makes it harder to accidentally return the address of a localobject.(This fixes rdar://problem/48640859 for the Apple folks)Differential Revision: https://reviews.llvm.org/D59030llvm-svn: 355553 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Language/ObjC/NSError.cpp

2946cd70 - Update the file headers across all of the LLVM projects in the monorepo

Sat, 19 Jan 2019 08:50:56 +0000

Update the file headers across all of the LLVM projects in the monorepoto reflect the new license.We understand that people may be surprised that we're moving the headerentirely to discuss the new license. We checked this carefully with theFoundation's lawyer and we believe this is the correct approach.Essentially, all code in the project is now made available by the LLVMproject under our new license, so you will see that the license headersinclude that license only. Some of our contributors have contributedcode under our old license, and accordingly, we have retained a copy ofour old license notice in the top-level files in each project andrepository.llvm-svn: 351636 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Language/ObjC/NSError.cpp

ceff6644 - Remove header grouping comments.

Sun, 11 Nov 2018 23:17:06 +0000

Remove header grouping comments.This patch removes the comments grouping header includes. They wereadded after running IWYU over the LLDB codebase. However they add littlevalue, are often outdates and burdensome to maintain.llvm-svn: 346626 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Language/ObjC/NSError.cpp

05097246 - Reflow paragraphs in comments.

Mon, 30 Apr 2018 16:49:04 +0000

Reflow paragraphs in comments.This is intended as a clean up after the big clang-format commit(r280751), which unfortunately resulted in many of the commentparagraphs in LLDB being very hard to read.FYI, the script I used was:import textwrapimport commandsimport osimport sysimport retmp = "%s.tmp"%sys.argv[1]out = open(tmp, "w+")with open(sys.argv[1], "r") as f: header = "" text = "" comment = re.compile(r'^( *//) ([^ ].*)$') special = re.compile(r'^((([A-Z]+[: ])|([0-9]+ )).*)|(.*;)$') for line in f: match = comment.match(line) if match and not special.match(match.group(2)): # skip intentionally short comments. if not text and len(match.group(2)) < 40: out.write(line) continue if text: text += " " + match.group(2) else: header = match.group(1) text = match.group(2) continue if text: filled = textwrap.wrap(text, width=(78-len(header)), break_long_words=False) for l in filled: out.write(header+" "+l+'\n') text = "" out.write(line)os.rename(tmp, sys.argv[1])Differential Revision: https://reviews.llvm.org/D46144llvm-svn: 331197 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Language/ObjC/NSError.cpp

97206d57 - Rename Error -> Status.

Fri, 12 May 2017 04:51:55 +0000

Rename Error -> Status.This renames the LLDB error class to Status, as discussedon the lldb-dev mailing list.A change of this magnitude cannot easily be done withoutfind and replace, but that has potential to catch unwantedoccurrences of common strings such as "Error". Every effortwas made to find all the obvious things such as the word "Error"appearing in a string, etc, but it's possible there are stillsome lingering occurences left around. Hopefully nothing tooserious.llvm-svn: 302872 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Language/ObjC/NSError.cpp

666cc0b2 - Move DataBuffer / DataExtractor and friends from Core -> Utility.

Sat, 04 Mar 2017 01:30:05 +0000

Move DataBuffer / DataExtractor and friends from Core -> Utility.llvm-svn: 296943 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Language/ObjC/NSError.cpp

01c3243f - Remove dependencies from Utility to Core and Target.

Tue, 14 Feb 2017 19:06:07 +0000

Remove dependencies from Utility to Core and Target.With this patch, the only dependency left is from Utilityto Host. After this is broken, Utility will finally bestandalone.Differential Revision: https://reviews.llvm.org/D29909llvm-svn: 295088 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Language/ObjC/NSError.cpp

bf9a7730 - Move classes from Core -> Utility.

Thu, 02 Feb 2017 21:39:50 +0000

Move classes from Core -> Utility.This moves the following classes from Core -> Utility.ConstStringErrorRegularExpressionStreamStreamStringThe goal here is to get lldbUtility into a state where it hasno dependendencies except on itself and LLVM, so it can be thestarting point at which to start untangling LLDB's dependencies.These are all low level and very widely used classes, andpreviously lldbUtility had dependencies up to lldbCore in orderto use these classes. So moving then down to lldbUtility makessense from both the short term and long term perspective insolving this problem.Differential Revision: https://reviews.llvm.org/D29427llvm-svn: 293941 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Language/ObjC/NSError.cpp

b9c1b51e - *** This commit represents a complete reformatting of the LLDB source code

Tue, 06 Sep 2016 20:57:50 +0000

*** This commit represents a complete reformatting of the LLDB source code*** to conform to clang-format’s LLVM style. This kind of mass change has*** two obvious implications:Firstly, merging this particular commit into a downstream fork may be a hugeeffort. Alternatively, it may be worth merging all changes up to this commit,performing the same reformatting operation locally, and then discarding themerge for this particular commit. The commands used to accomplish thisreformatting were as follows (with current working directory as the root ofthe repository): find . $ -iname "*.c" -or -iname "*.cpp" -or -iname "*.h" -or -iname "*.mm" $ -exec clang-format -i {} + find . -iname "*.py" -exec autopep8 --in-place --aggressive --aggressive {} + ;The version of clang-format used was 3.9.0, and autopep8 was 1.2.4.Secondly, “blame” style tools will generally point to this commit instead ofa meaningful prior commit. There are alternatives available that will attemptto look through this change and find the appropriate prior commit. YMMV.llvm-svn: 280751 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Language/ObjC/NSError.cpp

106aae51 - Because of our lifetime rules w.r.t. ValueObjects and ClusterManagers, synthetic children caching is a tricky area:

Wed, 06 Jul 2016 21:24:28 +0000

Because of our lifetime rules w.r.t. ValueObjects and ClusterManagers, synthetic children caching is a tricky area:- if a synthetic child comes from the same hierarchy as its parent object, then it can't be cached by SharedPointer inside the synthetic provider, or it will cause a reference loop;- but, if a synthetic child is made from whole cloth (e.g. from an expression, a memory region, ...), then it better be cached by SharedPointer, or it will be cleared out and cause an assert() to fail if used at a later pointFor most cases of self-rooted synthetic children, we have a flag we set "IsSyntheticChildrenGenerated", but we were not using it to track caching. So, what ended up happening is each provider would set up its own cache, and if it got it wrong, a hard to diagnose crash would ensueThis patch fixes that by centralizing caching in ValueObjectSynthetic - if a provider returns a self-rooted child (as per the flag), then it gets cached centrally by the ValueObject itselfThis cache is used only for lifetime management and not later retrieval of child values - a different cache handles that (because we might have a mix of self-rooted and properly nested child values for the same parent, we can't trivially use this lifetime cache for retrieval)Fixes rdar://26480007llvm-svn: 274683 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Language/ObjC/NSError.cpp