en Copyright 2015 Java http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp#c34698a8 [lldb] Rename Logging.h to LLDBLog.h and clean up includesMost of our code was including Log.h even though that is not where the"lldb" log channel is defined (Log.h defines the generic logginginfrastructure). This worked because Log.h included Logging.h, eventhough it should.After the recent refactor, it became impossible the two files includeeach other in this direction (the opposite inclusion is needed), so thispatch removes the workaround that was put in place and cleans up allfiles to include the right thing. It also renames the file to LLDBLog tobetter reflect its purpose. List of files: /llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp Thu, 03 Feb 2022 12:26:10 +0000 Pavel Labath <pavel@labath.sk> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp#a007a6d8 [lldb] Convert "LLDB" log channel to the new API List of files: /llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp Mon, 31 Jan 2022 14:57:48 +0000 Pavel Labath <pavel@labath.sk> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp#6fa1b4ff Remove ConstString from DynamicLoader, JITLoader and Instruction plugin names List of files: /llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp Thu, 21 Oct 2021 11:32:42 +0000 Pavel Labath <pavel@labath.sk> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp#a3939e15 [lldb] Return StringRef from PluginInterface::GetPluginNameThere is no reason why this function should be returning a ConstString.While modifying these files, I also fixed several instances whereGetPluginName and GetPluginNameStatic were returning different strings.I am not changing the return type of GetPluginNameStatic in this patch, as thatwould necessitate additional changes, and this patch is big enough as it is.Differential Revision: https://reviews.llvm.org/D111877 List of files: /llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp Fri, 15 Oct 2021 11:07:39 +0000 Pavel Labath <pavel@labath.sk> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp#3d7161e3 [lldb] Remove shared_ptr from some global Properties objectsthey're unnecessary, make the code longer, and their removal actuallyensures proper initialization in multithreaded scenarios. List of files: /llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp Thu, 07 Oct 2021 13:44:47 +0000 Pavel Labath <pavel@labath.sk> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp#b0312676 [lldb] Remove PluginInterface::GetPluginVersionIn all these years, we haven't found a use for this function (it haszero callers). Lets just remove the boilerplate.Differential Revision: https://reviews.llvm.org/D109600 List of files: /llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp Fri, 10 Sep 2021 12:38:27 +0000 Pavel Labath <pavel@labath.sk> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp#57e0cd35 [lldb] Make DoReadMemory a protected method.DoReadMemory is LLDB's internal implementation and shouldn't be calleddirectly.Differential revision: https://reviews.llvm.org/D94284 List of files: /llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp Fri, 08 Jan 2021 04:54:30 +0000 Jonas Devlieghere <jonas@devlieghere.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp#0863f675 [lldb] Remove DataExtractor::GetPointerThis function is equivalent to GetAddress, but getAddress is alsopresent on the llvm version of the data extractor. List of files: /llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp Tue, 18 Feb 2020 09:37:04 +0000 Pavel Labath <pavel@labath.sk> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp#bba9ba8d [lldb/Plugin] s/LLDB_PLUGIN/LLDB_PLUGIN_DEFINE/ (NFC)Rename LLDB_PLUGIN to LLDB_PLUGIN_DEFINE as Pavel suggested in D73067 toavoid name conflict. List of files: /llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp Fri, 14 Feb 2020 17:46:02 +0000 Jonas Devlieghere <jonas@devlieghere.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp#6115bd9b [LLDB] Fix GCC warnings about extra semicolons. NFC. List of files: /llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp Mon, 10 Feb 2020 09:17:48 +0000 Martin Storsjö <martin@martin.st> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp#fbb4d1e4 [lldb/Plugins] Use external functions to (de)initialize pluginsThis is a step towards making the initialize and terminate calls begenerated by CMake, which in turn is towards making it possible todisable plugins at configuration time.Differential revision: https://reviews.llvm.org/D74245 List of files: /llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp Fri, 07 Feb 2020 22:58:18 +0000 Jonas Devlieghere <jonas@devlieghere.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp#80814287 [lldb][NFC] Fix all formatting errors in .cpp file headersSummary:A *.cpp file header in LLDB (and in LLDB) should like this:```//===-- TestUtilities.cpp -------------------------------------------------===//```However in LLDB most of our source files have arbitrary changes to this format andthese changes are spreading through LLDB as folks usually just use the existingsource files as templates for their new files (most notably the unnecessaryeditor language indicator `-*- C++ -*-` is spreading and in every reviewsomeone is pointing out that this is wrong, resulting in people pointing out that thisis done in the same way in other files).This patch removes most of these inconsistencies including the editor language indicators,all the different missing/additional '-' characters, files that center the file name, missingtrailing `===//` (mostly caused by clang-format breaking the line).Reviewers: aprantl, espindola, jfb, shafik, JDevlieghereReviewed By: JDevlieghereSubscribers: dexonsmith, wuzish, emaste, sdardis, nemanjai, kbarton, MaskRay, atanasyan, arphaman, jfb, abidh, jsji, JDevlieghere, usaxena95, lldb-commitsTags: #lldbDifferential Revision: https://reviews.llvm.org/D73258 List of files: /llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp Fri, 24 Jan 2020 07:23:27 +0000 Raphael Isemann <teemperor@gmail.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp#1ad655e2 Modernize the rest of the Find.* API (NFC)This patch removes the size_t return value and the append parameterfrom the remainder of the Find.* functions in LLDB's internal API. Asin the previous patches, this is motivated by the fact that theseparameters aren't really used, and in the case of the append parameterwere frequently implemented incorrectly.Differential Revision: https://reviews.llvm.org/D69119llvm-svn: 375160 List of files: /llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp Thu, 17 Oct 2019 19:56:40 +0000 Adrian Prantl <aprantl@apple.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp#e063eccc Format OptionEnumValueElement (NFC)Reformat OptionEnumValueElement to make it easier to distinguish betweenits fields. This also removes the need to disable clang-format for thesearrays.Differential revision: https://reviews.llvm.org/D65489llvm-svn: 367638 List of files: /llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp Fri, 02 Aug 2019 00:18:44 +0000 Jonas Devlieghere <jonas@devlieghere.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp#e84f7841 Add llvm-style RTTI to ObjectFile hierarchySummary:On the heels of D62934, this patch uses the same approach to introducellvm RTTI support to the ObjectFile hierarchy. It also replaces theexisting uses of GetPluginName doing run-time type checks withllvm::dyn_cast and friends.This formally introduces new dependencies from some other plugins toObjectFile plugins. However, I believe this is fine because:- these dependencies were already kind of there, and the only reason we could get away with not modeling them explicitly was because the code was relying on magically knowing what will GetPluginName() return for a particular kind of object files.- the dependencies themselves are logical (it makes sense for SymbolVendorELF to depend on ObjectFileELF), or at least don't actively get in the way (the JitLoaderGDB->MachO thing).- they don't introduce any new dependency loops as ObjectFile plugins don't depend on any other pluginsReviewers: xiaobai, JDevlieghere, espindolaSubscribers: emaste, mgorny, arichardson, MaskRay, lldb-commitsDifferential Revision: https://reviews.llvm.org/D65450llvm-svn: 367413 List of files: /llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp Wed, 31 Jul 2019 11:57:34 +0000 Pavel Labath <pavel@labath.sk> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp#6a253d37 [lldb] Qualify includes of Properties[Enum].inc files. NFCSummary:This is a bit more explicit, and makes it possible to build LLDB withoutvarying the -I lines per-directory.(The latter is useful because many build systems only allow this to beconfigured per-library, and LLDB is insufficiently layered to be split intomultiple libraries on stricter build systems).(My comment on D65185 has some more context)Reviewers: JDevlieghere, labath, chandlerc, jdoerfertReviewed By: labathSubscribers: mgorny, lldb-commitsTags: #lldbDifferential Revision: https://reviews.llvm.org/D65397Patch by Sam McCall!llvm-svn: 367241 List of files: /llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp Mon, 29 Jul 2019 17:22:10 +0000 Jordan Rupprecht <rupprecht@google.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp#a8ea5955 [lldb] Also include the array definition in Properties.incRight now our Properties.inc only generates the initializer for theoptions list but not the array declaration boilerplate around it. As thearray definition is identical for all arrays, we might as well also letthe Properties.inc generate it alongside the initializers.Unfortunately we cannot do the same for enums, as there's this magicePropertyExperimental, which needs to come at the end to be interpretedcorrectly. Hopefully we can get rid of this in the future and do thesame for the property enums.Differential revision: https://reviews.llvm.org/D65353llvm-svn: 367238 List of files: /llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp Mon, 29 Jul 2019 16:41:30 +0000 Jonas Devlieghere <jonas@devlieghere.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp#971f9ca6 Let tablegen generate property definitionsProperty definitions are currently defined in a PropertyDefinition arrayand have a corresponding enum to index in this array. Unfortunately thisis quite error prone. Indeed, just today we found an incorrect mergewhere a discrepancy between the order of the enum values and theirdefinition caused the test suite to fail spectacularly.Tablegen can streamline the process of generating the propertydefinition table while at the same time guaranteeing that the enums stayin sync. That's exactly what this patch does. It adds a new tablegenfile for the properties, building on top of the infrastructure thatRaphael added recently for the command options. It also introduces twonew tablegen backends: one for the property definitions and one fortheir corresponding enums.It might be worth mentioning that I generated most of the tablegendefinitions from the existing property definitions, by adding a dumpmethod to the struct. This seems both more efficient and less errorprone that copying everything over by hand. Only Enum properties neededmanual fixup for the EnumValues and DefaultEnumValue fields.Differential revision: https://reviews.llvm.org/D65185llvm-svn: 367058 List of files: /llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp Thu, 25 Jul 2019 21:36:37 +0000 Jonas Devlieghere <jonas@devlieghere.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp#63e5fb76 [Logging] Replace Log::Printf with LLDB_LOG macro (NFC)This patch replaces explicit calls to log::Printf with the new LLDB_LOGFmacro. The macro is similar to LLDB_LOG but supports printf-style formatstrings, instead of formatv-style format strings.So instead of writing: if (log) log->Printf("%s\n", str);You'd write: LLDB_LOG(log, "%s\n", str);This change was done mechanically with the command below. I replaced thespurious if-checks with vim, since I know how to do multi-linereplacements with it. find . -type f -name '*.cpp' -exec \ sed -i '' -E 's/log->Printf\(/LLDB_LOGF\(log, /g' "{}" +Differential revision: https://reviews.llvm.org/D65128llvm-svn: 366936 List of files: /llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp Wed, 24 Jul 2019 17:56:10 +0000 Jonas Devlieghere <jonas@devlieghere.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp#efe8e7e3 typedef enum -> enumReviewed By: labathDifferential Revision: https://reviews.llvm.org/D61883llvm-svn: 360654 List of files: /llvm-project-15.0.7/lldb/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp Tue, 14 May 2019 08:55:50 +0000 Fangrui Song <maskray@google.com>