Changes in EmulateInstructionARM64.cpp

f15014ff - Revert "Rename llvm::array_lengthof into llvm::size to match std::size from C++17"

Wed, 26 Jan 2022 15:55:53 +0000

Revert "Rename llvm::array_lengthof into llvm::size to match std::size from C++17"This reverts commit ef8206320769ad31422a803a0d6de6077fd231d2.- It conflicts with the existing llvm::size in STLExtras, which will now never be called.- Calling it without llvm:: breaks C++17 compat List of files: /llvm-project-15.0.7/lldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp

ef820632 - Rename llvm::array_lengthof into llvm::size to match std::size from C++17

Wed, 26 Jan 2022 15:11:12 +0000

Rename llvm::array_lengthof into llvm::size to match std::size from C++17As a conquence move llvm::array_lengthof from STLExtras.h toSTLForwardCompat.h (which is included by STLExtras.h so no buildbreakage expected). List of files: /llvm-project-15.0.7/lldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp

6fa1b4ff - Remove ConstString from DynamicLoader, JITLoader and Instruction plugin names

Thu, 21 Oct 2021 11:32:42 +0000

Remove ConstString from DynamicLoader, JITLoader and Instruction plugin names List of files: /llvm-project-15.0.7/lldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp

a3939e15 - [lldb] Return StringRef from PluginInterface::GetPluginName

Fri, 15 Oct 2021 11:07:39 +0000

[lldb] Return StringRef from PluginInterface::GetPluginNameThere is no reason why this function should be returning a ConstString.While modifying these files, I also fixed several instances whereGetPluginName and GetPluginNameStatic were returning different strings.I am not changing the return type of GetPluginNameStatic in this patch, as thatwould necessitate additional changes, and this patch is big enough as it is.Differential Revision: https://reviews.llvm.org/D111877 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp

202af507 - Recommit: [lldb] Remove "dwarf dynamic register size expressions" from RegisterInfo

Thu, 23 Sep 2021 12:10:49 +0000

Recommit: [lldb] Remove "dwarf dynamic register size expressions" from RegisterInfoThe previous version of the patch did not update the definitions inconditionally compiled code. This patch includes changes to ARC andwindows targets.Original commit message was:These were added to support some mips registers on linux, but linux mipssupport has now been removed due.They are still referenced in the freebds mips implementation, but thecompleteness of that implementation is also unknown. All otherarchitectures just set these fields to zero, which is a cause ofsignificant bloat in our register info definitions.Arm also has registers with variable sizes, but they were implemented ina more gdb-compatible fashion and don't use this feature.Differential Revision: https://reviews.llvm.org/D110914 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp

b2c906da - Revert "[lldb] Remove "dwarf dynamic register size expressions" from RegisterInfo"

Wed, 06 Oct 2021 15:46:26 +0000

Revert "[lldb] Remove "dwarf dynamic register size expressions" from RegisterInfo"This reverts commit 00e704bf080ffeeb9e334fb3ab71594f9aa50969.This commit should should have updatedllvm/llvm-project/lldb/source/Plugins/ABI/ARC/ABISysV_arc.cpp like the otherarchitectures. List of files: /llvm-project-15.0.7/lldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp

00e704bf - [lldb] Remove "dwarf dynamic register size expressions" from RegisterInfo

Thu, 23 Sep 2021 12:10:49 +0000

[lldb] Remove "dwarf dynamic register size expressions" from RegisterInfoThese were added to support some mips registers on linux, but linux mipssupport has now been removed due.They are still referenced in the freebds mips implementation, but thecompleteness of that implementation is also unknown. All otherarchitectures just set these fields to zero, which is a cause ofsignificant bloat in our register info definitions.Arm also has registers with variable sizes, but they were implemented ina more gdb-compatible fashion and don't use this feature.Differential Revision: https://reviews.llvm.org/D110914 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp

1b2d2d70 - [LLDB][NFC] Remove redundant condition

Thu, 25 Jun 2020 14:23:35 +0000

[LLDB][NFC] Remove redundant conditionCondition `auto_advance_pc` is checked both in an outer and in aninner `if` statement in `EmulateInstructionARM::EvaluateInstruction()`,`EmulateInstructionARM64::EvaluateInstruction()` and`EmulateInstructionPPC64::EvaluateInstruction()`. This patch removes theredundant inner check.The issue was found using `clang-tidy` check under review`misc-redundant-condition`. See https://reviews.llvm.org/D81272.Differential Revision: https://reviews.llvm.org/D82558 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp

a0b674fd - Fix UB in EmulateInstructionARM64.cpp

Mon, 01 Jun 2020 21:23:04 +0000

Fix UB in EmulateInstructionARM64.cppThis fixes an unhandled signed integer overflow in AddWithCarry() byusing the llvm::checkedAdd() function. Thats to Vedant Kumar for thesuggestion!Differential Revision: https://reviews.llvm.org/D80955 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp

30ddd4ce - [ARM64] Remove more dead code. NFC.

Fri, 01 May 2020 22:05:42 +0000

[ARM64] Remove more dead code. NFC. List of files: /llvm-project-15.0.7/lldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp

68f8e026 - [ARM64] Remove dead code.

Fri, 01 May 2020 22:04:44 +0000

[ARM64] Remove dead code. List of files: /llvm-project-15.0.7/lldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp

ccad1948 - [lldb/Plugins] Rename initializers to match their plugin name.

Tue, 18 Feb 2020 03:59:03 +0000

[lldb/Plugins] Rename initializers to match their plugin name.Use LLDB_PLUGIN_DEFINE_ADV to make the name of the generated initializermatch the name of the plugin. This is a step towards generating theinitializers with a def file. I'm landing this change in pieces so I cannarrow down what exactly breaks the Windows bot. List of files: /llvm-project-15.0.7/lldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp

50c9cd95 - Revert "[lldb/CMake] Auto-generate the Initialize and Terminate calls for plugin"

Tue, 18 Feb 2020 03:02:25 +0000

Revert "[lldb/CMake] Auto-generate the Initialize and Terminate calls for plugin"This is still failing spectacularly on the Windows bot and I still haveno clue what's going on. List of files: /llvm-project-15.0.7/lldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp

9b12dc98 - Re-land "[lldb/CMake] Auto-generate the Initialize and Terminate calls for plugin"

Mon, 17 Feb 2020 22:03:14 +0000

Re-land "[lldb/CMake] Auto-generate the Initialize and Terminate calls for plugin"This patch changes the way we initialize and terminate the plugins inthe system initializer. It uses an approach similar to LLVM'sTARGETS_TO_BUILD with a def file that enumerates the plugins.The previously landed patch got reverted because it was lacking: (1) A plugin definition for the Objective-C language runtime, (2) The dependency between the Static and WASM dynamic loader, (3) Explicit initialization of ScriptInterpreterNone for lldb-test.All issues have been addressed in this patch.Differential revision: https://reviews.llvm.org/D73067 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp

058cb1b4 - Revert "[lldb/CMake] Auto-generate the Initialize and Terminate calls for plugin"

Mon, 17 Feb 2020 20:32:53 +0000

Revert "[lldb/CMake] Auto-generate the Initialize and Terminate calls for plugin"This temporarily reverts commit 7d6da329dee1eda1761430d9097d1323f32c4c0cbecause it's causing test failures on the bots. List of files: /llvm-project-15.0.7/lldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp

7d6da329 - [lldb/CMake] Auto-generate the Initialize and Terminate calls for plugin

Mon, 17 Feb 2020 17:02:29 +0000

[lldb/CMake] Auto-generate the Initialize and Terminate calls for pluginThis patch changes the way we initialize and terminate the plugins inthe system initializer. It uses an approach similar to LLVM'sTARGETS_TO_BUILD with a def file that enumerates the plugins.Differential revision: https://reviews.llvm.org/D73067 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp

bba9ba8d - [lldb/Plugin] s/LLDB_PLUGIN/LLDB_PLUGIN_DEFINE/ (NFC)

Fri, 14 Feb 2020 17:46:02 +0000

[lldb/Plugin] s/LLDB_PLUGIN/LLDB_PLUGIN_DEFINE/ (NFC)Rename LLDB_PLUGIN to LLDB_PLUGIN_DEFINE as Pavel suggested in D73067 toavoid name conflict. List of files: /llvm-project-15.0.7/lldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp

6115bd9b - [LLDB] Fix GCC warnings about extra semicolons. NFC.

Mon, 10 Feb 2020 09:17:48 +0000

[LLDB] Fix GCC warnings about extra semicolons. NFC. List of files: /llvm-project-15.0.7/lldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp

fbb4d1e4 - [lldb/Plugins] Use external functions to (de)initialize plugins

Fri, 07 Feb 2020 22:58:18 +0000

[lldb/Plugins] Use external functions to (de)initialize pluginsThis is a step towards making the initialize and terminate calls begenerated by CMake, which in turn is towards making it possible todisable plugins at configuration time.Differential revision: https://reviews.llvm.org/D74245 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp

80814287 - [lldb][NFC] Fix all formatting errors in .cpp file headers

Fri, 24 Jan 2020 07:23:27 +0000

[lldb][NFC] Fix all formatting errors in .cpp file headersSummary:A *.cpp file header in LLDB (and in LLDB) should like this:```//===-- TestUtilities.cpp -------------------------------------------------===//```However in LLDB most of our source files have arbitrary changes to this format andthese changes are spreading through LLDB as folks usually just use the existingsource files as templates for their new files (most notably the unnecessaryeditor language indicator `-*- C++ -*-` is spreading and in every reviewsomeone is pointing out that this is wrong, resulting in people pointing out that thisis done in the same way in other files).This patch removes most of these inconsistencies including the editor language indicators,all the different missing/additional '-' characters, files that center the file name, missingtrailing `===//` (mostly caused by clang-format breaking the line).Reviewers: aprantl, espindola, jfb, shafik, JDevlieghereReviewed By: JDevlieghereSubscribers: dexonsmith, wuzish, emaste, sdardis, nemanjai, kbarton, MaskRay, atanasyan, arphaman, jfb, abidh, jsji, JDevlieghere, usaxena95, lldb-commitsTags: #lldbDifferential Revision: https://reviews.llvm.org/D73258 List of files: /llvm-project-15.0.7/lldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp