Changes in PseudoTerminal.cpp

43916252 - [lldb] Fix an unused function warning

Wed, 25 May 2022 16:49:05 +0000

[lldb] Fix an unused function warningThis patch fixes: .../llvm-project/lldb/source/Host/common/PseudoTerminal.cpp:106:20: error: unused function 'use_ptsname' [-Werror,-Wunused-function] List of files: /llvm-project-15.0.7/lldb/source/Host/common/PseudoTerminal.cpp

ea486400 - [lldb] Fix 'ptsname_r' is only available on macOS 10.13.4 or newer

Thu, 19 May 2022 20:07:20 +0000

[lldb] Fix 'ptsname_r' is only available on macOS 10.13.4 or newerA deployment target less than 10.13.4 causes an error saying that'ptsname_r' is only available on macOS 10.13.4 or newer. The currentlogic only checks if the symbol is available and doesn't account for thedeployment target. This patch fixes that by adding an availabilitycheck.Differential revision: https://reviews.llvm.org/D125995 List of files: /llvm-project-15.0.7/lldb/source/Host/common/PseudoTerminal.cpp

fd2433e1 - [lldb] Replace default bodies of special member functions with = default;

Fri, 02 Jul 2021 18:27:37 +0000

[lldb] Replace default bodies of special member functions with = default;Replace default bodies of special member functions with = default;$ run-clang-tidy.py -header-filter='lldb' -checks='-*,modernize-use-equals-default' -fix ,https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-equals-default.htmlDifferential revision: https://reviews.llvm.org/D104041 List of files: /llvm-project-15.0.7/lldb/source/Host/common/PseudoTerminal.cpp

9494c510 - [lldb] Use C++11 default member initializers

Wed, 09 Jun 2021 16:25:29 +0000

[lldb] Use C++11 default member initializersThis converts a default constructor's member initializers into C++11default member initializers. This patch was automatically generated withclang-tidy and the modernize-use-default-member-init check.$ run-clang-tidy.py -header-filter='lldb' -checks='-*,modernize-use-default-member-init' -fixThis is a mass-refactoring patch and this commit will be added to.git-blame-ignore-revs.Differential revision: https://reviews.llvm.org/D103483 List of files: /llvm-project-15.0.7/lldb/source/Host/common/PseudoTerminal.cpp

76e47d48 - [lldb][NFC] Use C++ versions of the deprecated C standard library headers

Wed, 26 May 2021 10:19:37 +0000

[lldb][NFC] Use C++ versions of the deprecated C standard library headersThe C headers are deprecated so as requested in D102845, this is replacing themall with their (not deprecated) C++ equivalent.Reviewed By: shafikDifferential Revision: https://reviews.llvm.org/D103084 List of files: /llvm-project-15.0.7/lldb/source/Host/common/PseudoTerminal.cpp

ba447f38 - [NFC][lldb] Silence unused variable warning

Sun, 01 Nov 2020 14:37:06 +0000

[NFC][lldb] Silence unused variable warning List of files: /llvm-project-15.0.7/lldb/source/Host/common/PseudoTerminal.cpp

e4cc6e9b - [lldb] Modernize PseudoTerminal::Fork

Wed, 14 Oct 2020 14:39:25 +0000

[lldb] Modernize PseudoTerminal::Fork List of files: /llvm-project-15.0.7/lldb/source/Host/common/PseudoTerminal.cpp

daae4a84 - [lldb] Modernize PseudoTerminal::OpenSecondary

Wed, 07 Oct 2020 15:46:50 +0000

[lldb] Modernize PseudoTerminal::OpenSecondary List of files: /llvm-project-15.0.7/lldb/source/Host/common/PseudoTerminal.cpp

6bb123b8 - [lldb] Modernize PseudoTerminal::OpenFirstAvailablePrimary

Wed, 07 Oct 2020 15:35:13 +0000

[lldb] Modernize PseudoTerminal::OpenFirstAvailablePrimaryreplace char*+length combo with llvm::Error List of files: /llvm-project-15.0.7/lldb/source/Host/common/PseudoTerminal.cpp

3dfb9498 - [lldb] Check for and use ptsname_r if available

Fri, 02 Oct 2020 11:38:09 +0000

[lldb] Check for and use ptsname_r if availableptsname is not thread-safe. ptsname_r is available on most (but not all)systems -- use it preferentially.In the patch I also improve the thread-safety of the ptsname fallbackpath by wrapping it in a mutex. This should guarantee the safety of atypical ptsname implementation using a single static buffer, as long asall callers go through this function.I also remove the error arguments, as the only way this function canfail is if the "primary" fd is not valid. This is a programmer error asthis requirement is documented, and all callers ensure that is the case.Differential Revision: https://reviews.llvm.org/D88728 List of files: /llvm-project-15.0.7/lldb/source/Host/common/PseudoTerminal.cpp

64ec505d - [lldb] Rename Master/Slave to Primary/Secondary (NFC)

Mon, 15 Jun 2020 22:36:14 +0000

[lldb] Rename Master/Slave to Primary/Secondary (NFC) List of files: /llvm-project-15.0.7/lldb/source/Host/common/PseudoTerminal.cpp

80814287 - [lldb][NFC] Fix all formatting errors in .cpp file headers

Fri, 24 Jan 2020 07:23:27 +0000

[lldb][NFC] Fix all formatting errors in .cpp file headersSummary:A *.cpp file header in LLDB (and in LLDB) should like this:```//===-- TestUtilities.cpp -------------------------------------------------===//```However in LLDB most of our source files have arbitrary changes to this format andthese changes are spreading through LLDB as folks usually just use the existingsource files as templates for their new files (most notably the unnecessaryeditor language indicator `-*- C++ -*-` is spreading and in every reviewsomeone is pointing out that this is wrong, resulting in people pointing out that thisis done in the same way in other files).This patch removes most of these inconsistencies including the editor language indicators,all the different missing/additional '-' characters, files that center the file name, missingtrailing `===//` (mostly caused by clang-format breaking the line).Reviewers: aprantl, espindola, jfb, shafik, JDevlieghereReviewed By: JDevlieghereSubscribers: dexonsmith, wuzish, emaste, sdardis, nemanjai, kbarton, MaskRay, atanasyan, arphaman, jfb, abidh, jsji, JDevlieghere, usaxena95, lldb-commitsTags: #lldbDifferential Revision: https://reviews.llvm.org/D73258 List of files: /llvm-project-15.0.7/lldb/source/Host/common/PseudoTerminal.cpp

3011d55f - [lldb/Host] Use cmakedefine01 for LLDB_ENABLE_POSIX

Thu, 12 Dec 2019 18:00:45 +0000

[lldb/Host] Use cmakedefine01 for LLDB_ENABLE_POSIXRename LLDB_DISABLE_POSIX to LLDB_ENABLE_POSIX and use cmakedefine01 forconsistency. List of files: /llvm-project-15.0.7/lldb/source/Host/common/PseudoTerminal.cpp

8b3af63b - [NFC] Remove ASCII lines from comments

Wed, 10 Apr 2019 20:48:55 +0000

[NFC] Remove ASCII lines from commentsA lot of comments in LLDB are surrounded by an ASCII line to delimit thebegging and end of the comment.Its use is not really consistent across the code base, sometimes thelines are longer, sometimes they are shorter and sometimes they areomitted. Furthermore, it looks kind of weird with the 80 column limit,where the comment actually extends past the line, but not by much.Furthermore, when /// is used for Doxygen comments, it looksparticularly odd. And when // is used, it incorrectly gives theimpression that it's actually a Doxygen comment.I assume these lines were added to improve distinguishing betweencomments and code. However, given that todays editors and IDEs do agreat job at highlighting comments, I think it's worth to drop this forthe sake of consistency. The alternative is fixing all theinconsistencies, which would create a lot more churn.Differential revision: https://reviews.llvm.org/D60508llvm-svn: 358135 List of files: /llvm-project-15.0.7/lldb/source/Host/common/PseudoTerminal.cpp

2819136f - [lldb] Add missing EINTR handling

Thu, 21 Mar 2019 19:35:55 +0000

[lldb] Add missing EINTR handlingDifferential Revision: https://reviews.llvm.org/D59606llvm-svn: 356703 List of files: /llvm-project-15.0.7/lldb/source/Host/common/PseudoTerminal.cpp

2946cd70 - Update the file headers across all of the LLVM projects in the monorepo

Sat, 19 Jan 2019 08:50:56 +0000

Update the file headers across all of the LLVM projects in the monorepoto reflect the new license.We understand that people may be surprised that we're moving the headerentirely to discuss the new license. We checked this carefully with theFoundation's lawyer and we believe this is the correct approach.Essentially, all code in the project is now made available by the LLVMproject under our new license, so you will see that the license headersinclude that license only. Some of our contributors have contributedcode under our old license, and accordingly, we have retained a copy ofour old license notice in the top-level files in each project andrepository.llvm-svn: 351636 List of files: /llvm-project-15.0.7/lldb/source/Host/common/PseudoTerminal.cpp

26e97995 - [PseudoTerminal][NFC] Use llvm errno helpers

Mon, 03 Sep 2018 14:59:57 +0000

[PseudoTerminal][NFC] Use llvm errno helpersSummary:LLVM provide (str)errno helpers, so convert code to use it.Also fixes warning:/home/xbolva00/LLVM/llvm/tools/lldb/source/Host/common/PseudoTerminal.cpp:248:25: warning: ignoring return value of ‘char* strerror_r(int, char*, size_t)’, declared with attribute warn_unused_result [-Wunused-result] ::strerror_r(errno, error_str, error_len);Reviewers: JDevlieghereReviewed By: JDevlieghereSubscribers: abidh, lldb-commitsDifferential Revision: https://reviews.llvm.org/D51591llvm-svn: 341320 List of files: /llvm-project-15.0.7/lldb/source/Host/common/PseudoTerminal.cpp

05097246 - Reflow paragraphs in comments.

Mon, 30 Apr 2018 16:49:04 +0000

Reflow paragraphs in comments.This is intended as a clean up after the big clang-format commit(r280751), which unfortunately resulted in many of the commentparagraphs in LLDB being very hard to read.FYI, the script I used was:import textwrapimport commandsimport osimport sysimport retmp = "%s.tmp"%sys.argv[1]out = open(tmp, "w+")with open(sys.argv[1], "r") as f: header = "" text = "" comment = re.compile(r'^( *//) ([^ ].*)$') special = re.compile(r'^((([A-Z]+[: ])|([0-9]+ )).*)|(.*;)$') for line in f: match = comment.match(line) if match and not special.match(match.group(2)): # skip intentionally short comments. if not text and len(match.group(2)) < 40: out.write(line) continue if text: text += " " + match.group(2) else: header = match.group(1) text = match.group(2) continue if text: filled = textwrap.wrap(text, width=(78-len(header)), break_long_words=False) for l in filled: out.write(header+" "+l+'\n') text = "" out.write(line)os.rename(tmp, sys.argv[1])Differential Revision: https://reviews.llvm.org/D46144llvm-svn: 331197 List of files: /llvm-project-15.0.7/lldb/source/Host/common/PseudoTerminal.cpp

07d6f881 - Move PseudoTerminal to the lldb_private namespace

Mon, 11 Dec 2017 10:09:14 +0000

Move PseudoTerminal to the lldb_private namespacelldb_utility doesn't make sense, as it is no longer even living in the"utility" module.llvm-svn: 320346 List of files: /llvm-project-15.0.7/lldb/source/Host/common/PseudoTerminal.cpp

24ae6294 - Finish breaking the dependency from Utility.

Thu, 16 Feb 2017 19:38:21 +0000

Finish breaking the dependency from Utility.Differential Revision: https://reviews.llvm.org/D29964llvm-svn: 295368 List of files: /llvm-project-15.0.7/lldb/source/Host/common/PseudoTerminal.cpp