en Copyright 2015 Java http://172.16.0.5:8080/history/llvm-project-15.0.7/lld/test/COFF/invalid-obj.test#45b8a741 [LLD][COFF] When using LLD-as-a-library, always prevent re-entrance on failuresThis is a follow-up for D70378 (Cover usage of LLD as a library).While debugging an intermittent failure on a bot, I recalled this scenario whichcauses the issue:1.When executing lld/test/ELF/invalid/symtab-sh-info.s L45, we reach lld::elf::Obj-File::ObjFile() which goes straight into its base ELFFileBase(), then ELFFileBase::init().2.At that point fatal() is thrown in lld/ELF/InputFiles.cpp L381, leaving a half-initialized ObjFile instance.3.We then end up in lld::exitLld() and since we are running with LLD_IN_TEST, we hapily restore the control flow to CrashRecoveryContext::RunSafely() then back in lld::safeLldMain().4.Before this patch, we called errorHandler().reset() just after, and this attempted to reset the associated SpecificAlloc<ObjFile<ELF64LE>>. That tried to free the half-initialized ObjFile instance, and more precisely its ObjFile::dwarf member.Sometimes that worked, sometimes it failed and was catched by theCrashRecoveryContext. This scenario was the reason we callederrorHandler().reset() through a CrashRecoveryContext.But in some rare cases, the above repro somehow corrupted the heap, creating astack overflow. When the CrashRecoveryContext's filter (that is,__except (ExceptionFilter(GetExceptionInformation()))) tried to handle theexception, it crashed again since the stack was exhausted -- and that took thewhole application down. That is the issue seen on the bot. Locally it happensabout 1 times out of 15.Now this situation can happen anywhere in LLD. Since catching stack overflows isnot a reliable scenario ATM when using CrashRecoveryContext, we're nowpreventing further re-entrance when such failures occur, by signalinglld::SafeReturn::canRunAgain=false. When running with LLD_IN_TEST=2 (or above),only one iteration will be executed, instead of two.Differential Revision: https://reviews.llvm.org/D88348 List of files: /llvm-project-15.0.7/lld/test/COFF/invalid-obj.test Thu, 12 Nov 2020 13:14:20 +0000 Alexandre Ganea <alexandre.ganea@ubisoft.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/lld/test/COFF/invalid-obj.test#b587ca93 [test] Replace `yaml2obj >` with `yaml2obj -o` and remove unneeded input redirection List of files: /llvm-project-15.0.7/lld/test/COFF/invalid-obj.test Thu, 20 Aug 2020 22:00:25 +0000 Fangrui Song <maskray@google.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/lld/test/COFF/invalid-obj.test#ca5170e3 [yaml2obj] Updating LLD tests to account for LLVM r273915This removed the -format flag from yaml2obj in favor of YAML tags.llvm-svn: 273920 List of files: /llvm-project-15.0.7/lld/test/COFF/invalid-obj.test Mon, 27 Jun 2016 20:17:08 +0000 Chris Bieneman <beanz@apple.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/lld/test/COFF/invalid-obj.test#8e186df2 COFF: Corrected error message if a section failed to load.There is no sense to use Name in these lines as it is not initialized yet.Patch from Igor Kudrin!llvm-svn: 247531 List of files: /llvm-project-15.0.7/lld/test/COFF/invalid-obj.test Sun, 13 Sep 2015 20:22:22 +0000 Rui Ueyama <ruiu@google.com>