Changes in visit.pass.cpp

cb71d77c - [libcxx][test] Add missing includes and suppress warnings

Wed, 29 Dec 2021 22:06:25 +0000

[libcxx][test] Add missing includes and suppress warnings... from testing with MSVC's STL. Mostly truncation warnings and variables that are only used in `LIBCPP_ASSERT`.Differential Revision: https://reviews.llvm.org/D116878 List of files: /llvm-project-15.0.7/libcxx/test/std/utilities/variant/variant.visit/visit.pass.cpp

d4b59a05 - [libc++] Remove "// -- C++ --" comments from all .cpp files. NFCI.

Thu, 30 Sep 2021 19:43:38 +0000

[libc++] Remove "// -*- C++ -*-" comments from all .cpp files. NFCI.Even if these comments have a benefit in .h files (for editors thatcare about language but can't be configured to treat .h as C++ code),they certainly have no benefit for files with the .cpp extension.Discussed in D110794. List of files: /llvm-project-15.0.7/libcxx/test/std/utilities/variant/variant.visit/visit.pass.cpp

c360553c - [runtimes] Simplify how we specify XFAIL & friends based on the triple

Fri, 18 Jun 2021 17:33:14 +0000

[runtimes] Simplify how we specify XFAIL & friends based on the tripleNow that Lit supports regular expressions inside XFAIL & friends, it ismuch easier to write Lit annotations based on the triple.Differential Revision: https://reviews.llvm.org/D104747 List of files: /llvm-project-15.0.7/libcxx/test/std/utilities/variant/variant.visit/visit.pass.cpp

74d096e5 - [libc++] Move handling of the target triple to the DSL

Fri, 07 May 2021 14:15:36 +0000

[libc++] Move handling of the target triple to the DSLThis fixes a long standing issue where the triple is not always setconsistently in all configurations. This change also moves theback-deployment Lit features to using the proper target tripleinstead of using something ad-hoc.This will be necessary for using from scratch Lit configuration filesin both normal testing and back-deployment testing.Differential Revision: https://reviews.llvm.org/D102012 List of files: /llvm-project-15.0.7/libcxx/test/std/utilities/variant/variant.visit/visit.pass.cpp

0324b46c - [libc++] [C++2b] [P2162] Allow inheritance from std::variant.

Thu, 25 Mar 2021 17:09:11 +0000

[libc++] [C++2b] [P2162] Allow inheritance from std::variant.This patch changes the variant even in pre-C++2b.It should not break anything, only allow use cases that didn't work previously.Notes: `__as_variant` is used in `__visitation::__variant::__visit_alt`, but I haven't used it in `__visitation::__variant::__visit_alt_at`.That's because it is used only in `__visit_value_at`, which in turn is always used on variant specializations (that's in comparison operators).* https://wg21.link/P2162Reviewed By: ldionne, #libc, QuuxplusoneDifferential Revision: https://reviews.llvm.org/D97394 List of files: /llvm-project-15.0.7/libcxx/test/std/utilities/variant/variant.visit/visit.pass.cpp

3c62198c - [libc++] NFC: Normalize links to bug reports

Wed, 03 Mar 2021 18:45:06 +0000

[libc++] NFC: Normalize links to bug reports List of files: /llvm-project-15.0.7/libcxx/test/std/utilities/variant/variant.visit/visit.pass.cpp

51faba35 - [libc++] Implement P0655R1 visit: Explicit Return Type for visit

Mon, 25 Jan 2021 16:12:25 +0000

[libc++] Implement P0655R1 visit: Explicit Return Type for visitDifferential Revision: https://reviews.llvm.org/D92044 List of files: /llvm-project-15.0.7/libcxx/test/std/utilities/variant/variant.visit/visit.pass.cpp

e0ec7a02 - [libcxx/variant] Correctly propagate return type of the visitor.

Mon, 17 Aug 2020 17:53:59 +0000

[libcxx/variant] Correctly propagate return type of the visitor.The tests for it were missing so I've added them.Reviewed By: #libc, EricWFDifferential Revision: https://reviews.llvm.org/D86006 List of files: /llvm-project-15.0.7/libcxx/test/std/utilities/variant/variant.visit/visit.pass.cpp

a175a965 - [libcxx/variant] Introduce `switch`-based mechanism for `std::visit`.

Tue, 11 Aug 2020 22:52:49 +0000

[libcxx/variant] Introduce `switch`-based mechanism for `std::visit`.This patch introduces mechanism for `std::visit` backed by `switch`.The `switch` is structured such that it's a flattened manual vtable (an n-ary array).The `switch` mechanism is enabled if `(1 * ... * vs.size()) < 1024`.The following are performance numbers from the benchmarks added in D85419, tested on my 2017 Macbook Pro.```$ ./projects/libcxx/benchmarks/variant_visit_1.libcxx.out2020-08-09 23:55:14Running ./projects/libcxx/benchmarks/variant_visit_1.libcxx.outRun on (8 X 3100 MHz CPU s)CPU Caches: L1 Data 32K (x4) L1 Instruction 32K (x4) L2 Unified 262K (x4) L3 Unified 8388K (x1)Load Average: 2.03, 2.36, 2.43------------------------------------------------------------Benchmark Time CPU Iterations------------------------------------------------------------BM_Visit<1, 1> 0.260 ns 0.260 ns 1000000000BM_Visit<1, 2> 1.56 ns 1.56 ns 435925220BM_Visit<1, 3> 1.55 ns 1.55 ns 444416228BM_Visit<1, 4> 1.57 ns 1.57 ns 427951336BM_Visit<1, 5> 1.57 ns 1.56 ns 444766371BM_Visit<1, 6> 1.70 ns 1.68 ns 446639358BM_Visit<1, 7> 1.64 ns 1.64 ns 400441630BM_Visit<1, 8> 1.56 ns 1.56 ns 430729471BM_Visit<1, 9> 1.58 ns 1.58 ns 449894596BM_Visit<1, 10> 1.54 ns 1.54 ns 449660506BM_Visit<1, 20> 1.56 ns 1.56 ns 450813074BM_Visit<1, 30> 1.59 ns 1.59 ns 440032940BM_Visit<1, 40> 1.59 ns 1.59 ns 443731656BM_Visit<1, 50> 1.56 ns 1.56 ns 444709859BM_Visit<1, 60> 1.59 ns 1.58 ns 439527320BM_Visit<1, 70> 1.57 ns 1.57 ns 438450890BM_Visit<1, 80> 1.58 ns 1.58 ns 443001525BM_Visit<1, 90> 1.63 ns 1.62 ns 448456349BM_Visit<1, 100> 1.57 ns 1.57 ns 445740630$ ./projects/libcxx/benchmarks/variant_visit_2.libcxx.out2020-08-09 23:59:35Running ./projects/libcxx/benchmarks/variant_visit_2.libcxx.outRun on (8 X 3100 MHz CPU s)CPU Caches: L1 Data 32K (x4) L1 Instruction 32K (x4) L2 Unified 262K (x4) L3 Unified 8388K (x1)Load Average: 1.40, 1.94, 2.22-----------------------------------------------------------Benchmark Time CPU Iterations-----------------------------------------------------------BM_Visit<2, 1> 0.261 ns 0.260 ns 1000000000BM_Visit<2, 2> 1.55 ns 1.54 ns 432844219BM_Visit<2, 3> 1.30 ns 1.30 ns 532529974BM_Visit<2, 4> 1.54 ns 1.54 ns 446055910BM_Visit<2, 5> 1.31 ns 1.31 ns 531099680BM_Visit<2, 6> 1.56 ns 1.56 ns 443203475BM_Visit<2, 7> 1.29 ns 1.29 ns 526478087BM_Visit<2, 8> 1.56 ns 1.56 ns 439000834BM_Visit<2, 9> 1.30 ns 1.30 ns 528756817BM_Visit<2, 10> 1.56 ns 1.55 ns 442923039BM_Visit<2, 20> 1.35 ns 1.35 ns 517021072BM_Visit<2, 30> 1.60 ns 1.59 ns 419724661BM_Visit<2, 40> 1.45 ns 1.44 ns 472137163BM_Visit<2, 50> 1.65 ns 1.65 ns 421389743$ ./projects/libcxx/benchmarks/variant_visit_3.libcxx.out2020-08-10 00:01:32Running ./projects/libcxx/benchmarks/variant_visit_3.libcxx.outRun on (8 X 3100 MHz CPU s)CPU Caches: L1 Data 32K (x4) L1 Instruction 32K (x4) L2 Unified 262K (x4) L3 Unified 8388K (x1)Load Average: 2.20, 2.01, 2.21-----------------------------------------------------------Benchmark Time CPU Iterations-----------------------------------------------------------BM_Visit<3, 1> 0.272 ns 0.271 ns 1000000000BM_Visit<3, 2> 1.87 ns 1.86 ns 361858090BM_Visit<3, 3> 1.77 ns 1.77 ns 391192579BM_Visit<3, 4> 1.84 ns 1.84 ns 374694223BM_Visit<3, 5> 1.75 ns 1.75 ns 408270392BM_Visit<3, 6> 1.88 ns 1.88 ns 378759185BM_Visit<3, 7> 1.79 ns 1.79 ns 395498102BM_Visit<3, 8> 1.85 ns 1.85 ns 371660366BM_Visit<3, 9> 1.80 ns 1.80 ns 386872851BM_Visit<3, 10> 1.84 ns 1.84 ns 362367606BM_Visit<3, 15> 1.77 ns 1.77 ns 392060220BM_Visit<3, 20> 1.85 ns 1.85 ns 379157188``````$ ./projects/libcxx/benchmarks/variant_visit_1.libcxx.out2020-08-10 00:05:57Running ./projects/libcxx/benchmarks/variant_visit_1.libcxx.outRun on (8 X 3100 MHz CPU s)CPU Caches: L1 Data 32K (x4) L1 Instruction 32K (x4) L2 Unified 262K (x4) L3 Unified 8388K (x1)Load Average: 2.27, 2.36, 2.34------------------------------------------------------------Benchmark Time CPU Iterations------------------------------------------------------------BM_Visit<1, 1> 0.271 ns 0.271 ns 1000000000BM_Visit<1, 2> 0.269 ns 0.269 ns 1000000000BM_Visit<1, 3> 0.271 ns 0.271 ns 1000000000BM_Visit<1, 4> 0.270 ns 0.270 ns 1000000000BM_Visit<1, 5> 0.269 ns 0.269 ns 1000000000BM_Visit<1, 6> 0.270 ns 0.269 ns 1000000000BM_Visit<1, 7> 0.265 ns 0.265 ns 1000000000BM_Visit<1, 8> 0.269 ns 0.269 ns 1000000000BM_Visit<1, 9> 0.268 ns 0.268 ns 1000000000BM_Visit<1, 10> 0.269 ns 0.269 ns 1000000000BM_Visit<1, 20> 0.267 ns 0.267 ns 1000000000BM_Visit<1, 30> 0.272 ns 0.272 ns 1000000000BM_Visit<1, 40> 0.268 ns 0.268 ns 1000000000BM_Visit<1, 50> 0.268 ns 0.268 ns 1000000000BM_Visit<1, 60> 0.268 ns 0.268 ns 1000000000BM_Visit<1, 70> 0.269 ns 0.269 ns 1000000000BM_Visit<1, 80> 0.266 ns 0.266 ns 1000000000BM_Visit<1, 90> 0.268 ns 0.268 ns 1000000000BM_Visit<1, 100> 0.267 ns 0.267 ns 1000000000$ ./projects/libcxx/benchmarks/variant_visit_2.libcxx.out2020-08-12 04:09:59Running ./projects/libcxx/benchmarks/variant_visit_2.libcxx.outRun on (8 X 3100 MHz CPU s)CPU Caches: L1 Data 32K (x4) L1 Instruction 32K (x4) L2 Unified 262K (x4) L3 Unified 8388K (x1)Load Average: 2.17, 4.20, 4.78-----------------------------------------------------------Benchmark Time CPU Iterations-----------------------------------------------------------BM_Visit<2, 1> 0.302 ns 0.301 ns 1000000000BM_Visit<2, 2> 0.297 ns 0.295 ns 1000000000BM_Visit<2, 3> 0.353 ns 0.351 ns 1000000000BM_Visit<2, 4> 0.276 ns 0.276 ns 1000000000BM_Visit<2, 5> 0.285 ns 0.283 ns 1000000000BM_Visit<2, 6> 0.290 ns 0.287 ns 1000000000BM_Visit<2, 7> 0.282 ns 0.280 ns 1000000000BM_Visit<2, 8> 0.290 ns 0.287 ns 1000000000BM_Visit<2, 9> 0.291 ns 0.285 ns 1000000000BM_Visit<2, 10> 0.293 ns 0.287 ns 1000000000BM_Visit<2, 20> 1.70 ns 1.68 ns 391400375BM_Visit<2, 30> 1.64 ns 1.63 ns 418925874BM_Visit<2, 40> 1.63 ns 1.62 ns 423623677BM_Visit<2, 50> 1.68 ns 1.67 ns 411687212$ ./projects/libcxx/benchmarks/variant_visit_3.libcxx.out2020-08-12 04:10:43Running ./projects/libcxx/benchmarks/variant_visit_3.libcxx.outRun on (8 X 3100 MHz CPU s)CPU Caches: L1 Data 32K (x4) L1 Instruction 32K (x4) L2 Unified 262K (x4) L3 Unified 8388K (x1)Load Average: 1.57, 3.76, 4.59-----------------------------------------------------------Benchmark Time CPU Iterations-----------------------------------------------------------BM_Visit<3, 1> 0.271 ns 0.270 ns 1000000000BM_Visit<3, 2> 0.344 ns 0.334 ns 1000000000BM_Visit<3, 3> 0.347 ns 0.336 ns 1000000000BM_Visit<3, 4> 0.300 ns 0.296 ns 1000000000BM_Visit<3, 5> 0.290 ns 0.286 ns 1000000000BM_Visit<3, 6> 0.272 ns 0.271 ns 1000000000BM_Visit<3, 7> 1.72 ns 1.71 ns 415765841BM_Visit<3, 8> 1.73 ns 1.72 ns 408909555BM_Visit<3, 9> 2.16 ns 2.04 ns 380898485BM_Visit<3, 10> 2.45 ns 2.40 ns 295714256BM_Visit<3, 15> 1.92 ns 1.85 ns 375990332BM_Visit<3, 20> 1.66 ns 1.65 ns 414456233```Differential Revision: https://reviews.llvm.org/D85420 List of files: /llvm-project-15.0.7/libcxx/test/std/utilities/variant/variant.visit/visit.pass.cpp

2659663e - [libc++] Remove shortcut Lit features for Apple backdeployment

Thu, 16 Jul 2020 19:34:15 +0000

[libc++] Remove shortcut Lit features for Apple backdeploymentSome time ago, I introduced shortcut features like dylib-has-no-shared_mutexto encode whether the deployment target supported shared_mutex (say). Thismade the test suite annotations cleaner.However, the problem with building Lit features on top of other Litfeatures is that it's easier for them to become stale, especially whenthey are generated programmatically. Furthermore, it makes the bar fordefining configurations from scratch higher, since more features haveto be defined. Instead, I think it's better to put the XFAILs in thetests directly, which allows cleaning them up with a simple grep. List of files: /llvm-project-15.0.7/libcxx/test/std/utilities/variant/variant.visit/visit.pass.cpp

31cbe0f2 - [libc++] Remove the c++98 Lit feature from the test suite

Mon, 01 Jun 2020 14:38:23 +0000

[libc++] Remove the c++98 Lit feature from the test suiteC++98 and C++03 are effectively aliases as far as Clang is concerned.As such, allowing both std=c++98 and std=c++03 as Lit parameters isjust slightly confusing, but provides no value. It's similar to allowingboth std=c++17 and std=c++1z, which we don't do.This was discovered because we had an internal bot that ran the testsuite under both c++98 AND c++03 -- one of which is redundant.Differential Revision: https://reviews.llvm.org/D80926 List of files: /llvm-project-15.0.7/libcxx/test/std/utilities/variant/variant.visit/visit.pass.cpp

8c61114c - [libc++/abi/unwind] Rename Lit features for no exceptions to 'no-exceptions'

Fri, 17 Apr 2020 14:29:15 +0000

[libc++/abi/unwind] Rename Lit features for no exceptions to 'no-exceptions'Instead of having different names for the same Lit feature accross codebases, use the same name everywhere. This NFC commit is in preparationfor a refactor where all three projects will be using the same Litfeature detection logic, and hence it won't be convenient to usedifferent names for the feature.Differential Revision: https://reviews.llvm.org/D78370 List of files: /llvm-project-15.0.7/libcxx/test/std/utilities/variant/variant.visit/visit.pass.cpp

cc89063b - libcxx: Rename .hpp files in libcxx/test/support to .h

Wed, 21 Aug 2019 00:14:12 +0000

libcxx: Rename .hpp files in libcxx/test/support to .hLLVM uses .h as its extension for header files.Files renamed using: for f in libcxx/test/support/*.hpp; do git mv $f ${f%.hpp}.h; doneReferences to the files updated using: for f in $(git diff master | grep 'rename from' | cut -f 3 -d ' '); do a=$(basename $f); echo $a; rg -l $a libcxx | xargs sed -i '' "s/$a/${a%.hpp}.h/"; doneHPP include guards updated manually using: for f in $(git diff master | grep 'rename from' | cut -f 3 -d ' '); do echo ${f%.hpp}.h ; done | xargs mvimDifferential Revision: https://reviews.llvm.org/D66104llvm-svn: 369481 List of files: /llvm-project-15.0.7/libcxx/test/std/utilities/variant/variant.visit/visit.pass.cpp

f5f2f777 - [libc++] Fix XFAILs on macOS when exceptions are disabled

Tue, 05 Feb 2019 20:11:58 +0000

[libc++] Fix XFAILs on macOS when exceptions are disabledSome tests are marked as failing on platforms where the dylib does notprovide the required exception classes. However, when testing withexceptions disabled, those tests shouldn't be marked as failing.llvm-svn: 353210 List of files: /llvm-project-15.0.7/libcxx/test/std/utilities/variant/variant.visit/visit.pass.cpp

51358e45 - [libcxx] Start defining lit features for tests depending on availability

Tue, 05 Feb 2019 19:22:38 +0000

[libcxx] Start defining lit features for tests depending on availabilityThis patch removes some vendor-specific availability XFAILs from thetest suite. In the future, when a new feature is introduced in thedylib, an availability macro should be created and a matching litfeature should be created. That way, the test suite can XFAIL wheneverthe implementation lacks the necessary feature instead of beingcluttered by vendor-specific annotations.Right now, those vendor-specific annotations are still somewhat clutteringthe test suite by being in `config.py`, but at least they are localized.In the future, we could design a way to define those less intrusively oreven automatically based on the availability macros that already existin <__config>.llvm-svn: 353201 List of files: /llvm-project-15.0.7/libcxx/test/std/utilities/variant/variant.visit/visit.pass.cpp

2df59c50 - Support tests in freestanding

Mon, 04 Feb 2019 20:31:13 +0000

Support tests in freestandingSummary:Freestanding is *weird*. The standard allows it to differ in a bunch of oddmanners from regular C++, and the committee would like to improve thatsituation. I'd like to make libc++ behave better with what freestanding shouldbe, so that it can be a tool we use in improving the standard. To do that weneed to try stuff out, both with "freestanding the language mode" and"freestanding the library subset".Let's start with the super basic: run the libc++ tests in freestanding, usingclang as the compiler, and see what works. The easiest hack to do this:In utils/libcxx/test/config.py add: self.cxx.compile_flags += ['-ffreestanding']Run the tests and they all fail.Why? Because in freestanding `main` isn't special. This "not special" propertyhas two effects: main doesn't get mangled, and main isn't allowed to omit its`return` statement. The first means main gets mangled and the linker can'tcreate a valid executable for us to test. The second means we spew out warnings(ew) and the compiler doesn't insert the `return` we omitted, and main justfalls of the end and does whatever undefined behavior (if you're luck, ud2leading to non-zero return code).Let's start my work with the basics. This patch changes all libc++ tests todeclare `main` as `int main(int, char**` so it mangles consistently (enabling usto declare another `extern "C"` main for freestanding which calls the mangledone), and adds `return 0;` to all places where it was missing. This touches 6124files, and I apologize.The former was done with The Magic Of Sed.The later was done with a (not quite correct but decent) clang tool: https://gist.github.com/jfbastien/793819ff360baa845483dde81170feedThis works for most tests, though I did have to adjust a few places when e.g.the test runs with `-x c`, macros are used for main (such as for the filesystemtests), etc.Once this is in we can create a freestanding bot which will prevent furtherregressions. After that, we can start the real work of supporting C++freestanding fairly well in libc++.Reviewers: ldionne, mclow.lists, EricWFSubscribers: christof, jkorous, dexonsmith, arphaman, miyuki, libcxx-commitsDifferential Revision: https://reviews.llvm.org/D57624llvm-svn: 353086 List of files: /llvm-project-15.0.7/libcxx/test/std/utilities/variant/variant.visit/visit.pass.cpp

57b08b09 - Update more file headers across all of the LLVM projects in the monorepo

Sat, 19 Jan 2019 10:56:40 +0000

Update more file headers across all of the LLVM projects in the monorepoto reflect the new license. These used slightly different spellings thatdefeated my regular expressions.We understand that people may be surprised that we're moving the headerentirely to discuss the new license. We checked this carefully with theFoundation's lawyer and we believe this is the correct approach.Essentially, all code in the project is now made available by the LLVMproject under our new license, so you will see that the license headersinclude that license only. Some of our contributors have contributedcode under our old license, and accordingly, we have retained a copy ofour old license notice in the top-level files in each project andrepository.llvm-svn: 351648 List of files: /llvm-project-15.0.7/libcxx/test/std/utilities/variant/variant.visit/visit.pass.cpp

8a063df1 - [libcxx] Add availability markup for bad_optional_access, bad_variant_access and bad_any_cast

Mon, 19 Nov 2018 15:37:04 +0000

[libcxx] Add availability markup for bad_optional_access, bad_variant_access and bad_any_castReviewers: dexonsmith, EricWFSubscribers: christof, arphaman, libcxx-commitsDifferential Revision: https://reviews.llvm.org/D53256llvm-svn: 347219 List of files: /llvm-project-15.0.7/libcxx/test/std/utilities/variant/variant.visit/visit.pass.cpp

ade32237 - [libcxx] [test] Fix URLs in comments and make them HTTPS. NFC.

Sat, 05 Aug 2017 00:44:24 +0000

[libcxx] [test] Fix URLs in comments and make them HTTPS. NFC.llvm-svn: 310156 List of files: /llvm-project-15.0.7/libcxx/test/std/utilities/variant/variant.visit/visit.pass.cpp

215f55f5 - Fix `std::visit` for the zero variants case.

Thu, 11 May 2017 07:17:12 +0000

Fix `std::visit` for the zero variants case.Summary:The following code is broken:``` std::visit([]{});```Reviewers: EricWFReviewed By: EricWFDifferential Revision: https://reviews.llvm.org/D33090llvm-svn: 302773 List of files: /llvm-project-15.0.7/libcxx/test/std/utilities/variant/variant.visit/visit.pass.cpp