Changes in PR28469_undefined_behavior_segfault.sh.cpp

3c62198c - [libc++] NFC: Normalize links to bug reports

Wed, 03 Mar 2021 18:45:06 +0000

[libc++] NFC: Normalize links to bug reports List of files: /llvm-project-15.0.7/libcxx/test/std/containers/associative/map/PR28469_undefined_behavior_segfault.sh.cpp

1fc5010d - [libc++] Consider everything inside %T to be a dependency of each test

Wed, 10 Jun 2020 18:41:47 +0000

[libc++] Consider everything inside %T to be a dependency of each testInstead of passing file dependencies individually, assume that thewhole content of the unique test directory is a dependency. Thissimplifies the test harness significantly, by making %T the directorythat contains everything required to run a test. This also removes theneed for the %{file_dependencies} substitution, which is removed by thispatch.Furthermore, this patch also changes the harness to execute tests locallyinside %T, so as to avoid creating a separate directory for no purpose. List of files: /llvm-project-15.0.7/libcxx/test/std/containers/associative/map/PR28469_undefined_behavior_segfault.sh.cpp

31cbe0f2 - [libc++] Remove the c++98 Lit feature from the test suite

Mon, 01 Jun 2020 14:38:23 +0000

[libc++] Remove the c++98 Lit feature from the test suiteC++98 and C++03 are effectively aliases as far as Clang is concerned.As such, allowing both std=c++98 and std=c++03 as Lit parameters isjust slightly confusing, but provides no value. It's similar to allowingboth std=c++17 and std=c++1z, which we don't do.This was discovered because we had an internal bot that ran the testsuite under both c++98 AND c++03 -- one of which is redundant.Differential Revision: https://reviews.llvm.org/D80926 List of files: /llvm-project-15.0.7/libcxx/test/std/containers/associative/map/PR28469_undefined_behavior_segfault.sh.cpp

68fb8051 - [libc++] Turn on warnings in the test suite in C++03 for Clang-based compilers

Fri, 01 May 2020 17:14:04 +0000

[libc++] Turn on warnings in the test suite in C++03 for Clang-based compilers List of files: /llvm-project-15.0.7/libcxx/test/std/containers/associative/map/PR28469_undefined_behavior_segfault.sh.cpp

07e46252 - [libc++] Allow running .sh.cpp tests with SSHExecutors

Tue, 31 Mar 2020 16:09:20 +0000

[libc++] Allow running .sh.cpp tests with SSHExecutorsThis commit adds a script that can be used as an %{exec} substitutionsuch that .sh.cpp tests can now run on remote hosts when using theSSHExecutor. List of files: /llvm-project-15.0.7/libcxx/test/std/containers/associative/map/PR28469_undefined_behavior_segfault.sh.cpp

08776def - [libc++/libc++abi] Properly delimit lit substitutions

Fri, 27 Mar 2020 14:04:13 +0000

[libc++/libc++abi] Properly delimit lit substitutionslit is not very clever when it performs substitution on RUN lines. Itsimply looks for a match anywhere in the line (without tokenization)and replaces it by the expansion. This means that a RUN line containinge.g. `-verify-ignore-unexpected=note` wouod be expanded to`-verify-ignore-unexpected=e`, which issurprising and nonsensical.It also means that something like `%compile_module` could be expandedto `_module` or to the correct substitution,depending on the order in which substitutions are evaluated by lit.To avoid such problems, it is a good habit to delimit custom substitutionswith some token. This commit does that for all substitutions used in thelibc++ and libc++abi test suites. List of files: /llvm-project-15.0.7/libcxx/test/std/containers/associative/map/PR28469_undefined_behavior_segfault.sh.cpp

2df59c50 - Support tests in freestanding

Mon, 04 Feb 2019 20:31:13 +0000

Support tests in freestandingSummary:Freestanding is *weird*. The standard allows it to differ in a bunch of oddmanners from regular C++, and the committee would like to improve thatsituation. I'd like to make libc++ behave better with what freestanding shouldbe, so that it can be a tool we use in improving the standard. To do that weneed to try stuff out, both with "freestanding the language mode" and"freestanding the library subset".Let's start with the super basic: run the libc++ tests in freestanding, usingclang as the compiler, and see what works. The easiest hack to do this:In utils/libcxx/test/config.py add: self.cxx.compile_flags += ['-ffreestanding']Run the tests and they all fail.Why? Because in freestanding `main` isn't special. This "not special" propertyhas two effects: main doesn't get mangled, and main isn't allowed to omit its`return` statement. The first means main gets mangled and the linker can'tcreate a valid executable for us to test. The second means we spew out warnings(ew) and the compiler doesn't insert the `return` we omitted, and main justfalls of the end and does whatever undefined behavior (if you're luck, ud2leading to non-zero return code).Let's start my work with the basics. This patch changes all libc++ tests todeclare `main` as `int main(int, char**` so it mangles consistently (enabling usto declare another `extern "C"` main for freestanding which calls the mangledone), and adds `return 0;` to all places where it was missing. This touches 6124files, and I apologize.The former was done with The Magic Of Sed.The later was done with a (not quite correct but decent) clang tool: https://gist.github.com/jfbastien/793819ff360baa845483dde81170feedThis works for most tests, though I did have to adjust a few places when e.g.the test runs with `-x c`, macros are used for main (such as for the filesystemtests), etc.Once this is in we can create a freestanding bot which will prevent furtherregressions. After that, we can start the real work of supporting C++freestanding fairly well in libc++.Reviewers: ldionne, mclow.lists, EricWFSubscribers: christof, jkorous, dexonsmith, arphaman, miyuki, libcxx-commitsDifferential Revision: https://reviews.llvm.org/D57624llvm-svn: 353086 List of files: /llvm-project-15.0.7/libcxx/test/std/containers/associative/map/PR28469_undefined_behavior_segfault.sh.cpp

57b08b09 - Update more file headers across all of the LLVM projects in the monorepo

Sat, 19 Jan 2019 10:56:40 +0000

Update more file headers across all of the LLVM projects in the monorepoto reflect the new license. These used slightly different spellings thatdefeated my regular expressions.We understand that people may be surprised that we're moving the headerentirely to discuss the new license. We checked this carefully with theFoundation's lawyer and we believe this is the correct approach.Essentially, all code in the project is now made available by the LLVMproject under our new license, so you will see that the license headersinclude that license only. Some of our contributors have contributedcode under our old license, and accordingly, we have retained a copy ofour old license notice in the top-level files in each project andrepository.llvm-svn: 351648 List of files: /llvm-project-15.0.7/libcxx/test/std/containers/associative/map/PR28469_undefined_behavior_segfault.sh.cpp

3c35491f - Update all bug URL's to point to https://bugs.llvm.org/...

Fri, 17 Feb 2017 08:37:03 +0000

Update all bug URL's to point to https://bugs.llvm.org/...llvm-svn: 295434 List of files: /llvm-project-15.0.7/libcxx/test/std/containers/associative/map/PR28469_undefined_behavior_segfault.sh.cpp

d05b10ab - Fix undefined behavior in __tree

Tue, 19 Jul 2016 17:56:20 +0000

Fix undefined behavior in __treeSummary:This patch attempts to fix the undefined behavior in __tree by changing the node pointer types used throughout. The pointer types are changed for raw pointers in the current ABI and for fancy pointers in ABI V2 (since the fancy pointer types may not be ABI compatible).The UB in `__tree` arises because tree downcasts the embedded end node and then deferences that pointer. Currently there are 3 node types in __tree.* `__tree_end_node` which contains the `__left_` pointer. This node is embedded within the container.* `__tree_node_base` which contains `__right_`, `__parent_` and `__is_black`. This node is used throughout the tree rebalancing algorithms.* `__tree_node` which contains `__value_`.Currently `__tree` stores the start of the tree, `__begin_node_`, as a pointer to a `__tree_node`. Additionally the iterators store their position as a pointer to a `__tree_node`. In both of these cases the pointee can be the end node. This is fixed by changing them to store `__tree_end_node` pointers instead.To make this change I introduced an `__iter_pointer` typedef which is defined to be a pointer to either `__tree_end_node` in the new ABI or `__tree_node` in the current one.Both `__tree::__begin_node_` and iterator pointers are now stored as `__iter_pointers`.The other situation where `__tree_end_node` is stored as the wrong type is in `__tree_node_base::__parent_`. Currently `__left_`, `__right_`, and `__parent_` are all `__tree_node_base` pointers. Since the end node will only be stored in `__parent_` the fix is to change `__parent_` to be a pointer to `__tree_end_node`.To make this change I introduced a `__parent_pointer` typedef which is defined to be a pointer to either `__tree_end_node` in the new ABI or `__tree_node_base` in the current one.Note that in the new ABI `__iter_pointer` and `__parent_pointer` are the same type (but not in the old one). The confusion between these two types is unfortunate but it was the best solution I could come up with that maintains the ABI.The typedef changes force a ton of explicit type casts to correct pointer types and to make current code compatible with both the old and new pointer typedefs. This is the bulk of the change and it's really messy. Unfortunately I don't know how to avoid it.Please let me know what you think.Reviewers: howard.hinnant, mclow.listsSubscribers: howard.hinnant, bbannier, cfe-commitsDifferential Revision: https://reviews.llvm.org/D20786llvm-svn: 276003 List of files: /llvm-project-15.0.7/libcxx/test/std/containers/associative/map/PR28469_undefined_behavior_segfault.sh.cpp