Changes in fstream

2ae52326 - [libc++] Towards a simpler extern template story in libc++

Tue, 08 Jun 2021 21:25:08 +0000

[libc++] Towards a simpler extern template story in libc++The flexibility around extern template instantiation declarations inlibc++ result in a very complicated model, especially when support forslightly different configurations (like the debug mode or assertionsin the dylib) are taken into account. That results in unexpected bugslike http://llvm.org/PR50534 (and there have been multiple similarbugs in the past, notably around the debug mode).This patch gets rid of the _LIBCPP_DISABLE_EXTERN_TEMPLATE knob, whichI don't think is fundamental. Indeed, the motivation for that knob was toavoid taking a dependency on the library, however that can be done betterby linking against the static library instead. And in fact, some parts ofthe headers will always depend on things defined in the library, whichdefeats the original goal of _LIBCPP_DISABLE_EXTERN_TEMPLATE.Differential Revision: https://reviews.llvm.org/D103960 List of files: /llvm-project-15.0.7/libcxx/include/fstream

4ff70dba - [libc++] Fix undefined behavior in `std::filebuf`

Thu, 14 Apr 2022 14:17:24 +0000

[libc++] Fix undefined behavior in `std::filebuf`Fixes https://github.com/llvm/llvm-project/issues/49267.Fixes https://github.com/llvm/llvm-project/issues/49282.Fixes https://github.com/llvm/llvm-project/issues/49789.Reviewed By: ldionneDifferential Revision: https://reviews.llvm.org/D122257 List of files: /llvm-project-15.0.7/libcxx/include/fstream

385cc25a - [libc++] Ensure that all public C++ headers include <__assert>

Fri, 25 Mar 2022 16:55:36 +0000

[libc++] Ensure that all public C++ headers include <__assert>This patch changes the requirement for getting the declaration of theassertion handler from including <__assert> to including any publicC++ header of the library. Note that C compatibility headers areexcluded because we don't implement all the C headers ourselves --some of them are taken straight from the C library, like assert.h.It also adds a generated test to check it. Furthermore, this newgenerated test is designed in a way that will make it possible toreplace almost all the existing test-generation scripts with thissystem in upcoming patches.Differential Revision: https://reviews.llvm.org/D122506 List of files: /llvm-project-15.0.7/libcxx/include/fstream

52915d78 - [libc++] Granularize includes

Sat, 05 Mar 2022 18:17:07 +0000

[libc++] Granularize includesReviewed By: ldionne, #libcSpies: EricWF, libcxx-commits, arphamanDifferential Revision: https://reviews.llvm.org/D120466 List of files: /llvm-project-15.0.7/libcxx/include/fstream

f87aa19b - [libc++] Move everything related solely to _LIBCPP_ASSERT to its own file

Mon, 14 Feb 2022 18:41:09 +0000

[libc++] Move everything related solely to _LIBCPP_ASSERT to its own fileThis is the first step towards disentangling the debug mode and assertionsin libc++. This patch doesn't make any functional change: it simply moves_LIBCPP_ASSERT-related stuff to its own file so as to make it clear thatlibc++ assertions and the debug mode are different things. Future patcheswill make it possible to enable assertions without enabling the debugmode.Differential Revision: https://reviews.llvm.org/D119769 List of files: /llvm-project-15.0.7/libcxx/include/fstream

2e2f3158 - [libc++] Granularize algorithm includes

Tue, 15 Feb 2022 17:18:08 +0000

[libc++] Granularize algorithm includesReviewed By: Mordante, ldionne, Quuxplusone, #libc, #libc_abiSpies: #libc_vendors, libcxx-commits, miyukiDifferential Revision: https://reviews.llvm.org/D119667 List of files: /llvm-project-15.0.7/libcxx/include/fstream

2a8f9a5e - [libc++] Implement P0627R6 (Function to mark unreachable code)

Mon, 14 Feb 2022 17:26:02 +0000

[libc++] Implement P0627R6 (Function to mark unreachable code)Reviewed By: ldionne, Quuxplusone, #libcSpies: arichardson, mstorsjo, libcxx-commits, mgornyDifferential Revision: https://reviews.llvm.org/D119152 List of files: /llvm-project-15.0.7/libcxx/include/fstream

fa6b9e40 - [libc++] Normalize all our '#pragma GCC system_header', and regression-test.

Wed, 02 Feb 2022 01:16:40 +0000

[libc++] Normalize all our '#pragma GCC system_header', and regression-test.Now we'll notice if a header forgets to include this magic phrase.Differential Revision: https://reviews.llvm.org/D118800 List of files: /llvm-project-15.0.7/libcxx/include/fstream

bd6e6846 - [libc++] Add the version header to all headers.

Wed, 22 Dec 2021 17:14:14 +0000

[libc++] Add the version header to all headers.Some headers which require the version header depend on other headers toprovide it. Include the version header in all top-level headers to makesure a header cleanup can't remove the version header.Note this doesn't add the version header to the c headers.Reviewed By: #libc, Quuxplusone, ldionneDifferential Revision: https://reviews.llvm.org/D116172 List of files: /llvm-project-15.0.7/libcxx/include/fstream

eb8650a7 - [runtimes][NFC] Remove filenames at the top of the license notice

Wed, 17 Nov 2021 21:25:01 +0000

[runtimes][NFC] Remove filenames at the top of the license noticeWe've stopped doing it in libc++ for a while now because these nameswould end up rotting as we move things around and copy/paste stuff.This cleans up all the existing files so as to stop the spreadingas people copy-paste headers around. List of files: /llvm-project-15.0.7/libcxx/include/fstream

87dd5198 - [libc++] Remove support for CloudABI, which has been abandoned

Tue, 24 Aug 2021 15:40:05 +0000

[libc++] Remove support for CloudABI, which has been abandonedBased on https://github.com/NuxiNL/cloudlibc, it appears that the CloudABIproject has been abandoned. This patch removes a bunch of CloudABI specificlogic that had been added to support that platform.Note that some knobs like LIBCXX_ENABLE_STDIN and LIBCXX_ENABLE_STDOUTcoud be useful in their own right, however those are currently broken.If we want to re-add such knobs in the future, we can do it like we'vedone it for localization & friends so that we can officially supportthat configuration.Differential Revision: https://reviews.llvm.org/D108637 List of files: /llvm-project-15.0.7/libcxx/include/fstream

a8d1182f - [libc++] Remove some _LIBCPP_CXX03_LANG from iostreams headers.

Tue, 15 Jun 2021 16:47:05 +0000

[libc++] Remove some _LIBCPP_CXX03_LANG from iostreams headers.With the STL containers, I didn't enable move operations in C++03 modebecause that would change the overload resolution for things that todayare copy operations. With iostreams, though, the copy operations aren'tpresent at all, and so I see no problem with enabling move operationseven in (Clang's greatly extended) C++03 mode.Clang's C++03 mode does not support delegating constructors.Differential Revision: https://reviews.llvm.org/D104310 List of files: /llvm-project-15.0.7/libcxx/include/fstream

bfbd73f8 - [libc++] Alphabetize and include-what-you-use. NFCI.

Wed, 19 May 2021 15:57:04 +0000

[libc++] Alphabetize and include-what-you-use. NFCI.Differential Revision: https://reviews.llvm.org/D102781 List of files: /llvm-project-15.0.7/libcxx/include/fstream

06b40e80 - [libc++] Alphabetize header inclusions and include-what-you-use <__debug>. NFCI.

Thu, 13 May 2021 03:04:03 +0000

[libc++] Alphabetize header inclusions and include-what-you-use <__debug>. NFCI. List of files: /llvm-project-15.0.7/libcxx/include/fstream

4cd6ca10 - [libc++] NFC: Normalize `#endif //` comment indentation

Tue, 20 Apr 2021 16:03:32 +0000

[libc++] NFC: Normalize `#endif //` comment indentation List of files: /llvm-project-15.0.7/libcxx/include/fstream

52e9d80d - [libc++] add `inline` for __open's definition in ifstream and ofstream

Mon, 12 Apr 2021 19:22:12 +0000

[libc++] add `inline` for __open's definition in ifstream and ofstreamSummary:When building with gcc on AIX, it seems that gcc does not like the`always_inline` without the `inline` keyword.So adding the inline keywords in for __open in ifstream and ofstream.That will also make it consistent with __open in basic_filebuf(it seems we added `inline` there before for gcc build as well).Differential Revision: https://reviews.llvm.org/D99422 List of files: /llvm-project-15.0.7/libcxx/include/fstream

8deaa4a1 - [libc++] Move checks for newlib to actually work

Mon, 12 Apr 2021 18:19:51 +0000

[libc++] Move checks for newlib to actually workThe checks did not work in __config, since no header defining`_NEWLIB_VERSION` was included before. This patch moves the twochecks for newlib to the headers that actually need it - and afterthey already include relevant headers.Differential Revision: https://reviews.llvm.org/D79888 List of files: /llvm-project-15.0.7/libcxx/include/fstream

933518ff - [libc++] Make LIBCXX_ENABLE_FILESYSTEM fully consistent

Mon, 18 Jan 2021 17:18:18 +0000

[libc++] Make LIBCXX_ENABLE_FILESYSTEM fully consistentPreviously, LIBCXX_ENABLE_FILESYSTEM controlled only whether the filesystemsupport was compiled into libc++'s library. This commit promotes thesetting to a first-class option like LIBCXX_ENABLE_LOCALIZATION, wherethe whole library is aware of the setting and features that depend on won't be provided at all. The test suite is also properlyannotated such that tests that depend on are disabled whenthe library doesn't support it.This is an alternative to https://llvm.org/D94824, but also an improvementalong the lines of LIBCXX_ENABLE_LOCALIZATION that I had been wanting tomake for a while.Differential Revision: https://reviews.llvm.org/D94921 List of files: /llvm-project-15.0.7/libcxx/include/fstream

3696227c - [libc++] ADL-proof by adding _VSTD:: qualifications to memmove etc.

Tue, 08 Dec 2020 02:50:15 +0000

[libc++] ADL-proof by adding _VSTD:: qualifications to memmove etc.Generally these calls aren't vulnerable to ADL because they involve onlyprimitive types. The ones in and drag in namespace stdbut that's OK; the ones in and are vulnerableiff `CharT` is an enum type, which seems far-fetched.But absolutely zero of them *need* ADL to happen; so in my opinionthey should all be consistently qualified, just like calls to anyother (non-user-customizable) functions in namespace std.Also: Include and in <__string>.We seemed to be getting lucky that included included included . That gave us theglobal-namespace `wmemmove`, but not `_VSTD::wmemmove`.This is now fixed.I didn't touch these headers: uses strlen, safely uses memcpy, safely uses memchr and strchr, safely uses wcschr, safely<__bsd_locale_fallbacks.h> uses wcsnrtombs, safelyDifferential Revision: https://reviews.llvm.org/D93061 List of files: /llvm-project-15.0.7/libcxx/include/fstream

527a7fdf - [libc++] Replace several uses of 0 by nullptr

Tue, 24 Nov 2020 17:53:53 +0000

[libc++] Replace several uses of 0 by nullptrDifferential Revision: https://reviews.llvm.org/D43159 List of files: /llvm-project-15.0.7/libcxx/include/fstream