Changes in compare

385cc25a - [libc++] Ensure that all public C++ headers include <__assert>

Fri, 25 Mar 2022 16:55:36 +0000

[libc++] Ensure that all public C++ headers include <__assert>This patch changes the requirement for getting the declaration of theassertion handler from including <__assert> to including any publicC++ header of the library. Note that C compatibility headers areexcluded because we don't implement all the C headers ourselves --some of them are taken straight from the C library, like assert.h.It also adds a generated test to check it. Furthermore, this newgenerated test is designed in a way that will make it possible toreplace almost all the existing test-generation scripts with thissystem in upcoming patches.Differential Revision: https://reviews.llvm.org/D122506 List of files: /llvm-project-15.0.7/libcxx/include/compare

fa6b9e40 - [libc++] Normalize all our '#pragma GCC system_header', and regression-test.

Wed, 02 Feb 2022 01:16:40 +0000

[libc++] Normalize all our '#pragma GCC system_header', and regression-test.Now we'll notice if a header forgets to include this magic phrase.Differential Revision: https://reviews.llvm.org/D118800 List of files: /llvm-project-15.0.7/libcxx/include/compare

bf20a097 - [libc++] [P1614] Implement the second half of [cmp.alg]: compare_{strong,weak,partial}_fallback.

Wed, 08 Sep 2021 20:48:50 +0000

[libc++] [P1614] Implement the second half of [cmp.alg]: compare_{strong,weak,partial}_fallback.The tests for these are just copy-pasted from the tests for std::{strong,weak,partial}_order,and then I added an extra clause in each (test_2()) to test the stuff that's not just the sameas std::*_order.This also includes the fix for https://wg21.link/LWG3465 (which falls naturally out of the"you must write it three times" style, but I've added test cases for it also).There is an action item here to go back and give good diagnostics for SFINAE failuresin these CPOs. I've filed this as https://github.com/llvm/llvm-project/issues/53456 .Differential Revision: https://reviews.llvm.org/D111514 List of files: /llvm-project-15.0.7/libcxx/include/compare

bd6e6846 - [libc++] Add the version header to all headers.

Wed, 22 Dec 2021 17:14:14 +0000

[libc++] Add the version header to all headers.Some headers which require the version header depend on other headers toprovide it. Include the version header in all top-level headers to makesure a header cleanup can't remove the version header.Note this doesn't add the version header to the c headers.Reviewed By: #libc, Quuxplusone, ldionneDifferential Revision: https://reviews.llvm.org/D116172 List of files: /llvm-project-15.0.7/libcxx/include/compare

413c3c4f - [libc++] Add missing `#pragma GCC system_header` in a few headers. NFCI.

Sun, 05 Dec 2021 18:08:36 +0000

[libc++] Add missing `#pragma GCC system_header` in a few headers. NFCI. List of files: /llvm-project-15.0.7/libcxx/include/compare

d8380ad9 - [libc++] [P1614] Implement [cmp.alg]'s std::{strong,weak,partial}_order.

Thu, 29 Jul 2021 02:04:18 +0000

[libc++] [P1614] Implement [cmp.alg]'s std::{strong,weak,partial}_order.This does not include `std::compare_*_fallback`; those are coming later.There's still an open question of how to implement std::strong_orderfor `long double`, which has 80 value bits and 48 padding bits on x86-64,and which is presumably *not* IEEE 754-compliant on PPC64 and so on.So that part is left unimplemented.Differential Revision: https://reviews.llvm.org/D110738 List of files: /llvm-project-15.0.7/libcxx/include/compare

eb8650a7 - [runtimes][NFC] Remove filenames at the top of the license notice

Wed, 17 Nov 2021 21:25:01 +0000

[runtimes][NFC] Remove filenames at the top of the license noticeWe've stopped doing it in libc++ for a while now because these nameswould end up rotting as we move things around and copy/paste stuff.This cleans up all the existing files so as to stop the spreadingas people copy-paste headers around. List of files: /llvm-project-15.0.7/libcxx/include/compare

c0f87e83 - [libc++] Remove _LIBCPP_HAS_NO_SPACESHIP_OPERATOR

Mon, 15 Nov 2021 21:47:58 +0000

[libc++] Remove _LIBCPP_HAS_NO_SPACESHIP_OPERATORAll supported compilers support spaceship in C++20 nowadays.Differential Revision: https://reviews.llvm.org/D113938 List of files: /llvm-project-15.0.7/libcxx/include/compare

3df094d3 - [libc++] [P1614] Implement std::compare_three_way.

Thu, 29 Jul 2021 03:40:29 +0000

[libc++] [P1614] Implement std::compare_three_way.Differential Revision: https://reviews.llvm.org/D110735 List of files: /llvm-project-15.0.7/libcxx/include/compare

969359e3 - [libc++] [compare] Named comparison functions, is_eq etc.

Mon, 27 Sep 2021 04:48:39 +0000

[libc++] [compare] Named comparison functions, is_eq etc.Some of these were previously half-implemented in "ordering.h";now they're all implemented, and tested.Note that `constexpr` functions are implicitly `inline`, so thestandard wording omits `inline` on these; but Louis and I agreethat that's surprising and it's better to be explicit about it.Differential Revision: https://reviews.llvm.org/D110515 List of files: /llvm-project-15.0.7/libcxx/include/compare

8ce2675b - [libc++][compare] Implement three_way_comparable[_with] concepts

Sun, 05 Sep 2021 03:16:18 +0000

[libc++][compare] Implement three_way_comparable[_with] conceptsImplementation of `three_way_comparable` and `three_way_comparable_with` concepts from header.Please note that I have temporarily removed `` header from `` due to cyclic dependency that prevents using `` header in `` one.I tried to quickly resolve those issues including applying suggestions from @cjdb and dive deeper by myself but the problem seems more complicated that we thought initially.I am in progress to prepare the patch with resolving this cyclic dependency between headers but for now I decided to put all that I have to the review to unblock people that depend on that functionality. At first glance the patch with resolving cyclic dependency is not so small (unless I find the way to make it smaller and cleaner) so I don't want to mix everything to one review.Reviewed By: ldionne, cjdb, #libc, QuuxplusoneDifferential Revision: https://reviews.llvm.org/D103478 List of files: /llvm-project-15.0.7/libcxx/include/compare

7e325d4c - [libc++][NFC] Remove unused include in .

Thu, 19 Aug 2021 23:06:52 +0000

[libc++][NFC] Remove unused include in .`` was included in the first iteration of `` whenit was created as a monolithic header, then never removed. Removing itnow is a beneficial no-op since it is not guaranteed by the standardand is already included by all of its subheaders.Reviewed By: cjdb, #libc, QuuxplusoneDifferential Revision: https://reviews.llvm.org/D107801 List of files: /llvm-project-15.0.7/libcxx/include/compare

38812f4a - [libc++] [P1614] Implement std::compare_three_way_result.

Thu, 29 Jul 2021 04:03:01 +0000

[libc++] [P1614] Implement std::compare_three_way_result.Differential Revision: https://reviews.llvm.org/D103581 List of files: /llvm-project-15.0.7/libcxx/include/compare

d4840175 - [libc++] Remove excess whitespace in synopsis comment. NFCI.

Thu, 29 Jul 2021 05:34:31 +0000

[libc++] Remove excess whitespace in synopsis comment. NFCI. List of files: /llvm-project-15.0.7/libcxx/include/compare

61c35fb0 - [libc++][modularisation] Split into internal headers.

Thu, 29 Jul 2021 02:05:46 +0000

[libc++][modularisation] Split into internal headers.Differential Revision: https://reviews.llvm.org/D106107 List of files: /llvm-project-15.0.7/libcxx/include/compare

2e4755ff - [libc++] Fix a few warnings in system headers with GCC

Tue, 27 Jul 2021 21:30:47 +0000

[libc++] Fix a few warnings in system headers with GCCThis isn't fixing all of them, but at least it's making some progress.Differential Revision: https://reviews.llvm.org/D106283 List of files: /llvm-project-15.0.7/libcxx/include/compare

46c17429 - [libcxx] modifies `_CmpUnspecifiedParam` ignore types outside its domain

Sun, 02 May 2021 02:21:28 +0000

[libcxx] modifies `_CmpUnspecifiedParam` ignore types outside its domainD85051's honeypot solution was a bit too aggressive swallowed up thecomparison types, which made comparing objects of different orderingtypes ambiguous.Depends on D101707.Differential Revision: https://reviews.llvm.org/D101708 List of files: /llvm-project-15.0.7/libcxx/include/compare

9eb0969a - [libcxx] makes comparison operators for `std::*_ordering` types hidden friends

Sat, 01 May 2021 19:00:36 +0000

[libcxx] makes comparison operators for `std::*_ordering` types hidden friendsThe standard leaves it up to the implementation to decide whether or notthese operators are hidden friends. There are several (well-documented)reasons to prefer hidden friends, as well as an argument for improvedreadability.Depends on D100342.Differential Revision: https://reviews.llvm.org/D101707 List of files: /llvm-project-15.0.7/libcxx/include/compare

20506fb1 - [libcxx] removes operator!= and globally guards against no spaceship operator

Mon, 12 Apr 2021 20:55:05 +0000

[libcxx] removes operator!= and globally guards against no spaceship operator* `operator!=` isn't in the spec* `` is designed to work with `operator<=>` so it doesn't really make sense to have `operator<=>`-less friendly sections.Depends on D100283.Differential Revision: https://reviews.llvm.org/D100342 List of files: /llvm-project-15.0.7/libcxx/include/compare

4ff2fe1d - [libcxx] removes `weak_equality` and `strong_equality` from

Mon, 12 Apr 2021 05:23:09 +0000

[libcxx] removes `weak_equality` and `strong_equality` from `weak_equality` and `strong_equality` were removed before beingstandardised, and need to be removed.Also adjusts `common_comparison_category` since its test neededadjusting due to the equality deletions.Differential Revision: https://reviews.llvm.org/D100283 List of files: /llvm-project-15.0.7/libcxx/include/compare