Changes in __debug

2aea8af2 - [libc++] Make _LIBCPP_DEBUG_RANDOMIZE_RANGE a function

Sun, 03 Jul 2022 14:52:22 +0000

[libc++] Make _LIBCPP_DEBUG_RANDOMIZE_RANGE a functionReviewed By: ldionne, Mordante, var-const, #libcSpies: mgorny, libcxx-commitsDifferential Revision: https://reviews.llvm.org/D128181 List of files: /llvm-project-15.0.7/libcxx/include/__debug

23d6cde1 - [libc++] Add a test to pin down the set of transitive public includes

Mon, 20 Jun 2022 21:10:53 +0000

[libc++] Add a test to pin down the set of transitive public includesA situation that happens fairly often in libc++ is that we remove sometransitive includes in a header (either purposefully or not) and thatends up breaking users. Of course, we want to be able to remove ourtransitive includes, however it's also good to have a grip on thatto know which commit changed what and when. Furthermore, it's goodto accumulate include removals for a couple of releases to avoidbreaking users at every release for this reason.This commit adds a test that should break whenever we remove aninclude. Hence, it should allow us to track which headers includewhich other headers transitively, giving us a traceable way toremove headers.Differential Revision: https://reviews.llvm.org/D128236 List of files: /llvm-project-15.0.7/libcxx/include/__debug

f3966eaf - [libc++] Make the Debug mode a configuration-time only option

Fri, 01 Apr 2022 20:38:30 +0000

[libc++] Make the Debug mode a configuration-time only optionThe debug mode has been broken pretty much ever since it was shippedbecause it was possible to enable the debug mode in user code withoutactually enabling it in the dylib, leading to ODR violations thatcaused various kinds of failures.This commit makes the debug mode a knob that is configured whenbuilding the library and which can't be changed afterwards. This isless flexible for users, however it will actually work as intendedand it will allow us, in the future, to add various kinds of checksthat do not assume the same ABI as the normal library. Furthermore,this will make the debug mode more robust, which means that vendorsmight be more tempted to support it properly, which hasn't been thecase with the current debug mode.This patch shouldn't break any user code, except folks who are buildingagainst a library that doesn't have the debug mode enabled and who tryto enable the debug mode in their code. Such users will get a compile-timeerror explaining that this configuration isn't supported anymore.In the future, we should further increase the granularity of the debugmode checks so that we can cherry-pick which checks to enable, like wedo for unspecified behavior randomization.Differential Revision: https://reviews.llvm.org/D122941 List of files: /llvm-project-15.0.7/libcxx/include/__debug

08f68dfe - [libc++] Add a few more debug wrapper functions

Sat, 07 May 2022 20:20:23 +0000

[libc++] Add a few more debug wrapper functionsReviewed By: ldionne, #libc, jloserSpies: libcxx-commitsDifferential Revision: https://reviews.llvm.org/D125176 List of files: /llvm-project-15.0.7/libcxx/include/__debug

e70533ae - [libc++] Remove unused include from <__debug>

Sun, 03 Apr 2022 16:40:39 +0000

[libc++] Remove unused include from <__debug>Differential Revision: https://reviews.llvm.org/D122999 List of files: /llvm-project-15.0.7/libcxx/include/__debug

cc82a1b0 - [libc++][NFC] Fix include guards and add a missing license header

Wed, 23 Mar 2022 17:11:04 +0000

[libc++][NFC] Fix include guards and add a missing license header List of files: /llvm-project-15.0.7/libcxx/include/__debug

f86c2b6f - [libc++] Add `explicit` to a bunch of internal detail ctors.

Wed, 09 Feb 2022 22:30:46 +0000

[libc++] Add `explicit` to a bunch of internal detail ctors.Notably the following ctors remain non-explicit because theyare used as implicit conversions in too many places:* __debug_less(_Compare&)* __map_iterator(_TreeIterator)* __map_const_iterator(_TreeIterator)* __hash_map_iterator(_HashIterator)* __hash_map_const_iterator(_HashIterator)Differential Revision: https://reviews.llvm.org/D119894 List of files: /llvm-project-15.0.7/libcxx/include/__debug

318507ed - [libc++] Remove a few unneeded _LIBCPP_CXX03_LANG ifdefs

Wed, 16 Feb 2022 17:55:43 +0000

[libc++] Remove a few unneeded _LIBCPP_CXX03_LANG ifdefsReviewed By: Quuxplusone, ldionne, #libcSpies: libcxx-commitsDifferential Revision: https://reviews.llvm.org/D119896 List of files: /llvm-project-15.0.7/libcxx/include/__debug

f87aa19b - [libc++] Move everything related solely to _LIBCPP_ASSERT to its own file

Mon, 14 Feb 2022 18:41:09 +0000

[libc++] Move everything related solely to _LIBCPP_ASSERT to its own fileThis is the first step towards disentangling the debug mode and assertionsin libc++. This patch doesn't make any functional change: it simply moves_LIBCPP_ASSERT-related stuff to its own file so as to make it clear thatlibc++ assertions and the debug mode are different things. Future patcheswill make it possible to enable assertions without enabling the debugmode.Differential Revision: https://reviews.llvm.org/D119769 List of files: /llvm-project-15.0.7/libcxx/include/__debug

506cf6dc - [libc++] Fix modules and benchmarks CI builds when incomplete features are disabled

Fri, 04 Feb 2022 20:37:01 +0000

[libc++] Fix modules and benchmarks CI builds when incomplete features are disabledDifferential Revision: https://reviews.llvm.org/D119036 List of files: /llvm-project-15.0.7/libcxx/include/__debug

157bbe6a - [libc++] Remove the ability to use the std::nullptr_t emulation in C++03 mode

Wed, 08 Sep 2021 16:57:58 +0000

[libc++] Remove the ability to use the std::nullptr_t emulation in C++03 modeBack in https://reviews.llvm.org/D109459, we stopped using the C++03emulation for std::nullptr_t by default, which was an ABI break. Westill left a knob for users to turn it back on if they were broken bythe change, with a note that we would remove that knob after one release.The time has now come to remove the knob and clean up the std::nullptr_temulation.Differential Revision: https://reviews.llvm.org/D114786 List of files: /llvm-project-15.0.7/libcxx/include/__debug

fa6b9e40 - [libc++] Normalize all our '#pragma GCC system_header', and regression-test.

Wed, 02 Feb 2022 01:16:40 +0000

[libc++] Normalize all our '#pragma GCC system_header', and regression-test.Now we'll notice if a header forgets to include this magic phrase.Differential Revision: https://reviews.llvm.org/D118800 List of files: /llvm-project-15.0.7/libcxx/include/__debug

caf5548c - [libc++] Introduce __debug_db_insert_i()

Mon, 17 Jan 2022 18:25:21 +0000

[libc++] Introduce __debug_db_insert_i()Introduce `__debug_db_insert_i()`Reviewed By: ldionne, #libcSpies: libcxx-commitsDifferential Revision: https://reviews.llvm.org/D117410 List of files: /llvm-project-15.0.7/libcxx/include/__debug

42185ad8 - [libc++] Add tests verifying alphabetical order for several things.

Fri, 07 Jan 2022 14:45:05 +0000

[libc++] Add tests verifying alphabetical order for several things.These things are header #includes, CMakeLists.txt, and module.modulemap.Differential Revision: https://reviews.llvm.org/D116958 List of files: /llvm-project-15.0.7/libcxx/include/__debug

e3cf7050 - [libc++] Introduce __debug_db_insert_c()

Mon, 10 Jan 2022 23:33:35 +0000

[libc++] Introduce __debug_db_insert_c()There are a lot of```#if _LIBCPP_DEBUG_LEVEL == 2 __get_db()->__insert_c(this);#endif```This patch introduces `__debug_db_insert_c()` to put the `#if` in one central place.Reviewed By: ldionne, #libcSpies: libcxx-commitsDifferential Revision: https://reviews.llvm.org/D116947 List of files: /llvm-project-15.0.7/libcxx/include/__debug

5675b611 - [libc++] Disable _LIBCPP_DEBUG_ASSERT during constant evaluation

Thu, 16 Dec 2021 13:55:03 +0000

[libc++] Disable _LIBCPP_DEBUG_ASSERT during constant evaluationDisable `_LIBCPP_DEBUG_ASSERT` and debug iterators in during constant evaluationReviewed By: ldionne, #libcSpies: goncharov, libcxx-commitsDifferential Revision: https://reviews.llvm.org/D115788 List of files: /llvm-project-15.0.7/libcxx/include/__debug

eb8650a7 - [runtimes][NFC] Remove filenames at the top of the license notice

Wed, 17 Nov 2021 21:25:01 +0000

[runtimes][NFC] Remove filenames at the top of the license noticeWe've stopped doing it in libc++ for a while now because these nameswould end up rotting as we move things around and copy/paste stuff.This cleans up all the existing files so as to stop the spreadingas people copy-paste headers around. List of files: /llvm-project-15.0.7/libcxx/include/__debug

4cd6ca10 - [libc++] NFC: Normalize `#endif //` comment indentation

Tue, 20 Apr 2021 16:03:32 +0000

[libc++] NFC: Normalize `#endif //` comment indentation List of files: /llvm-project-15.0.7/libcxx/include/__debug

be4c657b - [libc++] Consistently replace `::new(p) T` with `::new ((void*)p) T`. NFCI.

Sat, 12 Dec 2020 01:30:28 +0000

[libc++] Consistently replace `::new(__p) T` with `::new ((void*)__p) T`. NFCI.Everywhere, normalize the whitespace to `::new (EXPR) T`.Everywhere, normalize the spelling of the cast to `(void*)EXPR`.Without the cast to `(void*)`, the expression triggers ADL on GCC.(I think this is a GCC bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98249)Even if it doesn't trigger ADL, it still seems incorrect to use any argumentthat's not exactly `(void*)` because that opens the possibility of overloadresolution picking a user-defined overload of `operator new`, which would bewrong.Differential Revision: https://reviews.llvm.org/D93153 List of files: /llvm-project-15.0.7/libcxx/include/__debug

d586f92c - [libc++] Consistently replace `std::` qualification with `_VSTD::` or nothing. NFCI.

Fri, 27 Nov 2020 16:02:06 +0000

[libc++] Consistently replace `std::` qualification with `_VSTD::` or nothing. NFCI.I used a lot of `git grep` to find places where `std::` was being usedoutside of comments and assert-messages. There were three outcomes:- Qualified function calls, e.g. `std::move` becomes `_VSTD::move`. This is the most common case.- Typenames that don't need qualification, e.g. `std::allocator` becomes `allocator`. Leaving these as `_VSTD::allocator` would also be fine, but I decided that removing the qualification is more consistent with existing practice.- Names that specifically need un-versioned `std::` qualification, or that I wasn't sure about. For example, I didn't touch any code in , , , or any ext/ or experimental/ headers; and I didn't touch any instances of `std::type_info`.In some deduction guides, we were accidentally using `class Alloc = typename std::allocator`,despite `std::allocator`'s type-ness not being template-dependent.Because `std::allocator` is a qualified name, this did parse as we intended;but what we meant was simply `class Alloc = allocator`.Differential Revision: https://reviews.llvm.org/D92250 List of files: /llvm-project-15.0.7/libcxx/include/__debug