en Copyright 2015 Java http://172.16.0.5:8080/history/llvm-project-15.0.7/flang/test/Lower/pointer-initial-target-2.f90#2c8cb9ac [flang] Handle common block with different sizes in same fileSemantics is not preventing a named common block to appear withdifferent size in a same file (named common block should always havethe same storage size (see Fortran 2018 8.10.2.5), but it is a commonextension to accept different sizes).Lowering was not coping with this well, since it just use the firstcommon block appearance, starting with BLOCK DATAs to define commonblocks (this also was an issue with the blank common block, which canlegally appear with different size in different scoping units).Semantics is also not preventing named common from being initializedoutside of a BLOCK DATA, and lowering was dealing badly with this,since it only gave an initial value to common blocks Globals if thefirst common block appearance, starting with BLOCK DATAs had an initialvalue.Semantics is also allowing blank common to be initialized, whilelowering was assuming this would never happen, and was never creatingan initial value for it.Lastly, semantics was not complaining if a COMMON block was initializedin several scoping unit in a same file, while lowering can only generateone of these initial value.To fix this, add a structure to keep track of COMMON block properties(biggest size, and initial value if any) at the Program level. Once thesize of a common block appearance is know, the common block appearanceis checked against this information. It allows semantics to emit an errorin case of multiple initialization in different scopes of a same commonblock, and to warn in case named common blocks appears with differentsizes. Lastly, this allows lowering to use the Program level info aboutcommon blocks to emit the right GlobalOp for a Common Block, regardlessof the COMMON Block appearances order: It emits a GlobalOp with thebiggest size, whose lowest bytes are initialized with the initial valueif any is given in a scope where the common block appears.Lowering is updated to go emit the common blocks before anything else sothat the related GlobalOps are available when lowering the scopes wherecommon block appear. It is also updated to not assume that blank commonare never initialized.Differential Revision: https://reviews.llvm.org/D124622 List of files: /llvm-project-15.0.7/flang/test/Lower/pointer-initial-target-2.f90 Fri, 29 Apr 2022 12:52:27 +0000 Jean Perier <jperier@nvidia.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/flang/test/Lower/pointer-initial-target-2.f90#3de6b1ce [flang][NFC] Add pointer dummy arguments testsThis patch adds test for calls with POINTER dummy arguments on the caller side.It also fixes some formatting error that was introduced when upstreamingthe other pointer tests.This patch is part of the upstreaming effort from fir-dev branch.Reviewed By: PeteSteinfeldDifferential Revision: https://reviews.llvm.org/D122238Co-authored-by: Jean Perier <jperier@nvidia.com> List of files: /llvm-project-15.0.7/flang/test/Lower/pointer-initial-target-2.f90 Tue, 22 Mar 2022 19:56:25 +0000 Valentin Clement <clementval@gmail.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/flang/test/Lower/pointer-initial-target-2.f90#a1425019 [flang] Lower more pointer assignments/disassociation casesThis patch lowers more cases of pointer assignments anddisassociations.This patch is part of the upstreaming effort from fir-dev branch.Reviewed By: PeteSteinfeld, schweitzDifferential Revision: https://reviews.llvm.org/D121697Co-authored-by: V Donaldson <vdonaldson@nvidia.com>Co-authored-by: Jean Perier <jperier@nvidia.com>Co-authored-by: mleair <leairmark@gmail.com>Co-authored-by: Eric Schweitz <eschweitz@nvidia.com> List of files: /llvm-project-15.0.7/flang/test/Lower/pointer-initial-target-2.f90 Tue, 15 Mar 2022 20:57:30 +0000 Valentin Clement <clementval@gmail.com>