Changes in tsan_interceptors_libdispatch.cpp

8246b2e1 - [Sanitizers][Darwin] Replace SANITIZER_MAC with SANITIZER_APPLE in source files

Mon, 23 May 2022 21:35:42 +0000

[Sanitizers][Darwin] Replace SANITIZER_MAC with SANITIZER_APPLE in source filesThis is a follow up to [Sanitizers][Darwin] Rename Apple macro SANITIZER_MAC -> SANITIZER_APPLE (D125816)Performed a global search/replace as in title against LLVM sourcesDifferential Revision: https://reviews.llvm.org/D126263 List of files: /llvm-project-15.0.7/compiler-rt/lib/tsan/rtl/tsan_interceptors_libdispatch.cpp

4cefa861 - [TSan][libdispatch] Fix compilation error on Linux

Wed, 02 Sep 2020 18:20:47 +0000

[TSan][libdispatch] Fix compilation error on LinuxThe interceptor for the block variants of the API references thefunction versions (via `REAL(name##_f)`). On Linux, this accesses theunderlying "real pointer", defined by the interceptor macro. So we needto declare interceptors in the right order to avoid undefined symbolcompiler error:```error: no member named 'real_dispatch_async_and_wait_f' in namespace '__tsan::__interception'```rdar://68181542 List of files: /llvm-project-15.0.7/compiler-rt/lib/tsan/rtl/tsan_interceptors_libdispatch.cpp

c1d25e9a - [TSan][libdispatch] Add interceptors for dispatch_barrier_async_and_wait(), pt. 2

Mon, 24 Aug 2020 21:36:18 +0000

[TSan][libdispatch] Add interceptors for dispatch_barrier_async_and_wait(), pt. 2Also intercept these target functions on Linux. List of files: /llvm-project-15.0.7/compiler-rt/lib/tsan/rtl/tsan_interceptors_libdispatch.cpp

fa0a855c - [TSan][libdispatch] Add interceptors for dispatch_barrier_async_and_wait()

Mon, 24 Aug 2020 20:56:22 +0000

[TSan][libdispatch] Add interceptors for dispatch_barrier_async_and_wait()Add interceptors for the barrier variants of the "async and wait"dispatch API family. List of files: /llvm-project-15.0.7/compiler-rt/lib/tsan/rtl/tsan_interceptors_libdispatch.cpp

686fe293 - [TSan][libdispatch] Ensure TSan dylib works on old systems

Mon, 17 Aug 2020 19:41:18 +0000

[TSan][libdispatch] Ensure TSan dylib works on old systems`dispatch_async_and_wait()` was introduced in macOS 10.14, which isgreater than our minimal deployment target. We need to forward declareit as a "weak import" to ensure we generate a weak reference so the TSandylib continues to work on older systems. We cannot simply `#include` or use the Darwin availability macros since this file ismulti-platform.In addition, we want to prevent building these interceptors at all whenbuilding with older SDKs because linking always fails.Before:```➤ dyldinfo -bind ./lib/clang/12.0.0/lib/darwin/libclang_rt.tsan_osx_dynamic.dylib | grep dispatch_async_and_wait__DATA __interpose 0x000F5E68 pointer 0 libSystem _dispatch_async_and_wait_f```After:```➤ dyldinfo -bind ./lib/clang/12.0.0/lib/darwin/libclang_rt.tsan_osx_dynamic.dylib | grep dispatch_async_and_wait__DATA __got 0x000EC0A8 pointer 0 libSystem _dispatch_async_and_wait (weak import)__DATA __interpose 0x000F5E78 pointer 0 libSystem _dispatch_async_and_wait (weak import)```This is a follow-up to D85854 and should fix:https://reviews.llvm.org/D85854#2221529Reviewed By: kubamracekDifferential Revision: https://reviews.llvm.org/D86103 List of files: /llvm-project-15.0.7/compiler-rt/lib/tsan/rtl/tsan_interceptors_libdispatch.cpp

0c4863a2 - Reland "[TSan][libdispatch] Add interceptors for dispatch_async_and_wait()"

Tue, 11 Aug 2020 22:01:20 +0000

Reland "[TSan][libdispatch] Add interceptors for dispatch_async_and_wait()"The linker errors caused by this revision have been addressed.Add interceptors for `dispatch_async_and_wait[_f]()` which was added inmacOS 10.14. This pair of functions is similar to `dispatch_sync()`,but does not force a context switch of the queue onto the caller threadwhen the queue is active (and hence is more efficient). For TSan, wecan apply the same semantics as for `dispatch_sync()`.From the header docs:> Differences with dispatch_sync()>> When the runtime has brought up a thread to invoke the asynchronous> workitems already submitted to the specified queue, that servicing> thread will also be used to execute synchronous work submitted to the> queue with dispatch_async_and_wait().>> However, if the runtime has not brought up a thread to service the> specified queue (because it has no workitems enqueued, or only> synchronous workitems), then dispatch_async_and_wait() will invoke the> workitem on the calling thread, similar to the behaviour of functions> in the dispatch_sync family.Additional context:> The guidance is to use `dispatch_async_and_wait()` instead of> `dispatch_sync()` when it is necessary to mix async and sync calls on> the same queue. `dispatch_async_and_wait()` does not guarantee> execution on the caller thread which allows to reduce context switches> when the target queue is active.> https://gist.github.com/tclementdev/6af616354912b0347cdf6db159c37057rdar://35757961Reviewed By: kubamracekDifferential Revision: https://reviews.llvm.org/D85854 List of files: /llvm-project-15.0.7/compiler-rt/lib/tsan/rtl/tsan_interceptors_libdispatch.cpp

501a078c - Revert "[TSan][libdispatch] Add interceptors for dispatch_async_and_wait()"

Tue, 18 Aug 2020 16:49:05 +0000

Revert "[TSan][libdispatch] Add interceptors for dispatch_async_and_wait()"This reverts commit d137db80297f286f3a19eacc63d4a980646da437.Breaks builds on older SDKs. List of files: /llvm-project-15.0.7/compiler-rt/lib/tsan/rtl/tsan_interceptors_libdispatch.cpp

d137db80 - [TSan][libdispatch] Add interceptors for dispatch_async_and_wait()

Tue, 11 Aug 2020 22:01:20 +0000

[TSan][libdispatch] Add interceptors for dispatch_async_and_wait()Add interceptors for `dispatch_async_and_wait[_f]()` which was added inmacOS 10.14. This pair of functions is similar to `dispatch_sync()`,but does not force a context switch of the queue onto the caller threadwhen the queue is active (and hence is more efficient). For TSan, wecan apply the same semantics as for `dispatch_sync()`.From the header docs:> Differences with dispatch_sync()>> When the runtime has brought up a thread to invoke the asynchronous> workitems already submitted to the specified queue, that servicing> thread will also be used to execute synchronous work submitted to the> queue with dispatch_async_and_wait().>> However, if the runtime has not brought up a thread to service the> specified queue (because it has no workitems enqueued, or only> synchronous workitems), then dispatch_async_and_wait() will invoke the> workitem on the calling thread, similar to the behaviour of functions> in the dispatch_sync family.Additional context:> The guidance is to use `dispatch_async_and_wait()` instead of> `dispatch_sync()` when it is necessary to mix async and sync calls on> the same queue. `dispatch_async_and_wait()` does not guarantee> execution on the caller thread which allows to reduce context switches> when the target queue is active.> https://gist.github.com/tclementdev/6af616354912b0347cdf6db159c37057rdar://35757961Reviewed By: kubamracekDifferential Revision: https://reviews.llvm.org/D85854 List of files: /llvm-project-15.0.7/compiler-rt/lib/tsan/rtl/tsan_interceptors_libdispatch.cpp

def061e6 - [TSan] Rename file with libdispatch interceptors

Tue, 20 Aug 2019 00:04:19 +0000

[TSan] Rename file with libdispatch interceptorsllvm-svn: 369314 List of files: /llvm-project-15.0.7/compiler-rt/lib/tsan/rtl/tsan_interceptors_libdispatch.cpp