en Copyright 2015 Java http://172.16.0.5:8080/history/llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp#036f9630 scudo: fix __attribute__((format))The attribute should be in the header on declaration.It's almost pointless in the source file.Depends on D107977.Reviewed By: vitalybukaDifferential Revision: https://reviews.llvm.org/D107978 List of files: /llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp Thu, 12 Aug 2021 17:59:12 +0000 Dmitry Vyukov <dvyukov@google.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp#85e578f5 [compiler-rt] Replace INLINE with inlineThis fixes the clash with BSD headers.Reviewed By: vitalybukaDifferential Revision: https://reviews.llvm.org/D87562 List of files: /llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp Thu, 17 Sep 2020 14:04:50 +0000 Kamil Rytarowski <n54@gmx.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp#9959eb91 Add vendor identity check for Hygon Dhyana processor in ScudoSummary:The Hygon Dhyana processor supports hardware CRC32.Related link:https://reviews.llvm.org/D78874Result of "make check":Testing Time: 1364.04s Unsupported Tests: 317 Expected Passes : 36802 Expected Failures: 161[100%] Built target check-llvm[100%] Built target checkReviewers: cryptoadReviewed By: cryptoadSubscribers: craig.topper, cryptoad, cfe-commits, #sanitizers, llvm-commitsTags: #clang, #sanitizers, #llvmDifferential Revision: https://reviews.llvm.org/D62368 List of files: /llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp Mon, 11 May 2020 16:16:54 +0000 Kostya Kortchinsky <kostyak@google.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp#2946cd70 Update the file headers across all of the LLVM projects in the monorepoto reflect the new license.We understand that people may be surprised that we're moving the headerentirely to discuss the new license. We checked this carefully with theFoundation's lawyer and we believe this is the correct approach.Essentially, all code in the project is now made available by the LLVMproject under our new license, so you will see that the license headersinclude that license only. Some of our contributors have contributedcode under our old license, and accordingly, we have retained a copy ofour old license notice in the top-level files in each project andrepository.llvm-svn: 351636 List of files: /llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp Sat, 19 Jan 2019 08:50:56 +0000 Chandler Carruth <chandlerc@gmail.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp#2efb847b [scudo] Add some logs for AndroidSummary:Namely, set the abort message, and allow to write the message to syslog if theoption is enabled.Reviewers: alekseyshlReviewed By: alekseyshlSubscribers: delcypher, #sanitizers, llvm-commitsDifferential Revision: https://reviews.llvm.org/D48902llvm-svn: 336445 List of files: /llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp Fri, 06 Jul 2018 16:50:12 +0000 Kostya Kortchinsky <kostyak@google.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp#5a8bdc81 [scudo] Read ARM feature bits using Fuchsia APIs.Summary: Fuchsia uses zx_system_get_features in lieu of getauxval. Use this call when checking for CRC32 support.Reviewers: cryptoadReviewed By: cryptoadSubscribers: delcypher, llvm-commits, #sanitizers, kristof.beyls, chribDifferential Revision: https://reviews.llvm.org/D45896llvm-svn: 330598 List of files: /llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp Mon, 23 Apr 2018 14:53:13 +0000 Kostya Kortchinsky <kostyak@google.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp#e245ec0c [scudo] Make logging more consistentSummary:A few changes related to logging:- prepend `Scudo` to the error messages so that users can identify that we reported an error;- replace a couple of `Report` calls in the RSS check code with `dieWithMessage`/`Print`, mark a condition as `UNLIKELY` in the process;- change some messages so that they all look more or less the same. This includes the `CHECK` message;- adapt a couple of tests with the new strings.A couple of side notes: this results in a few 1-line-blocks, for which I leftbrackets. There doesn't seem to be any style guide for that, I can remove themif need be. I didn't use `SanitizerToolName` in the strings, but directly`Scudo` because we are the only users, I could change that too.Reviewers: alekseyshl, flowerhackReviewed By: alekseyshlSubscribers: mgorny, delcypher, llvm-commits, #sanitizersDifferential Revision: https://reviews.llvm.org/D44171llvm-svn: 326901 List of files: /llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp Wed, 07 Mar 2018 16:22:16 +0000 Kostya Kortchinsky <kostyak@google.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp#06b891f6 [scudo] Workaround for uninitialized Bionic globalsSummary:Bionic doesn't initialize its globals early enough. This causes issues whentrying to access them from a preinit_array (b/25751302) or from anotherconstructor called before the libc one (b/68046352). __progname is initializedafter the other globals, so we can check its value to know if calling`getauxval` is safe.Reviewers: alekseyshlReviewed By: alekseyshlSubscribers: srhines, llvm-commitsDifferential Revision: https://reviews.llvm.org/D40504llvm-svn: 319099 List of files: /llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp Mon, 27 Nov 2017 21:34:43 +0000 Kostya Kortchinsky <kostyak@google.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp#0207b6fb [scudo] Overhaul hardware CRC32 feature detectionSummary:This patch aims at condensing the hardware CRC32 feature detection and makingit slightly more effective on Android.The following changes are included:- remove the `CPUFeature` enum, and get rid of one level of nesting of functions: we only used CRC32, so we just implement and use `hasHardwareCRC32`;- allow for a weak `getauxval`: the Android toolchain is compiled at API level 14 for Android ARM, meaning no `getauxval` at compile time, yet we will run on API level 27+ devices. The `/proc/self/auxv` fallback can work but is worthless for a process like `init` where the proc filesystem doesn't exist yet. If a weak `getauxval` doesn't exist, then fallback.- couple of extra corrections.Reviewers: alekseyshlReviewed By: alekseyshlSubscribers: kubamracek, aemerson, srhines, kristof.beyls, llvm-commitsDifferential Revision: https://reviews.llvm.org/D40322llvm-svn: 318859 List of files: /llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp Wed, 22 Nov 2017 18:30:44 +0000 Kostya Kortchinsky <kostyak@google.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp#36e56785 [scudo] Bump the Android API level requirement to 21 for getauxvalSummary:`getauxval` was introduced in 18 & 21 depending on the architecture. Bump therequirement to 21.It also turns out that the NDK is finicky: NDK r13b doesn't include sys/auxv.hwhen creating a standalone toolchain at API level 19 for ARM. So 18 didn't workwell with older NDKs.Reviewers: alekseyshlReviewed By: alekseyshlSubscribers: aemerson, srhines, llvm-commits, kristof.beylsDifferential Revision: https://reviews.llvm.org/D39905llvm-svn: 317907 List of files: /llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp Fri, 10 Nov 2017 19:01:17 +0000 Kostya Kortchinsky <kostyak@google.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp#6edadae3 [sanitizer] Add Scudo to the sanitizer lint checks.Summary:Scudo abides by the coding style enforced by the sanitizer_commonlinter, but as of right now, it's not linter-enforced.Add Scudo to the list of directories checked by check_lint.sh.Also: fixes some linter errors found after getting this running.Reviewers: cryptoadReviewed By: cryptoadSubscribers: llvm-commits, kubamracekDifferential Revision: https://reviews.llvm.org/D39757llvm-svn: 317699 List of files: /llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp Wed, 08 Nov 2017 16:42:29 +0000 Kostya Kortchinsky <kostyak@google.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp#73a80c54 [scudo] Do not include sanitizer_posix.h if not on a Posix platformSummary:Move the `sanitizer_posix.h` include within the `SANITIZER_ANDROID` `#if`,otherwise this errors when built on non-Posix platforms (eg: Fuchsia).Reviewers: alekseyshlReviewed By: alekseyshlSubscribers: llvm-commitsDifferential Revision: https://reviews.llvm.org/D38956llvm-svn: 315917 List of files: /llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp Mon, 16 Oct 2017 17:06:13 +0000 Kostya Kortchinsky <kostyak@google.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp#6bc7b26d [scudo] getauxval alternative for AndroidSummary:`getauxval` was introduced with API level 18. In order to get things to workat lower API levels (for the toolchain itself which is built at 14 for 32-bit),we introduce an alternative implementation reading directly from`/proc/self/auxv`.Reviewers: alekseyshlReviewed By: alekseyshlSubscribers: srhines, llvm-commitsDifferential Revision: https://reviews.llvm.org/D37488llvm-svn: 312653 List of files: /llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp Wed, 06 Sep 2017 17:51:32 +0000 Kostya Kortchinsky <kostyak@google.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp#00582563 [scudo] PRNG makeoverSummary:This follows the addition of `GetRandom` with D34412. We remove our`/dev/urandom` code and use the new function. Additionally, change the PRNG fora slightly faster version. One of the issues with the old code is that we have64 full bits of randomness per "next", using only 8 of those for the Salt anddiscarding the rest. So we add a cached u64 in the PRNG that can serve up to8 u8 before having to call the "next" function again.During some integration work, I also realized that some very early processes(like `init`) do not benefit from `/dev/urandom` yet. So if there is no`getrandom` syscall as well, we have to fallback to some sort of initializationof the PRNG.Now a few words on why XoRoShiRo and not something else. I have played a whilewith various PRNGs on 32 & 64 bit platforms. Some results are below. LCG 32 & 64are usually faster but produce respectively 15 & 31 bits of entropy, meaningthat to get a full 64-bit, you would need to call them several times. The simpleXorShift is fast, produces 32 bits but is mediocre with regard to PRNG testsuites, PCG is slower overall, and XoRoShiRo is faster than XorShift128+ andproduces full 64 bits.%%%root@tulip-chiphd:/data # ./randtest.arm[+] starting xs32...[?] xs32 duration: 22431833053ns[+] starting lcg32...[?] lcg32 duration: 14941402090ns[+] starting pcg32...[?] pcg32 duration: 44941973771ns[+] starting xs128p...[?] xs128p duration: 48889786981ns[+] starting lcg64...[?] lcg64 duration: 33831042391ns[+] starting xos128p...[?] xos128p duration: 44850878605nsroot@tulip-chiphd:/data # ./randtest.aarch64[+] starting xs32...[?] xs32 duration: 22425151678ns[+] starting lcg32...[?] lcg32 duration: 14954255257ns[+] starting pcg32...[?] pcg32 duration: 37346265726ns[+] starting xs128p...[?] xs128p duration: 22523807219ns[+] starting lcg64...[?] lcg64 duration: 26141304679ns[+] starting xos128p...[?] xos128p duration: 14937033215ns%%%Reviewers: alekseyshlReviewed By: alekseyshlSubscribers: aemerson, kristof.beyls, llvm-commitsDifferential Revision: https://reviews.llvm.org/D35221llvm-svn: 307798 List of files: /llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp Wed, 12 Jul 2017 15:29:08 +0000 Kostya Kortchinsky <kostyak@google.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp#36b34341 [scudo] Move thread local variables into their own filesSummary:This change introduces scudo_tls.h & scudo_tls_linux.cpp, where we move thethread local variables used by the allocator, namely the cache, quarantinecache & prng. `ScudoThreadContext` will hold those. This patch doesn'tintroduce any new platform support yet, this will be the object of a laterpatch. This also changes the PRNG so that the structure can be POD.Reviewers: kcc, dvyukov, alekseyshlReviewed By: dvyukov, alekseyshlSubscribers: llvm-commits, mgornyDifferential Revision: https://reviews.llvm.org/D32440llvm-svn: 301584 List of files: /llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp Thu, 27 Apr 2017 20:21:16 +0000 Kostya Kortchinsky <kostyak@google.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp#006805d1 [scudo] Minor changes and refactoringSummary:This is part of D31947 that is being split into several smaller changes.This one deals with all the minor changes, more specifically:- Rename some variables and functions to make their purpose clearer;- Reorder some code;- Mark the hot termination incurring checks as `UNLIKELY`; if they happen, the program will die anyway;- Add a `getScudoChunk` method;- Add an `eraseHeader` method to ScudoChunk that will clear a header with 0s;- Add a parameter to `allocate` to know if the allocated chunk should be filled with zeros. This allows `calloc` to not have to call `GetActuallyAllocatedSize`; more changes to get rid of this function on the hot paths will follow;- reallocate was missing a check to verify that the pointer is properly aligned on `MinAlignment`;- The `Stats` in the secondary have to be protected by a mutex as the `Add` and `Sub` methods are actually not atomic;- The software CRC32 function was moved to the header to allow for inlining.Reviewers: dvyukov, alekseyshl, kccReviewed By: dvyukovSubscribers: llvm-commitsDifferential Revision: https://reviews.llvm.org/D32242llvm-svn: 300846 List of files: /llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp Thu, 20 Apr 2017 15:11:00 +0000 Kostya Kortchinsky <kostyak@google.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp#b39dff45 [scudo] Refactor of CRC32 and ARM runtime CRC32 detectionSummary:ARM & AArch64 runtime detection for hardware support of CRC32 has been addedvia check of the AT_HWVAL auxiliary vector.Following Michal's suggestions in D28417, the CRC32 code has been furtherchanged and looks better now. When compiled with full relro (which is stronglysuggested to benefit from additional hardening), the weak symbol forcomputeHardwareCRC32 is read-only and the assembly generated is fairly cleanand straight forward. As suggested, an additional optimization is to skipthe runtime check if SSE 4.2 has been enabled globally, as opposed to onlyfor scudo_crc32.cpp.scudo_crc32.h has no purpose anymore and was removed.Reviewers: alekseyshl, kcc, rengolin, mgorny, phosekReviewed By: rengolin, mgornySubscribers: aemerson, rengolin, llvm-commitsDifferential Revision: https://reviews.llvm.org/D28574llvm-svn: 292409 List of files: /llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp Wed, 18 Jan 2017 17:11:17 +0000 Kostya Kortchinsky <kostyak@google.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp#97ab7fe6 [scudo] Eliminate the runtime dependency on libc++abiMaking this variable non-static avoids the need for locking to ensurethat the initialization is thread-safe which in turns eliminates theruntime dependency on libc++abi library (for __cxa_guard_acquire and__cxa_guard_release) which makes it possible to link scudo againstpure C programs.Differential Revision: https://reviews.llvm.org/D28757llvm-svn: 292253 List of files: /llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp Tue, 17 Jan 2017 20:41:04 +0000 Petr Hosek <phosek@chromium.org> http://172.16.0.5:8080/history/llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp#c4d6c938 [scudo] Separate hardware CRC32 routinesSummary:As raised in D28304, enabling SSE 4.2 for the whole Scudo tree leads to theemission of SSE 4.2 instructions everywhere, while the runtime checks onlyapplied to the CRC32 computing function.This patch separates the CRC32 function taking advantage of the hardware intoits own file, and only enabled -msse4.2 for that file, if detected to besupported by the compiler.Another consequence of removing SSE4.2 globally is realizing that memcpy werenot being optimized, which turned out to be due to the -fno-builtin inSANITIZER_COMMON_CFLAGS. So we now explicitely enable builtins for Scudo.The resulting assembly looks good, with some CALLs are introduced instead ofthe CRC32 code being inlined.Reviewers: kcc, mgorny, alekseyshlSubscribers: llvm-commitsDifferential Revision: https://reviews.llvm.org/D28417llvm-svn: 291570 List of files: /llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp Tue, 10 Jan 2017 16:39:36 +0000 Kostya Kortchinsky <kostyak@google.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp#2defe4d9 [sanitizer] Do not use the alignment-rounded-up size when using the secondarySummary:The combined allocator rounds up the requested size with regard to thealignment, which makes sense when being serviced by the primary as it comeswith alignment guarantees, but not with the secondary. For the rare case oflarge alignments, it wastes memory, and entices unnecessarily large fields forthe Scudo header. With this patch, we pass the non-alignement-rounded-up sizeto the secondary, and adapt the Scudo code for this change.Reviewers: alekseyshl, kccSubscribers: llvm-commits, kubabreckaDifferential Revision: https://reviews.llvm.org/D27428llvm-svn: 289088 List of files: /llvm-project-15.0.7/compiler-rt/lib/scudo/scudo_utils.cpp Thu, 08 Dec 2016 19:05:46 +0000 Kostya Kortchinsky <kostyak@google.com>