Changes in resolve-single-template-id.cpp

ad14b5b0 - [clang] Stop providing builtin overload candidate for relational function pointer comparisons

Tue, 22 Jun 2021 01:48:51 +0000

[clang] Stop providing builtin overload candidate for relational function pointer comparisonsWord on the grapevine was that the committee had some discussion thatended with unanimous agreement on eliminating relational function pointer comparisons.We wanted to be bold and just ban all of them cold turkey.But then we chickened out at the last second and are going foreliminating just the spaceship overload candidate instead, for now.See D104680 for reference.This should be fine and "safe", because the only possible semantic change thiswould cause is that overload resolution could possibly be ambiguous ifthere was another viable candidate equally as good.But to save face a little we are going to:* Issue an "error" for three-way comparisons on function pointers. But all this is doing really is changing one vague error message, from an "invalid operands to binary expression" into an "ordered comparison of function pointers", which sounds more like we mean business.* Otherwise "warn" that comparing function pointers like that is totally not cool (unless we are told to keep quiet about this).Signed-off-by: Matheus Izvekov Reviewed By: rsmithDifferential Revision: https://reviews.llvm.org/D104892 List of files: /llvm-project-15.0.7/clang/test/SemaTemplate/resolve-single-template-id.cpp

07ed9cfc - Fix crash and rejects-valid when a later template parameter or default

Thu, 20 Jun 2019 19:49:13 +0000

Fix crash and rejects-valid when a later template parameter or defaulttemplate argument contains a backreference to a dependently-typedearlier parameter.In a case like: template struct X {}; template auto Y = X();we previously treated both references to `A` in the third parameter asbeing of type `int` when checking the template-id in `Y`. That`s wrong;the type of `A` in these contexts is the dependent type `U`.When we encounter a non-type template argument that we can't convert tothe parameter type because of type-dependence, we now insert a dependentconversion node so that the SubstNonTypeTemplateParmExpr for thetemplate argument will have the parameter's type rather than whatevertype the argument had.llvm-svn: 363972 List of files: /llvm-project-15.0.7/clang/test/SemaTemplate/resolve-single-template-id.cpp

99e1c951 - Move the warning about unused relational comparison from -Wunused-value to

Tue, 11 Mar 2014 03:11:08 +0000

Move the warning about unused relational comparison from -Wunused-value to-Wunused-comparison. Also, newly warn on unused result from overloadedrelational comparisons, now also in -Wunused-comparison.llvm-svn: 203535 List of files: /llvm-project-15.0.7/clang/test/SemaTemplate/resolve-single-template-id.cpp

3bb8b56a - PR16074, implement warnings to catch pointer to boolean true and pointer to

Wed, 26 Feb 2014 02:36:06 +0000

PR16074, implement warnings to catch pointer to boolean true and pointer tonull comparison when the pointer is known to be non-null.This catches the array to pointer decay, function to pointer decay andaddress of variables. This does not catch address of function since thishas been previously used to silence a warning.Pointer to bool conversion is under -Wbool-conversion.Pointer to null comparison is under -Wtautological-pointer-compare, a sub-groupof -Wtautological-compare.void foo() { int arr[5]; int x; // warn on these conditionals if (foo); if (arr); if (&x); if (foo == null); if (arr == null); if (&x == null); if (&foo); // no warning}llvm-svn: 202216 List of files: /llvm-project-15.0.7/clang/test/SemaTemplate/resolve-single-template-id.cpp

4e28b265 - sizeof(void) etc. should be a hard error in C++.

Tue, 13 Aug 2013 22:26:42 +0000

sizeof(void) etc. should be a hard error in C++.PR16872.llvm-svn: 188324 List of files: /llvm-project-15.0.7/clang/test/SemaTemplate/resolve-single-template-id.cpp

6df859d8 - Bound member function diagnostic - suggest no-args calls and note overload candidates

Tue, 04 Jun 2013 00:28:46 +0000

Bound member function diagnostic - suggest no-args calls and note overload candidatesStill missing cases for templates, but this is a step in the rightdirection. Also omits suggestions that would be ambiguous (eg: voidfunc(int = 0); + void func(float = 0); func;)llvm-svn: 183173 List of files: /llvm-project-15.0.7/clang/test/SemaTemplate/resolve-single-template-id.cpp

10eb4b67 - Add notes for suppressing and (if it's a zero-arg function returning bool) fixing the function-to-bool conversion warning.

Fri, 09 Dec 2011 21:42:37 +0000

Add notes for suppressing and (if it's a zero-arg function returning bool) fixing the function-to-bool conversion warning.llvm-svn: 146280 List of files: /llvm-project-15.0.7/clang/test/SemaTemplate/resolve-single-template-id.cpp

df5c121f - Add a warning for implicit conversion from function literals (and static

Mon, 05 Dec 2011 20:49:50 +0000

Add a warning for implicit conversion from function literals (and staticmethods) to bool. E.g.void foo() {}if (f) { ... // <- Warns here.}Only applies to non-weak functions, and does not apply if the function addressis taken explicitly with the addr-of operator.llvm-svn: 145849 List of files: /llvm-project-15.0.7/clang/test/SemaTemplate/resolve-single-template-id.cpp

9ca5c425 - Update all tests other than Driver/std.cpp to use -std=c++11 rather than

Thu, 13 Oct 2011 22:29:44 +0000

Update all tests other than Driver/std.cpp to use -std=c++11 rather than-std=c++0x. Patch by Ahmed Charles!llvm-svn: 141900 List of files: /llvm-project-15.0.7/clang/test/SemaTemplate/resolve-single-template-id.cpp

50a2c2c1 - Catch placeholder types in DefaultLvalueConversion

Tue, 11 Oct 2011 23:14:30 +0000

Catch placeholder types in DefaultLvalueConversionand DefaultFunctionArrayLvalueConversion. To preventsignificant regression for should-this-be-a-call fixits,and to repair some such regression from the introduction ofbound member placeholders, make those placeholder checkstry to build calls appropriately. Harden the build-a-calllogic while we're at it.llvm-svn: 141738 List of files: /llvm-project-15.0.7/clang/test/SemaTemplate/resolve-single-template-id.cpp

e2669397 - Treating the unused equality comparisons as something other than part of

Wed, 17 Aug 2011 09:34:37 +0000

Treating the unused equality comparisons as something other than part of-Wunused was a mistake. It resulted in duplicate warnings and lots ofother hacks. Instead, this should be a special sub-category to-Wunused-value, much like -Wunused-result is.Moved to -Wunused-comparison, moved the implementation to piggy back onthe -Wunused-value implementation instead of rolling its own, differentmechanism for catching all of the "interesting" statements.I like the unused-value mechanism for this better, but its currentlymissing several top-level statements. For now, I've FIXME-ed out thosetest cases. I'll enhance the generic infrastructure to catch thesestatements in a subsequent patch.This patch also removes the cast-to-void fixit hint. This hint isn'tavailable on any of the other -Wunused-value diagnostics, and if we wantit to be, we should add it generically rather than in one specific case.llvm-svn: 137822 List of files: /llvm-project-15.0.7/clang/test/SemaTemplate/resolve-single-template-id.cpp

3aef3d87 - Simplify calling CheckPlaceholderExpr, converge on it in a few places,

Sun, 10 Apr 2011 19:13:55 +0000

Simplify calling CheckPlaceholderExpr, converge on it in a few places,and move a vector-splat check to follow l-value conversion.llvm-svn: 129254 List of files: /llvm-project-15.0.7/clang/test/SemaTemplate/resolve-single-template-id.cpp

31996343 - Basic, untested implementation for an "unknown any" type requested by LLDB.

Thu, 07 Apr 2011 08:22:57 +0000

Basic, untested implementation for an "unknown any" type requested by LLDB.The idea is that you can create a VarDecl with an unknown type, or aFunctionDecl with an unknown return type, and it will still be valid toaccess that object as long as you explicitly cast it at every use. I'mstill going back and forth about how I want to test this effectively, butI wanted to go ahead and provide a skeletal implementation for the LLDBfolks' benefit and because it also improves some diagnostic goodness forplaceholder expressions.llvm-svn: 129065 List of files: /llvm-project-15.0.7/clang/test/SemaTemplate/resolve-single-template-id.cpp

89f3cd5c - Clean up our handling of template-ids that resolve down to a single

Wed, 16 Mar 2011 19:16:25 +0000

Clean up our handling of template-ids that resolve down to a singleoverload, so that we actually do the resolution for full expressionsand emit more consistent, useful diagnostics. Also fixes an IRGencrasher, where Sema wouldn't diagnose a resolvable bound memberfunction template-id used in a full-expression ().llvm-svn: 127747 List of files: /llvm-project-15.0.7/clang/test/SemaTemplate/resolve-single-template-id.cpp