Changes in weak-init.cpp

76476efd - Rewording "static_assert" diagnostics

Mon, 25 Jul 2022 11:22:54 +0000

Rewording "static_assert" diagnosticsThis patch rewords the static assert diagnostic output. Failing a_Static_assert in C should not report that static_assert failed. Thischanges the wording to be more like GCC and uses "static assertion"when possible instead of hard coding the name. This also changes someinstances of 'static_assert' to instead be based on the token in thesource code.Differential Revision: https://reviews.llvm.org/D129048 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/weak-init.cpp

1da31190 - Revert "Rewording the "static_assert" to static assertion"

Thu, 21 Jul 2022 13:39:22 +0000

Revert "Rewording the "static_assert" to static assertion"Looks like we again are going to have problems with libcxx tests thatare overly specific in their dependency on clang's diagnostics.This reverts commit 6542cb55a3eb115b1c3592514590a19987ffc498. List of files: /llvm-project-15.0.7/clang/test/SemaCXX/weak-init.cpp

6542cb55 - Rewording the "static_assert" to static assertion

Thu, 21 Jul 2022 13:32:54 +0000

Rewording the "static_assert" to static assertionThis patch is basically the rewording of the static assert statement'soutput(error) on screen after failing. Failing a _Static_assert in Cshould not report that static_assert failed. It’d probably be better toreword the diagnostic to be more like GCC and say “static assertion”failed in both C and C++.consider a c file having code_Static_assert(0, "oh no!");In clang the output is like::1:1: error: static_assert failed: oh no!_Static_assert(0, "oh no!");^ ~1 error generated.Compiler returned: 1Thus here the "static_assert" is not much good, it will be better toreword it to the "static assertion failed" to more generic. as the gccprints as::1:1: error: static assertion failed: "oh no!" 1 | _Static_assert(0, "oh no!"); | ^~~~~~~~~~~~~~ Compiler returned: 1The above can also be seen here. This patch is about rewordingthe static_assert to static assertion.Differential Revision: https://reviews.llvm.org/D129048 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/weak-init.cpp

041d4012 - Revert "Rewording "static_assert" diagnostics"

Thu, 14 Jul 2022 17:52:43 +0000

Revert "Rewording "static_assert" diagnostics"This reverts commit b7e77ff25fb2412f6ab6d6cc756666b0e2f97bd3.Reason: Broke sanitizer builds bots + libcxx. 'static assertionexpression is not an integral constant expression'. More detailsavailable in the Phabricator review: https://reviews.llvm.org/D129048 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/weak-init.cpp

b7e77ff2 - Rewording "static_assert" diagnostics

Thu, 14 Jul 2022 11:44:51 +0000

86f9cf88 - [clang] Add tests for (const) weak variables

Fri, 27 May 2022 23:21:16 +0000

[clang] Add tests for (const) weak variablesThis adds tests checking the behavior of const variables declared withweak attribute.Both checking that they can not be used in places where a constantexpression is required and that a dynamic initializer is emitted whenused as an initializer expression.Differential Revision: https://reviews.llvm.org/D126578 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/weak-init.cpp