Changes in warn-unused-but-set-variables-cpp.cpp

2af845a6 - Relands "[Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators"

Thu, 24 Mar 2022 09:32:57 +0000

Relands "[Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators" List of files: /llvm-project-15.0.7/clang/test/SemaCXX/warn-unused-but-set-variables-cpp.cpp

5b6b8405 - Revert "[Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators"

Thu, 24 Mar 2022 06:43:24 +0000

Revert "[Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators"This reverts commit 460fc440ad8d41ca2e3882987512989b1c188fbe. List of files: /llvm-project-15.0.7/clang/test/SemaCXX/warn-unused-but-set-variables-cpp.cpp

460fc440 - [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators

Wed, 23 Mar 2022 21:03:57 +0000

[Clang] -Wunused-but-set-variable warning - handle also pre/post unary operatorsClang fails to diagnose:```void test() { int j = 0; for (int i = 0; i < 1000; i++) j++; return;}```Reason: Missing support for UnaryOperator.We should not warn with volatile variables... so add check for it.Reviewed By: efriedmaDifferential Revision: https://reviews.llvm.org/D122271 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/warn-unused-but-set-variables-cpp.cpp

b5b9489b - Only consider built-in compound assignment operators for -Wunused-but-set-*

Mon, 14 Jun 2021 05:57:22 +0000

Only consider built-in compound assignment operators for -Wunused-but-set-*At least LibreOffice has, for mainly historic reasons that would be hard tochange now, a class Any with an overloaded operator >>= that semantically doesnot assign to the LHS but rather extracts into the (by-reference) RHS. Whichthus caused false positive -Wunused-but-set-parameter and-Wunused-but-set-variable after those have been introduced recently.This change is more conservative about the assumed semantics of overloadedoperators, excluding compound assignment operators but keeping plain operator =ones. At least for LibreOffice, that strikes a good balance of not producingfalse positives but still finding lots of true ones.(The change to the BinaryOperator case in MaybeDecrementCount is necessarybecause e.g. the template f4 test code in warn-unused-but-set-variables-cpp.cppturns the += into a BinaryOperator.)Differential Revision: https://reviews.llvm.org/D103949 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/warn-unused-but-set-variables-cpp.cpp

cf49cae2 - [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

Tue, 01 Jun 2021 21:49:34 +0000

[Clang] -Wunused-but-set-parameter and -Wunused-but-set-variableThese are intended to mimic warnings available in gcc.Differential Revision: https://reviews.llvm.org/D100581 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/warn-unused-but-set-variables-cpp.cpp

14dfb383 - [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

Mon, 17 May 2021 17:50:25 +0000

[Clang] -Wunused-but-set-parameter and -Wunused-but-set-variableThese are intended to mimic warnings available in gcc.Reviewed By: aeubanksDifferential Revision: https://reviews.llvm.org/D100581 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/warn-unused-but-set-variables-cpp.cpp

9b0501ab - [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

Mon, 26 Apr 2021 20:53:21 +0000

[Clang] -Wunused-but-set-parameter and -Wunused-but-set-variableThese are intended to mimic warnings available in gcc.-Wunused-but-set-variable is triggered in the case of a variable whichappears on the LHS of an assignment but not otherwise used.For instance: void f() { int x; x = 0; }-Wunused-but-set-parameter works similarly, but for function parametersinstead of variables.In C++, they are triggered only for scalar types; otherwise, they aretriggered for all types. This is gcc's behavior.-Wunused-but-set-parameter is controlled by -Wextra, while-Wunused-but-set-variable is controlled by -Wunused. This is slightlydifferent from gcc's behavior, but seems most consistent with clang'sbehavior for -Wunused-parameter and -Wunused-variable.Reviewed By: aeubanksDifferential Revision: https://reviews.llvm.org/D100581 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/warn-unused-but-set-variables-cpp.cpp