en Copyright 2015 Java http://172.16.0.5:8080/history/llvm-project-15.0.7/clang/test/SemaCXX/warn-assignment-condition.cpp#db2630fb Unrevert r166268, reverted in r166272, with a fix for the issue which Nickfound: if an overloaded operator& is present before a template definition,the expression &T::foo is represented as a CXXOperatorCallExpr, not as aUnaryOperator, so we didn't notice that it's permitted to reference a non-staticdata member of an unrelated class.While investigating this, I discovered another problem in this area: we aretreating template default arguments as unevaluated contexts during substitution,resulting in performing incorrect checks for uses of non-static data members inC++11. That is not fixed by this patch (I'll look into this soon; it's relatedto the failure to correctly instantiate constexpr function templates), but wasresulting in this bug not firing in C++11 mode (except with -Wc++98-compat).Original message:PR14124: When performing template instantiation of a qualified-id outside of aclass, diagnose if the qualified-id instantiates to a non-static class member.llvm-svn: 166385 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/warn-assignment-condition.cpp Sun, 21 Oct 2012 03:28:35 +0000 Richard Smith <richard-llvm@metafoo.co.uk> http://172.16.0.5:8080/history/llvm-project-15.0.7/clang/test/SemaCXX/warn-assignment-condition.cpp#2e3b7169 Revert r166268, this fix for a crash-on-invalid introduced a rejects-valid.Richard has an unreduced testcase to work with.llvm-svn: 166272 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/warn-assignment-condition.cpp Fri, 19 Oct 2012 08:08:02 +0000 Nick Lewycky <nicholas@mxc.ca> http://172.16.0.5:8080/history/llvm-project-15.0.7/clang/test/SemaCXX/warn-assignment-condition.cpp#b2d6df5c PR14124: When performing template instantiation of a qualified-id outside of aclass, diagnose if the qualified-id instantiates to a non-static class member.llvm-svn: 166268 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/warn-assignment-condition.cpp Fri, 19 Oct 2012 06:32:17 +0000 Richard Smith <richard-llvm@metafoo.co.uk> http://172.16.0.5:8080/history/llvm-project-15.0.7/clang/test/SemaCXX/warn-assignment-condition.cpp#99c0966f Place 'equality comparison with extraneous parentheses...' into a subgroup of -Wparentheses called -Wparentheses-equality.llvm-svn: 139180 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/warn-assignment-condition.cpp Tue, 06 Sep 2011 20:58:32 +0000 Ted Kremenek <kremenek@apple.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/clang/test/SemaCXX/warn-assignment-condition.cpp#ba699d61 Don't do the checks of Sema::DiagnoseEqualityWithExtraParens() on type-dependent expressions. Fixes rdar://9027658.llvm-svn: 128437 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/warn-assignment-condition.cpp Mon, 28 Mar 2011 23:52:04 +0000 Argyrios Kyrtzidis <akyrtzi@gmail.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/clang/test/SemaCXX/warn-assignment-condition.cpp#ae022096 Remove redundant check to not warn for warn_equality_with_extra_parens if we are in a macro. This is checked twice.llvm-svn: 124714 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/warn-assignment-condition.cpp Wed, 02 Feb 2011 02:20:30 +0000 Ted Kremenek <kremenek@apple.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/clang/test/SemaCXX/warn-assignment-condition.cpp#c358d9f3 Don't warn about extraneous '()' around a comparison if it occurs within a macro.Macros frequently contain extra '()' to make instantiation less error prone.This warning was flagging a ton of times on postgresql because of its use of macros.llvm-svn: 124695 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/warn-assignment-condition.cpp Tue, 01 Feb 2011 22:36:09 +0000 Ted Kremenek <kremenek@apple.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/clang/test/SemaCXX/warn-assignment-condition.cpp#f4f8278c Don't warn for "if ((a == b))" if the parens came from a macro. Thanks to Fariborz for the hint!llvm-svn: 124689 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/warn-assignment-condition.cpp Tue, 01 Feb 2011 22:23:56 +0000 Argyrios Kyrtzidis <akyrtzi@gmail.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/clang/test/SemaCXX/warn-assignment-condition.cpp#582dd685 For "if ((a == b))" only warn if 'a' is a modifiable l-value. Caught by John!llvm-svn: 124675 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/warn-assignment-condition.cpp Tue, 01 Feb 2011 19:32:59 +0000 Argyrios Kyrtzidis <akyrtzi@gmail.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/clang/test/SemaCXX/warn-assignment-condition.cpp#8b6ec687 Warn for "if ((a == b))" where the equality expression is needlessly wrapped inside parentheses.It's highly likely that the user intended an assignment used as condition.Addresses rdar://8848646.llvm-svn: 124668 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/warn-assignment-condition.cpp Tue, 01 Feb 2011 18:24:22 +0000 Argyrios Kyrtzidis <akyrtzi@gmail.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/clang/test/SemaCXX/warn-assignment-condition.cpp#2d4f64f4 Warn about the use of unparenthesized |= in conditionals (which may bea typo for !=). Fixes PR9001, from Hans Wennborg!llvm-svn: 123836 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/warn-assignment-condition.cpp Wed, 19 Jan 2011 16:50:08 +0000 Douglas Gregor <dgregor@apple.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/clang/test/SemaCXX/warn-assignment-condition.cpp#2bf2d3d0 When diagnosing suspicious precedence or assignments, move the fix-itthat adds parentheses from the main diagnostic down to a newnote. This way, when the fix-it represents a choice between twooptions, each of the options is associted with a note. There is nodefault option in such cases. For example:/Users/dgregor/t.c:2:9: warning: & has lower precedence than ==; ==will be evaluated first [-Wparentheses] if (x & y == 0) { ^~~~~~~~/Users/dgregor/t.c:2:9: note: place parentheses around the &expression to evaluate it first if (x & y == 0) { ^ ( )/Users/dgregor/t.c:2:9: note: place parentheses around the ==expression to silence this warning if (x & y == 0) { ^ ( )llvm-svn: 101249 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/warn-assignment-condition.cpp Wed, 14 Apr 2010 16:09:52 +0000 Douglas Gregor <dgregor@apple.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/clang/test/SemaCXX/warn-assignment-condition.cpp#fa1e36d0 Improve the fix-its for -Wparentheses to ensure that the fix-itsuggestions follow recovery. Additionally, add a note to thesediagnostics which suggests a fix-it for changing the behavior to whatthe user probably meant. Examples:t.cpp:2:9: warning: & has lower precedence than ==; == will be evaluated first [-Wparentheses] if (i & j == k) { ^~~~~~~~ ( )t.cpp:2:9: note: place parentheses around the & expression to evaluate it first if (i & j == k) { ^ ( )t.cpp:14:9: warning: using the result of an assignment as a conditionwithout parentheses [-Wparentheses] if (i = f()) { ~~^~~~~ ( )t.cpp:14:9: note: use '==' to turn this assignment into an equalitycomparison if (i = f()) { ^ ==llvm-svn: 92975 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/warn-assignment-condition.cpp Fri, 08 Jan 2010 00:20:23 +0000 Douglas Gregor <dgregor@apple.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/clang/test/SemaCXX/warn-assignment-condition.cpp#8fbe78f6 Update tests to use %clang_cc1 instead of 'clang-cc' or 'clang -cc1'. - This is designed to make it obvious that %clang_cc1 is a "test variable" which is substituted. It is '%clang_cc1' instead of '%clang -cc1' because it can be useful to redefine what gets run as 'clang -cc1' (for example, to set a default target).llvm-svn: 91446 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/warn-assignment-condition.cpp Tue, 15 Dec 2009 20:14:24 +0000 Daniel Dunbar <daniel@zuster.org> http://172.16.0.5:8080/history/llvm-project-15.0.7/clang/test/SemaCXX/warn-assignment-condition.cpp#d5707abd Implement -Wparentheses: warn about using assignments in contexts that requireconditions. Add a fixit to insert the parentheses. Also fix a very minorpossible memory leak in 'for' conditions.Fixes PR 4876 and rdar://problem/7289172llvm-svn: 83907 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/warn-assignment-condition.cpp Mon, 12 Oct 2009 21:59:07 +0000 John McCall <rjmccall@apple.com>