Changes in static-cast.cpp

888673b6 - Revert "[clang] Implement ElaboratedType sugaring for types written bare"

Fri, 15 Jul 2022 04:13:57 +0000

Revert "[clang] Implement ElaboratedType sugaring for types written bare"This reverts commit 7c51f02effdbd0d5e12bfd26f9c3b2ab5687c93f because itstills breaks the LLDB tests. This was re-landed without addressing theissue or even agreement on how to address the issue. More details anddiscussion in https://reviews.llvm.org/D112374. List of files: /llvm-project-15.0.7/clang/test/SemaCXX/static-cast.cpp

7c51f02e - [clang] Implement ElaboratedType sugaring for types written bare

Mon, 11 Oct 2021 16:15:36 +0000

[clang] Implement ElaboratedType sugaring for types written bareWithout this patch, clang will not wrap in an ElaboratedType node types writtenwithout a keyword and nested name qualifier, which goes against the intent thatwe should produce an AST which retains enough details to recover how things arewritten.The lack of this sugar is incompatible with the intent of the type printerdefault policy, which is to print types as written, but to fall back and printthem fully qualified when they are desugared.An ElaboratedTypeLoc without keyword / NNS uses no storage by itself, but stillrequires pointer alignment due to pre-existing bug in the TypeLoc bufferhandling.---Troubleshooting list to deal with any breakage seen with this patch:1) The most likely effect one would see by this patch is a change in how a type is printed. The type printer will, by design and default, print types as written. There are customization options there, but not that many, and they mainly apply to how to print a type that we somehow failed to track how it was written. This patch fixes a problem where we failed to distinguish between a type that was written without any elaborated-type qualifiers, such as a 'struct'/'class' tags and name spacifiers such as 'std::', and one that has been stripped of any 'metadata' that identifies such, the so called canonical types. Example: ``` namespace foo { struct A {}; A a; }; ``` If one were to print the type of `foo::a`, prior to this patch, this would result in `foo::A`. This is how the type printer would have, by default, printed the canonical type of A as well. As soon as you add any name qualifiers to A, the type printer would suddenly start accurately printing the type as written. This patch will make it print it accurately even when written without qualifiers, so we will just print `A` for the initial example, as the user did not really write that `foo::` namespace qualifier.2) This patch could expose a bug in some AST matcher. Matching types is harder to get right when there is sugar involved. For example, if you want to match a type against being a pointer to some type A, then you have to account for getting a type that is sugar for a pointer to A, or being a pointer to sugar to A, or both! Usually you would get the second part wrong, and this would work for a very simple test where you don't use any name qualifiers, but you would discover is broken when you do. The usual fix is to either use the matcher which strips sugar, which is annoying to use as for example if you match an N level pointer, you have to put N+1 such matchers in there, beginning to end and between all those levels. But in a lot of cases, if the property you want to match is present in the canonical type, it's easier and faster to just match on that... This goes with what is said in 1), if you want to match against the name of a type, and you want the name string to be something stable, perhaps matching on the name of the canonical type is the better choice.3) This patch could exposed a bug in how you get the source range of some TypeLoc. For some reason, a lot of code is using getLocalSourceRange(), which only looks at the given TypeLoc node. This patch introduces a new, and more common TypeLoc node which contains no source locations on itself. This is not an inovation here, and some other, more rare TypeLoc nodes could also have this property, but if you use getLocalSourceRange on them, it's not going to return any valid locations, because it doesn't have any. The right fix here is to always use getSourceRange() or getBeginLoc/getEndLoc which will dive into the inner TypeLoc to get the source range if it doesn't find it on the top level one. You can use getLocalSourceRange if you are really into micro-optimizations and you have some outside knowledge that the TypeLocs you are dealing with will always include some source location.4) Exposed a bug somewhere in the use of the normal clang type class API, where you have some type, you want to see if that type is some particular kind, you try a `dyn_cast` such as `dyn_cast` and that fails because now you have an ElaboratedType which has a TypeDefType inside of it, which is what you wanted to match. Again, like 2), this would usually have been tested poorly with some simple tests with no qualifications, and would have been broken had there been any other kind of type sugar, be it an ElaboratedType or a TemplateSpecializationType or a SubstTemplateParmType. The usual fix here is to use `getAs` instead of `dyn_cast`, which will look deeper into the type. Or use `getAsAdjusted` when dealing with TypeLocs. For some reason the API is inconsistent there and on TypeLocs getAs behaves like a dyn_cast.5) It could be a bug in this patch perhaps.Let me know if you need any help!Signed-off-by: Matheus Izvekov Differential Revision: https://reviews.llvm.org/D112374 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/static-cast.cpp

3968936b - Revert "[clang] Implement ElaboratedType sugaring for types written bare"

Wed, 13 Jul 2022 16:11:45 +0000

Revert "[clang] Implement ElaboratedType sugaring for types written bare"This reverts commit bdc6974f92304f4ed542241b9b89ba58ba6b20aa because itbreaks all the LLDB tests that import the std module. import-std-module/array.TestArrayFromStdModule.py import-std-module/deque-basic.TestDequeFromStdModule.py import-std-module/deque-dbg-info-content.TestDbgInfoContentDequeFromStdModule.py import-std-module/forward_list.TestForwardListFromStdModule.py import-std-module/forward_list-dbg-info-content.TestDbgInfoContentForwardListFromStdModule.py import-std-module/list.TestListFromStdModule.py import-std-module/list-dbg-info-content.TestDbgInfoContentListFromStdModule.py import-std-module/queue.TestQueueFromStdModule.py import-std-module/stack.TestStackFromStdModule.py import-std-module/vector.TestVectorFromStdModule.py import-std-module/vector-bool.TestVectorBoolFromStdModule.py import-std-module/vector-dbg-info-content.TestDbgInfoContentVectorFromStdModule.py import-std-module/vector-of-vectors.TestVectorOfVectorsFromStdModule.pyhttps://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/45301/ List of files: /llvm-project-15.0.7/clang/test/SemaCXX/static-cast.cpp

bdc6974f - [clang] Implement ElaboratedType sugaring for types written bare

Mon, 11 Oct 2021 16:15:36 +0000

2eeddfb1 - Warn when a reference is bound to an empty l-value (dereferenced null pointer).

Sat, 14 May 2016 17:44:14 +0000

Warn when a reference is bound to an empty l-value (dereferenced null pointer).llvm-svn: 269572 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/static-cast.cpp

ffa7dc37 - PR 17456

Wed, 28 Jan 2015 21:31:26 +0000

PR 17456More helpful diagnostic on casts between unrelated class hierarchies.llvm-svn: 227371 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/static-cast.cpp

f5b93794 - Sema: Fix crash during member pointer conversion involving incomplete classes

Thu, 16 Jan 2014 12:02:55 +0000

Sema: Fix crash during member pointer conversion involving incomplete classesWe would attempt to determine the inheritance relationship betweenclasses 'A' and 'B' during static_cast if we tried to convert from 'intA::*' to 'int B::*'. However, the question "does A derive from B" isnot meaningful when 'A' isn't defined.Handle this case by requiring that 'A' be defined.This fixes PR18506.llvm-svn: 199374 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/static-cast.cpp

6ed72516 - Revert "Don't require -re suffix on -verify directives with regexes."

Sat, 14 Dec 2013 01:07:05 +0000

Revert "Don't require -re suffix on -verify directives with regexes."This patch was submitted to the list for review and didn't receive a LGTM.(In fact one explicit objection and one query were raised.)This reverts commit r197295.llvm-svn: 197299 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/static-cast.cpp

9b395ef2 - Don't require -re suffix on -verify directives with regexes.

Sat, 14 Dec 2013 00:46:53 +0000

Don't require -re suffix on -verify directives with regexes.Differential Revision: http://llvm-reviews.chandlerc.com/D2392llvm-svn: 197295 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/static-cast.cpp

86be54cc - Tighten test regexes checking for attribute((thiscall)) on function types.

Fri, 13 Dec 2013 18:34:23 +0000

Tighten test regexes checking for __attribute__((thiscall)) on function types.The tests were perhaps made too relaxed in r197164 when we switched to the newMinGW ABI. This makes sure we check explicitly for an optional thiscallattribute and nothing else.We should still look into whether we should print these attributes at all inthese cases.llvm-svn: 197252 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/static-cast.cpp

34970697 - Switch to the new MingW ABI.

Thu, 12 Dec 2013 16:07:11 +0000

Switch to the new MingW ABI.GCC 4.7 changed the MingW ABI. On the clang side this means that methods nowhave the thiscall calling convention by default.llvm-svn: 197164 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/static-cast.cpp

b472e93a - Implement appropriate semantics for C++ casting and conversion when

Fri, 15 Apr 2011 17:59:54 +0000

Implement appropriate semantics for C++ casting and conversion whendealing with address-space- and GC-qualified pointers. Previously,these qualifiers were being treated just like cvr-qualifiers (in somecases) or were completely ignored, leading to uneven behavior. Forexample, const_cast would allow conversion between pointers todifferent address spaces.The new semantics are fairly simple: reinterpret_cast can be used toexplicitly cast between pointers to different address spaces(including adding/removing addresss spaces), whilestatic_cast/dynamic_cast/const_cast do not tolerate any changes in theaddress space. C-style casts can add/remove/change address spacesthrough the reinterpret_cast mechanism. Other non-CVR qualifiers(e.g., Objective-C GC qualifiers) work similarly.As part of this change, I tweaked the "casts away constness"diagnostic to use the term "casts away qualifiers". The term"constness" actually comes from the C++ standard, despite the factthat removing "volatile" also falls under that category. In Clang, wealso have restrict, address spaces, ObjC GC attributes, etc., so themore general "qualifiers" is clearer.llvm-svn: 129583 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/static-cast.cpp

e81f58e1 - Properly diagnose invalid casts to function references. Patch by

Mon, 08 Nov 2010 03:40:48 +0000

Properly diagnose invalid casts to function references. Patch byFaisal Vali, tweaked by me. Fixes PR8230.llvm-svn: 118400 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/static-cast.cpp

24b89469 - 'const std::type_info' instead of 'std::type_info const'

Sun, 05 Sep 2010 00:17:29 +0000

'const std::type_info*' instead of 'std::type_info const*'llvm-svn: 113092 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/static-cast.cpp

53fa0490 - make clang print types as "const int " instead of "int const",

Sun, 05 Sep 2010 00:04:01 +0000

make clang print types as "const int *" instead of "int const*",which is should have done from the beginning. As usual, the mostfun with this sort of change is updating all the testcases.llvm-svn: 113090 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/static-cast.cpp

3155f573 - Turn access control on by default in -cc1.

Fri, 09 Apr 2010 19:03:51 +0000

Turn access control on by default in -cc1.Remove -faccess-control from -cc1; add -fno-access-control.Make the driver pass -fno-access-control by default.Update a bunch of tests to be correct under access control.llvm-svn: 100880 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/static-cast.cpp

deb714ce - Switch static_cast from the old reference-initialization code (via

Wed, 24 Mar 2010 23:38:29 +0000

Switch static_cast from the old reference-initialization code (viaCheckReferenceInit) over to the new initialization code(InitializationSequence), which is better-tested and doesn't requireus to compute the entire conversion sequence twice.llvm-svn: 99452 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/static-cast.cpp

85f90559 - When pretty-printing tag types, only print the tag if we're in C (and

Wed, 10 Mar 2010 11:27:22 +0000

When pretty-printing tag types, only print the tag if we're in C (andtherefore not creating ElaboratedTypes, which are still pretty-printedwith the written tag).Most of these testcase changes were done by script, so don't feel toosorry for my fingers.llvm-svn: 98149 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/static-cast.cpp

c934bc84 - Perform overload resolution when static_cast'ing from a

Sun, 07 Mar 2010 23:24:59 +0000

Perform overload resolution when static_cast'ing from apointer-to-member-to-derived to a pointer-to-member-to-base. FixesPR6072.llvm-svn: 97923 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/static-cast.cpp

5b0829a3 - Improve access control diagnostics. Perform access control on member-pointer

Wed, 10 Feb 2010 09:31:12 +0000

Improve access control diagnostics. Perform access control on member-pointerconversions. Fix an access-control bug where privileges were not consideredat intermediate points along the inheritance path. Prepare for friends.llvm-svn: 95775 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/static-cast.cpp