Changes in recovery-expr-type.cpp

76476efd - Rewording "static_assert" diagnostics

Mon, 25 Jul 2022 11:22:54 +0000

Rewording "static_assert" diagnosticsThis patch rewords the static assert diagnostic output. Failing a_Static_assert in C should not report that static_assert failed. Thischanges the wording to be more like GCC and uses "static assertion"when possible instead of hard coding the name. This also changes someinstances of 'static_assert' to instead be based on the token in thesource code.Differential Revision: https://reviews.llvm.org/D129048 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/recovery-expr-type.cpp

1da31190 - Revert "Rewording the "static_assert" to static assertion"

Thu, 21 Jul 2022 13:39:22 +0000

Revert "Rewording the "static_assert" to static assertion"Looks like we again are going to have problems with libcxx tests thatare overly specific in their dependency on clang's diagnostics.This reverts commit 6542cb55a3eb115b1c3592514590a19987ffc498. List of files: /llvm-project-15.0.7/clang/test/SemaCXX/recovery-expr-type.cpp

6542cb55 - Rewording the "static_assert" to static assertion

Thu, 21 Jul 2022 13:32:54 +0000

Rewording the "static_assert" to static assertionThis patch is basically the rewording of the static assert statement'soutput(error) on screen after failing. Failing a _Static_assert in Cshould not report that static_assert failed. It’d probably be better toreword the diagnostic to be more like GCC and say “static assertion”failed in both C and C++.consider a c file having code_Static_assert(0, "oh no!");In clang the output is like::1:1: error: static_assert failed: oh no!_Static_assert(0, "oh no!");^ ~1 error generated.Compiler returned: 1Thus here the "static_assert" is not much good, it will be better toreword it to the "static assertion failed" to more generic. as the gccprints as::1:1: error: static assertion failed: "oh no!" 1 | _Static_assert(0, "oh no!"); | ^~~~~~~~~~~~~~ Compiler returned: 1The above can also be seen here. This patch is about rewordingthe static_assert to static assertion.Differential Revision: https://reviews.llvm.org/D129048 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/recovery-expr-type.cpp

888673b6 - Revert "[clang] Implement ElaboratedType sugaring for types written bare"

Fri, 15 Jul 2022 04:13:57 +0000

Revert "[clang] Implement ElaboratedType sugaring for types written bare"This reverts commit 7c51f02effdbd0d5e12bfd26f9c3b2ab5687c93f because itstills breaks the LLDB tests. This was re-landed without addressing theissue or even agreement on how to address the issue. More details anddiscussion in https://reviews.llvm.org/D112374. List of files: /llvm-project-15.0.7/clang/test/SemaCXX/recovery-expr-type.cpp

7c51f02e - [clang] Implement ElaboratedType sugaring for types written bare

Mon, 11 Oct 2021 16:15:36 +0000

[clang] Implement ElaboratedType sugaring for types written bareWithout this patch, clang will not wrap in an ElaboratedType node types writtenwithout a keyword and nested name qualifier, which goes against the intent thatwe should produce an AST which retains enough details to recover how things arewritten.The lack of this sugar is incompatible with the intent of the type printerdefault policy, which is to print types as written, but to fall back and printthem fully qualified when they are desugared.An ElaboratedTypeLoc without keyword / NNS uses no storage by itself, but stillrequires pointer alignment due to pre-existing bug in the TypeLoc bufferhandling.---Troubleshooting list to deal with any breakage seen with this patch:1) The most likely effect one would see by this patch is a change in how a type is printed. The type printer will, by design and default, print types as written. There are customization options there, but not that many, and they mainly apply to how to print a type that we somehow failed to track how it was written. This patch fixes a problem where we failed to distinguish between a type that was written without any elaborated-type qualifiers, such as a 'struct'/'class' tags and name spacifiers such as 'std::', and one that has been stripped of any 'metadata' that identifies such, the so called canonical types. Example: ``` namespace foo { struct A {}; A a; }; ``` If one were to print the type of `foo::a`, prior to this patch, this would result in `foo::A`. This is how the type printer would have, by default, printed the canonical type of A as well. As soon as you add any name qualifiers to A, the type printer would suddenly start accurately printing the type as written. This patch will make it print it accurately even when written without qualifiers, so we will just print `A` for the initial example, as the user did not really write that `foo::` namespace qualifier.2) This patch could expose a bug in some AST matcher. Matching types is harder to get right when there is sugar involved. For example, if you want to match a type against being a pointer to some type A, then you have to account for getting a type that is sugar for a pointer to A, or being a pointer to sugar to A, or both! Usually you would get the second part wrong, and this would work for a very simple test where you don't use any name qualifiers, but you would discover is broken when you do. The usual fix is to either use the matcher which strips sugar, which is annoying to use as for example if you match an N level pointer, you have to put N+1 such matchers in there, beginning to end and between all those levels. But in a lot of cases, if the property you want to match is present in the canonical type, it's easier and faster to just match on that... This goes with what is said in 1), if you want to match against the name of a type, and you want the name string to be something stable, perhaps matching on the name of the canonical type is the better choice.3) This patch could exposed a bug in how you get the source range of some TypeLoc. For some reason, a lot of code is using getLocalSourceRange(), which only looks at the given TypeLoc node. This patch introduces a new, and more common TypeLoc node which contains no source locations on itself. This is not an inovation here, and some other, more rare TypeLoc nodes could also have this property, but if you use getLocalSourceRange on them, it's not going to return any valid locations, because it doesn't have any. The right fix here is to always use getSourceRange() or getBeginLoc/getEndLoc which will dive into the inner TypeLoc to get the source range if it doesn't find it on the top level one. You can use getLocalSourceRange if you are really into micro-optimizations and you have some outside knowledge that the TypeLocs you are dealing with will always include some source location.4) Exposed a bug somewhere in the use of the normal clang type class API, where you have some type, you want to see if that type is some particular kind, you try a `dyn_cast` such as `dyn_cast` and that fails because now you have an ElaboratedType which has a TypeDefType inside of it, which is what you wanted to match. Again, like 2), this would usually have been tested poorly with some simple tests with no qualifications, and would have been broken had there been any other kind of type sugar, be it an ElaboratedType or a TemplateSpecializationType or a SubstTemplateParmType. The usual fix here is to use `getAs` instead of `dyn_cast`, which will look deeper into the type. Or use `getAsAdjusted` when dealing with TypeLocs. For some reason the API is inconsistent there and on TypeLocs getAs behaves like a dyn_cast.5) It could be a bug in this patch perhaps.Let me know if you need any help!Signed-off-by: Matheus Izvekov Differential Revision: https://reviews.llvm.org/D112374 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/recovery-expr-type.cpp

041d4012 - Revert "Rewording "static_assert" diagnostics"

Thu, 14 Jul 2022 17:52:43 +0000

Revert "Rewording "static_assert" diagnostics"This reverts commit b7e77ff25fb2412f6ab6d6cc756666b0e2f97bd3.Reason: Broke sanitizer builds bots + libcxx. 'static assertionexpression is not an integral constant expression'. More detailsavailable in the Phabricator review: https://reviews.llvm.org/D129048 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/recovery-expr-type.cpp

b7e77ff2 - Rewording "static_assert" diagnostics

Thu, 14 Jul 2022 11:44:51 +0000

3968936b - Revert "[clang] Implement ElaboratedType sugaring for types written bare"

Wed, 13 Jul 2022 16:11:45 +0000

Revert "[clang] Implement ElaboratedType sugaring for types written bare"This reverts commit bdc6974f92304f4ed542241b9b89ba58ba6b20aa because itbreaks all the LLDB tests that import the std module. import-std-module/array.TestArrayFromStdModule.py import-std-module/deque-basic.TestDequeFromStdModule.py import-std-module/deque-dbg-info-content.TestDbgInfoContentDequeFromStdModule.py import-std-module/forward_list.TestForwardListFromStdModule.py import-std-module/forward_list-dbg-info-content.TestDbgInfoContentForwardListFromStdModule.py import-std-module/list.TestListFromStdModule.py import-std-module/list-dbg-info-content.TestDbgInfoContentListFromStdModule.py import-std-module/queue.TestQueueFromStdModule.py import-std-module/stack.TestStackFromStdModule.py import-std-module/vector.TestVectorFromStdModule.py import-std-module/vector-bool.TestVectorBoolFromStdModule.py import-std-module/vector-dbg-info-content.TestDbgInfoContentVectorFromStdModule.py import-std-module/vector-of-vectors.TestVectorOfVectorsFromStdModule.pyhttps://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/45301/ List of files: /llvm-project-15.0.7/clang/test/SemaCXX/recovery-expr-type.cpp

bdc6974f - [clang] Implement ElaboratedType sugaring for types written bare

Mon, 11 Oct 2021 16:15:36 +0000

d6f9000e - [clang] Fix a constant evaluator crash on a NULL-type expr.

Mon, 25 Apr 2022 13:42:35 +0000

[clang] Fix a constant evaluator crash on a NULL-type expr.Differential Revision: https://reviews.llvm.org/D124384 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/recovery-expr-type.cpp

c9e46219 - [clang] retain type sugar in auto / template argument deduction

Fri, 12 Nov 2021 23:40:18 +0000

[clang] retain type sugar in auto / template argument deductionThis implements the following changes:* AutoType retains sugared deduced-as-type.* Template argument deduction machinery analyses the sugared type all the waydown. It would previously lose the sugar on first recursion.* Undeduced AutoType will be properly canonicalized, including the constrainttemplate arguments.* Remove the decltype node created from the decltype(auto) deduction.As a result, we start seeing sugared types in a lot more test cases,including some which showed very unfriendly `type-parameter-*-*` types.Signed-off-by: Matheus Izvekov Reviewed By: rsmith, #libc, ldionneDifferential Revision: https://reviews.llvm.org/D110216 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/recovery-expr-type.cpp

6438a52d - Revert "[clang] retain type sugar in auto / template argument deduction"

Sun, 14 Nov 2021 23:29:05 +0000

Revert "[clang] retain type sugar in auto / template argument deduction"This reverts commit 4d8fff477e024698facd89741cc6cf996708d598. List of files: /llvm-project-15.0.7/clang/test/SemaCXX/recovery-expr-type.cpp

4d8fff47 - [clang] retain type sugar in auto / template argument deduction

Fri, 12 Nov 2021 23:40:18 +0000

[clang] retain type sugar in auto / template argument deductionThis implements the following changes:* AutoType retains sugared deduced-as-type.* Template argument deduction machinery analyses the sugared type all the waydown. It would previously lose the sugar on first recursion.* Undeduced AutoType will be properly canonicalized, including the constrainttemplate arguments.* Remove the decltype node created from the decltype(auto) deduction.As a result, we start seeing sugared types in a lot more test cases,including some which showed very unfriendly `type-parameter-*-*` types.Signed-off-by: Matheus Izvekov Reviewed By: rsmithDifferential Revision: https://reviews.llvm.org/D110216 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/recovery-expr-type.cpp

1d7fdbbc - Revert "[clang] retain type sugar in auto / template argument deduction"

Fri, 12 Nov 2021 12:15:51 +0000

Revert "[clang] retain type sugar in auto / template argument deduction"This reverts commit 9b6036deedf28e10d797fc4ca734d57680d18053.Breaks two libc++ tests. List of files: /llvm-project-15.0.7/clang/test/SemaCXX/recovery-expr-type.cpp

9b6036de - [clang] retain type sugar in auto / template argument deduction

Mon, 13 Sep 2021 13:35:45 +0000

[clang] retain type sugar in auto / template argument deductionThis implements the following changes:* AutoType retains sugared deduced-as-type.* Template argument deduction machinery analyses the sugared type all the waydown. It would previously lose the sugar on first recursion.* Undeduced AutoType will be properly canonicalized, including the constrainttemplate arguments.* Remove the decltype node created from the decltype(auto) deduction.As a result, we start seeing sugared types in a lot more test cases,including some which showed very unfriendly `type-parameter-*-*` types.Signed-off-by: Matheus Izvekov Reviewed By: rsmithDifferential Revision: https://reviews.llvm.org/D110216 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/recovery-expr-type.cpp

5880c835 - [Sema] Avoid crash in CheckEnumConstant with contains-error expressions

Fri, 20 Aug 2021 08:01:45 +0000

[Sema] Avoid crash in CheckEnumConstant with contains-error expressionsFixes https://bugs.llvm.org/show_bug.cgi?id=51554Differential Revision: https://reviews.llvm.org/D108451 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/recovery-expr-type.cpp

086e1112 - [clang] NFC: include non friendly types and missing sugar in test expectations

Wed, 22 Sep 2021 00:33:45 +0000

[clang] NFC: include non friendly types and missing sugar in test expectationsThe dump of all diagnostics of all tests under `clang/test/{CXX,SemaCXX,SemaTemplate}` was analyzed , and all the cases where there were obviously bad canonical types being printed, like `type-parameter-*-*` and `` were identified. Also a small amount of cases of missing sugar were analyzed.This patch then spells those explicitly in the test expectations, as preparatory work for future fixes for these problems.Signed-off-by: Matheus Izvekov Reviewed By: rsmithDifferential Revision: https://reviews.llvm.org/D110210 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/recovery-expr-type.cpp

314e456d - [clang] Fix CallExpr dependence bit may not respect all its arguments.

Wed, 30 Jun 2021 08:15:59 +0000

[clang] Fix CallExpr dependence bit may not respect all its arguments.Before this patch, the dependence of CallExpr was only computed in theconstructor, the dependence bits might not reflect truth -- some arguments mightbe not set (nullptr) during this time, e.g. CXXDefaultArgExpr will be set viathe setArg method in the later parsing stage, so we need to recompute thedependence bits. List of files: /llvm-project-15.0.7/clang/test/SemaCXX/recovery-expr-type.cpp

49eba8bf - [clang] Do not crash when ArgTy is null in CheckArgAlignment

Mon, 07 Jun 2021 16:26:21 +0000

[clang] Do not crash when ArgTy is null in CheckArgAlignmentThis can happen around RecoveryExpr.Differential Revision: https://reviews.llvm.org/D103825 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/recovery-expr-type.cpp

fbfcfdbf - [clang] Fix assert() crash when checking undeduced arg alignment

Fri, 16 Apr 2021 18:07:46 +0000

[clang] Fix assert() crash when checking undeduced arg alignmentThere already was a check for undeduced and incomplete types, but itfailed to trigger when outer type (SubstTemplateTypeParm in test) lookedfine, but inner type was not.Differential Revision: https://reviews.llvm.org/D100667 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/recovery-expr-type.cpp