Changes in member-init.cpp

888673b6 - Revert "[clang] Implement ElaboratedType sugaring for types written bare"

Fri, 15 Jul 2022 04:13:57 +0000

Revert "[clang] Implement ElaboratedType sugaring for types written bare"This reverts commit 7c51f02effdbd0d5e12bfd26f9c3b2ab5687c93f because itstills breaks the LLDB tests. This was re-landed without addressing theissue or even agreement on how to address the issue. More details anddiscussion in https://reviews.llvm.org/D112374. List of files: /llvm-project-15.0.7/clang/test/SemaCXX/member-init.cpp

7c51f02e - [clang] Implement ElaboratedType sugaring for types written bare

Mon, 11 Oct 2021 16:15:36 +0000

[clang] Implement ElaboratedType sugaring for types written bareWithout this patch, clang will not wrap in an ElaboratedType node types writtenwithout a keyword and nested name qualifier, which goes against the intent thatwe should produce an AST which retains enough details to recover how things arewritten.The lack of this sugar is incompatible with the intent of the type printerdefault policy, which is to print types as written, but to fall back and printthem fully qualified when they are desugared.An ElaboratedTypeLoc without keyword / NNS uses no storage by itself, but stillrequires pointer alignment due to pre-existing bug in the TypeLoc bufferhandling.---Troubleshooting list to deal with any breakage seen with this patch:1) The most likely effect one would see by this patch is a change in how a type is printed. The type printer will, by design and default, print types as written. There are customization options there, but not that many, and they mainly apply to how to print a type that we somehow failed to track how it was written. This patch fixes a problem where we failed to distinguish between a type that was written without any elaborated-type qualifiers, such as a 'struct'/'class' tags and name spacifiers such as 'std::', and one that has been stripped of any 'metadata' that identifies such, the so called canonical types. Example: ``` namespace foo { struct A {}; A a; }; ``` If one were to print the type of `foo::a`, prior to this patch, this would result in `foo::A`. This is how the type printer would have, by default, printed the canonical type of A as well. As soon as you add any name qualifiers to A, the type printer would suddenly start accurately printing the type as written. This patch will make it print it accurately even when written without qualifiers, so we will just print `A` for the initial example, as the user did not really write that `foo::` namespace qualifier.2) This patch could expose a bug in some AST matcher. Matching types is harder to get right when there is sugar involved. For example, if you want to match a type against being a pointer to some type A, then you have to account for getting a type that is sugar for a pointer to A, or being a pointer to sugar to A, or both! Usually you would get the second part wrong, and this would work for a very simple test where you don't use any name qualifiers, but you would discover is broken when you do. The usual fix is to either use the matcher which strips sugar, which is annoying to use as for example if you match an N level pointer, you have to put N+1 such matchers in there, beginning to end and between all those levels. But in a lot of cases, if the property you want to match is present in the canonical type, it's easier and faster to just match on that... This goes with what is said in 1), if you want to match against the name of a type, and you want the name string to be something stable, perhaps matching on the name of the canonical type is the better choice.3) This patch could exposed a bug in how you get the source range of some TypeLoc. For some reason, a lot of code is using getLocalSourceRange(), which only looks at the given TypeLoc node. This patch introduces a new, and more common TypeLoc node which contains no source locations on itself. This is not an inovation here, and some other, more rare TypeLoc nodes could also have this property, but if you use getLocalSourceRange on them, it's not going to return any valid locations, because it doesn't have any. The right fix here is to always use getSourceRange() or getBeginLoc/getEndLoc which will dive into the inner TypeLoc to get the source range if it doesn't find it on the top level one. You can use getLocalSourceRange if you are really into micro-optimizations and you have some outside knowledge that the TypeLocs you are dealing with will always include some source location.4) Exposed a bug somewhere in the use of the normal clang type class API, where you have some type, you want to see if that type is some particular kind, you try a `dyn_cast` such as `dyn_cast` and that fails because now you have an ElaboratedType which has a TypeDefType inside of it, which is what you wanted to match. Again, like 2), this would usually have been tested poorly with some simple tests with no qualifications, and would have been broken had there been any other kind of type sugar, be it an ElaboratedType or a TemplateSpecializationType or a SubstTemplateParmType. The usual fix here is to use `getAs` instead of `dyn_cast`, which will look deeper into the type. Or use `getAsAdjusted` when dealing with TypeLocs. For some reason the API is inconsistent there and on TypeLocs getAs behaves like a dyn_cast.5) It could be a bug in this patch perhaps.Let me know if you need any help!Signed-off-by: Matheus Izvekov Differential Revision: https://reviews.llvm.org/D112374 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/member-init.cpp

3968936b - Revert "[clang] Implement ElaboratedType sugaring for types written bare"

Wed, 13 Jul 2022 16:11:45 +0000

Revert "[clang] Implement ElaboratedType sugaring for types written bare"This reverts commit bdc6974f92304f4ed542241b9b89ba58ba6b20aa because itbreaks all the LLDB tests that import the std module. import-std-module/array.TestArrayFromStdModule.py import-std-module/deque-basic.TestDequeFromStdModule.py import-std-module/deque-dbg-info-content.TestDbgInfoContentDequeFromStdModule.py import-std-module/forward_list.TestForwardListFromStdModule.py import-std-module/forward_list-dbg-info-content.TestDbgInfoContentForwardListFromStdModule.py import-std-module/list.TestListFromStdModule.py import-std-module/list-dbg-info-content.TestDbgInfoContentListFromStdModule.py import-std-module/queue.TestQueueFromStdModule.py import-std-module/stack.TestStackFromStdModule.py import-std-module/vector.TestVectorFromStdModule.py import-std-module/vector-bool.TestVectorBoolFromStdModule.py import-std-module/vector-dbg-info-content.TestDbgInfoContentVectorFromStdModule.py import-std-module/vector-of-vectors.TestVectorOfVectorsFromStdModule.pyhttps://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/45301/ List of files: /llvm-project-15.0.7/clang/test/SemaCXX/member-init.cpp

bdc6974f - [clang] Implement ElaboratedType sugaring for types written bare

Mon, 11 Oct 2021 16:15:36 +0000

15fbae8a - Use "default member initializer" instead of "in-class initializer" for diagnostics.

Tue, 29 Sep 2020 19:03:29 +0000

Use "default member initializer" instead of "in-class initializer" for diagnostics.This changes some diagnostics to use terminology from the standardrather than invented terminology, which improves consistency with otherdiagnostics as well. There are no functional changes intended otherthan wording and naming. List of files: /llvm-project-15.0.7/clang/test/SemaCXX/member-init.cpp

89d9912c - [AST] dont invaliate VarDecl when the initializer contains errors.

Tue, 21 Apr 2020 07:57:06 +0000

[AST] dont invaliate VarDecl when the initializer contains errors.Summary:This patch contains 2 separate changes:1) the initializer of a variable should play no part in decl "invalid" bit;2) preserve the invalid initializer via recovery exprs;With 1), we will regress the diagnostics (one big regression is that we loosethe "selected 'begin' function with iterator type" diagnostic in for-range stmt;but with 2) together, we don't have regressions (the new diagnostics seems to beimproved).Reviewers: sammccallReviewed By: sammccallSubscribers: cfe-commitsTags: #clangDifferential Revision: https://reviews.llvm.org/D78116 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/member-init.cpp

24ad1215 - Add -std=c++20 flag, replace C++2a with C++20 throughout the Clang

Wed, 19 Feb 2020 00:13:23 +0000

Add -std=c++20 flag, replace C++2a with C++20 throughout the Clanguser interface and documentation, and update __cplusplus for C++20.WG21 considers the C++20 standard to be finished (even though it stillhas some more steps to pass through in the ISO process).The old flag names are accepted for compatibility, as usual, and westill have lots of references to C++2a in comments and identifiers;those can be cleaned up separately. List of files: /llvm-project-15.0.7/clang/test/SemaCXX/member-init.cpp

5030928d - [c++20] Implement semantic restrictions for C++20 designated

Fri, 30 Aug 2019 22:52:55 +0000

[c++20] Implement semantic restrictions for C++20 designatedinitializers.This has some interesting interactions with our existing extensions tosupport C99 designated initializers as an extension in C++. Those areresolved as follows: * We continue to permit the full breadth of C99 designated initializers in C++, with the exception that we disallow a partial overwrite of an initializer with a non-trivially-destructible type. (Full overwrite is OK, because we won't run the first initializer at all.) * The C99 extensions are disallowed in SFINAE contexts and during overload resolution, where they could change the meaning of valid programs. * C++20 disallows reordering of initializers. We only check for that for the simple cases that the C++20 rules permit (designators of the form '.field_name =' and continue to allow reordering in other cases). It would be nice to improve this behavior in future. * All C99 designated initializer extensions produce a warning by default in C++20 mode. People are going to learn the C++ rules based on what Clang diagnoses, so it's important we diagnose these properly by default. * In C++ <= 17, we apply the C++20 rules rather than the C99 rules, and so still diagnose C99 extensions as described above. We continue to accept designated C++20-compatible initializers in C++ <= 17 silently by default (but naturally still reject under -pedantic-errors).This is not a complete implementation of P0329R4. In particular, thatpaper introduces new non-C99-compatible syntax { .field { init } }, andwe do not support that yet.This is based on a previous patch by Don Hinton, though I've madesubstantial changes when addressing the above interactions.Differential Revision: https://reviews.llvm.org/D59754llvm-svn: 370544 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/member-init.cpp

2b45b267 - P1286R2: Remove restriction that the exception specification of a

Mon, 06 May 2019 05:04:56 +0000

P1286R2: Remove restriction that the exception specification of adefaulted special member matches the implicit exception specification.llvm-svn: 360011 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/member-init.cpp

5159bbad - PR38627: Fix handling of exception specification adjustment for

Wed, 05 Sep 2018 22:30:37 +0000

PR38627: Fix handling of exception specification adjustment fordestructors.We previously tried to patch up the exception specification aftercompleting the class, which went wrong when the exception specificationwas needed within the class body (in particular, by a friendredeclaration of the destructor in a nested class). We now mark thedestructor as having a not-yet-computed exception specificationimmediately after creating it.This requires delaying various checks against the exceptionspecification (where we'd previously have just got the wrong exceptionspecification, and now find we have an exception specification that wecan't compute yet) when those checks fire while the class is beingdefined.This also exposed an issue that we were missing a CodeSynthesisContextfor computation of exception specifications (otherwise we'd fail to makethe module containing the definition of the class visible when computingits members' exception specs). Adding that incidentally also gives us adiagnostic quality improvement.This has also exposed an pre-existing problem: making the exceptionspecification evaluation context a non-SFINAE context (as it should be)results in a bootstrap failure; PR38850 filed for this.llvm-svn: 341499 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/member-init.cpp

d87aab93 - Restructure checking for, and warning on, lifetime extension.

Tue, 17 Jul 2018 22:24:09 +0000

Restructure checking for, and warning on, lifetime extension.This change implements C++ DR1696, which makes initialization of areference member of a class from a temporary object ill-formed. Thestandard wording here is imprecise, but we interpret it as meaning thatany time a mem-initializer would result in lifetime extension, theprogram is ill-formed.This reinstates r337226, reverted in r337255, with a fix for theInitializedEntity alignment problem that was breaking ARM buildbots.llvm-svn: 337329 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/member-init.cpp

0aa117dd - Temporarily revert r337226 "Restructure checking for, and warning on, lifetime extension."

Tue, 17 Jul 2018 09:23:31 +0000

Temporarily revert r337226 "Restructure checking for, and warning on, lifetime extension."This change breaks on ARM because pointers to clang::InitializedEntity are only4 byte aligned and do not have 3 bits to store values. A possible solutionwould be to change the fields in clang::InitializedEntity to enforce a biggeralignment requirement.The error message isllvm/include/llvm/ADT/PointerIntPair.h:132:3: error: static_assert failed "PointerIntPair with integer size too large for pointer" static_assert(IntBits <= PtrTraits::NumLowBitsAvailable,include/llvm/ADT/PointerIntPair.h:73:13: note: in instantiation of template class 'llvm::PointerIntPairInfo >' requested here Value = Info::updateInt(Info::updatePointer(0, PtrVal),llvm/include/llvm/ADT/PointerIntPair.h:51:5: note: in instantiation of member function 'llvm::PointerIntPair, llvm::PointerIntPairInfo > >::setPointerAndInt' requested here setPointerAndInt(PtrVal, IntVal); ^llvm/tools/clang/lib/Sema/SemaInit.cpp:6237:12: note: in instantiation of member function 'llvm::PointerIntPair, llvm::PointerIntPairInfo > >::PointerIntPair' requested here return {Entity, LK_Extended};Full log here:http://lab.llvm.org:8011/builders/clang-cmake-armv7-global-isel/builds/1330http://lab.llvm.org:8011/builders/clang-cmake-armv7-full/builds/1394llvm-svn: 337255 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/member-init.cpp

0a9969b3 - Restructure checking for, and warning on, lifetime extension.

Tue, 17 Jul 2018 00:11:41 +0000

Restructure checking for, and warning on, lifetime extension.This change implements C++ DR1696, which makes initialization of areference member of a class from a temporary object ill-formed. Thestandard wording here is imprecise, but we interpret it as meaning thatany time a mem-initializer would result in lifetime extension, theprogram is ill-formed.llvm-svn: 337226 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/member-init.cpp

61061d69 - [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes)

Sat, 07 Apr 2018 10:39:21 +0000

[Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes)Summary:This has just bit me, so i though it would be nice to avoid that next time :)Motivational case: https://godbolt.org/g/cq9UNkBasically, it's likely to happen if you don't like shadowing issues,and use `-Wshadow` and friends. And it won't be diagnosed by clang.The reason is, these self-assign diagnostics only work for builtin assignmentoperators. Which makes sense, one could have a very special operator=,that does something unusual in case of self-assignment,so it may make sense to not warn on that.But while it may be intentional in some cases, it may be a bug in other cases,so it would be really great to have some diagnostic about it...Reviewers: aaron.ballman, rsmith, rtrieu, nikola, rjmccall, dblaikieReviewed By: rjmccallSubscribers: EricWF, lebedev.ri, thakis, Quuxplusone, cfe-commitsDifferential Revision: https://reviews.llvm.org/D44883llvm-svn: 329493 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/member-init.cpp

6b8e3c02 - [c++2a] P0683R1: Permit default member initializers for bit-fields.

Mon, 28 Aug 2017 00:28:14 +0000

[c++2a] P0683R1: Permit default member initializers for bit-fields.This would be trivial, except that our in-memory and serialized representationsfor FieldDecls assumed that this can't happen.llvm-svn: 311867 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/member-init.cpp

d6a15082 - PR23135: Don't instantiate constexpr functions referenced in unevaluated operands where possible.

Sat, 07 Jan 2017 00:48:55 +0000

PR23135: Don't instantiate constexpr functions referenced in unevaluated operands where possible.This implements something like the current direction of DR1581: we use a narrowsyntactic check to determine the set of places where a constant expressioncould be evaluated, and only instantiate a constexpr function or variable ifit's referenced in one of those contexts, or is odr-used.It's not yet clear whether this is the right set of syntactic locations; wecurrently consider all contexts within templates that would result in odr-usesafter instantiation, and contexts within list-initialization (narrowingconversions take another victim...), as requiring instantiation. We could inprinciple restrict the former cases more (only const integral / referencevariable initializers, and contexts in which a constant expression is required,perhaps). However, this is sufficient to allow us to accept libstdc++ code,which relies on GCC's behavior (which appears to be somewhat similar to thisapproach).llvm-svn: 291318 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/member-init.cpp

cbe1eba0 - Fix the spelling of 'bitfield' in diagnostics to be consistently 'bit-field'.

Tue, 20 Dec 2016 02:43:58 +0000

Fix the spelling of 'bitfield' in diagnostics to be consistently 'bit-field'.The latter agrees with most existing diagnostics and the C and C++ standards.Differential Revision: https://reviews.llvm.org/D26530llvm-svn: 290159 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/member-init.cpp

b8c0f553 - DR1295 and cleanup for P0135R1: Make our initialization code more directly

Fri, 09 Dec 2016 18:49:13 +0000

DR1295 and cleanup for P0135R1: Make our initialization code more directlymirror the description in the standard. Per DR1295, this means that binding aconst / rvalue reference to a bit-field no longer "binds directly", and perP0135R1, this means that we materialize a temporary in reference bindingafter adjusting cv-qualifiers and before performing a derived-to-base cast.In C++11 onwards, this should have fixed the last case where we wouldmaterialize a temporary of the wrong type (with a subobject adjustment insidethe MaterializeTemporaryExpr instead of outside), but we still have to dealwith that possibility in C++98, unless we want to start using xvalues torepresent materialized temporaries there too.llvm-svn: 289250 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/member-init.cpp

8dbc6b26 - Make diagnostic for use of default member initializer before enclosing class is

Tue, 22 Nov 2016 22:55:12 +0000

Make diagnostic for use of default member initializer before enclosing class iscomplete a little more general; it is produced in other cases than the one thatit previously talked about.llvm-svn: 287713 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/member-init.cpp

76a25626 - [Sema] Don't crash when a field w/ a mem-initializer clashes with a record name

Thu, 09 Jun 2016 05:26:56 +0000

[Sema] Don't crash when a field w/ a mem-initializer clashes with a record nameIt is possible for a field and a class to have the same name. In suchcases, performing lookup for the field might return a result set withmore than one entry. An overzealous assertion fired, causing us tocrash instead of using the non-class lookup result.This fixes PR28060.llvm-svn: 272247 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/member-init.cpp