Changes in decl-init-ref.cpp

888673b6 - Revert "[clang] Implement ElaboratedType sugaring for types written bare"

Fri, 15 Jul 2022 04:13:57 +0000

Revert "[clang] Implement ElaboratedType sugaring for types written bare"This reverts commit 7c51f02effdbd0d5e12bfd26f9c3b2ab5687c93f because itstills breaks the LLDB tests. This was re-landed without addressing theissue or even agreement on how to address the issue. More details anddiscussion in https://reviews.llvm.org/D112374. List of files: /llvm-project-15.0.7/clang/test/SemaCXX/decl-init-ref.cpp

7c51f02e - [clang] Implement ElaboratedType sugaring for types written bare

Mon, 11 Oct 2021 16:15:36 +0000

[clang] Implement ElaboratedType sugaring for types written bareWithout this patch, clang will not wrap in an ElaboratedType node types writtenwithout a keyword and nested name qualifier, which goes against the intent thatwe should produce an AST which retains enough details to recover how things arewritten.The lack of this sugar is incompatible with the intent of the type printerdefault policy, which is to print types as written, but to fall back and printthem fully qualified when they are desugared.An ElaboratedTypeLoc without keyword / NNS uses no storage by itself, but stillrequires pointer alignment due to pre-existing bug in the TypeLoc bufferhandling.---Troubleshooting list to deal with any breakage seen with this patch:1) The most likely effect one would see by this patch is a change in how a type is printed. The type printer will, by design and default, print types as written. There are customization options there, but not that many, and they mainly apply to how to print a type that we somehow failed to track how it was written. This patch fixes a problem where we failed to distinguish between a type that was written without any elaborated-type qualifiers, such as a 'struct'/'class' tags and name spacifiers such as 'std::', and one that has been stripped of any 'metadata' that identifies such, the so called canonical types. Example: ``` namespace foo { struct A {}; A a; }; ``` If one were to print the type of `foo::a`, prior to this patch, this would result in `foo::A`. This is how the type printer would have, by default, printed the canonical type of A as well. As soon as you add any name qualifiers to A, the type printer would suddenly start accurately printing the type as written. This patch will make it print it accurately even when written without qualifiers, so we will just print `A` for the initial example, as the user did not really write that `foo::` namespace qualifier.2) This patch could expose a bug in some AST matcher. Matching types is harder to get right when there is sugar involved. For example, if you want to match a type against being a pointer to some type A, then you have to account for getting a type that is sugar for a pointer to A, or being a pointer to sugar to A, or both! Usually you would get the second part wrong, and this would work for a very simple test where you don't use any name qualifiers, but you would discover is broken when you do. The usual fix is to either use the matcher which strips sugar, which is annoying to use as for example if you match an N level pointer, you have to put N+1 such matchers in there, beginning to end and between all those levels. But in a lot of cases, if the property you want to match is present in the canonical type, it's easier and faster to just match on that... This goes with what is said in 1), if you want to match against the name of a type, and you want the name string to be something stable, perhaps matching on the name of the canonical type is the better choice.3) This patch could exposed a bug in how you get the source range of some TypeLoc. For some reason, a lot of code is using getLocalSourceRange(), which only looks at the given TypeLoc node. This patch introduces a new, and more common TypeLoc node which contains no source locations on itself. This is not an inovation here, and some other, more rare TypeLoc nodes could also have this property, but if you use getLocalSourceRange on them, it's not going to return any valid locations, because it doesn't have any. The right fix here is to always use getSourceRange() or getBeginLoc/getEndLoc which will dive into the inner TypeLoc to get the source range if it doesn't find it on the top level one. You can use getLocalSourceRange if you are really into micro-optimizations and you have some outside knowledge that the TypeLocs you are dealing with will always include some source location.4) Exposed a bug somewhere in the use of the normal clang type class API, where you have some type, you want to see if that type is some particular kind, you try a `dyn_cast` such as `dyn_cast` and that fails because now you have an ElaboratedType which has a TypeDefType inside of it, which is what you wanted to match. Again, like 2), this would usually have been tested poorly with some simple tests with no qualifications, and would have been broken had there been any other kind of type sugar, be it an ElaboratedType or a TemplateSpecializationType or a SubstTemplateParmType. The usual fix here is to use `getAs` instead of `dyn_cast`, which will look deeper into the type. Or use `getAsAdjusted` when dealing with TypeLocs. For some reason the API is inconsistent there and on TypeLocs getAs behaves like a dyn_cast.5) It could be a bug in this patch perhaps.Let me know if you need any help!Signed-off-by: Matheus Izvekov Differential Revision: https://reviews.llvm.org/D112374 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/decl-init-ref.cpp

3968936b - Revert "[clang] Implement ElaboratedType sugaring for types written bare"

Wed, 13 Jul 2022 16:11:45 +0000

Revert "[clang] Implement ElaboratedType sugaring for types written bare"This reverts commit bdc6974f92304f4ed542241b9b89ba58ba6b20aa because itbreaks all the LLDB tests that import the std module. import-std-module/array.TestArrayFromStdModule.py import-std-module/deque-basic.TestDequeFromStdModule.py import-std-module/deque-dbg-info-content.TestDbgInfoContentDequeFromStdModule.py import-std-module/forward_list.TestForwardListFromStdModule.py import-std-module/forward_list-dbg-info-content.TestDbgInfoContentForwardListFromStdModule.py import-std-module/list.TestListFromStdModule.py import-std-module/list-dbg-info-content.TestDbgInfoContentListFromStdModule.py import-std-module/queue.TestQueueFromStdModule.py import-std-module/stack.TestStackFromStdModule.py import-std-module/vector.TestVectorFromStdModule.py import-std-module/vector-bool.TestVectorBoolFromStdModule.py import-std-module/vector-dbg-info-content.TestDbgInfoContentVectorFromStdModule.py import-std-module/vector-of-vectors.TestVectorOfVectorsFromStdModule.pyhttps://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/45301/ List of files: /llvm-project-15.0.7/clang/test/SemaCXX/decl-init-ref.cpp

bdc6974f - [clang] Implement ElaboratedType sugaring for types written bare

Mon, 11 Oct 2021 16:15:36 +0000

aee49255 - Recommit: Compress formatting of array type names (int [4] -> int[4])

Thu, 14 Oct 2021 21:52:47 +0000

Recommit: Compress formatting of array type names (int [4] -> int[4])Based on post-commit review discussion on2bd84938470bf2e337801faafb8a67710f46429d with Richard Smith.Other uses of forcing HasEmptyPlaceHolder to false seem OK to me -they're all around pointer/reference types where the pointer/referencetoken will appear at the rightmost side of the left side of the typename, so they make nested types (eg: the "int" in "int *") behave asthough there is a non-empty placeholder (because the "*" is essentiallythe placeholder as far as the "int" is concerned).This was originally committed in 277623f4d5a672d707390e2c3eaf30a9eb4b075cReverted in f9ad1d1c775a8e264bebc15d75e0c6e5c20eefc7 due to breakagesoutside of clang - lldb seems to have some strange/strong dependence on"char [N]" versus "char[N]" when printing strings (not due to that nameappearing in DWARF, but probably due to using clang to stringify typenames) that'll need to be addressed, plus a few other odds and ends inother subprojects (clang-tools-extra, compiler-rt, etc). List of files: /llvm-project-15.0.7/clang/test/SemaCXX/decl-init-ref.cpp

f9ad1d1c - Revert "Compress formatting of array type names (int [4] -> int[4])"

Thu, 14 Oct 2021 21:48:17 +0000

Revert "Compress formatting of array type names (int [4] -> int[4])"Looks like lldb has some issues with this - somehow it causes lldb totreat a "char[N]" type as an array of chars (prints them outindividually) but a "char [N]" is printed as a string. (even though theDWARF doesn't have this string in it - it's something to do with thestring lldb generates for itself using clang)This reverts commit 277623f4d5a672d707390e2c3eaf30a9eb4b075c. List of files: /llvm-project-15.0.7/clang/test/SemaCXX/decl-init-ref.cpp

277623f4 - Compress formatting of array type names (int [4] -> int[4])

Thu, 14 Oct 2021 21:07:51 +0000

Compress formatting of array type names (int [4] -> int[4])Based on post-commit review discussion on2bd84938470bf2e337801faafb8a67710f46429d with Richard Smith.Other uses of forcing HasEmptyPlaceHolder to false seem OK to me -they're all around pointer/reference types where the pointer/referencetoken will appear at the rightmost side of the left side of the typename, so they make nested types (eg: the "int" in "int *") behave asthough there is a non-empty placeholder (because the "*" is essentiallythe placeholder as far as the "int" is concerned). List of files: /llvm-project-15.0.7/clang/test/SemaCXX/decl-init-ref.cpp

b5f2c4e4 - PR23029 / C++ DR2233: Allow expanded parameter packs to follow

Tue, 02 Jun 2020 17:42:36 +0000

PR23029 / C++ DR2233: Allow expanded parameter packs to followparameters with default arguments.Directly follow the wording by relaxing the AST invariant that allparameters after one with a default arguemnt also have defaultarguments, and removing the diagnostic on missing default argumentson a pack-expanded parameter following a parameter with a defaultargument.Testing also revealed that we need to special-case explicitspecializations of templates with a pack following a parameter with adefault argument, as such explicit specializations are otherwiseimpossible to write. The standard wording doesn't address this case; aissue has been filed.This exposed a bug where we would briefly consider a parameter to haveno default argument while we parse a delay-parsed default argument forthat parameter, which is also fixed.Partially incorporates a patch by Raul Tambre. List of files: /llvm-project-15.0.7/clang/test/SemaCXX/decl-init-ref.cpp

1147f71f - Improve diagnostic to tell you a type is incomplete.

Fri, 01 Feb 2019 22:06:02 +0000

Improve diagnostic to tell you a type is incomplete.I recently ran into this code:```\#include void foo(const std::string &s, const std::string& = "");\#include void test() { foo(""); }```The diagnostic produced said it can't bind char[1] to std::stringconst&. It didn't mention std::string is incomplete. The user had toinfer that.This patch causes the diagnostic to now say "incomplete type".llvm-svn: 352927 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/decl-init-ref.cpp

52b8b60d - Add increment/decrement operators and compound assignment operators to the

Thu, 25 Sep 2014 01:15:40 +0000

Add increment/decrement operators and compound assignment operators to theuninitialized checkers that did not have them before.llvm-svn: 218435 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/decl-init-ref.cpp

0bca59d6 - PR16502: Fix a dumb bug where we might look past the last initializer in an

Mon, 01 Jul 2013 06:08:20 +0000

PR16502: Fix a dumb bug where we might look past the last initializer in anInitListExpr.llvm-svn: 185304 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/decl-init-ref.cpp

72752e88 - Fix handling of braced-init-list as reference initializer within aggregate

Fri, 31 May 2013 02:56:17 +0000

Fix handling of braced-init-list as reference initializer within aggregateinitialization. Previously we would incorrectly require an extra set of bracesaround such initializers.llvm-svn: 182983 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/decl-init-ref.cpp

9ca5c425 - Update all tests other than Driver/std.cpp to use -std=c++11 rather than

Thu, 13 Oct 2011 22:29:44 +0000

Update all tests other than Driver/std.cpp to use -std=c++11 rather than-std=c++0x. Patch by Ahmed Charles!llvm-svn: 141900 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/decl-init-ref.cpp

f143cd50 - Re-instate r123977/r123978, my updates of the reference-binding

Mon, 24 Jan 2011 16:14:37 +0000

Re-instate r123977/r123978, my updates of the reference-bindingimplementation used by overload resolution to support rvaluereferences. The original commits caused PR9026 and somehard-to-reproduce self-host breakage.The only (crucial!) difference between this commit and the previouscommits is that we now properly check the SuppressUserConversions flagbefore attempting to perform a second user-defined conversion inreference binding, breaking the infinite recursion chain ofuser-defined conversions.Rvalue references should be working a bit better now.llvm-svn: 124121 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/decl-init-ref.cpp

24b89469 - 'const std::type_info' instead of 'std::type_info const'

Sun, 05 Sep 2010 00:17:29 +0000

'const std::type_info*' instead of 'std::type_info const*'llvm-svn: 113092 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/decl-init-ref.cpp

53fa0490 - make clang print types as "const int " instead of "int const",

Sun, 05 Sep 2010 00:04:01 +0000

make clang print types as "const int *" instead of "int const*",which is should have done from the beginning. As usual, the mostfun with this sort of change is updating all the testcases.llvm-svn: 113090 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/decl-init-ref.cpp

85f90559 - When pretty-printing tag types, only print the tag if we're in C (and

Wed, 10 Mar 2010 11:27:22 +0000

When pretty-printing tag types, only print the tag if we're in C (andtherefore not creating ElaboratedTypes, which are still pretty-printedwith the written tag).Most of these testcase changes were done by script, so don't feel toosorry for my fingers.llvm-svn: 98149 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/decl-init-ref.cpp

1f53e803 - Fix PR number in test case

Tue, 09 Feb 2010 01:02:53 +0000

Fix PR number in test casellvm-svn: 95640 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/decl-init-ref.cpp

34c0a902 - Be more careful when checking initializer lists that involve reference

Tue, 09 Feb 2010 00:50:06 +0000

Be more careful when checking initializer lists that involve referencetypes; we don't want to give an expression reference type. Fixes PR6177.llvm-svn: 95635 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/decl-init-ref.cpp

fd0b2f8f - Improve the diagnostics used to report implicitly-generated class members

Wed, 06 Jan 2010 09:43:14 +0000

Improve the diagnostics used to report implicitly-generated class membersas parts of overload sets. Also, refer to constructors as 'constructors'rather than functions.Adjust a lot of tests.llvm-svn: 92832 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/decl-init-ref.cpp