Changes in class-base-member-init.cpp

888673b6 - Revert "[clang] Implement ElaboratedType sugaring for types written bare"

Fri, 15 Jul 2022 04:13:57 +0000

Revert "[clang] Implement ElaboratedType sugaring for types written bare"This reverts commit 7c51f02effdbd0d5e12bfd26f9c3b2ab5687c93f because itstills breaks the LLDB tests. This was re-landed without addressing theissue or even agreement on how to address the issue. More details anddiscussion in https://reviews.llvm.org/D112374. List of files: /llvm-project-15.0.7/clang/test/SemaCXX/class-base-member-init.cpp

7c51f02e - [clang] Implement ElaboratedType sugaring for types written bare

Mon, 11 Oct 2021 16:15:36 +0000

[clang] Implement ElaboratedType sugaring for types written bareWithout this patch, clang will not wrap in an ElaboratedType node types writtenwithout a keyword and nested name qualifier, which goes against the intent thatwe should produce an AST which retains enough details to recover how things arewritten.The lack of this sugar is incompatible with the intent of the type printerdefault policy, which is to print types as written, but to fall back and printthem fully qualified when they are desugared.An ElaboratedTypeLoc without keyword / NNS uses no storage by itself, but stillrequires pointer alignment due to pre-existing bug in the TypeLoc bufferhandling.---Troubleshooting list to deal with any breakage seen with this patch:1) The most likely effect one would see by this patch is a change in how a type is printed. The type printer will, by design and default, print types as written. There are customization options there, but not that many, and they mainly apply to how to print a type that we somehow failed to track how it was written. This patch fixes a problem where we failed to distinguish between a type that was written without any elaborated-type qualifiers, such as a 'struct'/'class' tags and name spacifiers such as 'std::', and one that has been stripped of any 'metadata' that identifies such, the so called canonical types. Example: ``` namespace foo { struct A {}; A a; }; ``` If one were to print the type of `foo::a`, prior to this patch, this would result in `foo::A`. This is how the type printer would have, by default, printed the canonical type of A as well. As soon as you add any name qualifiers to A, the type printer would suddenly start accurately printing the type as written. This patch will make it print it accurately even when written without qualifiers, so we will just print `A` for the initial example, as the user did not really write that `foo::` namespace qualifier.2) This patch could expose a bug in some AST matcher. Matching types is harder to get right when there is sugar involved. For example, if you want to match a type against being a pointer to some type A, then you have to account for getting a type that is sugar for a pointer to A, or being a pointer to sugar to A, or both! Usually you would get the second part wrong, and this would work for a very simple test where you don't use any name qualifiers, but you would discover is broken when you do. The usual fix is to either use the matcher which strips sugar, which is annoying to use as for example if you match an N level pointer, you have to put N+1 such matchers in there, beginning to end and between all those levels. But in a lot of cases, if the property you want to match is present in the canonical type, it's easier and faster to just match on that... This goes with what is said in 1), if you want to match against the name of a type, and you want the name string to be something stable, perhaps matching on the name of the canonical type is the better choice.3) This patch could exposed a bug in how you get the source range of some TypeLoc. For some reason, a lot of code is using getLocalSourceRange(), which only looks at the given TypeLoc node. This patch introduces a new, and more common TypeLoc node which contains no source locations on itself. This is not an inovation here, and some other, more rare TypeLoc nodes could also have this property, but if you use getLocalSourceRange on them, it's not going to return any valid locations, because it doesn't have any. The right fix here is to always use getSourceRange() or getBeginLoc/getEndLoc which will dive into the inner TypeLoc to get the source range if it doesn't find it on the top level one. You can use getLocalSourceRange if you are really into micro-optimizations and you have some outside knowledge that the TypeLocs you are dealing with will always include some source location.4) Exposed a bug somewhere in the use of the normal clang type class API, where you have some type, you want to see if that type is some particular kind, you try a `dyn_cast` such as `dyn_cast` and that fails because now you have an ElaboratedType which has a TypeDefType inside of it, which is what you wanted to match. Again, like 2), this would usually have been tested poorly with some simple tests with no qualifications, and would have been broken had there been any other kind of type sugar, be it an ElaboratedType or a TemplateSpecializationType or a SubstTemplateParmType. The usual fix here is to use `getAs` instead of `dyn_cast`, which will look deeper into the type. Or use `getAsAdjusted` when dealing with TypeLocs. For some reason the API is inconsistent there and on TypeLocs getAs behaves like a dyn_cast.5) It could be a bug in this patch perhaps.Let me know if you need any help!Signed-off-by: Matheus Izvekov Differential Revision: https://reviews.llvm.org/D112374 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/class-base-member-init.cpp

3968936b - Revert "[clang] Implement ElaboratedType sugaring for types written bare"

Wed, 13 Jul 2022 16:11:45 +0000

Revert "[clang] Implement ElaboratedType sugaring for types written bare"This reverts commit bdc6974f92304f4ed542241b9b89ba58ba6b20aa because itbreaks all the LLDB tests that import the std module. import-std-module/array.TestArrayFromStdModule.py import-std-module/deque-basic.TestDequeFromStdModule.py import-std-module/deque-dbg-info-content.TestDbgInfoContentDequeFromStdModule.py import-std-module/forward_list.TestForwardListFromStdModule.py import-std-module/forward_list-dbg-info-content.TestDbgInfoContentForwardListFromStdModule.py import-std-module/list.TestListFromStdModule.py import-std-module/list-dbg-info-content.TestDbgInfoContentListFromStdModule.py import-std-module/queue.TestQueueFromStdModule.py import-std-module/stack.TestStackFromStdModule.py import-std-module/vector.TestVectorFromStdModule.py import-std-module/vector-bool.TestVectorBoolFromStdModule.py import-std-module/vector-dbg-info-content.TestDbgInfoContentVectorFromStdModule.py import-std-module/vector-of-vectors.TestVectorOfVectorsFromStdModule.pyhttps://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/45301/ List of files: /llvm-project-15.0.7/clang/test/SemaCXX/class-base-member-init.cpp

bdc6974f - [clang] Implement ElaboratedType sugaring for types written bare

Mon, 11 Oct 2021 16:15:36 +0000

a0e6a7fc - Make CXXBaseSpecifier::getType return unqual type.

Thu, 11 Jul 2013 22:22:22 +0000

Make CXXBaseSpecifier::getType return unqual type.Various pieces of code, like base initialization in Sema and RTTI IRGen,don't properly ignore qualifiers on base classes. Instead of auditing thewhole codebase, just strip them off in the getter. (The type as written isstill available in the TypeSourceInfo for code that cares.)Fixes PR16596.llvm-svn: 186125 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/class-base-member-init.cpp

ea306a14 - Don't crash when attempting to redundantly initialize a member of an anonymous union.

Mon, 25 Mar 2013 23:28:23 +0000

Don't crash when attempting to redundantly initialize a member of an anonymous union.llvm-svn: 177941 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/class-base-member-init.cpp

186a8899 - Support decltype in member initializers.

Tue, 24 Jan 2012 06:03:59 +0000

Support decltype in member initializers.This is the last piece of N3031 (decltype in weird places) - supportingthe use of decltype in a class ctor's member-initializer-list tospecify the base classes to initialize.Reviewed by Richard Smith.llvm-svn: 148789 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/class-base-member-init.cpp

0f65d59e - Include named unions in union member init checking

Thu, 17 Nov 2011 06:01:57 +0000

Include named unions in union member init checkingllvm-svn: 144883 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/class-base-member-init.cpp

23eebd9c - Diagnose more cases of initializing distinct members of an anonymous union

Sat, 10 Apr 2010 09:28:51 +0000

Diagnose more cases of initializing distinct members of an anonymous unionmember. Use a better diagnostic for this case. Also fix a bug with nestedanonymous structs/unions for -Wreorder; this last was PR6575.llvm-svn: 100923 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/class-base-member-init.cpp

7b3f2788 - Diagnose multiple base and member initializers in class templates.

Fri, 02 Apr 2010 05:42:15 +0000

Diagnose multiple base and member initializers in class templates.llvm-svn: 100179 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/class-base-member-init.cpp

83ac3129 - Fix a bug where we would incorrectly report an error about initializing two fields in an anonymous struct.

Tue, 30 Mar 2010 16:19:37 +0000

Fix a bug where we would incorrectly report an error about initializing two fields in an anonymous struct.llvm-svn: 99891 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/class-base-member-init.cpp

85f90559 - When pretty-printing tag types, only print the tag if we're in C (and

Wed, 10 Mar 2010 11:27:22 +0000

When pretty-printing tag types, only print the tag if we're in C (andtherefore not creating ElaboratedTypes, which are still pretty-printedwith the written tag).Most of these testcase changes were done by script, so don't feel toosorry for my fingers.llvm-svn: 98149 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/class-base-member-init.cpp

8fbe78f6 - Update tests to use %clang_cc1 instead of 'clang-cc' or 'clang -cc1'.

Tue, 15 Dec 2009 20:14:24 +0000

Update tests to use %clang_cc1 instead of 'clang-cc' or 'clang -cc1'. - This is designed to make it obvious that %clang_cc1 is a "test variable" which is substituted. It is '%clang_cc1' instead of '%clang -cc1' because it can be useful to redefine what gets run as 'clang -cc1' (for example, to set a default target).llvm-svn: 91446 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/class-base-member-init.cpp

11289f42 - Remove tabs, and whitespace cleanups.

Wed, 09 Sep 2009 15:08:12 +0000

Remove tabs, and whitespace cleanups.llvm-svn: 81346 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/class-base-member-init.cpp

651185bf - A more detailed diagnosis of ill-formed ctor-initializer

Tue, 30 Jun 2009 00:02:17 +0000

A more detailed diagnosis of ill-formed ctor-initializerlist.llvm-svn: 74480 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/class-base-member-init.cpp

2be8bf44 - Diagnose multiple initialzation of data-member/base

Mon, 29 Jun 2009 22:33:26 +0000

Diagnose multiple initialzation of data-member/base in the ctor-initializer list. More to come.llvm-svn: 74465 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/class-base-member-init.cpp