Changes in alias-template.cpp

76476efd - Rewording "static_assert" diagnostics

Mon, 25 Jul 2022 11:22:54 +0000

Rewording "static_assert" diagnosticsThis patch rewords the static assert diagnostic output. Failing a_Static_assert in C should not report that static_assert failed. Thischanges the wording to be more like GCC and uses "static assertion"when possible instead of hard coding the name. This also changes someinstances of 'static_assert' to instead be based on the token in thesource code.Differential Revision: https://reviews.llvm.org/D129048 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/alias-template.cpp

1da31190 - Revert "Rewording the "static_assert" to static assertion"

Thu, 21 Jul 2022 13:39:22 +0000

Revert "Rewording the "static_assert" to static assertion"Looks like we again are going to have problems with libcxx tests thatare overly specific in their dependency on clang's diagnostics.This reverts commit 6542cb55a3eb115b1c3592514590a19987ffc498. List of files: /llvm-project-15.0.7/clang/test/SemaCXX/alias-template.cpp

6542cb55 - Rewording the "static_assert" to static assertion

Thu, 21 Jul 2022 13:32:54 +0000

Rewording the "static_assert" to static assertionThis patch is basically the rewording of the static assert statement'soutput(error) on screen after failing. Failing a _Static_assert in Cshould not report that static_assert failed. It’d probably be better toreword the diagnostic to be more like GCC and say “static assertion”failed in both C and C++.consider a c file having code_Static_assert(0, "oh no!");In clang the output is like::1:1: error: static_assert failed: oh no!_Static_assert(0, "oh no!");^ ~1 error generated.Compiler returned: 1Thus here the "static_assert" is not much good, it will be better toreword it to the "static assertion failed" to more generic. as the gccprints as::1:1: error: static assertion failed: "oh no!" 1 | _Static_assert(0, "oh no!"); | ^~~~~~~~~~~~~~ Compiler returned: 1The above can also be seen here. This patch is about rewordingthe static_assert to static assertion.Differential Revision: https://reviews.llvm.org/D129048 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/alias-template.cpp

041d4012 - Revert "Rewording "static_assert" diagnostics"

Thu, 14 Jul 2022 17:52:43 +0000

Revert "Rewording "static_assert" diagnostics"This reverts commit b7e77ff25fb2412f6ab6d6cc756666b0e2f97bd3.Reason: Broke sanitizer builds bots + libcxx. 'static assertionexpression is not an integral constant expression'. More detailsavailable in the Phabricator review: https://reviews.llvm.org/D129048 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/alias-template.cpp

b7e77ff2 - Rewording "static_assert" diagnostics

Thu, 14 Jul 2022 11:44:51 +0000

aee49255 - Recommit: Compress formatting of array type names (int [4] -> int[4])

Thu, 14 Oct 2021 21:52:47 +0000

Recommit: Compress formatting of array type names (int [4] -> int[4])Based on post-commit review discussion on2bd84938470bf2e337801faafb8a67710f46429d with Richard Smith.Other uses of forcing HasEmptyPlaceHolder to false seem OK to me -they're all around pointer/reference types where the pointer/referencetoken will appear at the rightmost side of the left side of the typename, so they make nested types (eg: the "int" in "int *") behave asthough there is a non-empty placeholder (because the "*" is essentiallythe placeholder as far as the "int" is concerned).This was originally committed in 277623f4d5a672d707390e2c3eaf30a9eb4b075cReverted in f9ad1d1c775a8e264bebc15d75e0c6e5c20eefc7 due to breakagesoutside of clang - lldb seems to have some strange/strong dependence on"char [N]" versus "char[N]" when printing strings (not due to that nameappearing in DWARF, but probably due to using clang to stringify typenames) that'll need to be addressed, plus a few other odds and ends inother subprojects (clang-tools-extra, compiler-rt, etc). List of files: /llvm-project-15.0.7/clang/test/SemaCXX/alias-template.cpp

f9ad1d1c - Revert "Compress formatting of array type names (int [4] -> int[4])"

Thu, 14 Oct 2021 21:48:17 +0000

Revert "Compress formatting of array type names (int [4] -> int[4])"Looks like lldb has some issues with this - somehow it causes lldb totreat a "char[N]" type as an array of chars (prints them outindividually) but a "char [N]" is printed as a string. (even though theDWARF doesn't have this string in it - it's something to do with thestring lldb generates for itself using clang)This reverts commit 277623f4d5a672d707390e2c3eaf30a9eb4b075c. List of files: /llvm-project-15.0.7/clang/test/SemaCXX/alias-template.cpp

277623f4 - Compress formatting of array type names (int [4] -> int[4])

Thu, 14 Oct 2021 21:07:51 +0000

Compress formatting of array type names (int [4] -> int[4])Based on post-commit review discussion on2bd84938470bf2e337801faafb8a67710f46429d with Richard Smith.Other uses of forcing HasEmptyPlaceHolder to false seem OK to me -they're all around pointer/reference types where the pointer/referencetoken will appear at the rightmost side of the left side of the typename, so they make nested types (eg: the "int" in "int *") behave asthough there is a non-empty placeholder (because the "*" is essentiallythe placeholder as far as the "int" is concerned). List of files: /llvm-project-15.0.7/clang/test/SemaCXX/alias-template.cpp

b23c5e8c - [c++20] Implement P0846R0: allow (ADL-only) calls to template-ids whose

Thu, 09 May 2019 03:31:27 +0000

[c++20] Implement P0846R0: allow (ADL-only) calls to template-ids whosetemplate name is not visible to unqualified lookup.In order to support this without a severe degradation in our ability todiagnose typos in template names, this change significantly restructuresthe way we handle template-id-shaped syntax for which lookup of thetemplate name finds nothing.Instead of eagerly diagnosing an undeclared template name, we now form aplaceholder template-name representing a name that is known to not findany templates. When the parser sees such a name, it attempts todisambiguate whether we have a less-than comparison or a template-id.Any diagnostics or typo-correction for the name are delayed until itspoint of use.The upshot should be a small improvement of our diagostic qualityoverall: we now take more syntactic context into account when trying toresolve an undeclared identifier on the left hand side of a '<'. Infact, this works well enough that the backwards-compatible portion (foran undeclared identifier rather than a lookup that finds functions butno function templates) is enabled in all language modes.llvm-svn: 360308 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/alias-template.cpp

7dda73a2 - [SemaCXX] Fix ICE for unexpanded parameter pack

Mon, 07 Jan 2019 03:25:59 +0000

[SemaCXX] Fix ICE for unexpanded parameter packSummary:The documentation for RecursiveASTVisitor::TraverseDecl states that theDecl being traversed may be null. In fact, this is the case when aCXXCatchStmt with no exception decl is traversed. Because the visitorfor diagnosing unexpanded parameter packs does not check for null, itends up crashing when it attempts to call the Decl::isParameterPackmethod on a null Decl pointer.Add a null check to prevent an ICE, and a test case that would crashotherwise. Also, because the test requires C++ exceptions and C++14,change the test parameters for the entire test file. (Alternatively, Ithought about adding a new test file, but went with this approach for myown convenience.)Co-authored-by: Andreas Molzer Co-authored-by: Mara Bos Reviewers: rsmithReviewed By: rsmithSubscribers: cfe-commitsDifferential Revision: https://reviews.llvm.org/D56271llvm-svn: 350501 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/alias-template.cpp

ba88e21f - [Sema] Make sure we substitute an instantiation-dependent default template argument

Mon, 12 Nov 2018 21:31:06 +0000

[Sema] Make sure we substitute an instantiation-dependent default template argumentFixes llvm.org/PR39623Differential revision: https://reviews.llvm.org/D54414llvm-svn: 346709 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/alias-template.cpp

3cbf3f1f - Push alias-declarations and alias-template declarations into scope even if

Fri, 15 Jul 2016 20:53:25 +0000

Push alias-declarations and alias-template declarations into scope even ifthey're redeclarations. This is necessary in order for name lookup to correctlyfind the most recent declaration of the name (which affects default templateargument lookup and cross-module merging, among other things).llvm-svn: 275612 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/alias-template.cpp

16a74704 - [AST] Perform additional canonicalization for DependentSizedArrayType

Fri, 24 Jul 2015 05:54:19 +0000

[AST] Perform additional canonicalization for DependentSizedArrayTypeWe treated DependentSizedArrayTypes with the same element type butdiffering size expressions as equivalently canonical. This would leadto bizarre behavior during template instantiation.This fixes PR24212.llvm-svn: 243093 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/alias-template.cpp

88fe69ce - DR1909: Diagnose all invalid cases of a class member sharing its name with the class.

Mon, 06 Jul 2015 01:45:27 +0000

DR1909: Diagnose all invalid cases of a class member sharing its name with the class.llvm-svn: 241425 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/alias-template.cpp

025f428c - Replace "can not" with "cannot" in diagnostics messages.

Fri, 07 Mar 2014 22:36:23 +0000

Replace "can not" with "cannot" in diagnostics messages.llvm-svn: 203302 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/alias-template.cpp

f703b588 - Implement DR577

Wed, 19 Feb 2014 03:00:56 +0000

Implement DR577DR18 previously forebode typedefs to be used as parameter types if theywere of type 'void'. DR577 allows 'void' to be used as a functionparameter type regardless from where it came.llvm-svn: 201631 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/alias-template.cpp

29e1c4b0 - Fixed an assertion failure triggered by invalid code.

Fri, 11 Jan 2013 14:34:39 +0000

Fixed an assertion failure triggered by invalid code.Set invalid type of declarator after emitting error diagnostics,so that it won't be later considered when instantiating the template.Added test5_inst in test/SemaCXX/condition.cpp for non-regression.llvm-svn: 172201 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/alias-template.cpp

72249ba9 - PR12647: An alias template instantiation which occurs in a SFINAE context is

Thu, 26 Apr 2012 07:24:08 +0000

PR12647: An alias template instantiation which occurs in a SFINAE context isitself a SFINAE context.llvm-svn: 155621 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/alias-template.cpp

c5b05520 - Fix parsing of type-specifier-seq's. Types are syntactically allowed to be

Mon, 12 Mar 2012 07:56:15 +0000

Fix parsing of type-specifier-seq's. Types are syntactically allowed to bedefined here, but not semantically, so new struct S {};is always ill-formed, even if there is a struct S in scope.We also had a couple of bugs in ParseOptionalTypeSpecifier caused by it beingunder-loved (due to it only being used in a few places) so merge it intoParseDeclarationSpecifiers with a new DeclSpecContext. To avoid regressing, thisrequired improving ParseDeclarationSpecifiers' diagnostics in some cases. Thisalso required teaching ParseSpecifierQualifierList about constexpr... whichincidentally fixes an issue where we'd allow the constexpr specifier in otherbad places.llvm-svn: 152549 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/alias-template.cpp

63168c75 - PR11684, core issue 1417:

Fri, 10 Feb 2012 11:05:11 +0000

PR11684, core issue 1417:o Correct the handling of the restrictions on usage of cv-qualified and ref-qualified function types.o Fix a bug where such types were rejected in template type parameter default arguments, due to such arguments not being treated as a template type arg context.o Remove the ExtWarn for usage of such types as template arguments; that was a standard defect, not a GCC extension.o Improve the wording and unify the code for diagnosing cv-qualifiers with the code for diagnosing ref-qualifiers.llvm-svn: 150244 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/alias-template.cpp