Changes in abstract.cpp

888673b6 - Revert "[clang] Implement ElaboratedType sugaring for types written bare"

Fri, 15 Jul 2022 04:13:57 +0000

Revert "[clang] Implement ElaboratedType sugaring for types written bare"This reverts commit 7c51f02effdbd0d5e12bfd26f9c3b2ab5687c93f because itstills breaks the LLDB tests. This was re-landed without addressing theissue or even agreement on how to address the issue. More details anddiscussion in https://reviews.llvm.org/D112374. List of files: /llvm-project-15.0.7/clang/test/SemaCXX/abstract.cpp

7c51f02e - [clang] Implement ElaboratedType sugaring for types written bare

Mon, 11 Oct 2021 16:15:36 +0000

[clang] Implement ElaboratedType sugaring for types written bareWithout this patch, clang will not wrap in an ElaboratedType node types writtenwithout a keyword and nested name qualifier, which goes against the intent thatwe should produce an AST which retains enough details to recover how things arewritten.The lack of this sugar is incompatible with the intent of the type printerdefault policy, which is to print types as written, but to fall back and printthem fully qualified when they are desugared.An ElaboratedTypeLoc without keyword / NNS uses no storage by itself, but stillrequires pointer alignment due to pre-existing bug in the TypeLoc bufferhandling.---Troubleshooting list to deal with any breakage seen with this patch:1) The most likely effect one would see by this patch is a change in how a type is printed. The type printer will, by design and default, print types as written. There are customization options there, but not that many, and they mainly apply to how to print a type that we somehow failed to track how it was written. This patch fixes a problem where we failed to distinguish between a type that was written without any elaborated-type qualifiers, such as a 'struct'/'class' tags and name spacifiers such as 'std::', and one that has been stripped of any 'metadata' that identifies such, the so called canonical types. Example: ``` namespace foo { struct A {}; A a; }; ``` If one were to print the type of `foo::a`, prior to this patch, this would result in `foo::A`. This is how the type printer would have, by default, printed the canonical type of A as well. As soon as you add any name qualifiers to A, the type printer would suddenly start accurately printing the type as written. This patch will make it print it accurately even when written without qualifiers, so we will just print `A` for the initial example, as the user did not really write that `foo::` namespace qualifier.2) This patch could expose a bug in some AST matcher. Matching types is harder to get right when there is sugar involved. For example, if you want to match a type against being a pointer to some type A, then you have to account for getting a type that is sugar for a pointer to A, or being a pointer to sugar to A, or both! Usually you would get the second part wrong, and this would work for a very simple test where you don't use any name qualifiers, but you would discover is broken when you do. The usual fix is to either use the matcher which strips sugar, which is annoying to use as for example if you match an N level pointer, you have to put N+1 such matchers in there, beginning to end and between all those levels. But in a lot of cases, if the property you want to match is present in the canonical type, it's easier and faster to just match on that... This goes with what is said in 1), if you want to match against the name of a type, and you want the name string to be something stable, perhaps matching on the name of the canonical type is the better choice.3) This patch could exposed a bug in how you get the source range of some TypeLoc. For some reason, a lot of code is using getLocalSourceRange(), which only looks at the given TypeLoc node. This patch introduces a new, and more common TypeLoc node which contains no source locations on itself. This is not an inovation here, and some other, more rare TypeLoc nodes could also have this property, but if you use getLocalSourceRange on them, it's not going to return any valid locations, because it doesn't have any. The right fix here is to always use getSourceRange() or getBeginLoc/getEndLoc which will dive into the inner TypeLoc to get the source range if it doesn't find it on the top level one. You can use getLocalSourceRange if you are really into micro-optimizations and you have some outside knowledge that the TypeLocs you are dealing with will always include some source location.4) Exposed a bug somewhere in the use of the normal clang type class API, where you have some type, you want to see if that type is some particular kind, you try a `dyn_cast` such as `dyn_cast` and that fails because now you have an ElaboratedType which has a TypeDefType inside of it, which is what you wanted to match. Again, like 2), this would usually have been tested poorly with some simple tests with no qualifications, and would have been broken had there been any other kind of type sugar, be it an ElaboratedType or a TemplateSpecializationType or a SubstTemplateParmType. The usual fix here is to use `getAs` instead of `dyn_cast`, which will look deeper into the type. Or use `getAsAdjusted` when dealing with TypeLocs. For some reason the API is inconsistent there and on TypeLocs getAs behaves like a dyn_cast.5) It could be a bug in this patch perhaps.Let me know if you need any help!Signed-off-by: Matheus Izvekov Differential Revision: https://reviews.llvm.org/D112374 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/abstract.cpp

3968936b - Revert "[clang] Implement ElaboratedType sugaring for types written bare"

Wed, 13 Jul 2022 16:11:45 +0000

Revert "[clang] Implement ElaboratedType sugaring for types written bare"This reverts commit bdc6974f92304f4ed542241b9b89ba58ba6b20aa because itbreaks all the LLDB tests that import the std module. import-std-module/array.TestArrayFromStdModule.py import-std-module/deque-basic.TestDequeFromStdModule.py import-std-module/deque-dbg-info-content.TestDbgInfoContentDequeFromStdModule.py import-std-module/forward_list.TestForwardListFromStdModule.py import-std-module/forward_list-dbg-info-content.TestDbgInfoContentForwardListFromStdModule.py import-std-module/list.TestListFromStdModule.py import-std-module/list-dbg-info-content.TestDbgInfoContentListFromStdModule.py import-std-module/queue.TestQueueFromStdModule.py import-std-module/stack.TestStackFromStdModule.py import-std-module/vector.TestVectorFromStdModule.py import-std-module/vector-bool.TestVectorBoolFromStdModule.py import-std-module/vector-dbg-info-content.TestDbgInfoContentVectorFromStdModule.py import-std-module/vector-of-vectors.TestVectorOfVectorsFromStdModule.pyhttps://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/45301/ List of files: /llvm-project-15.0.7/clang/test/SemaCXX/abstract.cpp

bdc6974f - [clang] Implement ElaboratedType sugaring for types written bare

Mon, 11 Oct 2021 16:15:36 +0000

25b3370f - PR52139: Properly handle more kinds of declaration when checking for

Mon, 11 Oct 2021 23:16:32 +0000

PR52139: Properly handle more kinds of declaration when checking forusage of an abstract class type within itself.We were missing handling for deduction guides (which would assert),friend declarations, and variable templates. We were mishandling inlinevariables and other variables defined inside the class definition.These diagnostics should be downgraded to warnings, or perhaps removedentirely, once we implement P0929R2. List of files: /llvm-project-15.0.7/clang/test/SemaCXX/abstract.cpp

09e7fe98 - [AST][RecoveryAST] Preserve the type by default for recovery expression.

Mon, 24 Aug 2020 12:20:36 +0000

[AST][RecoveryAST] Preserve the type by default for recovery expression.Differential Revision: https://reviews.llvm.org/D82657 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/abstract.cpp

b5f2c4e4 - PR23029 / C++ DR2233: Allow expanded parameter packs to follow

Tue, 02 Jun 2020 17:42:36 +0000

PR23029 / C++ DR2233: Allow expanded parameter packs to followparameters with default arguments.Directly follow the wording by relaxing the AST invariant that allparameters after one with a default arguemnt also have defaultarguments, and removing the diagnostic on missing default argumentson a pack-expanded parameter following a parameter with a defaultargument.Testing also revealed that we need to special-case explicitspecializations of templates with a pack following a parameter with adefault argument, as such explicit specializations are otherwiseimpossible to write. The standard wording doesn't address this case; aissue has been filed.This exposed a bug where we would briefly consider a parameter to haveno default argument while we parse a delay-parsed default argument forthat parameter, which is also fixed.Partially incorporates a patch by Raul Tambre. List of files: /llvm-project-15.0.7/clang/test/SemaCXX/abstract.cpp

213bea33 - [Sema] Implement several unary type traits more accurately

Mon, 16 Nov 2015 06:58:51 +0000

[Sema] Implement several unary type traits more accuratelyis_empty, is_polymorphic, and is_abstract didn't handle incomplete typescorrectly. Only non-union class types must be complete for thesetraits.is_final and is_sealed don't care about the particular spelling of theFinalAttr.is_interface_class should always return false regardless of its input.The type trait can only be satisfied in a mode we do not support (/CLR).llvm-svn: 253184 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/abstract.cpp

b1004103 - Normalize line endings

Sun, 02 Mar 2014 18:46:05 +0000

Normalize line endingsSome files had CRLF line terminators, some only had a mixture ofCRLF and LF. Switch to LF.llvm-svn: 202659 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/abstract.cpp

bc46e434 - Implement DR257 / fix PR16659:

Mon, 22 Jul 2013 02:56:56 +0000

Implement DR257 / fix PR16659: A constructor for an abstract class does not call constructors for virtual base classes, so it is not an error if no initializer is present for the virtual base and the virtual base cannot be default initialized.Also provide a (disabled by default, for now) warning for the case where avirtual base class's initializer is ignored in an abstract class's constructor,and address a defect in DR257 where it was not carried through to C++11's rulesfor implicit deletion of special member functions.Based on a patch by Maurice Bos.llvm-svn: 186803 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/abstract.cpp

72d74057 - Add missing check for creating an instance of an abstract class through an

Sat, 20 Jul 2013 19:41:36 +0000

Add missing check for creating an instance of an abstract class through animplicit conversion sequence.llvm-svn: 186769 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/abstract.cpp

ea03214a - Detecting illegal instantiations of abstract types when using a function-style cast. Fixed PR12658.

Mon, 07 May 2012 00:02:00 +0000

Detecting illegal instantiations of abstract types when using a function-style cast. Fixed PR12658.llvm-svn: 156271 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/abstract.cpp

9ca5c425 - Update all tests other than Driver/std.cpp to use -std=c++11 rather than

Thu, 13 Oct 2011 22:29:44 +0000

Update all tests other than Driver/std.cpp to use -std=c++11 rather than-std=c++0x. Patch by Ahmed Charles!llvm-svn: 141900 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/abstract.cpp

385d3fd9 - When checking for abstract types, don't crash when we have a

Tue, 22 Feb 2011 23:21:06 +0000

When checking for abstract types, don't crash when we have aFunctionProtoTypeLoc with NULL function parameter types, which canoccur in invalid code. Fixes PR9247 / .llvm-svn: 126262 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/abstract.cpp

fc1ad1f3 - Update the test error messages to match the update I made to the actual

Sat, 19 Feb 2011 00:12:23 +0000

Update the test error messages to match the update I made to the actualmessages.llvm-svn: 125997 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/abstract.cpp

98e3c568 - Fix PR8767, improve diagnostic wording when allocating an object of an

Fri, 18 Feb 2011 23:59:51 +0000

Fix PR8767, improve diagnostic wording when allocating an object of anabstract class type.Patch by Stephen Hines, with a wording tweak from Doug applied by me.llvm-svn: 125996 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/abstract.cpp

8f42893a - Flesh out the test cases a little.

Wed, 18 Aug 2010 09:58:15 +0000

Flesh out the test cases a little.llvm-svn: 111359 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/abstract.cpp

02db245d - Rip out the existing retroactive abstract-class usage checker,

Wed, 18 Aug 2010 09:41:07 +0000

Rip out the existing retroactive abstract-class usage checker,which in a fit of zeal wanted to walk the entire translation unit,and replace it with a new checker that walks the types of declarationsnested within the class. Also, look into templates when doing this.llvm-svn: 111357 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/abstract.cpp

38e5f433 - Fix the build. Using declarations should not be considering when looking

Wed, 16 Jun 2010 09:33:39 +0000

Fix the build. Using declarations should not be considering when lookingfor overridden virtual methods.llvm-svn: 106096 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/abstract.cpp

7d8072e0 - Diagnose the use of abstract types as array element types. Previously,

Tue, 27 Apr 2010 19:38:14 +0000

Diagnose the use of abstract types as array element types. Previously,we were relying on checking for abstract class types when an arraytype was actually used to declare a variable, parameter, etc. However,we need to check when the construct the array for, e.g., SFINAEpurposes (see DR337). Fixes problems with Boost's is_abstract typetrait. llvm-svn: 102452 List of files: /llvm-project-15.0.7/clang/test/SemaCXX/abstract.cpp